audrius/stock-logistics-warehouse
1
0
Fork 1
mirror of https://github.com/OCA/stock-logistics-warehouse.git synced 2025-01-21 14:27:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] fix negative quant in blocked location

Browse Source 
When forcing an outgoing move and then moving it. Odoo create a
negative quant. This quant should not be in the locked location
because no quand will go in it and so the negative quant will stay
here for ever
This commit is contained in:
Sébastien BEAU
2019-07-05 17:46:07 +02:00
committed by Florian da Costa
parent 56d4fcdd94
commit 5766bfa2db
2 changed files with 30 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
stock_location_lockdown/models/stock_quant.py
View File

@@ -9,18 +9,13 @@ from odoo.exceptions import UserError
class StockQuant(models.Model): class StockQuant(models.Model):
_inherit = 'stock.quant' _inherit = 'stock.quant'
@api.model @api.constrains('location_id')
def quants_move( def _check_location_blocked(self):
self, quants, move, location_to, location_from=False, lot_id=False, for record in self:
owner_id=False, src_package_id=False, dest_package_id=False, if record.location_id.block_stock_entrance:
entire_pack=False): raise UserError(
if ( _('The location %s is blocked and can '
location_to.usage == 'internal' and 'not be used for moving the product %s')
location_to.block_stock_entrance): % (record.location_id.name, record.product_id.name)
raise UserError(_( )
"The location '%s' is not configured to receive stock.") return True
% location_to.display_name)
return super(StockQuant, self).quants_move(
quants, move, location_to, location_from=location_from,
lot_id=lot_id, owner_id=owner_id, src_package_id=src_package_id,
dest_package_id=dest_package_id, entire_pack=entire_pack)

22
stock_location_lockdown/tests/test_block_stock_location_entrance.py
View File

@@ -2,7 +2,7 @@
# Copyright 2018 Akretion France # Copyright 2018 Akretion France
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
from odoo.exceptions import UserError from odoo.exceptions import ValidationError
from odoo.tests.common import TransactionCase from odoo.tests.common import TransactionCase
@@ -13,6 +13,7 @@ class TestStockLocationLockdown(TransactionCase):
self.main_stock_location = self.env.ref('stock.stock_location_stock') self.main_stock_location = self.env.ref('stock.stock_location_stock')
self.main_stock_location.block_stock_entrance = True self.main_stock_location.block_stock_entrance = True
self.supplier_location = self.env.ref('stock.stock_location_suppliers') self.supplier_location = self.env.ref('stock.stock_location_suppliers')
self.customer_location = self.env.ref('stock.stock_location_customers')
self.product = self.env.ref('product.product_product_27') self.product = self.env.ref('product.product_product_27')
def test_transfer_stock_in_locked_location(self): def test_transfer_stock_in_locked_location(self):
@@ -29,5 +30,22 @@ class TestStockLocationLockdown(TransactionCase):
'name': 'test', 'name': 'test',
} }
stock_move = self.env['stock.move'].create(move_vals) stock_move = self.env['stock.move'].create(move_vals)
with self.assertRaises(UserError): with self.assertRaises(ValidationError):
stock_move.action_done()
def test_transfer_stock_out_locked_location(self):
"""
Test to move stock within a location that should not accept
Stock entrance.
"""
move_vals = {
'location_id': self.main_stock_location.id,
'location_dest_id': self.customer_location.id,
'product_id': self.product.id,
'product_uom_qty': '2.0',
'product_uom': 1,
'name': 'test',
}
stock_move = self.env['stock.move'].create(move_vals)
with self.assertRaises(ValidationError):
stock_move.action_done() stock_move.action_done()