From 5756ba9809411997bb2f76367d558c2fefd9be05 Mon Sep 17 00:00:00 2001
From: mav-adhoc <mav@adhoc.com.ar>
Date: Thu, 25 Jul 2024 11:22:10 -0300
Subject: [PATCH] [FIX] stock_exception: button_validate

---
 stock_exception/models/stock.py     |  6 +++
 stock_exception/tests/__init__.py   |  1 +
 stock_exception/tests/test_stock.py | 75 +++++++++++++++++++++++++++++
 3 files changed, 82 insertions(+)
 create mode 100644 stock_exception/tests/__init__.py
 create mode 100644 stock_exception/tests/test_stock.py

diff --git a/stock_exception/models/stock.py b/stock_exception/models/stock.py
index 341ef8c85..5e690b112 100644
--- a/stock_exception/models/stock.py
+++ b/stock_exception/models/stock.py
@@ -43,6 +43,12 @@ class StockPicking(models.Model):
                 return rec._popup_exceptions()
         return super().action_confirm()
 
+    def button_validate(self):
+        for rec in self:
+            if rec.detect_exceptions() and not rec.ignore_exception:
+                return rec._popup_exceptions()
+        return super().button_validate()
+
     @api.model
     def _get_popup_action(self):
         action = self.env.ref("stock_exception.action_stock_exception_confirm")
diff --git a/stock_exception/tests/__init__.py b/stock_exception/tests/__init__.py
new file mode 100644
index 000000000..e96f48eb2
--- /dev/null
+++ b/stock_exception/tests/__init__.py
@@ -0,0 +1 @@
+from . import test_stock
diff --git a/stock_exception/tests/test_stock.py b/stock_exception/tests/test_stock.py
new file mode 100644
index 000000000..1567bc15e
--- /dev/null
+++ b/stock_exception/tests/test_stock.py
@@ -0,0 +1,75 @@
+from odoo.tests.common import TransactionCase
+
+
+class TestStockPicking(TransactionCase):
+    def setUp(self):
+        super(TestStockPicking, self).setUp()
+        stock_location = self.env.ref("stock.stock_location_stock")
+        customer_location = self.env.ref("stock.stock_location_customers")
+        product = self.env.ref("product.product_product_4")
+        picking_type = self.env.ref("stock.picking_type_out")
+        # Create a picking in 'assigned' state with exceptions
+        self.picking_with_exceptions = self.env["stock.picking"].create(
+            {
+                "name": "Test Picking With Exceptions 2",
+                "state": "assigned",
+                "location_id": stock_location.id,
+                "location_dest_id": customer_location.id,
+                "picking_type_id": picking_type.id,
+                "move_ids": [
+                    (
+                        0,
+                        0,
+                        {
+                            "name": "Test Move With Exceptions",
+                            "product_id": product.id,
+                            "product_uom_qty": 1,
+                            "reserved_availability": 1,
+                            "product_uom": self.env.ref("uom.product_uom_unit").id,
+                            "location_id": stock_location.id,
+                            "location_dest_id": customer_location.id,
+                        },
+                    )
+                ],
+                "ignore_exception": False,
+            }
+        )
+
+        self.exception = self.env["exception.rule"].create(
+            {
+                "name": "Demand Quantity not positive",
+                "sequence": 50,
+                "model": "stock.move",
+                "code": "if self.product_uom_qty == 0: failed=True",
+                "active": True,
+            }
+        )
+
+    def test_detect_exceptions(self):
+        # Test that exceptions are detected for the picking with exceptions
+        exceptions = self.picking_with_exceptions.detect_exceptions()
+        self.assertFalse(exceptions, "Exceptions shouldn't be detected")
+        move = self.picking_with_exceptions.move_ids[0]
+        move.write({"product_uom_qty": 0})
+        exceptions = self.picking_with_exceptions.detect_exceptions()
+        self.assertTrue(exceptions, "Exceptions should be detected")
+
+    def test_button_validate_with_exceptions(self):
+        move = self.picking_with_exceptions.move_ids[0]
+        move.write({"product_uom_qty": 0})
+        move.write({"quantity_done": 1})
+        # Result returns a dict in case it detects an exception, otherwise it returns 'True'
+        result = self.picking_with_exceptions.button_validate()
+
+        # Verify the result of the button_validate action
+        # If exceptions detected, the result should be different from 'True'
+        self.assertNotEqual(
+            result, True, f"Expected result not to be True, but got {type(result)}"
+        )
+
+    def test_onchange_ignore_exception(self):
+        # Change state and verify onchange behavior for picking
+        self.picking_with_exceptions.write(
+            {"state": "waiting", "ignore_exception": True}
+        )
+        self.assertTrue(self.picking_with_exceptions.ignore_exception)