diff --git a/setup/stock_move_auto_assign_auto_release/odoo/addons/stock_move_auto_assign_auto_release b/setup/stock_move_auto_assign_auto_release/odoo/addons/stock_move_auto_assign_auto_release new file mode 120000 index 000000000..99367fb07 --- /dev/null +++ b/setup/stock_move_auto_assign_auto_release/odoo/addons/stock_move_auto_assign_auto_release @@ -0,0 +1 @@ +../../../../stock_move_auto_assign_auto_release \ No newline at end of file diff --git a/setup/stock_move_auto_assign_auto_release/setup.py b/setup/stock_move_auto_assign_auto_release/setup.py new file mode 100644 index 000000000..28c57bb64 --- /dev/null +++ b/setup/stock_move_auto_assign_auto_release/setup.py @@ -0,0 +1,6 @@ +import setuptools + +setuptools.setup( + setup_requires=['setuptools-odoo'], + odoo_addon=True, +) diff --git a/stock_move_auto_assign/models/product_product.py b/stock_move_auto_assign/models/product_product.py index 6251c2a9f..051a87180 100644 --- a/stock_move_auto_assign/models/product_product.py +++ b/stock_move_auto_assign/models/product_product.py @@ -46,6 +46,10 @@ class ProductProduct(models.Model): pickings = moves.picking_id if not pickings: return + self._lock_pickings_or_retry(pickings) + moves._action_assign() + + def _lock_pickings_or_retry(self, pickings): try: self.env.cr.execute( "SELECT id FROM stock_picking WHERE id IN %s FOR UPDATE NOWAIT", @@ -62,4 +66,3 @@ class ProductProduct(models.Model): "Could not obtain lock on transfers, will retry.", ignore_retry=True ) from err raise - moves._action_assign() diff --git a/stock_move_auto_assign/models/stock_move.py b/stock_move_auto_assign/models/stock_move.py index cdb85dc32..5ab9f84ef 100644 --- a/stock_move_auto_assign/models/stock_move.py +++ b/stock_move_auto_assign/models/stock_move.py @@ -57,13 +57,15 @@ class StockMove(models.Model): self._enqueue_auto_assign( self.env["product.product"].browse(product_id), self.env["stock.location"].browse(location_ids), - ) + ).delay() def _enqueue_auto_assign(self, product, locations, **job_options): """Enqueue a job ProductProduct.moves_auto_assign() Can be extended to pass different options to the job (priority, ...). The usage of `.setdefault` allows to override the options set by default. + + return: a `Job` instance """ job_options = job_options.copy() job_options.setdefault( @@ -74,4 +76,6 @@ class StockMove(models.Model): ) # do not enqueue 2 jobs for the same product and locations set job_options.setdefault("identity_key", identity_exact) - product.with_delay(**job_options).moves_auto_assign(locations) + delayable = product.delayable(**job_options) + job = delayable.moves_auto_assign(locations) + return job diff --git a/stock_move_auto_assign/tests/test_auto_assign.py b/stock_move_auto_assign/tests/test_auto_assign.py index c12ba6e83..4b99a0db5 100644 --- a/stock_move_auto_assign/tests/test_auto_assign.py +++ b/stock_move_auto_assign/tests/test_auto_assign.py @@ -2,7 +2,7 @@ # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). from odoo.addons.queue_job.job import identity_exact -from odoo.addons.queue_job.tests.common import mock_with_delay +from odoo.addons.queue_job.tests.common import trap_jobs from .common import StockMoveAutoAssignCase @@ -28,20 +28,18 @@ class TestStockMoveAutoAssign(StockMoveAutoAssignCase): move.move_line_ids.copy( default={"qty_done": 50, "location_dest_id": self.shelf2_loc.id} ) - with mock_with_delay() as (delayable_cls, delayable): + with trap_jobs() as trap: move._action_done() # .with_delay() has been called once - self.assertEqual(delayable_cls.call_count, 1) - delay_args, delay_kwargs = delayable_cls.call_args - # .with_delay() is called on self.product - self.assertEqual(delay_args, (self.product,)) - # .with_delay() with the following options - self.assertEqual(delay_kwargs.get("identity_key"), identity_exact) - # check what's passed to the job method 'moves_auto_assign' - self.assertEqual(delayable.moves_auto_assign.call_count, 1) - delay_args, delay_kwargs = delayable.moves_auto_assign.call_args - self.assertEqual(delay_args, (self.shelf1_loc | self.shelf2_loc,)) - self.assertDictEqual(delay_kwargs, {}) + trap.assert_jobs_count(1) + trap.assert_enqueued_job( + self.product.moves_auto_assign, + args=(self.shelf1_loc | self.shelf2_loc,), + kwargs={}, + properties=dict( + identity_key=identity_exact, + ), + ) def test_move_canceled_with_reservation_enqueue_job(self): """A canceled move with reservations enqueue a new job to assign other moves""" @@ -49,28 +47,26 @@ class TestStockMoveAutoAssign(StockMoveAutoAssignCase): # put stock in Stock/Shelf 1, the move has a source location in Stock self._update_qty_in_location(self.shelf1_loc, self.product, 100) move._action_assign() - with mock_with_delay() as (delayable_cls, delayable): + with trap_jobs() as trap: move._action_cancel() # .with_delay() has been called once - self.assertEqual(delayable_cls.call_count, 1) - delay_args, delay_kwargs = delayable_cls.call_args - # .with_delay() is called on self.product - self.assertEqual(delay_args, (self.product,)) - # .with_delay() with the following options - self.assertEqual(delay_kwargs.get("identity_key"), identity_exact) - # check what's passed to the job method 'moves_auto_assign' - self.assertEqual(delayable.moves_auto_assign.call_count, 1) - delay_args, delay_kwargs = delayable.moves_auto_assign.call_args - self.assertEqual(delay_args, (self.out_type.default_location_src_id,)) - self.assertDictEqual(delay_kwargs, {}) + trap.assert_jobs_count(1) + trap.assert_enqueued_job( + self.product.moves_auto_assign, + args=(self.out_type.default_location_src_id,), + kwargs={}, + properties=dict( + identity_key=identity_exact, + ), + ) def test_move_canceled_without_reservation_no_job(self): move = self._create_move(self.product, self.out_type, qty=100) move._action_assign() - with mock_with_delay() as (delayable_cls, delayable): + with trap_jobs() as trap: move._action_cancel() # .with_delay() has not been called - self.assertEqual(delayable_cls.call_count, 0) + trap.assert_jobs_count(0) def test_move_done_service_no_job(self): """Service products do not enqueue job""" @@ -79,10 +75,10 @@ class TestStockMoveAutoAssign(StockMoveAutoAssignCase): move._action_assign() move.move_line_ids.qty_done = 1 move.move_line_ids.location_dest_id = self.shelf1_loc.id - with mock_with_delay() as (delayable_cls, delayable): + with trap_jobs() as trap: move._action_done() # .with_delay() has not been called - self.assertEqual(delayable_cls.call_count, 0) + trap.assert_jobs_count(0) def test_move_done_chained_no_job(self): """A move chained to another does not enqueue job""" @@ -93,10 +89,10 @@ class TestStockMoveAutoAssign(StockMoveAutoAssignCase): move._action_assign() move.move_line_ids.qty_done = 1 move.move_line_ids.location_dest_id = self.shelf1_loc.id - with mock_with_delay() as (delayable_cls, delayable): + with trap_jobs() as trap: move._action_done() # .with_delay() has not been called - self.assertEqual(delayable_cls.call_count, 0) + trap.assert_jobs_count(0) def test_move_done_customer_no_job(self): """A move with other destination than internal does not enqueue job""" @@ -105,7 +101,7 @@ class TestStockMoveAutoAssign(StockMoveAutoAssignCase): move._action_assign() move.move_line_ids.qty_done = 1 move.move_line_ids.location_dest_id = self.customer_loc - with mock_with_delay() as (delayable_cls, delayable): + with trap_jobs() as trap: move._action_done() # .with_delay() has not been called - self.assertEqual(delayable_cls.call_count, 0) + trap.assert_jobs_count(0) diff --git a/stock_move_auto_assign_auto_release/README.rst b/stock_move_auto_assign_auto_release/README.rst new file mode 100644 index 000000000..45a10ea0c --- /dev/null +++ b/stock_move_auto_assign_auto_release/README.rst @@ -0,0 +1,90 @@ +=================================== +Stock Move Auto Assign Auto Release +=================================== + +.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistic--warehouse-lightgray.png?logo=github + :target: https://github.com/OCA/stock-logistic-warehouse/tree/16.0/stock_move_auto_assign_auto_release + :alt: OCA/stock-logistic-warehouse +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/stock-logistic-warehouse-16-0/stock-logistic-warehouse-16-0-stock_move_auto_assign_auto_release + :alt: Translate me on Weblate + +|badge1| |badge2| |badge3| |badge4| + +Automatically release stock moves when a move is set to "done" and the product +becomes available. + +It uses queue jobs to release the moves in order to have a minimal impact +on the user operations. + +The conditions to trigger the check are: + +* A job to check the availability of stock moves has been created + +At this point, jobs are generated: + +* One job per product +* Any available moves releasable are processed + +**Table of contents** + +.. contents:: + :local: + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +~~~~~~~ + +* ACSONE SA/NV + +Contributors +~~~~~~~~~~~~ + +* Laurent Mignon + +Other credits +~~~~~~~~~~~~~ + +The development of this module has been financially supported by: + +* Alcyon Belux Distrib Vétérinaire + +Maintainers +~~~~~~~~~~~ + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/stock-logistic-warehouse `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/stock_move_auto_assign_auto_release/__init__.py b/stock_move_auto_assign_auto_release/__init__.py new file mode 100644 index 000000000..0650744f6 --- /dev/null +++ b/stock_move_auto_assign_auto_release/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/stock_move_auto_assign_auto_release/__manifest__.py b/stock_move_auto_assign_auto_release/__manifest__.py new file mode 100644 index 000000000..26df3f336 --- /dev/null +++ b/stock_move_auto_assign_auto_release/__manifest__.py @@ -0,0 +1,19 @@ +# Copyright 2022 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +{ + "name": "Stock Move Auto Assign Auto Release", + "summary": """ + Auto release moves after auto assign""", + "version": "16.0.1.0.0", + "license": "AGPL-3", + "author": "ACSONE SA/NV,Odoo Community Association (OCA)", + "website": "https://github.com/OCA/stock-logistics-warehouse", + "depends": [ + "stock_available_to_promise_release", + "stock_move_auto_assign", + ], + "data": ["data/queue_job_channel_data.xml", "data/queue_job_function_data.xml"], + "demo": [], + "installable": True, +} diff --git a/stock_move_auto_assign_auto_release/data/queue_job_channel_data.xml b/stock_move_auto_assign_auto_release/data/queue_job_channel_data.xml new file mode 100644 index 000000000..4c8774bd5 --- /dev/null +++ b/stock_move_auto_assign_auto_release/data/queue_job_channel_data.xml @@ -0,0 +1,7 @@ + + + + stock_auto_release + + + diff --git a/stock_move_auto_assign_auto_release/data/queue_job_function_data.xml b/stock_move_auto_assign_auto_release/data/queue_job_function_data.xml new file mode 100644 index 000000000..1b01bdfae --- /dev/null +++ b/stock_move_auto_assign_auto_release/data/queue_job_function_data.xml @@ -0,0 +1,12 @@ + + + + + moves_auto_release + + + + diff --git a/stock_move_auto_assign_auto_release/models/__init__.py b/stock_move_auto_assign_auto_release/models/__init__.py new file mode 100644 index 000000000..119d6f6f5 --- /dev/null +++ b/stock_move_auto_assign_auto_release/models/__init__.py @@ -0,0 +1,3 @@ +from . import stock_move +from . import product_product +from . import stock_picking diff --git a/stock_move_auto_assign_auto_release/models/product_product.py b/stock_move_auto_assign_auto_release/models/product_product.py new file mode 100644 index 000000000..d099250cd --- /dev/null +++ b/stock_move_auto_assign_auto_release/models/product_product.py @@ -0,0 +1,29 @@ +# Copyright 2022 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import models + + +class ProductProduct(models.Model): + + _inherit = "product.product" + + def _moves_auto_release_domain(self): + return [ + ("product_id", "=", self.id), + ("is_auto_release_allowed", "=", True), + ] + + def moves_auto_release(self): + """Job trying to auto release moves based on product + + It searches all* the moves auto releasable and trigger the release + available to promise process. + """ + self.ensure_one() + moves = self.env["stock.move"].search(self._moves_auto_release_domain()) + pickings = moves.picking_id + if not pickings: + return + self._lock_pickings_or_retry(pickings) + moves.release_available_to_promise() diff --git a/stock_move_auto_assign_auto_release/models/stock_move.py b/stock_move_auto_assign_auto_release/models/stock_move.py new file mode 100644 index 000000000..33836980a --- /dev/null +++ b/stock_move_auto_assign_auto_release/models/stock_move.py @@ -0,0 +1,72 @@ +# Copyright 2022 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import _, api, fields, models +from odoo.osv.expression import NEGATIVE_TERM_OPERATORS + +from odoo.addons.queue_job.job import identity_exact + + +class StockMove(models.Model): + + _inherit = "stock.move" + + is_auto_release_allowed = fields.Boolean( + compute="_compute_is_auto_release_allowed", + search="_search_is_auto_release_allowed", + ) + + @api.model + def _is_auto_release_allowed_depends(self): + return [ + "state", + "need_release", + "ordered_available_to_promise_uom_qty", + "picking_id.is_auto_release_allowed", + ] + + @api.depends(lambda self: self._is_auto_release_allowed_depends()) + def _compute_is_auto_release_allowed(self): + auto_releaseable_moves = self.filtered_domain( + self._is_auto_release_allowed_domain + ) + auto_releaseable_move_ids = set(auto_releaseable_moves.ids) + for move in self: + move.is_auto_release_allowed = move.id in auto_releaseable_move_ids + + @property + def _is_auto_release_allowed_domain(self): + return [ + ("state", "not in", ("done", "cancel")), + ("need_release", "=", True), + ("ordered_available_to_promise_uom_qty", ">", 0), + ("picking_id.is_auto_release_allowed", "=", True), + ] + + @api.model + def _search_is_auto_release_allowed(self, operator, value): + if "in" in operator: + raise ValueError(f"Invalid operator {operator}") + negative_op = operator in NEGATIVE_TERM_OPERATORS + is_auto_release_allowed = (value and not negative_op) or ( + not value and negative_op + ) + domain = self._is_auto_release_allowed_domain + if not is_auto_release_allowed: + domain = [("id", "not in", self.search(domain).ids)] + return domain + + def _enqueue_auto_assign(self, product, locations, **job_options): + job = super()._enqueue_auto_assign(product, locations, **job_options) + job_options = job_options.copy() + job_options.setdefault( + "description", + _('Try releasing "{}" for quantities added in: {}').format( + product.display_name, ", ".join(locations.mapped("name")) + ), + ) + job_options.setdefault("identity_key", identity_exact) + delayable = product.delayable(**job_options) + release_job = delayable.moves_auto_release() + job.on_done(release_job) + return job diff --git a/stock_move_auto_assign_auto_release/models/stock_picking.py b/stock_move_auto_assign_auto_release/models/stock_picking.py new file mode 100644 index 000000000..8b40daf6f --- /dev/null +++ b/stock_move_auto_assign_auto_release/models/stock_picking.py @@ -0,0 +1,49 @@ +# Copyright 2022 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import api, fields, models +from odoo.osv.expression import NEGATIVE_TERM_OPERATORS + + +class StockPicking(models.Model): + + _inherit = "stock.picking" + + is_auto_release_allowed = fields.Boolean( + compute="_compute_is_auto_release_allowed", + search="_search_is_auto_release_allowed", + ) + + @api.model + def _is_auto_release_allowed_depends(self): + return ["state", "last_release_date", "printed", "release_ready"] + + @api.depends(lambda self: self._is_auto_release_allowed_depends()) + def _compute_is_auto_release_allowed(self): + auto_releaseable_pickings = self.filtered_domain( + self._is_auto_release_allowed_domain + ) + auto_releaseable_picking_ids = set(auto_releaseable_pickings.ids) + for picking in self: + picking.is_auto_release_allowed = picking.id in auto_releaseable_picking_ids + + @property + def _is_auto_release_allowed_domain(self): + return [ + ("state", "not in", ("done", "cancel")), + ("printed", "!=", True), + ("release_ready", "=", True), + ] + + @api.model + def _search_is_auto_release_allowed(self, operator, value): + if "in" in operator: + raise ValueError(f"Invalid operator {operator}") + negative_op = operator in NEGATIVE_TERM_OPERATORS + is_auto_release_allowed = (value and not negative_op) or ( + not value and negative_op + ) + domain = self._is_auto_release_allowed_domain + if not is_auto_release_allowed: + domain = [("id", "not in", self.search(domain).ids)] + return domain diff --git a/stock_move_auto_assign_auto_release/readme/CONTRIBUTORS.rst b/stock_move_auto_assign_auto_release/readme/CONTRIBUTORS.rst new file mode 100644 index 000000000..172b2d223 --- /dev/null +++ b/stock_move_auto_assign_auto_release/readme/CONTRIBUTORS.rst @@ -0,0 +1 @@ +* Laurent Mignon diff --git a/stock_move_auto_assign_auto_release/readme/CREDITS.rst b/stock_move_auto_assign_auto_release/readme/CREDITS.rst new file mode 100644 index 000000000..ea90c7c25 --- /dev/null +++ b/stock_move_auto_assign_auto_release/readme/CREDITS.rst @@ -0,0 +1,3 @@ +The development of this module has been financially supported by: + +* Alcyon Belux Distrib Vétérinaire diff --git a/stock_move_auto_assign_auto_release/readme/DESCRIPTION.rst b/stock_move_auto_assign_auto_release/readme/DESCRIPTION.rst new file mode 100644 index 000000000..89cc2cf9d --- /dev/null +++ b/stock_move_auto_assign_auto_release/readme/DESCRIPTION.rst @@ -0,0 +1,14 @@ +Automatically release stock moves when a move is set to "done" and the product +becomes available. + +It uses queue jobs to release the moves in order to have a minimal impact +on the user operations. + +The conditions to trigger the check are: + +* A job to check the availability of stock moves has been created + +At this point, jobs are generated: + +* One job per product +* Any available moves releasable are processed diff --git a/stock_move_auto_assign_auto_release/static/description/icon.png b/stock_move_auto_assign_auto_release/static/description/icon.png new file mode 100644 index 000000000..3a0328b51 Binary files /dev/null and b/stock_move_auto_assign_auto_release/static/description/icon.png differ diff --git a/stock_move_auto_assign_auto_release/static/description/index.html b/stock_move_auto_assign_auto_release/static/description/index.html new file mode 100644 index 000000000..9336b3dd2 --- /dev/null +++ b/stock_move_auto_assign_auto_release/static/description/index.html @@ -0,0 +1,439 @@ + + + + + + +Stock Move Auto Assign Auto Release + + + +
+

Stock Move Auto Assign Auto Release

+ + +

Beta License: AGPL-3 OCA/stock-logistic-warehouse Translate me on Weblate

+

Automatically release stock moves when a move is set to “done” and the product +becomes available.

+

It uses queue jobs to release the moves in order to have a minimal impact +on the user operations.

+

The conditions to trigger the check are:

+
    +
  • A job to check the availability of stock moves has been created
    • +
+

At this point, jobs are generated:

+
    +
  • One job per product
    • +
  • Any available moves releasable are processed
    • +
+

Table of contents

+ +
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • ACSONE SA/NV
    • +
+
+
+

Contributors

+ +
+
+

Other credits

+

The development of this module has been financially supported by:

+
    +
  • Alcyon Belux Distrib Vétérinaire
    • +
+
+
+

Maintainers

+

This module is maintained by the OCA.

+Odoo Community Association +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

This module is part of the OCA/stock-logistic-warehouse project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/stock_move_auto_assign_auto_release/tests/__init__.py b/stock_move_auto_assign_auto_release/tests/__init__.py new file mode 100644 index 000000000..603667525 --- /dev/null +++ b/stock_move_auto_assign_auto_release/tests/__init__.py @@ -0,0 +1 @@ +from . import test_assign_auto_release diff --git a/stock_move_auto_assign_auto_release/tests/test_assign_auto_release.py b/stock_move_auto_assign_auto_release/tests/test_assign_auto_release.py new file mode 100644 index 000000000..ae99a2708 --- /dev/null +++ b/stock_move_auto_assign_auto_release/tests/test_assign_auto_release.py @@ -0,0 +1,167 @@ +# Copyright 2022 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +from datetime import datetime + +from odoo.addons.queue_job.job import identity_exact +from odoo.addons.queue_job.tests.common import trap_jobs +from odoo.addons.stock_available_to_promise_release.tests.common import ( + PromiseReleaseCommonCase, +) + +RELEASABLE_DOMAINS = [ + [("is_auto_release_allowed", "=", True)], + [("is_auto_release_allowed", "!=", False)], +] + +NOT_RELEASABLE_DOMAINS = [ + [("is_auto_release_allowed", "=", False)], + [("is_auto_release_allowed", "!=", True)], +] + + +class TestAssignAutoRelease(PromiseReleaseCommonCase): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.wh.delivery_route_id.write( + { + "available_to_promise_defer_pull": True, + "no_backorder_at_release": True, + } + ) + cls.in_type = cls.wh.in_type_id + cls.loc_supplier = cls.env.ref("stock.stock_location_suppliers") + cls.shipping = cls._out_picking( + cls._create_picking_chain( + cls.wh, [(cls.product1, 10)], date=datetime(2019, 9, 2, 16, 0) + ) + ) + cls._update_qty_in_location(cls.loc_bin1, cls.product1, 5.0) + cls.shipping.release_available_to_promise() + cls.picking = cls._prev_picking(cls.shipping) + cls.picking.action_assign() + cls.unreleased_move = cls.shipping.move_ids.filtered("need_release") + + def _create_move( + self, + product, + picking_type, + qty=1.0, + state="confirmed", + procure_method="make_to_stock", + move_dest=None, + ): + source = picking_type.default_location_src_id or self.loc_supplier + dest = picking_type.default_location_dest_id or self.loc_customer + move_vals = { + "name": product.name, + "product_id": product.id, + "product_uom_qty": qty, + "product_uom": product.uom_id.id, + "picking_type_id": picking_type.id, + "location_id": source.id, + "location_dest_id": dest.id, + "state": state, + "procure_method": procure_method, + } + if move_dest: + move_vals["move_dest_ids"] = [(4, move_dest.id, False)] + return self.env["stock.move"].create(move_vals) + + def _get_job_for_method(self, jobs, method): + for job in jobs: + if str(job.func) == str(method): + return job + return None + + def _receive_product(self, product=None, qty=None): + qty = qty or 100 + move = self._create_move(product or self.product1, self.in_type, qty=qty) + move._action_assign() + move.move_line_ids.qty_done = qty + move.move_line_ids.location_dest_id = self.loc_bin1.id + move._action_done() + + def test_product_moves_auto_release(self): + """Test job method, update qty available and launch auto release on + the product""" + self.assertEqual(1, len(self.unreleased_move)) + self.assertEqual(1, len(self.picking.move_ids)) + self.assertEqual(5, self.picking.move_ids.product_qty) + # put stock in Stock/Shelf 1, the move has a source location in Stock + self._update_qty_in_location(self.loc_bin1, self.product1, 100) + self.product1.moves_auto_release() + self.assertFalse(self.unreleased_move.need_release) + self.assertEqual(1, len(self.picking.move_ids)) + self.assertEqual(10, self.picking.move_ids.product_qty) + + def test_move_done_enqueue_job(self): + """A move done enqueue 2 new jobs + * 1 to assign other moves + * 1 to release the other moves (This one depends on the first one) + """ + with trap_jobs() as trap: + self._receive_product(self.product1, 100) + # .with_delay() has been called a first one to auto assigned + trap.assert_jobs_count(2) + trap.assert_enqueued_job( + self.product1.moves_auto_assign, + args=(self.loc_bin1,), + kwargs={}, + properties=dict( + identity_key=identity_exact, + ), + ) + # and a second one to auto release + trap.assert_enqueued_job( + self.product1.moves_auto_release, + args=(), + kwargs={}, + properties=dict( + identity_key=identity_exact, + ), + ) + + job1 = self._get_job_for_method( + trap.enqueued_jobs, self.product1.moves_auto_assign + ) + job2 = self._get_job_for_method( + trap.enqueued_jobs, self.product1.moves_auto_release + ) + self.assertIn(job1, job2.depends_on) + + def test_picking_field_is_auto_release_allowed(self): + self.assertFalse(self.shipping.is_auto_release_allowed) + for domain in RELEASABLE_DOMAINS: + self.assertFalse(self.env["stock.picking"].search(domain)) + for domain in NOT_RELEASABLE_DOMAINS: + self.assertTrue(self.env["stock.picking"].search(domain)) + self._receive_product(self.product1, 100) + self.product1.moves_auto_assign(self.loc_bin1) + self.env.invalidate_all() + self.assertTrue(self.shipping.is_auto_release_allowed) + for domain in RELEASABLE_DOMAINS: + self.assertEqual(self.shipping, self.env["stock.picking"].search(domain)) + for domain in NOT_RELEASABLE_DOMAINS: + self.assertNotIn(self.shipping, self.env["stock.picking"].search(domain)) + + def test_move_field_is_auto_release_allowed(self): + moves = self.shipping.move_ids + move_released = moves.filtered(lambda m: not m.need_release) + move_not_released = moves.filtered("need_release") + self.assertFalse(move_released.is_auto_release_allowed) + self.assertFalse(move_not_released.is_auto_release_allowed) + for domain in RELEASABLE_DOMAINS: + self.assertFalse(self.env["stock.move"].search(domain)) + for domain in NOT_RELEASABLE_DOMAINS: + self.assertTrue(self.env["stock.move"].search(domain)) + self._receive_product(self.product1, 100) + self.product1.moves_auto_assign(self.loc_bin1) + self.env.invalidate_all() + self.assertFalse(move_released.is_auto_release_allowed) + self.assertTrue(move_not_released.is_auto_release_allowed) + for domain in RELEASABLE_DOMAINS: + self.assertEqual(move_not_released, self.env["stock.move"].search(domain)) + for domain in NOT_RELEASABLE_DOMAINS: + self.assertIn(move_released, self.env["stock.move"].search(domain)) + self.assertNotIn(move_not_released, self.env["stock.move"].search(domain))