From 3a5772169681033fe36fc9df1a80748ea1afb4a5 Mon Sep 17 00:00:00 2001 From: "Laurent Mignon (ACSONE)" Date: Tue, 20 Feb 2024 11:01:43 +0100 Subject: [PATCH] [ADD] stock_quant_safe_inventory: Prevent inventory on quant being processed --- .../odoo/addons/stock_quant_safe_inventory | 1 + setup/stock_quant_safe_inventory/setup.py | 6 + stock_quant_safe_inventory/README.rst | 103 ++++ stock_quant_safe_inventory/__init__.py | 1 + stock_quant_safe_inventory/__manifest__.py | 21 + stock_quant_safe_inventory/models/__init__.py | 3 + .../models/res_company.py | 16 + .../models/res_config_settings.py | 12 + .../models/stock_quant.py | 89 ++++ stock_quant_safe_inventory/readme/CONTEXT.md | 13 + .../readme/CONTRIBUTORS.md | 1 + .../readme/DESCRIPTION.md | 4 + stock_quant_safe_inventory/readme/USAGE.md | 3 + .../static/description/icon.png | Bin 0 -> 9455 bytes .../static/description/index.html | 447 ++++++++++++++++++ stock_quant_safe_inventory/tests/__init__.py | 1 + .../tests/test_safe_inventory.py | 73 +++ .../views/res_config_settings.xml | 31 ++ 18 files changed, 825 insertions(+) create mode 120000 setup/stock_quant_safe_inventory/odoo/addons/stock_quant_safe_inventory create mode 100644 setup/stock_quant_safe_inventory/setup.py create mode 100644 stock_quant_safe_inventory/README.rst create mode 100644 stock_quant_safe_inventory/__init__.py create mode 100644 stock_quant_safe_inventory/__manifest__.py create mode 100644 stock_quant_safe_inventory/models/__init__.py create mode 100644 stock_quant_safe_inventory/models/res_company.py create mode 100644 stock_quant_safe_inventory/models/res_config_settings.py create mode 100644 stock_quant_safe_inventory/models/stock_quant.py create mode 100644 stock_quant_safe_inventory/readme/CONTEXT.md create mode 100644 stock_quant_safe_inventory/readme/CONTRIBUTORS.md create mode 100644 stock_quant_safe_inventory/readme/DESCRIPTION.md create mode 100644 stock_quant_safe_inventory/readme/USAGE.md create mode 100644 stock_quant_safe_inventory/static/description/icon.png create mode 100644 stock_quant_safe_inventory/static/description/index.html create mode 100644 stock_quant_safe_inventory/tests/__init__.py create mode 100644 stock_quant_safe_inventory/tests/test_safe_inventory.py create mode 100644 stock_quant_safe_inventory/views/res_config_settings.xml diff --git a/setup/stock_quant_safe_inventory/odoo/addons/stock_quant_safe_inventory b/setup/stock_quant_safe_inventory/odoo/addons/stock_quant_safe_inventory new file mode 120000 index 000000000..57801c440 --- /dev/null +++ b/setup/stock_quant_safe_inventory/odoo/addons/stock_quant_safe_inventory @@ -0,0 +1 @@ +../../../../stock_quant_safe_inventory \ No newline at end of file diff --git a/setup/stock_quant_safe_inventory/setup.py b/setup/stock_quant_safe_inventory/setup.py new file mode 100644 index 000000000..28c57bb64 --- /dev/null +++ b/setup/stock_quant_safe_inventory/setup.py @@ -0,0 +1,6 @@ +import setuptools + +setuptools.setup( + setup_requires=['setuptools-odoo'], + odoo_addon=True, +) diff --git a/stock_quant_safe_inventory/README.rst b/stock_quant_safe_inventory/README.rst new file mode 100644 index 000000000..881426fc2 --- /dev/null +++ b/stock_quant_safe_inventory/README.rst @@ -0,0 +1,103 @@ +========================== +Stock Quant Safe Inventory +========================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:8d5ca98684eb4061dab8a6fd933f66881a81d33a3d885ebfc8b0d1e87dd9849d + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github + :target: https://github.com/OCA/stock-logistics-warehouse/tree/16.0/stock_quant_safe_inventory + :alt: OCA/stock-logistics-warehouse +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_safe_inventory + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-warehouse&target_branch=16.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module prevents the user from updating the quantity on a quant if +some quantity has been put as done on a move line not yet validated for +the same product, location, lot and package. + +**Table of contents** + +.. contents:: + :local: + +Use Cases / Context +=================== + +In odoo, you can update the quantity on a quant by filling the counted +quantity on the quant form view and clicking on the "Apply inventory" +button at the end of the line. Unfortunately, nothing prevents you from +doing this for a quant and location in front of which you are standing +to perform an inventory while some quantity have already been picked +from the location by another user but not yet validated. This can lead +to stock discrepancies since the quantity you are updating is not the +actual quantity in the location for the system and when the picking will +be validated, the system will decrease the quantity you just updated by +the quantity that was picked by the other user. + +This module prevents this by preventing the user from updating the +quantity on a quant if some quantity has been put as done on a move line +not yet validated for the same product, location, lot and package. + +Usage +===== + +To prevent inventory of quants being processed you must check the +``Stock quant no inventory if being picked`` parameter into the stock +settings panel. (stock -> configuration -> settings) + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* ACSONE SA/NV + +Contributors +------------ + +- Laurent Mignon laurent.mignon@acsone.eu (https://www.acsone.eu) + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/stock-logistics-warehouse `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/stock_quant_safe_inventory/__init__.py b/stock_quant_safe_inventory/__init__.py new file mode 100644 index 000000000..0650744f6 --- /dev/null +++ b/stock_quant_safe_inventory/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/stock_quant_safe_inventory/__manifest__.py b/stock_quant_safe_inventory/__manifest__.py new file mode 100644 index 000000000..7fe4fdcd3 --- /dev/null +++ b/stock_quant_safe_inventory/__manifest__.py @@ -0,0 +1,21 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +{ + "name": "Stock Quant Safe Inventory", + "summary": """ + Prevents the quantity on the quant from being updated if quantities have + already been picked but not validated in pickings in progress.""", + "version": "16.0.1.0.0", + "license": "AGPL-3", + "author": "ACSONE SA/NV,Odoo Community Association (OCA)", + "website": "https://github.com/OCA/stock-logistics-warehouse", + "depends": [ + "stock", + ], + "data": [ + "views/res_config_settings.xml", + ], + "demo": [], + "installable": True, +} diff --git a/stock_quant_safe_inventory/models/__init__.py b/stock_quant_safe_inventory/models/__init__.py new file mode 100644 index 000000000..e55dfd12a --- /dev/null +++ b/stock_quant_safe_inventory/models/__init__.py @@ -0,0 +1,3 @@ +from . import res_company +from . import res_config_settings +from . import stock_quant diff --git a/stock_quant_safe_inventory/models/res_company.py b/stock_quant_safe_inventory/models/res_company.py new file mode 100644 index 000000000..9ccf95029 --- /dev/null +++ b/stock_quant_safe_inventory/models/res_company.py @@ -0,0 +1,16 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import fields, models + + +class ResCompany(models.Model): + _inherit = "res.company" + + stock_quant_no_inventory_if_being_picked = fields.Boolean( + string="Stock quant no inventory if being picked", + help="If checked, the system will prevent inventory of stock quants if " + "some quantities are currently being picked for the same product, " + "location, lot and package.", + default=False, + ) diff --git a/stock_quant_safe_inventory/models/res_config_settings.py b/stock_quant_safe_inventory/models/res_config_settings.py new file mode 100644 index 000000000..44310a941 --- /dev/null +++ b/stock_quant_safe_inventory/models/res_config_settings.py @@ -0,0 +1,12 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import fields, models + + +class ResConfigSettings(models.TransientModel): + _inherit = "res.config.settings" + + stock_quant_no_inventory_if_being_picked = fields.Boolean( + related="company_id.stock_quant_no_inventory_if_being_picked", readonly=False + ) diff --git a/stock_quant_safe_inventory/models/stock_quant.py b/stock_quant_safe_inventory/models/stock_quant.py new file mode 100644 index 000000000..06ac3d747 --- /dev/null +++ b/stock_quant_safe_inventory/models/stock_quant.py @@ -0,0 +1,89 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import _, api, models +from odoo.exceptions import UserError +from odoo.tools import groupby + + +class StockQuant(models.Model): + _inherit = "stock.quant" + + @api.model + def _quant_move_common_keys(self): + """Return the list of fields that are used to select quant from move lines.""" + return [ + "location_id", + "product_id", + "lot_id", + "package_id", + "owner_id", + "company_id", + ] + + def _get_current_move_lines(self): + """Return a dictionary of move lines that are currently in progress + by quant. + + This method returns a dictionary with the key being the quant id and + the value being a list of move lines that are currently in progress + for that quant. + + A move line is considered to be in progress if it is not done and + its quantity done is positive for the same product, location, lot + and package as the quant. + """ + quants = self.filtered("reserved_quantity") + quant_selection_keys = self._quant_move_common_keys() + move_lines = self.env["stock.move.line"].search( + [ + ("state", "not in", ("done", "cancel")), + ("location_id", "in", quants.mapped("location_id").ids), + ("qty_done", ">", 0.0), + ] + ) + move_lines_by_location_by_product = dict( + groupby( + move_lines, + lambda ml: tuple([ml[quant_key] for quant_key in quant_selection_keys]), + ) + ) + ret = {} + for quant in quants: + key = tuple([quant[quant_key] for quant_key in quant_selection_keys]) + move_lines = move_lines_by_location_by_product.get(key, []) + if move_lines: + ret[quant.id] = move_lines + return ret + + def _check_update_quantity_allowed(self, raise_exception=True): + if not self.env.company.stock_quant_no_inventory_if_being_picked: + return + current_move_lines = self._get_current_move_lines() + if current_move_lines: + if raise_exception: + details = [] + for quant in self: + move_lines = current_move_lines.get(quant.id, []) + if move_lines: + details.extend( + f"{move_line.qty_done} {move_line.product_id.name} " + f"-> {move_line.location_id.name}" + for move_line in move_lines + ) + raise UserError( + _( + "You cannot update the quantity of a quant that is " + "currently being picked.\n %(details)s", + details="\n".join(details), + ) + ) + + def write(self, vals): + if "inventory_quantity" in vals: + self._check_update_quantity_allowed() + return super().write(vals) + + def _apply_inventory(self): + self.filtered("inventory_diff_quantity")._check_update_quantity_allowed() + return super()._apply_inventory() diff --git a/stock_quant_safe_inventory/readme/CONTEXT.md b/stock_quant_safe_inventory/readme/CONTEXT.md new file mode 100644 index 000000000..b38c47bd7 --- /dev/null +++ b/stock_quant_safe_inventory/readme/CONTEXT.md @@ -0,0 +1,13 @@ +In odoo, you can update the quantity on a quant by filling the +counted quantity on the quant form view and clicking on the "Apply inventory" +button at the end of the line. Unfortunately, nothing prevents you from doing +this for a quant and location in front of which you are standing to perform +an inventory while some quantity have already been picked from the location by +another user but not yet validated. This can lead to stock discrepancies since +the quantity you are updating is not the actual quantity in the location for the +system and when the picking will be validated, the system will decrease the +quantity you just updated by the quantity that was picked by the other user. + +This module prevents this by preventing the user from updating the quantity on +a quant if some quantity has been put as done on a move line not yet validated +for the same product, location, lot and package. diff --git a/stock_quant_safe_inventory/readme/CONTRIBUTORS.md b/stock_quant_safe_inventory/readme/CONTRIBUTORS.md new file mode 100644 index 000000000..a15e3ef24 --- /dev/null +++ b/stock_quant_safe_inventory/readme/CONTRIBUTORS.md @@ -0,0 +1 @@ +- Laurent Mignon (https://www.acsone.eu) diff --git a/stock_quant_safe_inventory/readme/DESCRIPTION.md b/stock_quant_safe_inventory/readme/DESCRIPTION.md new file mode 100644 index 000000000..725b083e2 --- /dev/null +++ b/stock_quant_safe_inventory/readme/DESCRIPTION.md @@ -0,0 +1,4 @@ +This module prevents the user from updating the quantity on a quant if some +quantity has been put as done on a move line not yet validated for the same +product, location, lot and package. + diff --git a/stock_quant_safe_inventory/readme/USAGE.md b/stock_quant_safe_inventory/readme/USAGE.md new file mode 100644 index 000000000..15bc862cd --- /dev/null +++ b/stock_quant_safe_inventory/readme/USAGE.md @@ -0,0 +1,3 @@ +To prevent inventory of quants being processed you must check the +`Stock quant no inventory if being picked` parameter into the stock +settings panel. (stock -> configuration -> settings) diff --git a/stock_quant_safe_inventory/static/description/icon.png b/stock_quant_safe_inventory/static/description/icon.png new file mode 100644 index 0000000000000000000000000000000000000000..3a0328b516c4980e8e44cdb63fd945757ddd132d GIT binary patch literal 9455 zcmW++2RxMjAAjx~&dlBk9S+%}OXg)AGE&Cb*&}d0jUxM@u(PQx^-s)697TX`ehR4?GS^qbkof1cslKgkU)h65qZ9Oc=ml_0temigYLJfnz{IDzUf>bGs4N!v3=Z3jMq&A#7%rM5eQ#dc?k~! zVpnB`o+K7|Al`Q_U;eD$B zfJtP*jH`siUq~{KE)`jP2|#TUEFGRryE2`i0**z#*^6~AI|YzIWy$Cu#CSLW3q=GA z6`?GZymC;dCPk~rBS%eCb`5OLr;RUZ;D`}um=H)BfVIq%7VhiMr)_#G0N#zrNH|__ zc+blN2UAB0=617@>_u;MPHN;P;N#YoE=)R#i$k_`UAA>WWCcEVMh~L_ zj--gtp&|K1#58Yz*AHCTMziU1Jzt_jG0I@qAOHsk$2}yTmVkBp_eHuY$A9)>P6o~I z%aQ?!(GqeQ-Y+b0I(m9pwgi(IIZZzsbMv+9w{PFtd_<_(LA~0H(xz{=FhLB@(1&qHA5EJw1>>=%q2f&^X>IQ{!GJ4e9U z&KlB)z(84HmNgm2hg2C0>WM{E(DdPr+EeU_N@57;PC2&DmGFW_9kP&%?X4}+xWi)( z;)z%wI5>D4a*5XwD)P--sPkoY(a~WBw;E~AW`Yue4kFa^LM3X`8x|}ZUeMnqr}>kH zG%WWW>3ml$Yez?i%)2pbKPI7?5o?hydokgQyZsNEr{a|mLdt;X2TX(#B1j35xPnPW z*bMSSOauW>o;*=kO8ojw91VX!qoOQb)zHJ!odWB}d+*K?#sY_jqPdg{Sm2HdYzdEx zOGVPhVRTGPtv0o}RfVP;Nd(|CB)I;*t&QO8h zFfekr30S!-LHmV_Su-W+rEwYXJ^;6&3|L$mMC8*bQptyOo9;>Qb9Q9`ySe3%V$A*9 zeKEe+b0{#KWGp$F+tga)0RtI)nhMa-K@JS}2krK~n8vJ=Ngm?R!9G<~RyuU0d?nz# z-5EK$o(!F?hmX*2Yt6+coY`6jGbb7tF#6nHA zuKk=GGJ;ZwON1iAfG$E#Y7MnZVmrY|j0eVI(DN_MNFJmyZ|;w4tf@=CCDZ#5N_0K= z$;R~bbk?}TpfDjfB&aiQ$VA}s?P}xPERJG{kxk5~R`iRS(SK5d+Xs9swCozZISbnS zk!)I0>t=A<-^z(cmSFz3=jZ23u13X><0b)P)^1T_))Kr`e!-pb#q&J*Q`p+B6la%C zuVl&0duN<;uOsB3%T9Fp8t{ED108<+W(nOZd?gDnfNBC3>M8WE61$So|P zVvqH0SNtDTcsUdzaMDpT=Ty0pDHHNL@Z0w$Y`XO z2M-_r1S+GaH%pz#Uy0*w$Vdl=X=rQXEzO}d6J^R6zjM1u&c9vYLvLp?W7w(?np9x1 zE_0JSAJCPB%i7p*Wvg)pn5T`8k3-uR?*NT|J`eS#_#54p>!p(mLDvmc-3o0mX*mp_ zN*AeS<>#^-{S%W<*mz^!X$w_2dHWpcJ6^j64qFBft-o}o_Vx80o0>}Du;>kLts;$8 zC`7q$QI(dKYG`Wa8#wl@V4jVWBRGQ@1dr-hstpQL)Tl+aqVpGpbSfN>5i&QMXfiZ> zaA?T1VGe?rpQ@;+pkrVdd{klI&jVS@I5_iz!=UMpTsa~mBga?1r}aRBm1WS;TT*s0f0lY=JBl66Upy)-k4J}lh=P^8(SXk~0xW=T9v*B|gzIhN z>qsO7dFd~mgxAy4V?&)=5ieYq?zi?ZEoj)&2o)RLy=@hbCRcfT5jigwtQGE{L*8<@Yd{zg;CsL5mvzfDY}P-wos_6PfprFVaeqNE%h zKZhLtcQld;ZD+>=nqN~>GvROfueSzJD&BE*}XfU|H&(FssBqY=hPCt`d zH?@s2>I(|;fcW&YM6#V#!kUIP8$Nkdh0A(bEVj``-AAyYgwY~jB zT|I7Bf@%;7aL7Wf4dZ%VqF$eiaC38OV6oy3Z#TER2G+fOCd9Iaoy6aLYbPTN{XRPz z;U!V|vBf%H!}52L2gH_+j;`bTcQRXB+y9onc^wLm5wi3-Be}U>k_u>2Eg$=k!(l@I zcCg+flakT2Nej3i0yn+g+}%NYb?ta;R?(g5SnwsQ49U8Wng8d|{B+lyRcEDvR3+`O{zfmrmvFrL6acVP%yG98X zo&+VBg@px@i)%o?dG(`T;n*$S5*rnyiR#=wW}}GsAcfyQpE|>a{=$Hjg=-*_K;UtD z#z-)AXwSRY?OPefw^iI+ z)AXz#PfEjlwTes|_{sB?4(O@fg0AJ^g8gP}ex9Ucf*@_^J(s_5jJV}c)s$`Myn|Kd z$6>}#q^n{4vN@+Os$m7KV+`}c%4)4pv@06af4-x5#wj!KKb%caK{A&Y#Rfs z-po?Dcb1({W=6FKIUirH&(yg=*6aLCekcKwyfK^JN5{wcA3nhO(o}SK#!CINhI`-I z1)6&n7O&ZmyFMuNwvEic#IiOAwNkR=u5it{B9n2sAJV5pNhar=j5`*N!Na;c7g!l$ z3aYBqUkqqTJ=Re-;)s!EOeij=7SQZ3Hq}ZRds%IM*PtM$wV z@;rlc*NRK7i3y5BETSKuumEN`Xu_8GP1Ri=OKQ$@I^ko8>H6)4rjiG5{VBM>B|%`&&s^)jS|-_95&yc=GqjNo{zFkw%%HHhS~e=s zD#sfS+-?*t|J!+ozP6KvtOl!R)@@-z24}`9{QaVLD^9VCSR2b`b!KC#o;Ki<+wXB6 zx3&O0LOWcg4&rv4QG0)4yb}7BFSEg~=IR5#ZRj8kg}dS7_V&^%#Do==#`u zpy6{ox?jWuR(;pg+f@mT>#HGWHAJRRDDDv~@(IDw&R>9643kK#HN`!1vBJHnC+RM&yIh8{gG2q zA%e*U3|N0XSRa~oX-3EAneep)@{h2vvd3Xvy$7og(sayr@95+e6~Xvi1tUqnIxoIH zVWo*OwYElb#uyW{Imam6f2rGbjR!Y3`#gPqkv57dB6K^wRGxc9B(t|aYDGS=m$&S!NmCtrMMaUg(c zc2qC=2Z`EEFMW-me5B)24AqF*bV5Dr-M5ig(l-WPS%CgaPzs6p_gnCIvTJ=Y<6!gT zVt@AfYCzjjsMEGi=rDQHo0yc;HqoRNnNFeWZgcm?f;cp(6CNylj36DoL(?TS7eU#+ z7&mfr#y))+CJOXQKUMZ7QIdS9@#-}7y2K1{8)cCt0~-X0O!O?Qx#E4Og+;A2SjalQ zs7r?qn0H044=sDN$SRG$arw~n=+T_DNdSrarmu)V6@|?1-ZB#hRn`uilTGPJ@fqEy zGt(f0B+^JDP&f=r{#Y_wi#AVDf-y!RIXU^0jXsFpf>=Ji*TeqSY!H~AMbJdCGLhC) zn7Rx+sXw6uYj;WRYrLd^5IZq@6JI1C^YkgnedZEYy<&4(z%Q$5yv#Boo{AH8n$a zhb4Y3PWdr269&?V%uI$xMcUrMzl=;w<_nm*qr=c3Rl@i5wWB;e-`t7D&c-mcQl7x! zZWB`UGcw=Y2=}~wzrfLx=uet<;m3~=8I~ZRuzvMQUQdr+yTV|ATf1Uuomr__nDf=X zZ3WYJtHp_ri(}SQAPjv+Y+0=fH4krOP@S&=zZ-t1jW1o@}z;xk8 z(Nz1co&El^HK^NrhVHa-_;&88vTU>_J33=%{if;BEY*J#1n59=07jrGQ#IP>@u#3A z;!q+E1Rj3ZJ+!4bq9F8PXJ@yMgZL;>&gYA0%_Kbi8?S=XGM~dnQZQ!yBSgcZhY96H zrWnU;k)qy`rX&&xlDyA%(a1Hhi5CWkmg(`Gb%m(HKi-7Z!LKGRP_B8@`7&hdDy5n= z`OIxqxiVfX@OX1p(mQu>0Ai*v_cTMiw4qRt3~NBvr9oBy0)r>w3p~V0SCm=An6@3n)>@z!|o-$HvDK z|3D2ZMJkLE5loMKl6R^ez@Zz%S$&mbeoqH5`Bb){Ei21q&VP)hWS2tjShfFtGE+$z zzCR$P#uktu+#!w)cX!lWN1XU%K-r=s{|j?)Akf@q#3b#{6cZCuJ~gCxuMXRmI$nGtnH+-h z+GEi!*X=AP<|fG`1>MBdTb?28JYc=fGvAi2I<$B(rs$;eoJCyR6_bc~p!XR@O-+sD z=eH`-ye})I5ic1eL~TDmtfJ|8`0VJ*Yr=hNCd)G1p2MMz4C3^Mj?7;!w|Ly%JqmuW zlIEW^Ft%z?*|fpXda>Jr^1noFZEwFgVV%|*XhH@acv8rdGxeEX{M$(vG{Zw+x(ei@ zmfXb22}8-?Fi`vo-YVrTH*C?a8%M=Hv9MqVH7H^J$KsD?>!SFZ;ZsvnHr_gn=7acz z#W?0eCdVhVMWN12VV^$>WlQ?f;P^{(&pYTops|btm6aj>_Uz+hqpGwB)vWp0Cf5y< zft8-je~nn?W11plq}N)4A{l8I7$!ks_x$PXW-2XaRFswX_BnF{R#6YIwMhAgd5F9X zGmwdadS6(a^fjHtXg8=l?Rc0Sm%hk6E9!5cLVloEy4eh(=FwgP`)~I^5~pBEWo+F6 zSf2ncyMurJN91#cJTy_u8Y}@%!bq1RkGC~-bV@SXRd4F{R-*V`bS+6;W5vZ(&+I<9$;-V|eNfLa5n-6% z2(}&uGRF;p92eS*sE*oR$@pexaqr*meB)VhmIg@h{uzkk$9~qh#cHhw#>O%)b@+(| z^IQgqzuj~Sk(J;swEM-3TrJAPCq9k^^^`q{IItKBRXYe}e0Tdr=Huf7da3$l4PdpwWDop%^}n;dD#K4s#DYA8SHZ z&1!riV4W4R7R#C))JH1~axJ)RYnM$$lIR%6fIVA@zV{XVyx}C+a-Dt8Y9M)^KU0+H zR4IUb2CJ{Hg>CuaXtD50jB(_Tcx=Z$^WYu2u5kubqmwp%drJ6 z?Fo40g!Qd<-l=TQxqHEOuPX0;^z7iX?Ke^a%XT<13TA^5`4Xcw6D@Ur&VT&CUe0d} z1GjOVF1^L@>O)l@?bD~$wzgf(nxX1OGD8fEV?TdJcZc2KoUe|oP1#=$$7ee|xbY)A zDZq+cuTpc(fFdj^=!;{k03C69lMQ(|>uhRfRu%+!k&YOi-3|1QKB z z?n?eq1XP>p-IM$Z^C;2L3itnbJZAip*Zo0aw2bs8@(s^~*8T9go!%dHcAz2lM;`yp zD=7&xjFV$S&5uDaiScyD?B-i1ze`+CoRtz`Wn+Zl&#s4&}MO{@N!ufrzjG$B79)Y2d3tBk&)TxUTw@QS0TEL_?njX|@vq?Uz(nBFK5Pq7*xj#u*R&i|?7+6# z+|r_n#SW&LXhtheZdah{ZVoqwyT{D>MC3nkFF#N)xLi{p7J1jXlmVeb;cP5?e(=f# zuT7fvjSbjS781v?7{)-X3*?>tq?)Yd)~|1{BDS(pqC zC}~H#WXlkUW*H5CDOo<)#x7%RY)A;ShGhI5s*#cRDA8YgqG(HeKDx+#(ZQ?386dv! zlXCO)w91~Vw4AmOcATuV653fa9R$fyK8ul%rG z-wfS zihugoZyr38Im?Zuh6@RcF~t1anQu7>#lPpb#}4cOA!EM11`%f*07RqOVkmX{p~KJ9 z^zP;K#|)$`^Rb{rnHGH{~>1(fawV0*Z#)}M`m8-?ZJV<+e}s9wE# z)l&az?w^5{)`S(%MRzxdNqrs1n*-=jS^_jqE*5XDrA0+VE`5^*p3CuM<&dZEeCjoz zR;uu_H9ZPZV|fQq`Cyw4nscrVwi!fE6ciMmX$!_hN7uF;jjKG)d2@aC4ropY)8etW=xJvni)8eHi`H$%#zn^WJ5NLc-rqk|u&&4Z6fD_m&JfSI1Bvb?b<*n&sfl0^t z=HnmRl`XrFvMKB%9}>PaA`m-fK6a0(8=qPkWS5bb4=v?XcWi&hRY?O5HdulRi4?fN zlsJ*N-0Qw+Yic@s0(2uy%F@ib;GjXt01Fmx5XbRo6+n|pP(&nodMoap^z{~q ziEeaUT@Mxe3vJSfI6?uLND(CNr=#^W<1b}jzW58bIfyWTDle$mmS(|x-0|2UlX+9k zQ^EX7Nw}?EzVoBfT(-LT|=9N@^hcn-_p&sqG z&*oVs2JSU+N4ZD`FhCAWaS;>|wH2G*Id|?pa#@>tyxX`+4HyIArWDvVrX)2WAOQff z0qyHu&-S@i^MS-+j--!pr4fPBj~_8({~e1bfcl0wI1kaoN>mJL6KUPQm5N7lB(ui1 zE-o%kq)&djzWJ}ob<-GfDlkB;F31j-VHKvQUGQ3sp`CwyGJk_i!y^sD0fqC@$9|jO zOqN!r!8-p==F@ZVP=U$qSpY(gQ0)59P1&t@y?5rvg<}E+GB}26NYPp4f2YFQrQtot5mn3wu_qprZ=>Ig-$ zbW26Ws~IgY>}^5w`vTB(G`PTZaDiGBo5o(tp)qli|NeV( z@H_=R8V39rt5J5YB2Ky?4eJJ#b`_iBe2ot~6%7mLt5t8Vwi^Jy7|jWXqa3amOIoRb zOr}WVFP--DsS`1WpN%~)t3R!arKF^Q$e12KEqU36AWwnCBICpH4XCsfnyrHr>$I$4 z!DpKX$OKLWarN7nv@!uIA+~RNO)l$$w}p(;b>mx8pwYvu;dD_unryX_NhT8*Tj>BTrTTL&!?O+%Rv;b?B??gSzdp?6Uug9{ zd@V08Z$BdI?fpoCS$)t4mg4rT8Q_I}h`0d-vYZ^|dOB*Q^S|xqTV*vIg?@fVFSmMpaw0qtTRbx} z({Pg?#{2`sc9)M5N$*N|4;^t$+QP?#mov zGVC@I*lBVrOU-%2y!7%)fAKjpEFsgQc4{amtiHb95KQEwvf<(3T<9-Zm$xIew#P22 zc2Ix|App^>v6(3L_MCU0d3W##AB0M~3D00EWoKZqsJYT(#@w$Y_H7G22M~ApVFTRHMI_3be)Lkn#0F*V8Pq zc}`Cjy$bE;FJ6H7p=0y#R>`}-m4(0F>%@P|?7fx{=R^uFdISRnZ2W_xQhD{YuR3t< z{6yxu=4~JkeA;|(J6_nv#>Nvs&FuLA&PW^he@t(UwFFE8)|a!R{`E`K`i^ZnyE4$k z;(749Ix|oi$c3QbEJ3b~D_kQsPz~fIUKym($a_7dJ?o+40*OLl^{=&oq$<#Q(yyrp z{J-FAniyAw9tPbe&IhQ|a`DqFTVQGQ&Gq3!C2==4x{6EJwiPZ8zub-iXoUtkJiG{} zPaR&}_fn8_z~(=;5lD-aPWD3z8PZS@AaUiomF!G8I}Mf>e~0g#BelA-5#`cj;O5>N Xviia!U7SGha1wx#SCgwmn*{w2TRX*I literal 0 HcmV?d00001 diff --git a/stock_quant_safe_inventory/static/description/index.html b/stock_quant_safe_inventory/static/description/index.html new file mode 100644 index 000000000..dc3dc72a2 --- /dev/null +++ b/stock_quant_safe_inventory/static/description/index.html @@ -0,0 +1,447 @@ + + + + + + +Stock Quant Safe Inventory + + + +
+

Stock Quant Safe Inventory

+ + +

Beta License: AGPL-3 OCA/stock-logistics-warehouse Translate me on Weblate Try me on Runboat

+

This module prevents the user from updating the quantity on a quant if +some quantity has been put as done on a move line not yet validated for +the same product, location, lot and package.

+

Table of contents

+ +
+

Use Cases / Context

+

In odoo, you can update the quantity on a quant by filling the counted +quantity on the quant form view and clicking on the “Apply inventory” +button at the end of the line. Unfortunately, nothing prevents you from +doing this for a quant and location in front of which you are standing +to perform an inventory while some quantity have already been picked +from the location by another user but not yet validated. This can lead +to stock discrepancies since the quantity you are updating is not the +actual quantity in the location for the system and when the picking will +be validated, the system will decrease the quantity you just updated by +the quantity that was picked by the other user.

+

This module prevents this by preventing the user from updating the +quantity on a quant if some quantity has been put as done on a move line +not yet validated for the same product, location, lot and package.

+
+
+

Usage

+

To prevent inventory of quants being processed you must check the +Stock quant no inventory if being picked parameter into the stock +settings panel. (stock -> configuration -> settings)

+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • ACSONE SA/NV
    • +
+
+ +
+

Maintainers

+

This module is maintained by the OCA.

+Odoo Community Association +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

This module is part of the OCA/stock-logistics-warehouse project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/stock_quant_safe_inventory/tests/__init__.py b/stock_quant_safe_inventory/tests/__init__.py new file mode 100644 index 000000000..8f2e66c79 --- /dev/null +++ b/stock_quant_safe_inventory/tests/__init__.py @@ -0,0 +1 @@ +from . import test_safe_inventory diff --git a/stock_quant_safe_inventory/tests/test_safe_inventory.py b/stock_quant_safe_inventory/tests/test_safe_inventory.py new file mode 100644 index 000000000..8a773309d --- /dev/null +++ b/stock_quant_safe_inventory/tests/test_safe_inventory.py @@ -0,0 +1,73 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo.exceptions import UserError + +from odoo.addons.base.tests.common import BaseCommon + + +class TestSafeInventory(BaseCommon): + def setUp(self): + super().setUp() + self.product = self.env["product.product"].create( + { + "name": "Product", + "type": "product", + "categ_id": self.env.ref("product.product_category_all").id, + } + ) + self.location = self.env["stock.location"].create( + {"name": "Location", "usage": "internal"} + ) + self.quant = self.env["stock.quant"].create( + { + "product_id": self.product.id, + "location_id": self.location.id, + "quantity": 10.0, + } + ) + self.picking = self.env["stock.picking"].create( + { + "picking_type_id": self.env.ref("stock.picking_type_in").id, + "location_id": self.location.id, + "location_dest_id": self.env.ref("stock.stock_location_stock").id, + } + ) + self.move = self.env["stock.move"].create( + { + "name": "Move", + "product_id": self.product.id, + "product_uom_qty": 5.0, + "product_uom": self.product.uom_id.id, + "picking_id": self.picking.id, + "location_id": self.location.id, + "location_dest_id": self.env.ref("stock.stock_location_stock").id, + } + ) + + @classmethod + def _make_inventory(cls, product, location, qty): + cls.env["stock.quant"].with_context(inventory_mode=True).create( + { + "product_id": product.id, + "location_id": location.id, + "inventory_quantity": qty, + } + )._apply_inventory() + + def test_safe_inventory_qty_done(self): + self.picking.action_assign() + self.picking.move_line_ids.write({"qty_done": 5.0}) + self.env.company.stock_quant_no_inventory_if_being_picked = True + with self.assertRaisesRegexp( + UserError, + "You cannot update the quantity of a quant that is currently being picked", + ): + self._make_inventory(self.product, self.location, 5.0) + self.env.company.stock_quant_no_inventory_if_being_picked = False + self._make_inventory(self.product, self.location, 5.0) + + def test_safe_inventory_no_qty_done(self): + self.picking.action_assign() + self.env.company.stock_quant_no_inventory_if_being_picked = True + self._make_inventory(self.product, self.location, 5.0) diff --git a/stock_quant_safe_inventory/views/res_config_settings.xml b/stock_quant_safe_inventory/views/res_config_settings.xml new file mode 100644 index 000000000..50b794412 --- /dev/null +++ b/stock_quant_safe_inventory/views/res_config_settings.xml @@ -0,0 +1,31 @@ + + + + + res.config.settings.view + res.config.settings + + +
+
+
+ +
+
+
+
+
+ + +