From 305ab9e6413ad0602750e979a99c6ad538aea3c2 Mon Sep 17 00:00:00 2001
From: Pierrick Brun <pierrick.brun@akretion.com>
Date: Wed, 9 Nov 2022 11:11:35 +0100
Subject: [PATCH] [MIG] scrap_reason_code: Migration to 16.0

---
 scrap_reason_code/__manifest__.py                 |  2 +-
 scrap_reason_code/models/stock_move.py            |  2 +-
 scrap_reason_code/models/stock_scrap.py           | 11 ++++++-----
 scrap_reason_code/tests/test_scrap_reason_code.py |  8 ++++----
 4 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/scrap_reason_code/__manifest__.py b/scrap_reason_code/__manifest__.py
index 11b11fbf7..6ddffce50 100644
--- a/scrap_reason_code/__manifest__.py
+++ b/scrap_reason_code/__manifest__.py
@@ -2,7 +2,7 @@
 
 {
     "name": "Scrap Reason Code",
-    "version": "15.0.1.0.1",
+    "version": "16.0.1.0.1",
     "license": "AGPL-3",
     "summary": "Reason code for scrapping",
     "author": "Open Source Integrators, Odoo Community Association (OCA)",
diff --git a/scrap_reason_code/models/stock_move.py b/scrap_reason_code/models/stock_move.py
index 1192e07a5..db41da403 100644
--- a/scrap_reason_code/models/stock_move.py
+++ b/scrap_reason_code/models/stock_move.py
@@ -8,4 +8,4 @@ from odoo import fields, models
 class StockMove(models.Model):
     _inherit = "stock.move"
 
-    reason_code_id = fields.Many2one("scrap.reason.code", string="Reason code")
+    reason_code_id = fields.Many2one("scrap.reason.code")
diff --git a/scrap_reason_code/models/stock_scrap.py b/scrap_reason_code/models/stock_scrap.py
index 0764ae597..6f00f178c 100644
--- a/scrap_reason_code/models/stock_scrap.py
+++ b/scrap_reason_code/models/stock_scrap.py
@@ -9,7 +9,7 @@ class StockScrap(models.Model):
     _inherit = "stock.scrap"
 
     reason_code_id = fields.Many2one(
-        "scrap.reason.code", string="Reason Code", states={"done": [("readonly", True)]}
+        "scrap.reason.code", states={"done": [("readonly", True)]}
     )
     scrap_location_id = fields.Many2one(readonly=True)
 
@@ -37,7 +37,8 @@ class StockScrap(models.Model):
         self._update_scrap_reason_code_location(vals)
         return super(StockScrap, self).write(vals)
 
-    @api.model
-    def create(self, vals):
-        self._update_scrap_reason_code_location(vals)
-        return super(StockScrap, self).create(vals)
+    @api.model_create_multi
+    def create(self, vals_list):
+        for vals in vals_list:
+            self._update_scrap_reason_code_location(vals)
+        return super().create(vals_list)
diff --git a/scrap_reason_code/tests/test_scrap_reason_code.py b/scrap_reason_code/tests/test_scrap_reason_code.py
index e7a4c416a..27851bf8a 100644
--- a/scrap_reason_code/tests/test_scrap_reason_code.py
+++ b/scrap_reason_code/tests/test_scrap_reason_code.py
@@ -84,8 +84,8 @@ class StockScrap(TransactionCase):
         )
         scrap._onchange_reason_code_id()
         scrap.do_scrap()
-        self.assertEqual(len(picking.move_lines), 2)
-        scrapped_move = picking.move_lines.filtered(lambda m: m.state == "done")
+        self.assertEqual(len(picking.move_ids), 2)
+        scrapped_move = picking.move_ids.filtered(lambda m: m.state == "done")
         self.assertTrue(scrapped_move, "No scrapped move created.")
         self.assertEqual(
             scrapped_move.scrap_ids.ids, [scrap.id], "Wrong scrap linked to the move."
@@ -148,8 +148,8 @@ class StockScrap(TransactionCase):
         )
         scrap2._onchange_reason_code_id()
         scrap2.do_scrap()
-        self.assertEqual(len(picking2.move_lines), 2)
-        scrapped_move = picking2.move_lines.filtered(lambda m: m.state == "done")
+        self.assertEqual(len(picking2.move_ids), 2)
+        scrapped_move = picking2.move_ids.filtered(lambda m: m.state == "done")
         self.assertTrue(scrapped_move, "No scrapped move created.")
         self.assertEqual(
             scrapped_move.scrap_ids.ids, [scrap2.id], "Wrong scrap linked to the move."