From 04b14f152154931712bebbab0bbf81ffcf59114b Mon Sep 17 00:00:00 2001
From: "Pedro M. Baeza" <pedro.baeza@gmail.com>
Date: Mon, 21 Jan 2019 00:20:16 +0100
Subject: [PATCH] [IMP] stock_quant_manual_assign: Add owner to criteria +
 reorder fields + add security groups + hook

---
 .../wizard/assign_manual_quants.py            | 64 ++++++++++++-------
 .../wizard/assign_manual_quants_view.xml      | 11 ++--
 2 files changed, 48 insertions(+), 27 deletions(-)

diff --git a/stock_quant_manual_assign/wizard/assign_manual_quants.py b/stock_quant_manual_assign/wizard/assign_manual_quants.py
index 42339b324..6339fafdd 100644
--- a/stock_quant_manual_assign/wizard/assign_manual_quants.py
+++ b/stock_quant_manual_assign/wizard/assign_manual_quants.py
@@ -47,28 +47,13 @@ class AssignManualQuants(models.TransientModel):
 
     @api.multi
     def assign_quants(self):
-        quant = self.env['stock.quant']
         move = self.move_id
         move._do_unreserve()
-        precision_digits = self.env[
-            'decimal.precision'].precision_get('Product Unit of Measure')
         for line in self.quants_lines:
-            if float_compare(line.qty, 0.0,
-                             precision_digits=precision_digits) > 0:
-                available_quantity = quant._get_available_quantity(
-                    move.product_id,
-                    line.location_id,
-                    lot_id=line.lot_id)
-                if float_compare(available_quantity, 0.0,
-                                 precision_digits=precision_digits) <= 0:
-                    continue
-                move._update_reserved_quantity(line.qty, available_quantity,
-                                               line.location_id,
-                                               lot_id=line.lot_id, strict=True)
-
-        if move.has_move_lines:
-            for ml in move.move_line_ids:
-                ml.qty_done = ml.product_qty
+            line._assign_quant_line()
+        # Auto-fill all lines as done
+        for ml in move.move_line_ids:
+            ml.qty_done = ml.product_qty
         move._recompute_state()
         move.mapped('picking_id')._compute_state()
         return {}
@@ -90,10 +75,13 @@ class AssignManualQuants(models.TransientModel):
             line['location_id'] = quant.location_id.id
             line['lot_id'] = quant.lot_id.id
             line['package_id'] = quant.package_id.id
+            line['owner_id'] = quant.owner_id.id
             line['selected'] = False
             move_lines = move.move_line_ids.filtered(
                 lambda ml: (ml.location_id == quant.location_id and
-                            ml.lot_id == quant.lot_id)
+                            ml.lot_id == quant.lot_id and
+                            ml.owner_id == quant.owner_id and
+                            ml.package_id == quant.package_id)
             )
             line['qty'] = sum(move_lines.mapped('ordered_qty'))
             line['selected'] = bool(line['qty'])
@@ -117,8 +105,12 @@ class AssignManualQuantsLines(models.TransientModel):
         comodel_name='stock.quant', string='Quant', required=True,
         ondelete='cascade', oldname='quant')
     location_id = fields.Many2one(
-        comodel_name='stock.location', string='Location',
-        related='quant_id.location_id', readonly=True)
+        comodel_name='stock.location',
+        string='Location',
+        related='quant_id.location_id',
+        readonly=True,
+        groups="stock.group_stock_multi_locations"
+    )
     lot_id = fields.Many2one(
         comodel_name='stock.production.lot', string='Lot',
         related='quant_id.lot_id', readonly=True,
@@ -127,6 +119,13 @@ class AssignManualQuantsLines(models.TransientModel):
         comodel_name='stock.quant.package', string='Package',
         related='quant_id.package_id', readonly=True,
         groups="stock.group_tracking_lot")
+    owner_id = fields.Many2one(
+        comodel_name='res.partner',
+        string='Owner',
+        related='quant_id.owner_id',
+        readonly=True,
+        groups="stock.group_tracking_owner",
+    )
     # This is not correctly shown as related or computed, so we make it regular
     on_hand = fields.Float(
         readonly=True,
@@ -178,3 +177,24 @@ class AssignManualQuantsLines(models.TransientModel):
                       'done meanwhile or you have manually increased the '
                       'suggested value.')
                 )
+
+    def _assign_quant_line(self):
+        self.ensure_one()
+        quant = self.env['stock.quant']
+        precision_digits = self.env[
+            'decimal.precision'].precision_get('Product Unit of Measure')
+        move = self.assign_wizard.move_id
+        if float_compare(self.qty, 0.0, precision_digits=precision_digits) > 0:
+            available_quantity = quant._get_available_quantity(
+                move.product_id, self.location_id, lot_id=self.lot_id,
+                package_id=self.package_id, owner_id=self.owner_id,
+            )
+            if float_compare(
+                available_quantity, 0.0, precision_digits=precision_digits
+            ) <= 0:
+                return
+            move._update_reserved_quantity(
+                self.qty, available_quantity, self.location_id,
+                lot_id=self.lot_id, package_id=self.package_id,
+                owner_id=self.owner_id, strict=True
+            )
diff --git a/stock_quant_manual_assign/wizard/assign_manual_quants_view.xml b/stock_quant_manual_assign/wizard/assign_manual_quants_view.xml
index 02485b89b..48409fda5 100644
--- a/stock_quant_manual_assign/wizard/assign_manual_quants_view.xml
+++ b/stock_quant_manual_assign/wizard/assign_manual_quants_view.xml
@@ -7,11 +7,12 @@
             <form>
                 <field name='quants_lines' colspan="4">
                     <tree editable="top" delete="0" create="0">
-                        <field name="lot_id" readonly="1"/>
-                        <field name="on_hand" readonly="1"/>
-                        <field name="reserved" readonly="1"/>
-                        <field name="location_id" readonly="1"/>
-                        <field name="package_id" readonly="1"/>
+                        <field name="lot_id"/>
+                        <field name="package_id"/>
+                        <field name="owner_id"/>
+                        <field name="location_id"/>
+                        <field name="on_hand"/>
+                        <field name="reserved"/>
                         <field name="selected"/>
                         <field name="qty" attrs="{'readonly':[('selected', '=', False)]}" sum="qty"/>
                     </tree>