From 857d9e42896628acfe611e616e017e4fdbecb56e Mon Sep 17 00:00:00 2001
From: Chanakya Soni <chanakya.soni@serpentcs.com>
Date: Tue, 9 Mar 2021 17:28:22 +0530
Subject: [PATCH 1/6] [14.0][ADD] Stock Picking Batch Report

---
 stock_picking_batch_report/README.rst         |  88 ++++
 stock_picking_batch_report/__init__.py        |   4 +
 stock_picking_batch_report/__manifest__.py    |  16 +
 stock_picking_batch_report/models/__init__.py |   4 +
 .../models/stock_picking_batch.py             |  26 ++
 .../reports/report_picking_batch.xml          | 428 ++++++++++++++++++
 6 files changed, 566 insertions(+)
 create mode 100644 stock_picking_batch_report/README.rst
 create mode 100644 stock_picking_batch_report/__init__.py
 create mode 100644 stock_picking_batch_report/__manifest__.py
 create mode 100644 stock_picking_batch_report/models/__init__.py
 create mode 100644 stock_picking_batch_report/models/stock_picking_batch.py
 create mode 100644 stock_picking_batch_report/reports/report_picking_batch.xml

diff --git a/stock_picking_batch_report/README.rst b/stock_picking_batch_report/README.rst
new file mode 100644
index 0000000..a25f71a
--- /dev/null
+++ b/stock_picking_batch_report/README.rst
@@ -0,0 +1,88 @@
+==========================
+Stock Picking Batch Report
+==========================
+
+.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Beta
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+    :alt: License: AGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--reporting-lightgray.png?logo=github
+    :target: https://github.com/OCA/stock-logistics-reporting/tree/12.0/stock_picking_product_label
+    :alt: OCA/stock-logistics-reporting
+.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
+    :target: https://translation.odoo-community.org/projects/stock-logistics-reporting-12-0/stock-logistics-reporting-12-0-stock_picking_product_label
+    :alt: Translate me on Weblate
+.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
+    :target: https://runbot.odoo-community.org/runbot/151/12.0
+    :alt: Try me on Runbot
+
+|badge1| |badge2| |badge3| |badge4| |badge5| 
+
+This module allows users to print batch picking.
+
+
+**Table of contents**
+
+.. contents::
+   :local:
+
+Usage
+=====
+
+This module will aggregate pickings by location in Batch.
+Also It will have picking details.
+
+Note: It will work only for 2 step delivery.
+
+
+Guidelines for use:
+
+ * In a Batch Transfer, press the Print Batch Transfer.
+
+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/stock-logistics-reporting/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us smashing it by providing a detailed and welcomed
+`feedback <https://github.com/OCA/stock-logistics-reporting/issues/new?body=module:%20stock_picking_product_label%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+
+Do not contact contributors directly about support or help with technical issues.
+
+Credits
+=======
+
+Authors
+~~~~~~~
+
+* Open Source Integrators
+
+Contributors
+~~~~~~~~~~~~
+
+* Chanakya Soni <csoni@opensourceintegrators.com>
+* Maxime Chambreuil <mchambreuil@opensourceintegrators.com>
+
+Maintainers
+~~~~~~~~~~~
+
+This module is maintained by the OCA.
+
+.. image:: https://odoo-community.org/logo.png
+   :alt: Odoo Community Association
+   :target: https://odoo-community.org
+
+OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.
+
+This module is part of the `OCA/stock-logistics-reporting <https://github.com/OCA/stock-logistics-reporting/tree/12.0/stock_picking_product_label>`_ project on GitHub.
+
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/stock_picking_batch_report/__init__.py b/stock_picking_batch_report/__init__.py
new file mode 100644
index 0000000..bb83730
--- /dev/null
+++ b/stock_picking_batch_report/__init__.py
@@ -0,0 +1,4 @@
+# Copyright (C) 2021 Open Source Integrators
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from . import models
diff --git a/stock_picking_batch_report/__manifest__.py b/stock_picking_batch_report/__manifest__.py
new file mode 100644
index 0000000..b93c4e2
--- /dev/null
+++ b/stock_picking_batch_report/__manifest__.py
@@ -0,0 +1,16 @@
+# Copyright (C) 2021 Open Source Integrators
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+{
+    "name": "Stock Picking Batch Report",
+    "version": "14.0.1.0.0",
+    "author": "Open Source Integrators, " "Odoo Community Association (OCA)",
+    "license": "AGPL-3",
+    "summary": "Stock Picking Batch Report",
+    "category": "Stock",
+    "maintainer": "Open Source Integrators",
+    "website": "https://github.com/OCA/stock-logistics-reporting",
+    "depends": ["stock_picking_batch"],
+    "data": ["reports/report_picking_batch.xml"],
+    "installable": True,
+}
diff --git a/stock_picking_batch_report/models/__init__.py b/stock_picking_batch_report/models/__init__.py
new file mode 100644
index 0000000..ced8a5a
--- /dev/null
+++ b/stock_picking_batch_report/models/__init__.py
@@ -0,0 +1,4 @@
+# Copyright (C) 2021 Open Source Integrators
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from . import stock_picking_batch
diff --git a/stock_picking_batch_report/models/stock_picking_batch.py b/stock_picking_batch_report/models/stock_picking_batch.py
new file mode 100644
index 0000000..38aa50b
--- /dev/null
+++ b/stock_picking_batch_report/models/stock_picking_batch.py
@@ -0,0 +1,26 @@
+# Copyright (C) 2021 Open Source Integrators
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import models
+
+
+class StockPikcingBatch(models.Model):
+    _inherit = "stock.picking.batch"
+
+    def get_out_pickings(self):
+        for rec in self:
+            # TO BE Modified Later
+            # if (
+            # rec.picking_type_id.warehouse_id
+            # and rec.picking_type_id.warehouse_id.delivery_steps != "pick_ship"
+            #             ):
+            #                 raise UserError(
+            #                         _(
+            #                             "This report is only available for "
+            #                    "warehouses configured with 2-steps delivery"
+            #                         )
+            #                     )
+            out_pickings = (
+                rec.mapped("move_ids").mapped("move_dest_ids").mapped("picking_id")
+            )
+        return out_pickings
diff --git a/stock_picking_batch_report/reports/report_picking_batch.xml b/stock_picking_batch_report/reports/report_picking_batch.xml
new file mode 100644
index 0000000..c5f105e
--- /dev/null
+++ b/stock_picking_batch_report/reports/report_picking_batch.xml
@@ -0,0 +1,428 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <data>
+        <template id="stock_picking_batch.report_picking_batch">
+            <t t-call="web.html_container">
+                <t t-foreach="docs" t-as="o">
+                    <t
+                        t-set="move_line_ids"
+                        t-value="o.picking_ids.mapped('move_line_ids').sorted(lambda line: line.location_id.display_name)"
+                    />
+                    <t
+                        t-set="has_serial_number"
+                        t-value="move_line_ids.filtered('lot_id')"
+                        groups="stock.group_production_lot"
+                    />
+                    <t t-call="web.external_layout">
+                        <div class="page">
+                            <div class="d-flex">
+                                <div><h3>Batch : <span t-field="o.name" /></h3></div>
+                                <div class="mr-auto">
+                                    <img
+                                        alt="Barcode"
+                                        t-att-src="'/report/barcode/?type=%s&amp;value=%s&amp;width=%s&amp;height=%s' % ('Code128', quote_plus(o.name or ''), 600, 150)"
+                                        style="width:300px;height:50px"
+                                    />
+                                </div>
+                            </div>
+                            <div t-if="o.user_id">
+                                <strong>Responsible:</strong>
+                                <span t-field="o.user_id" />
+                            </div><br />
+                                <table class="table table-condensed">
+                                    <thead>
+                                        <tr>
+                                            <th width="27%">Location</th>
+                                            <th>Product</th>
+                                            <th t-if="has_serial_number" width="15%">
+                                                <strong>Lot/Serial Number</strong>
+                                            </th>
+                                            <th>Quantity</th>
+                                            <th width="23%">Transfer</th>
+                                        </tr>
+                                    </thead>
+                                    <tbody>
+                                        <tr
+                                        t-foreach="move_line_ids"
+                                        t-as="move_operation"
+                                    >
+                                            <td>
+                                                <span
+                                                t-esc="move_operation.mapped('location_id').display_name"
+                                            />
+                                            </td>
+                                            <td>
+                                                <span
+                                                t-field="move_operation.display_name"
+                                            />
+                                            </td>
+                                            <td
+                                            t-if="has_serial_number"
+                                            class="text-center h6"
+                                            width="15%"
+                                        >
+                                                <img
+                                                t-if="move_operation.lot_id or move_operation.lot_name"
+                                                t-att-src="'/report/barcode/?type=%s&amp;value=%s&amp;width=%s&amp;height=%s&amp;humanreadable=1' % ('Code128', move_operation.lot_id.name, 600, 100)"
+                                                style="width:100%;height:35px;"
+                                                alt="Barcode"
+                                            />
+                                            </td>
+                                            <td>
+                                                <t t-if="not has_package">
+                                                    <t
+                                                    t-if="move_operation.state == 'done'"
+                                                >
+                                                        <span
+                                                        t-esc="sum(move_operation.mapped('qty_done'))"
+                                                    />
+                                                    </t>
+                                                    <t t-else="">
+                                                        <span
+                                                        t-esc="sum(move_operation.mapped('product_uom_qty'))"
+                                                    />
+                                                    </t>
+                                                </t>
+                                                <t t-if="has_package">
+                                                    <span
+                                                    t-esc="sum(move_operation.mapped('qty_done'))"
+                                                />
+                                                </t>
+                                                <span
+                                                t-field="move_operation.uom_id"
+                                                groups="move_operation.group_uom"
+                                            />
+                                            </td>
+                                            <td>
+                                                <span
+                                                t-esc="move_operation.mapped('picking_id').display_name"
+                                            />
+                                            </td>
+                                        </tr>
+                                    </tbody>
+                                </table>
+                                <p style="page-break-after: always;" />
+                                <t t-set="pickings" t-value="o.get_out_pickings()" />
+                                <t t-foreach="pickings" t-as="picking">
+                                    <t
+                                    t-set="picking"
+                                    t-value="picking.with_context(lang=picking.partner_id.lang)"
+                                />
+                                    <t
+                                    t-set="partner"
+                                    t-value="picking.partner_id or (picking.move_lines and picking.move_lines[0].partner_id) or False"
+                                />
+                                    <t t-if="partner" name="partner_header">
+                                        <t t-set="address">
+                                            <div
+                                            t-esc="partner"
+                                            t-options='{"widget": "contact", "fields": ["address", "name", "phone"], "no_marker": True}'
+                                        />
+                                       </t>
+                                    </t>
+
+                                    <div class="page">
+                                        <h2>
+                                            <span t-field="picking.name" />
+                                        </h2>
+                                        <div class="row mt32 mb32">
+                                            <div
+                                            t-if="picking.origin"
+                                            class="col-auto"
+                                            name="div_origin"
+                                        >
+                                                <strong>Order:</strong>
+                                                <p t-field="picking.origin" />
+                                            </div>
+                                            <div
+                                            t-if="picking.state"
+                                            class="col-auto"
+                                            name="div_sched_date"
+                                        >
+                                                <strong>Shipping Date:</strong>
+                                                <t t-if="picking.state == 'done'">
+                                                    <p t-field="picking.date_done" />
+                                                </t>
+                                                <t t-if="picking.state != 'done'">
+                                                    <p
+                                                    t-field="picking.scheduled_date"
+                                                />
+                                               </t>
+                                            </div>
+                                        </div>
+                                        <table
+                                        class="table table-sm"
+                                        t-if="picking.state!='done'"
+                                        name="stock_move_table"
+                                    >
+                                            <thead>
+                                                <tr>
+                                                    <th name="th_sm_product"><strong
+                                                    >Product</strong></th>
+                                                    <th name="th_sm_quantity"><strong
+                                                    >Quantity</strong></th>
+                                                </tr>
+                                            </thead>
+                                            <tbody>
+                                                <t
+                                                t-set="lines"
+                                                t-value="picking.move_lines.filtered(lambda x: x.product_uom_qty)"
+                                            />
+                                                <tr t-foreach="lines" t-as="move">
+                                                    <td>
+                                                        <span
+                                                        t-field="move.product_id"
+                                                    />
+                                                        <p
+                                                        t-if="move.description_picking != move.product_id.name"
+                                                    >
+                                                            <span
+                                                            t-field="move.description_picking"
+                                                        />
+                                                        </p>
+                                                    </td>
+                                                    <td>
+                                                        <span
+                                                        t-field="move.product_uom_qty"
+                                                    />
+                                                        <span
+                                                        t-field="move.product_uom"
+                                                    />
+                                                    </td>
+                                                </tr>
+                                            </tbody>
+                                        </table>
+                                        <table
+                                        class="table table-sm mt48"
+                                        t-if="picking.move_line_ids and picking.state=='done'"
+                                        name="stock_move_line_table"
+                                    >
+                                            <t
+                                            t-set="has_serial_number"
+                                            t-value="False"
+                                        />
+                                            <t
+                                            t-set="has_serial_number"
+                                            t-value="picking.move_line_ids.mapped('lot_id')"
+                                            groups="stock.group_lot_on_delivery_slip"
+                                        />
+                                            <thead>
+                                                <tr>
+                                                    <th name="th_sml_product"><strong
+                                                    >Product</strong></th>
+                                                    <t
+                                                    name="lot_serial"
+                                                    t-if="has_serial_number"
+                                                >
+                                                        <th>
+                                                            Lot/Serial Number
+                                                        </th>
+                                                    </t>
+                                                    <th
+                                                    name="th_sml_quantity"
+                                                    class="text-center"
+                                                ><strong>Quantity</strong></th>
+                                                </tr>
+                                            </thead>
+                                            <tbody>
+                                            <!-- This part gets complicated with different use cases (additional use cases in extensions of this report):
+                                                    1. If serial numbers are used and set to print on delivery slip => print lines as is, otherwise group them by overlapping
+                                                        product + description + uom combinations
+                                                    2. If any packages are assigned => split products up by package (or non-package) and then apply use case 1 -->
+                                                <!-- If has destination packages => create sections of corresponding products -->
+                                                <t
+                                                t-if="picking.has_packages"
+                                                name="has_packages"
+                                            >
+                                                    <t
+                                                    t-set="packages"
+                                                    t-value="picking.move_line_ids.mapped('result_package_id')"
+                                                />
+                                                    <t
+                                                    t-foreach="packages"
+                                                    t-as="package"
+                                                >
+                                                        <t
+                                                        t-call="stock.stock_report_delivery_package_section_line"
+                                                    />
+                                                        <t
+                                                        t-set="package_move_lines"
+                                                        t-value="picking.move_line_ids.filtered(lambda l: l.result_package_id == package)"
+                                                    />
+                                                        <!-- If printing lots/serial numbers => keep products in original lines -->
+                                                        <t t-if="has_serial_number">
+                                                            <tr
+                                                            t-foreach="package_move_lines"
+                                                            t-as="move_line"
+                                                        >
+                                                                <t
+                                                                t-call="stock.stock_report_delivery_has_serial_move_line"
+                                                            />
+                                                            </tr>
+                                                        </t>
+                                                        <!-- If not printing lots/serial numbers => merge lines with same product+description+uom -->
+                                                        <t t-else="">
+                                                            <t
+                                                            t-set="aggregated_lines"
+                                                            t-value="package_move_lines._get_aggregated_product_quantities()"
+                                                        />
+                                                            <t
+                                                            t-call="stock.stock_report_delivery_aggregated_move_lines"
+                                                        />
+                                                        </t>
+                                                    </t>
+                                                    <!-- Make sure we do another section for package-less products if they exist -->
+                                                    <t
+                                                    t-set="move_lines"
+                                                    t-value="picking.move_line_ids.filtered(lambda l: not l.result_package_id)"
+                                                />
+                                                    <t
+                                                    t-if="move_lines"
+                                                    name="no_package_move_lines"
+                                                >
+                                                        <t
+                                                        t-call="stock.stock_report_delivery_no_package_section_line"
+                                                        name="no_package_section"
+                                                    />
+                                                        <t t-if="has_serial_number">
+                                                            <tr
+                                                            t-foreach="move_lines"
+                                                            t-as="move_line"
+                                                        >
+                                                                <t
+                                                                t-call="stock.stock_report_delivery_has_serial_move_line"
+                                                            />
+                                                            </tr>
+                                                        </t>
+                                                        <t t-else="">
+                                                            <t
+                                                            t-set="aggregated_lines"
+                                                            t-value="move_lines._get_aggregated_product_quantities()"
+                                                        />
+                                                            <t t-if="aggregated_lines">
+                                                                <t
+                                                                t-call="stock.stock_report_delivery_aggregated_move_lines"
+                                                            />
+                                                            </t>
+                                                        </t>
+                                                    </t>
+                                                </t>
+                                                <!-- No destination packages -->
+                                                <t t-else="">
+                                                    <!-- If printing lots/serial numbers => keep products in original lines -->
+                                                    <t t-if="has_serial_number">
+                                                        <tr
+                                                        t-foreach="picking.move_line_ids"
+                                                        t-as="move_line"
+                                                    >
+                                                            <t
+                                                            t-call="stock.stock_report_delivery_has_serial_move_line"
+                                                        />
+                                                        </tr>
+                                                    </t>
+                                                    <!-- If not printing lots/serial numbers => merge lines with same product -->
+                                                    <t
+                                                    t-else=""
+                                                    name="aggregated_move_lines"
+                                                >
+                                                        <t
+                                                        t-set="aggregated_lines"
+                                                        t-value="picking.move_line_ids._get_aggregated_product_quantities()"
+                                                    />
+                                                            <t
+                                                        t-call="stock.stock_report_delivery_aggregated_move_lines"
+                                                    />
+                                                    </t>
+                                                </t>
+                                            </tbody>
+                                        </table>
+                                        <t
+                                        t-set="backorders"
+                                        t-value="picking.backorder_ids.filtered(lambda x: x.state not in ('done', 'cancel'))"
+                                    />
+                                        <t t-if="picking.backorder_ids and backorders">
+                                            <p>
+                                                <span
+                                            >All items couldn't be shipped, the following items will be shipped as soon as they become available.</span>
+                                            </p>
+                                            <table
+                                            class="table table-sm"
+                                            name="stock_backorder_table"
+                                        >
+                                                <thead>
+                                                    <tr>
+                                                        <th name="th_sb_product"><strong
+                                                        >Product</strong></th>
+                                                        <th
+                                                        name="th_sb_quantity"
+                                                        class="text-center"
+                                                    ><strong>Quantity</strong></th>
+                                                    </tr>
+                                                </thead>
+                                                <tbody>
+                                                    <t
+                                                    t-foreach="backorders"
+                                                    t-as="backorder"
+                                                >
+                                                        <t
+                                                        t-set="bo_lines"
+                                                        t-value="backorder.move_lines.filtered(lambda x: x.product_uom_qty)"
+                                                    />
+                                                        <tr
+                                                        t-foreach="bo_lines"
+                                                        t-as="bo_line"
+                                                    >
+                                                            <td>
+                                                                <span
+                                                                t-field="bo_line.product_id"
+                                                            />
+                                                                <p
+                                                                t-if="bo_line.description_picking != bo_line.product_id.name"
+                                                            >
+                                                                    <span
+                                                                    t-field="bo_line.description_picking"
+                                                                />
+                                                                </p>
+                                                            </td>
+                                                            <td class="text-center">
+                                                                <span
+                                                                t-field="bo_line.product_uom_qty"
+                                                            />
+                                                                <span
+                                                                t-field="bo_line.product_uom"
+                                                            />
+                                                            </td>
+                                                        </tr>
+                                                    </t>
+                                                </tbody>
+                                            </table>
+                                        </t>
+
+                                        <div
+                                        t-if="picking.signature"
+                                        class="mt32 ml64 mr4"
+                                        name="signature"
+                                    >
+                                            <div class="offset-8">
+                                                <strong>Signature</strong>
+                                            </div>
+                                            <div class="offset-8">
+                                                <img
+                                                t-att-src="image_data_uri(picking.signature)"
+                                                style="max-height: 4cm; max-width: 8cm;"
+                                            />
+                                            </div>
+                                            <div class="offset-8 text-center">
+                                                <p t-field="picking.partner_id.name" />
+                                            </div>
+                                        </div>
+                                    </div>
+                                    <p style="page-break-after: always;" />
+                                </t>
+                         </div>
+                     </t>
+                 </t>
+            </t>
+        </template>
+    </data>
+</odoo>

From f4d1988ada28d21c221f12f455d0a8d25bf359cd Mon Sep 17 00:00:00 2001
From: Chanakya Soni <chanakya.soni@serpentcs.com>
Date: Tue, 9 Mar 2021 21:31:02 +0530
Subject: [PATCH 2/6] [UPD] Updated Picking Report by sorting location,product

---
 .../reports/report_picking_batch.xml                 | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/stock_picking_batch_report/reports/report_picking_batch.xml b/stock_picking_batch_report/reports/report_picking_batch.xml
index c5f105e..87c465a 100644
--- a/stock_picking_batch_report/reports/report_picking_batch.xml
+++ b/stock_picking_batch_report/reports/report_picking_batch.xml
@@ -6,13 +6,18 @@
                 <t t-foreach="docs" t-as="o">
                     <t
                         t-set="move_line_ids"
-                        t-value="o.picking_ids.mapped('move_line_ids').sorted(lambda line: line.location_id.display_name)"
+                        t-value="o.picking_ids.mapped('move_line_ids').sorted(lambda line: (line.location_id.display_name, line.product_id.name))"
                     />
                     <t
                         t-set="has_serial_number"
                         t-value="move_line_ids.filtered('lot_id')"
                         groups="stock.group_production_lot"
                     />
+                    <t
+                        t-set="has_uom"
+                        t-value="move_line_ids.filtered('product_uom_id')"
+                        groups="uom.group_uom"
+                    />
                     <t t-call="web.external_layout">
                         <div class="page">
                             <div class="d-flex">
@@ -39,6 +44,7 @@
                                             </th>
                                             <th>Quantity</th>
                                             <th width="23%">Transfer</th>
+                                            
                                         </tr>
                                     </thead>
                                     <tbody>
@@ -89,8 +95,8 @@
                                                 />
                                                 </t>
                                                 <span
-                                                t-field="move_operation.uom_id"
-                                                groups="move_operation.group_uom"
+                                                t-field="move_operation.product_uom_id"
+                                                groups="uom.group_uom"
                                             />
                                             </td>
                                             <td>

From 43ac226a8998eb326e5a56e38df273cd4397b4c0 Mon Sep 17 00:00:00 2001
From: Chanakya Soni <chanakya.soni@serpentcs.com>
Date: Tue, 9 Mar 2021 21:34:28 +0530
Subject: [PATCH 3/6] [FIX] Fixed Travis

---
 stock_picking_batch_report/reports/report_picking_batch.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stock_picking_batch_report/reports/report_picking_batch.xml b/stock_picking_batch_report/reports/report_picking_batch.xml
index 87c465a..ab3bf43 100644
--- a/stock_picking_batch_report/reports/report_picking_batch.xml
+++ b/stock_picking_batch_report/reports/report_picking_batch.xml
@@ -44,7 +44,7 @@
                                             </th>
                                             <th>Quantity</th>
                                             <th width="23%">Transfer</th>
-                                            
+
                                         </tr>
                                     </thead>
                                     <tbody>

From 1db9ace03d7e8b503309a2b5a7284b44d6d455e1 Mon Sep 17 00:00:00 2001
From: "Atchuthan, Sodexis" <atchuthan@sodexis.com>
Date: Thu, 27 May 2021 10:42:12 +0530
Subject: [PATCH 4/6] [FIX] Delivery add & Carrier information in report

---
 .../reports/report_picking_batch.xml          | 21 +++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/stock_picking_batch_report/reports/report_picking_batch.xml b/stock_picking_batch_report/reports/report_picking_batch.xml
index ab3bf43..4033f52 100644
--- a/stock_picking_batch_report/reports/report_picking_batch.xml
+++ b/stock_picking_batch_report/reports/report_picking_batch.xml
@@ -119,12 +119,14 @@
                                     t-value="picking.partner_id or (picking.move_lines and picking.move_lines[0].partner_id) or False"
                                 />
                                     <t t-if="partner" name="partner_header">
-                                        <t t-set="address">
-                                            <div
-                                            t-esc="partner"
-                                            t-options='{"widget": "contact", "fields": ["address", "name", "phone"], "no_marker": True}'
-                                        />
-                                       </t>
+                                        <div class="row">
+                                            <div class="col-5 offset-7">
+                                                <div
+                                                t-esc="partner"
+                                                t-options='{"widget": "contact", "fields": ["address", "name", "phone"], "no_marker": True}'
+                                            />
+                                            </div>
+                                        </div>
                                     </t>
 
                                     <div class="page">
@@ -155,6 +157,13 @@
                                                 />
                                                </t>
                                             </div>
+                                            <div
+                                            t-if="picking.picking_type_id.code == 'outgoing' and picking.carrier_id"
+                                            class="col-auto"
+                                        >
+                                                <strong>Carrier:</strong>
+                                                <p t-field="picking.carrier_id" />
+                                            </div>
                                         </div>
                                         <table
                                         class="table table-sm"

From 89ffaeb68004523a5444ce85f366c2d842e3360d Mon Sep 17 00:00:00 2001
From: Christopher Ormaza <chris.ormaza@forgeflow.com>
Date: Wed, 18 Oct 2023 09:16:03 -0500
Subject: [PATCH 5/6] [IMP] stock_picking_batch_report: black, isort, prettier

---
 .../odoo/addons/stock_picking_batch_report                  | 1 +
 setup/stock_picking_batch_report/setup.py                   | 6 ++++++
 2 files changed, 7 insertions(+)
 create mode 120000 setup/stock_picking_batch_report/odoo/addons/stock_picking_batch_report
 create mode 100644 setup/stock_picking_batch_report/setup.py

diff --git a/setup/stock_picking_batch_report/odoo/addons/stock_picking_batch_report b/setup/stock_picking_batch_report/odoo/addons/stock_picking_batch_report
new file mode 120000
index 0000000..f27a8fd
--- /dev/null
+++ b/setup/stock_picking_batch_report/odoo/addons/stock_picking_batch_report
@@ -0,0 +1 @@
+../../../../stock_picking_batch_report
\ No newline at end of file
diff --git a/setup/stock_picking_batch_report/setup.py b/setup/stock_picking_batch_report/setup.py
new file mode 100644
index 0000000..28c57bb
--- /dev/null
+++ b/setup/stock_picking_batch_report/setup.py
@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)

From c69a5298d3441dcf3ea1259ac162c030089859e1 Mon Sep 17 00:00:00 2001
From: Christopher Ormaza <chris.ormaza@forgeflow.com>
Date: Wed, 18 Oct 2023 09:39:27 -0500
Subject: [PATCH 6/6] [16.0][MIG] stock_picking_batch_report

---
 stock_picking_batch_report/__manifest__.py    |   2 +-
 .../models/stock_picking_batch.py             |  17 +-
 .../reports/report_picking_batch.xml          | 795 +++++++++---------
 3 files changed, 391 insertions(+), 423 deletions(-)

diff --git a/stock_picking_batch_report/__manifest__.py b/stock_picking_batch_report/__manifest__.py
index b93c4e2..f54ec50 100644
--- a/stock_picking_batch_report/__manifest__.py
+++ b/stock_picking_batch_report/__manifest__.py
@@ -3,7 +3,7 @@
 
 {
     "name": "Stock Picking Batch Report",
-    "version": "14.0.1.0.0",
+    "version": "16.0.1.0.0",
     "author": "Open Source Integrators, " "Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "summary": "Stock Picking Batch Report",
diff --git a/stock_picking_batch_report/models/stock_picking_batch.py b/stock_picking_batch_report/models/stock_picking_batch.py
index 38aa50b..c167d51 100644
--- a/stock_picking_batch_report/models/stock_picking_batch.py
+++ b/stock_picking_batch_report/models/stock_picking_batch.py
@@ -8,19 +8,4 @@ class StockPikcingBatch(models.Model):
     _inherit = "stock.picking.batch"
 
     def get_out_pickings(self):
-        for rec in self:
-            # TO BE Modified Later
-            # if (
-            # rec.picking_type_id.warehouse_id
-            # and rec.picking_type_id.warehouse_id.delivery_steps != "pick_ship"
-            #             ):
-            #                 raise UserError(
-            #                         _(
-            #                             "This report is only available for "
-            #                    "warehouses configured with 2-steps delivery"
-            #                         )
-            #                     )
-            out_pickings = (
-                rec.mapped("move_ids").mapped("move_dest_ids").mapped("picking_id")
-            )
-        return out_pickings
+        return self.mapped("move_ids.move_dest_ids.picking_id")
diff --git a/stock_picking_batch_report/reports/report_picking_batch.xml b/stock_picking_batch_report/reports/report_picking_batch.xml
index 4033f52..566d081 100644
--- a/stock_picking_batch_report/reports/report_picking_batch.xml
+++ b/stock_picking_batch_report/reports/report_picking_batch.xml
@@ -1,333 +1,257 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
-        <template id="stock_picking_batch.report_picking_batch">
-            <t t-call="web.html_container">
-                <t t-foreach="docs" t-as="o">
-                    <t
-                        t-set="move_line_ids"
-                        t-value="o.picking_ids.mapped('move_line_ids').sorted(lambda line: (line.location_id.display_name, line.product_id.name))"
-                    />
-                    <t
-                        t-set="has_serial_number"
-                        t-value="move_line_ids.filtered('lot_id')"
-                        groups="stock.group_production_lot"
-                    />
-                    <t
-                        t-set="has_uom"
-                        t-value="move_line_ids.filtered('product_uom_id')"
-                        groups="uom.group_uom"
-                    />
-                    <t t-call="web.external_layout">
-                        <div class="page">
-                            <div class="d-flex">
-                                <div><h3>Batch : <span t-field="o.name" /></h3></div>
-                                <div class="mr-auto">
-                                    <img
-                                        alt="Barcode"
-                                        t-att-src="'/report/barcode/?type=%s&amp;value=%s&amp;width=%s&amp;height=%s' % ('Code128', quote_plus(o.name or ''), 600, 150)"
-                                        style="width:300px;height:50px"
-                                    />
-                                </div>
+    <template id="stock_picking_batch.report_picking_batch">
+        <t t-call="web.html_container">
+            <t t-foreach="docs" t-as="o">
+                <t
+                    t-set="move_line_ids"
+                    t-value="o.picking_ids.mapped('move_line_ids').sorted(lambda line: (line.location_id.display_name, line.product_id.name))"
+                />
+                <t
+                    t-set="has_serial_number"
+                    t-value="move_line_ids.filtered('lot_id')"
+                    groups="stock.group_production_lot"
+                />
+                <t
+                    t-set="has_uom"
+                    t-value="move_line_ids.filtered('product_uom_id')"
+                    groups="uom.group_uom"
+                />
+                <t t-call="web.external_layout">
+                    <div class="page">
+                        <div class="d-flex">
+                            <div><h3>Batch : <span t-field="o.name" /></h3></div>
+                            <div class="mr-auto">
+                                <img
+                                    alt="Barcode"
+                                    t-att-src="'/report/barcode/?barcode_type=%s&amp;value=%s&amp;width=%s&amp;height=%s' % ('Code128', quote_plus(o.name or ''), 600, 150)"
+                                    style="width:300px;height:50px"
+                                />
                             </div>
-                            <div t-if="o.user_id">
-                                <strong>Responsible:</strong>
-                                <span t-field="o.user_id" />
-                            </div><br />
-                                <table class="table table-condensed">
-                                    <thead>
-                                        <tr>
-                                            <th width="27%">Location</th>
-                                            <th>Product</th>
-                                            <th t-if="has_serial_number" width="15%">
-                                                <strong>Lot/Serial Number</strong>
-                                            </th>
-                                            <th>Quantity</th>
-                                            <th width="23%">Transfer</th>
+                        </div>
+                        <div t-if="o.user_id">
+                            <strong>Responsible:</strong>
+                            <span t-field="o.user_id" />
+                        </div><br />
+                            <table class="table table-condensed">
+                                <thead>
+                                    <tr>
+                                        <th width="27%">Location</th>
+                                        <th>Product</th>
+                                        <th t-if="has_serial_number" width="15%">
+                                            <strong>Lot/Serial Number</strong>
+                                        </th>
+                                        <th>Quantity</th>
+                                        <th width="23%">Transfer</th>
 
-                                        </tr>
-                                    </thead>
-                                    <tbody>
-                                        <tr
-                                        t-foreach="move_line_ids"
-                                        t-as="move_operation"
+                                    </tr>
+                                </thead>
+                                <tbody>
+                                    <tr t-foreach="move_line_ids" t-as="move_operation">
+                                        <td>
+                                            <span
+                                            t-esc="move_operation.mapped('location_id').display_name"
+                                        />
+                                        </td>
+                                        <td>
+                                            <span
+                                            t-field="move_operation.display_name"
+                                        />
+                                        </td>
+                                        <td
+                                        t-if="has_serial_number"
+                                        class="text-center h6"
+                                        width="15%"
                                     >
-                                            <td>
-                                                <span
-                                                t-esc="move_operation.mapped('location_id').display_name"
-                                            />
-                                            </td>
-                                            <td>
-                                                <span
-                                                t-field="move_operation.display_name"
-                                            />
-                                            </td>
-                                            <td
-                                            t-if="has_serial_number"
-                                            class="text-center h6"
-                                            width="15%"
-                                        >
-                                                <img
-                                                t-if="move_operation.lot_id or move_operation.lot_name"
-                                                t-att-src="'/report/barcode/?type=%s&amp;value=%s&amp;width=%s&amp;height=%s&amp;humanreadable=1' % ('Code128', move_operation.lot_id.name, 600, 100)"
-                                                style="width:100%;height:35px;"
-                                                alt="Barcode"
-                                            />
-                                            </td>
-                                            <td>
-                                                <t t-if="not has_package">
-                                                    <t
-                                                    t-if="move_operation.state == 'done'"
-                                                >
-                                                        <span
-                                                        t-esc="sum(move_operation.mapped('qty_done'))"
-                                                    />
-                                                    </t>
-                                                    <t t-else="">
-                                                        <span
-                                                        t-esc="sum(move_operation.mapped('product_uom_qty'))"
-                                                    />
-                                                    </t>
-                                                </t>
-                                                <t t-if="has_package">
+                                            <img
+                                            t-if="move_operation.lot_id or move_operation.lot_name"
+                                            t-att-src="'/report/barcode/?barcode_type=%s&amp;value=%s&amp;width=%s&amp;height=%s&amp;humanreadable=1' % ('Code128', move_operation.lot_id.name, 600, 100)"
+                                            style="width:100%;height:35px;"
+                                            alt="Barcode"
+                                        />
+                                        </td>
+                                        <td>
+                                            <t t-if="not has_package">
+                                                <t
+                                                t-if="move_operation.state == 'done'"
+                                            >
                                                     <span
                                                     t-esc="sum(move_operation.mapped('qty_done'))"
                                                 />
                                                 </t>
-                                                <span
-                                                t-field="move_operation.product_uom_id"
-                                                groups="uom.group_uom"
-                                            />
-                                            </td>
-                                            <td>
-                                                <span
-                                                t-esc="move_operation.mapped('picking_id').display_name"
-                                            />
-                                            </td>
-                                        </tr>
-                                    </tbody>
-                                </table>
-                                <p style="page-break-after: always;" />
-                                <t t-set="pickings" t-value="o.get_out_pickings()" />
-                                <t t-foreach="pickings" t-as="picking">
-                                    <t
-                                    t-set="picking"
-                                    t-value="picking.with_context(lang=picking.partner_id.lang)"
-                                />
-                                    <t
-                                    t-set="partner"
-                                    t-value="picking.partner_id or (picking.move_lines and picking.move_lines[0].partner_id) or False"
-                                />
-                                    <t t-if="partner" name="partner_header">
-                                        <div class="row">
-                                            <div class="col-5 offset-7">
-                                                <div
-                                                t-esc="partner"
-                                                t-options='{"widget": "contact", "fields": ["address", "name", "phone"], "no_marker": True}'
-                                            />
-                                            </div>
-                                        </div>
-                                    </t>
-
-                                    <div class="page">
-                                        <h2>
-                                            <span t-field="picking.name" />
-                                        </h2>
-                                        <div class="row mt32 mb32">
-                                            <div
-                                            t-if="picking.origin"
-                                            class="col-auto"
-                                            name="div_origin"
-                                        >
-                                                <strong>Order:</strong>
-                                                <p t-field="picking.origin" />
-                                            </div>
-                                            <div
-                                            t-if="picking.state"
-                                            class="col-auto"
-                                            name="div_sched_date"
-                                        >
-                                                <strong>Shipping Date:</strong>
-                                                <t t-if="picking.state == 'done'">
-                                                    <p t-field="picking.date_done" />
-                                                </t>
-                                                <t t-if="picking.state != 'done'">
-                                                    <p
-                                                    t-field="picking.scheduled_date"
-                                                />
-                                               </t>
-                                            </div>
-                                            <div
-                                            t-if="picking.picking_type_id.code == 'outgoing' and picking.carrier_id"
-                                            class="col-auto"
-                                        >
-                                                <strong>Carrier:</strong>
-                                                <p t-field="picking.carrier_id" />
-                                            </div>
-                                        </div>
-                                        <table
-                                        class="table table-sm"
-                                        t-if="picking.state!='done'"
-                                        name="stock_move_table"
-                                    >
-                                            <thead>
-                                                <tr>
-                                                    <th name="th_sm_product"><strong
-                                                    >Product</strong></th>
-                                                    <th name="th_sm_quantity"><strong
-                                                    >Quantity</strong></th>
-                                                </tr>
-                                            </thead>
-                                            <tbody>
-                                                <t
-                                                t-set="lines"
-                                                t-value="picking.move_lines.filtered(lambda x: x.product_uom_qty)"
-                                            />
-                                                <tr t-foreach="lines" t-as="move">
-                                                    <td>
-                                                        <span
-                                                        t-field="move.product_id"
-                                                    />
-                                                        <p
-                                                        t-if="move.description_picking != move.product_id.name"
-                                                    >
-                                                            <span
-                                                            t-field="move.description_picking"
-                                                        />
-                                                        </p>
-                                                    </td>
-                                                    <td>
-                                                        <span
-                                                        t-field="move.product_uom_qty"
-                                                    />
-                                                        <span
-                                                        t-field="move.product_uom"
-                                                    />
-                                                    </td>
-                                                </tr>
-                                            </tbody>
-                                        </table>
-                                        <table
-                                        class="table table-sm mt48"
-                                        t-if="picking.move_line_ids and picking.state=='done'"
-                                        name="stock_move_line_table"
-                                    >
-                                            <t
-                                            t-set="has_serial_number"
-                                            t-value="False"
-                                        />
-                                            <t
-                                            t-set="has_serial_number"
-                                            t-value="picking.move_line_ids.mapped('lot_id')"
-                                            groups="stock.group_lot_on_delivery_slip"
-                                        />
-                                            <thead>
-                                                <tr>
-                                                    <th name="th_sml_product"><strong
-                                                    >Product</strong></th>
-                                                    <t
-                                                    name="lot_serial"
-                                                    t-if="has_serial_number"
-                                                >
-                                                        <th>
-                                                            Lot/Serial Number
-                                                        </th>
-                                                    </t>
-                                                    <th
-                                                    name="th_sml_quantity"
-                                                    class="text-center"
-                                                ><strong>Quantity</strong></th>
-                                                </tr>
-                                            </thead>
-                                            <tbody>
-                                            <!-- This part gets complicated with different use cases (additional use cases in extensions of this report):
-                                                    1. If serial numbers are used and set to print on delivery slip => print lines as is, otherwise group them by overlapping
-                                                        product + description + uom combinations
-                                                    2. If any packages are assigned => split products up by package (or non-package) and then apply use case 1 -->
-                                                <!-- If has destination packages => create sections of corresponding products -->
-                                                <t
-                                                t-if="picking.has_packages"
-                                                name="has_packages"
-                                            >
-                                                    <t
-                                                    t-set="packages"
-                                                    t-value="picking.move_line_ids.mapped('result_package_id')"
-                                                />
-                                                    <t
-                                                    t-foreach="packages"
-                                                    t-as="package"
-                                                >
-                                                        <t
-                                                        t-call="stock.stock_report_delivery_package_section_line"
-                                                    />
-                                                        <t
-                                                        t-set="package_move_lines"
-                                                        t-value="picking.move_line_ids.filtered(lambda l: l.result_package_id == package)"
-                                                    />
-                                                        <!-- If printing lots/serial numbers => keep products in original lines -->
-                                                        <t t-if="has_serial_number">
-                                                            <tr
-                                                            t-foreach="package_move_lines"
-                                                            t-as="move_line"
-                                                        >
-                                                                <t
-                                                                t-call="stock.stock_report_delivery_has_serial_move_line"
-                                                            />
-                                                            </tr>
-                                                        </t>
-                                                        <!-- If not printing lots/serial numbers => merge lines with same product+description+uom -->
-                                                        <t t-else="">
-                                                            <t
-                                                            t-set="aggregated_lines"
-                                                            t-value="package_move_lines._get_aggregated_product_quantities()"
-                                                        />
-                                                            <t
-                                                            t-call="stock.stock_report_delivery_aggregated_move_lines"
-                                                        />
-                                                        </t>
-                                                    </t>
-                                                    <!-- Make sure we do another section for package-less products if they exist -->
-                                                    <t
-                                                    t-set="move_lines"
-                                                    t-value="picking.move_line_ids.filtered(lambda l: not l.result_package_id)"
-                                                />
-                                                    <t
-                                                    t-if="move_lines"
-                                                    name="no_package_move_lines"
-                                                >
-                                                        <t
-                                                        t-call="stock.stock_report_delivery_no_package_section_line"
-                                                        name="no_package_section"
-                                                    />
-                                                        <t t-if="has_serial_number">
-                                                            <tr
-                                                            t-foreach="move_lines"
-                                                            t-as="move_line"
-                                                        >
-                                                                <t
-                                                                t-call="stock.stock_report_delivery_has_serial_move_line"
-                                                            />
-                                                            </tr>
-                                                        </t>
-                                                        <t t-else="">
-                                                            <t
-                                                            t-set="aggregated_lines"
-                                                            t-value="move_lines._get_aggregated_product_quantities()"
-                                                        />
-                                                            <t t-if="aggregated_lines">
-                                                                <t
-                                                                t-call="stock.stock_report_delivery_aggregated_move_lines"
-                                                            />
-                                                            </t>
-                                                        </t>
-                                                    </t>
-                                                </t>
-                                                <!-- No destination packages -->
                                                 <t t-else="">
+                                                    <span
+                                                    t-esc="sum(move_operation.mapped('move_id.product_uom_qty'))"
+                                                />
+                                                </t>
+                                            </t>
+                                            <t t-if="has_package">
+                                                <span
+                                                t-esc="sum(move_operation.mapped('qty_done'))"
+                                            />
+                                            </t>
+                                            <span
+                                            t-field="move_operation.product_uom_id"
+                                            groups="uom.group_uom"
+                                        />
+                                        </td>
+                                        <td>
+                                            <span
+                                            t-esc="move_operation.mapped('picking_id').display_name"
+                                        />
+                                        </td>
+                                    </tr>
+                                </tbody>
+                            </table>
+                            <p style="page-break-after: always;" />
+                            <t t-set="pickings" t-value="o.get_out_pickings()" />
+                            <t t-foreach="pickings" t-as="picking">
+                                <t
+                                t-set="picking"
+                                t-value="picking.with_context(lang=picking.partner_id.lang)"
+                            />
+                                <t
+                                t-set="partner"
+                                t-value="picking.partner_id or (picking.move_ids and picking.move_ids[0].partner_id) or False"
+                            />
+                                <t t-if="partner" name="partner_header">
+                                    <div class="row">
+                                        <div class="col-5 offset-7">
+                                            <div
+                                            t-esc="partner"
+                                            t-options='{"widget": "contact", "fields": ["address", "name", "phone"], "no_marker": True}'
+                                        />
+                                        </div>
+                                    </div>
+                                </t>
+
+                                <div class="page">
+                                    <h2>
+                                        <span t-field="picking.name" />
+                                    </h2>
+                                    <div class="row mt32 mb32">
+                                        <div
+                                        t-if="picking.origin"
+                                        class="col-auto"
+                                        name="div_origin"
+                                    >
+                                            <strong>Order:</strong>
+                                            <p t-field="picking.origin" />
+                                        </div>
+                                        <div
+                                        t-if="picking.state"
+                                        class="col-auto"
+                                        name="div_sched_date"
+                                    >
+                                            <strong>Shipping Date:</strong>
+                                            <t t-if="picking.state == 'done'">
+                                                <p t-field="picking.date_done" />
+                                            </t>
+                                            <t t-if="picking.state != 'done'">
+                                                <p t-field="picking.scheduled_date" />
+                                           </t>
+                                        </div>
+                                        <div
+                                        t-if="picking.picking_type_id.code == 'outgoing' and picking.carrier_id"
+                                        class="col-auto"
+                                    >
+                                            <strong>Carrier:</strong>
+                                            <p t-field="picking.carrier_id" />
+                                        </div>
+                                    </div>
+                                    <table
+                                    class="table table-sm"
+                                    t-if="picking.state!='done'"
+                                    name="stock_move_table"
+                                >
+                                        <thead>
+                                            <tr>
+                                                <th name="th_sm_product"><strong
+                                                >Product</strong></th>
+                                                <th name="th_sm_quantity"><strong
+                                                >Quantity</strong></th>
+                                            </tr>
+                                        </thead>
+                                        <tbody>
+                                            <t
+                                            t-set="lines"
+                                            t-value="picking.move_ids.filtered(lambda x: x.product_uom_qty)"
+                                        />
+                                            <tr t-foreach="lines" t-as="move">
+                                                <td>
+                                                    <span t-field="move.product_id" />
+                                                    <p
+                                                    t-if="move.description_picking != move.product_id.name"
+                                                >
+                                                        <span
+                                                        t-field="move.description_picking"
+                                                    />
+                                                    </p>
+                                                </td>
+                                                <td>
+                                                    <span
+                                                    t-field="move.product_uom_qty"
+                                                />
+                                                    <span t-field="move.product_uom" />
+                                                </td>
+                                            </tr>
+                                        </tbody>
+                                    </table>
+                                    <table
+                                    class="table table-sm mt48"
+                                    t-if="picking.move_line_ids and picking.state=='done'"
+                                    name="stock_move_line_table"
+                                >
+                                        <t t-set="has_serial_number" t-value="False" />
+                                        <t
+                                        t-set="has_serial_number"
+                                        t-value="picking.move_line_ids.mapped('lot_id')"
+                                        groups="stock.group_lot_on_delivery_slip"
+                                    />
+                                        <thead>
+                                            <tr>
+                                                <th name="th_sml_product"><strong
+                                                >Product</strong></th>
+                                                <t
+                                                name="lot_serial"
+                                                t-if="has_serial_number"
+                                            >
+                                                    <th>
+                                                        Lot/Serial Number
+                                                    </th>
+                                                </t>
+                                                <th
+                                                name="th_sml_quantity"
+                                                class="text-center"
+                                            ><strong>Quantity</strong></th>
+                                            </tr>
+                                        </thead>
+                                        <tbody>
+                                        <!-- This part gets complicated with different use cases (additional use cases in extensions of this report):
+                                                1. If serial numbers are used and set to print on delivery slip => print lines as is, otherwise group them by overlapping
+                                                    product + description + uom combinations
+                                                2. If any packages are assigned => split products up by package (or non-package) and then apply use case 1 -->
+                                            <!-- If has destination packages => create sections of corresponding products -->
+                                            <t
+                                            t-if="picking.has_packages"
+                                            name="has_packages"
+                                        >
+                                                <t
+                                                t-set="packages"
+                                                t-value="picking.move_line_ids.mapped('result_package_id')"
+                                            />
+                                                <t t-foreach="packages" t-as="package">
+                                                    <t
+                                                    t-call="stock.stock_report_delivery_package_section_line"
+                                                />
+                                                    <t
+                                                    t-set="package_move_lines"
+                                                    t-value="picking.move_line_ids.filtered(lambda l: l.result_package_id == package)"
+                                                />
                                                     <!-- If printing lots/serial numbers => keep products in original lines -->
                                                     <t t-if="has_serial_number">
                                                         <tr
-                                                        t-foreach="picking.move_line_ids"
+                                                        t-foreach="package_move_lines"
                                                         t-as="move_line"
                                                     >
                                                             <t
@@ -335,109 +259,168 @@
                                                         />
                                                         </tr>
                                                     </t>
-                                                    <!-- If not printing lots/serial numbers => merge lines with same product -->
-                                                    <t
-                                                    t-else=""
-                                                    name="aggregated_move_lines"
-                                                >
+                                                    <!-- If not printing lots/serial numbers => merge lines with same product+description+uom -->
+                                                    <t t-else="">
                                                         <t
                                                         t-set="aggregated_lines"
-                                                        t-value="picking.move_line_ids._get_aggregated_product_quantities()"
+                                                        t-value="package_move_lines._get_aggregated_product_quantities()"
                                                     />
-                                                            <t
+                                                        <t
                                                         t-call="stock.stock_report_delivery_aggregated_move_lines"
                                                     />
                                                     </t>
                                                 </t>
-                                            </tbody>
-                                        </table>
-                                        <t
-                                        t-set="backorders"
-                                        t-value="picking.backorder_ids.filtered(lambda x: x.state not in ('done', 'cancel'))"
-                                    />
-                                        <t t-if="picking.backorder_ids and backorders">
-                                            <p>
-                                                <span
-                                            >All items couldn't be shipped, the following items will be shipped as soon as they become available.</span>
-                                            </p>
-                                            <table
-                                            class="table table-sm"
-                                            name="stock_backorder_table"
-                                        >
-                                                <thead>
-                                                    <tr>
-                                                        <th name="th_sb_product"><strong
-                                                        >Product</strong></th>
-                                                        <th
-                                                        name="th_sb_quantity"
-                                                        class="text-center"
-                                                    ><strong>Quantity</strong></th>
-                                                    </tr>
-                                                </thead>
-                                                <tbody>
+                                                <!-- Make sure we do another section for package-less products if they exist -->
+                                                <t
+                                                t-set="move_lines"
+                                                t-value="picking.move_line_ids.filtered(lambda l: not l.result_package_id)"
+                                            />
+                                                <t
+                                                t-if="move_lines"
+                                                name="no_package_move_lines"
+                                            >
                                                     <t
-                                                    t-foreach="backorders"
-                                                    t-as="backorder"
-                                                >
-                                                        <t
-                                                        t-set="bo_lines"
-                                                        t-value="backorder.move_lines.filtered(lambda x: x.product_uom_qty)"
-                                                    />
+                                                    t-call="stock.stock_report_delivery_no_package_section_line"
+                                                    name="no_package_section"
+                                                />
+                                                    <t t-if="has_serial_number">
                                                         <tr
-                                                        t-foreach="bo_lines"
-                                                        t-as="bo_line"
+                                                        t-foreach="move_lines"
+                                                        t-as="move_line"
                                                     >
-                                                            <td>
-                                                                <span
-                                                                t-field="bo_line.product_id"
-                                                            />
-                                                                <p
-                                                                t-if="bo_line.description_picking != bo_line.product_id.name"
-                                                            >
-                                                                    <span
-                                                                    t-field="bo_line.description_picking"
-                                                                />
-                                                                </p>
-                                                            </td>
-                                                            <td class="text-center">
-                                                                <span
-                                                                t-field="bo_line.product_uom_qty"
-                                                            />
-                                                                <span
-                                                                t-field="bo_line.product_uom"
-                                                            />
-                                                            </td>
+                                                            <t
+                                                            t-call="stock.stock_report_delivery_has_serial_move_line"
+                                                        />
                                                         </tr>
                                                     </t>
-                                                </tbody>
-                                            </table>
-                                        </t>
-
-                                        <div
-                                        t-if="picking.signature"
-                                        class="mt32 ml64 mr4"
-                                        name="signature"
+                                                    <t t-else="">
+                                                        <t
+                                                        t-set="aggregated_lines"
+                                                        t-value="move_lines._get_aggregated_product_quantities()"
+                                                    />
+                                                        <t t-if="aggregated_lines">
+                                                            <t
+                                                            t-call="stock.stock_report_delivery_aggregated_move_lines"
+                                                        />
+                                                        </t>
+                                                    </t>
+                                                </t>
+                                            </t>
+                                            <!-- No destination packages -->
+                                            <t t-else="">
+                                                <!-- If printing lots/serial numbers => keep products in original lines -->
+                                                <t t-if="has_serial_number">
+                                                    <tr
+                                                    t-foreach="picking.move_line_ids"
+                                                    t-as="move_line"
+                                                >
+                                                        <t
+                                                        t-call="stock.stock_report_delivery_has_serial_move_line"
+                                                    />
+                                                    </tr>
+                                                </t>
+                                                <!-- If not printing lots/serial numbers => merge lines with same product -->
+                                                <t
+                                                t-else=""
+                                                name="aggregated_move_lines"
+                                            >
+                                                    <t
+                                                    t-set="aggregated_lines"
+                                                    t-value="picking.move_line_ids._get_aggregated_product_quantities()"
+                                                />
+                                                        <t
+                                                    t-call="stock.stock_report_delivery_aggregated_move_lines"
+                                                />
+                                                </t>
+                                            </t>
+                                        </tbody>
+                                    </table>
+                                    <t
+                                    t-set="backorders"
+                                    t-value="picking.backorder_ids.filtered(lambda x: x.state not in ('done', 'cancel'))"
+                                />
+                                    <t t-if="picking.backorder_ids and backorders">
+                                        <p>
+                                            <span
+                                        >All items couldn't be shipped, the following items will be shipped as soon as they become available.</span>
+                                        </p>
+                                        <table
+                                        class="table table-sm"
+                                        name="stock_backorder_table"
                                     >
-                                            <div class="offset-8">
-                                                <strong>Signature</strong>
-                                            </div>
-                                            <div class="offset-8">
-                                                <img
-                                                t-att-src="image_data_uri(picking.signature)"
-                                                style="max-height: 4cm; max-width: 8cm;"
-                                            />
-                                            </div>
-                                            <div class="offset-8 text-center">
-                                                <p t-field="picking.partner_id.name" />
-                                            </div>
+                                            <thead>
+                                                <tr>
+                                                    <th name="th_sb_product"><strong
+                                                    >Product</strong></th>
+                                                    <th
+                                                    name="th_sb_quantity"
+                                                    class="text-center"
+                                                ><strong>Quantity</strong></th>
+                                                </tr>
+                                            </thead>
+                                            <tbody>
+                                                <t
+                                                t-foreach="backorders"
+                                                t-as="backorder"
+                                            >
+                                                    <t
+                                                    t-set="bo_lines"
+                                                    t-value="backorder.move_ids.filtered(lambda x: x.product_uom_qty)"
+                                                />
+                                                    <tr
+                                                    t-foreach="bo_lines"
+                                                    t-as="bo_line"
+                                                >
+                                                        <td>
+                                                            <span
+                                                            t-field="bo_line.product_id"
+                                                        />
+                                                            <p
+                                                            t-if="bo_line.description_picking != bo_line.product_id.name"
+                                                        >
+                                                                <span
+                                                                t-field="bo_line.description_picking"
+                                                            />
+                                                            </p>
+                                                        </td>
+                                                        <td class="text-center">
+                                                            <span
+                                                            t-field="bo_line.product_uom_qty"
+                                                        />
+                                                            <span
+                                                            t-field="bo_line.product_uom"
+                                                        />
+                                                        </td>
+                                                    </tr>
+                                                </t>
+                                            </tbody>
+                                        </table>
+                                    </t>
+
+                                    <div
+                                    t-if="picking.signature"
+                                    class="mt32 ml64 mr4"
+                                    name="signature"
+                                >
+                                        <div class="offset-8">
+                                            <strong>Signature</strong>
+                                        </div>
+                                        <div class="offset-8">
+                                            <img
+                                            t-att-src="image_data_uri(picking.signature)"
+                                            style="max-height: 4cm; max-width: 8cm;"
+                                        />
+                                        </div>
+                                        <div class="offset-8 text-center">
+                                            <p t-field="picking.partner_id.name" />
                                         </div>
                                     </div>
-                                    <p style="page-break-after: always;" />
-                                </t>
-                         </div>
-                     </t>
+                                </div>
+                                <p style="page-break-after: always;" />
+                            </t>
+                     </div>
                  </t>
-            </t>
-        </template>
-    </data>
+             </t>
+        </t>
+    </template>
 </odoo>