audrius/stock-logistics-reporting
1
0
Fork 1
mirror of https://github.com/OCA/stock-logistics-reporting.git synced 2025-02-16 17:13:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] stock_picking_report_valued: valued line computation

Browse Source 
The fix in fac3997ee5 didn't consider
move lines without a linked sale line. That would end up in inconsistent
calculations and even the original line rewriting.

TT38863
This commit is contained in:
david
2022-09-07 10:14:47 +02:00
parent e466aed4e8
commit 4e8cc3fbbf
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
stock_picking_report_valued/models/stock_move_line.py
View File

@@ -53,25 +53,35 @@ class StockMoveLine(models.Model):
access to sales orders (stricter warehouse users, inter-company
records...).
"""
self.sale_tax_description = False
self.sale_price_subtotal = False
self.sale_price_tax = False
self.sale_price_total = False
self.sale_price_unit = False
for line in self:
quantity = line._get_report_valued_quantity()
valued_line = line.sale_line
if not valued_line:
continue
quantity = line._get_report_valued_quantity()
sale_line_uom = valued_line.product_uom
different_uom = valued_line.product_uom != line.product_uom_id
# If order line quantity don't match with move line quantity compute values
if valued_line and float_compare(
different_qty = float_compare(
quantity,
line.sale_line.product_uom_qty,
precision_rounding=line.product_uom_id.rounding,
):
)
if different_uom or different_qty:
# Force read to cache M2M field for get values with _convert_to_write
line.sale_line.mapped("tax_id")
# Create virtual sale line with stock move line quantity
sol_vals = line.sale_line._convert_to_write(line.sale_line._cache)
valued_line = line.sale_line.new(sol_vals)
valued_line.product_uom_qty = quantity
if different_qty:
# Force original price unit to avoid pricelist recomputed (not needed)
valued_line.price_unit = line.sale_line.price_unit
if sale_line_uom != line.product_uom_id:
if different_uom:
valued_line.price_unit = sale_line_uom._compute_price(
valued_line.price_unit, line.product_uom_id
)