diff --git a/base_external_dbsource_mysql/models/base_external_dbsource.py b/base_external_dbsource_mysql/models/base_external_dbsource.py index 32f367c8..9ada9c30 100644 --- a/base_external_dbsource_mysql/models/base_external_dbsource.py +++ b/base_external_dbsource_mysql/models/base_external_dbsource.py @@ -12,7 +12,7 @@ base_external_dbsource.BaseExternalDbsource.CONNECTORS.append(("mysql", "MySQL") class BaseExternalDbsource(models.Model): - """ It provides logic for connection to a MySQL data source. """ + """It provides logic for connection to a MySQL data source.""" _inherit = "base.external.dbsource" diff --git a/base_external_dbsource_mysql/tests/test_base_external_dbsource.py b/base_external_dbsource_mysql/tests/test_base_external_dbsource.py index f45eb03b..f276b9e3 100644 --- a/base_external_dbsource_mysql/tests/test_base_external_dbsource.py +++ b/base_external_dbsource_mysql/tests/test_base_external_dbsource.py @@ -15,19 +15,19 @@ class TestBaseExternalDbsource(common.TransactionCase): self.dbsource = self.env.ref("base_external_dbsource_mysql.demo_mysql") def test_connection_close_mysql(self): - """ It should close the connection """ + """It should close the connection""" connection = mock.MagicMock() res = self.dbsource.connection_close_mysql(connection) self.assertEqual(res, connection.close()) def test_connection_open_mysql(self): - """ It should call SQLAlchemy open """ + """It should call SQLAlchemy open""" with mock.patch.object(self.dbsource, "connection_open_mysql") as parent_method: self.dbsource.connection_open_mysql() parent_method.assert_called_once_with() def test_excecute_mysql(self): - """ It should pass args to SQLAlchemy execute """ + """It should pass args to SQLAlchemy execute""" expect = "sqlquery", "sqlparams", "metadata" with mock.patch.object(self.dbsource, "execute_mysql") as parent_method: self.dbsource.execute_mysql(*expect) diff --git a/requirements.txt b/requirements.txt index 88328f65..09c20b17 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,3 +1,4 @@ # generated from manifests external_dependencies +mysqlclient pymssql<=2.2.5 sqlalchemy diff --git a/setup/base_external_dbsource_mysql/odoo/addons/base_external_dbsource_mysql b/setup/base_external_dbsource_mysql/odoo/addons/base_external_dbsource_mysql new file mode 120000 index 00000000..01566901 --- /dev/null +++ b/setup/base_external_dbsource_mysql/odoo/addons/base_external_dbsource_mysql @@ -0,0 +1 @@ +../../../../base_external_dbsource_mysql \ No newline at end of file diff --git a/setup/base_external_dbsource_mysql/setup.py b/setup/base_external_dbsource_mysql/setup.py new file mode 100644 index 00000000..28c57bb6 --- /dev/null +++ b/setup/base_external_dbsource_mysql/setup.py @@ -0,0 +1,6 @@ +import setuptools + +setuptools.setup( + setup_requires=['setuptools-odoo'], + odoo_addon=True, +)