From 464cd59da32f12a8ca17466b34d5a9097bab864f Mon Sep 17 00:00:00 2001 From: David Virebayre Date: Mon, 9 Oct 2023 09:27:27 +0200 Subject: [PATCH] [FIX] Prevent exception if the query doesn't return rows --- .../models/base_external_dbsource.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/base_external_dbsource_sqlite/models/base_external_dbsource.py b/base_external_dbsource_sqlite/models/base_external_dbsource.py index 37b886fc..fc6ba2f1 100644 --- a/base_external_dbsource_sqlite/models/base_external_dbsource.py +++ b/base_external_dbsource_sqlite/models/base_external_dbsource.py @@ -38,5 +38,7 @@ class BaseExternalDbsource(models.Model): cur = connection.execute(sqlquery, sqlparams) if metadata: cols = list(cur.keys()) - rows = [r for r in cur] + # If the query doesn't return rows, trying to get them anyway + # will raise an exception `sqlalchemy.exc.ResourceClosedError` + rows = [r for r in cur] if cur.returns_rows else [] return rows, cols