From 76b4d8d2c0552952b0d9ed5833f40c5aabd24581 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Mart=C3=ADnez?= Date: Fri, 18 Nov 2022 08:09:07 +0100 Subject: [PATCH] [IMP] base_external_dbsource_mssql: black, isort, prettier --- .../models/base_external_dbsource.py | 2 +- .../tests/test_base_external_dbsource.py | 6 +++--- requirements.txt | 1 + .../odoo/addons/base_external_dbsource_mssql | 1 + setup/base_external_dbsource_mssql/setup.py | 6 ++++++ 5 files changed, 12 insertions(+), 4 deletions(-) create mode 120000 setup/base_external_dbsource_mssql/odoo/addons/base_external_dbsource_mssql create mode 100644 setup/base_external_dbsource_mssql/setup.py diff --git a/base_external_dbsource_mssql/models/base_external_dbsource.py b/base_external_dbsource_mssql/models/base_external_dbsource.py index 11332327..9a538cc8 100644 --- a/base_external_dbsource_mssql/models/base_external_dbsource.py +++ b/base_external_dbsource_mssql/models/base_external_dbsource.py @@ -26,7 +26,7 @@ except ImportError: class BaseExternalDbsource(models.Model): - """ It provides logic for connection to a MSSQL data source. """ + """It provides logic for connection to a MSSQL data source.""" _inherit = "base.external.dbsource" diff --git a/base_external_dbsource_mssql/tests/test_base_external_dbsource.py b/base_external_dbsource_mssql/tests/test_base_external_dbsource.py index 240396d6..6d334ccc 100644 --- a/base_external_dbsource_mssql/tests/test_base_external_dbsource.py +++ b/base_external_dbsource_mssql/tests/test_base_external_dbsource.py @@ -15,13 +15,13 @@ class TestBaseExternalDbsource(common.TransactionCase): self.dbsource = self.env.ref("base_external_dbsource_mssql.demo_mssql") def test_connection_close_mssql(self): - """ It should close the connection """ + """It should close the connection""" connection = mock.MagicMock() res = self.dbsource.connection_close_mssql(connection) self.assertEqual(res, connection.close()) def test_connection_open_mssql(self): - """ It should call SQLAlchemy open """ + """It should call SQLAlchemy open""" with mock.patch.object( self.dbsource, "_connection_open_sqlalchemy" ) as parent_method: @@ -29,7 +29,7 @@ class TestBaseExternalDbsource(common.TransactionCase): parent_method.assert_called_once_with() def test_excecute_mssql(self): - """ It should pass args to SQLAlchemy execute """ + """It should pass args to SQLAlchemy execute""" expect = "sqlquery", "sqlparams", "metadata" with mock.patch.object(self.dbsource, "_execute_sqlalchemy") as parent_method: self.dbsource.execute_mssql(*expect) diff --git a/requirements.txt b/requirements.txt index 867daed4..88328f65 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,2 +1,3 @@ # generated from manifests external_dependencies +pymssql<=2.2.5 sqlalchemy diff --git a/setup/base_external_dbsource_mssql/odoo/addons/base_external_dbsource_mssql b/setup/base_external_dbsource_mssql/odoo/addons/base_external_dbsource_mssql new file mode 120000 index 00000000..9a9b864e --- /dev/null +++ b/setup/base_external_dbsource_mssql/odoo/addons/base_external_dbsource_mssql @@ -0,0 +1 @@ +../../../../base_external_dbsource_mssql \ No newline at end of file diff --git a/setup/base_external_dbsource_mssql/setup.py b/setup/base_external_dbsource_mssql/setup.py new file mode 100644 index 00000000..28c57bb6 --- /dev/null +++ b/setup/base_external_dbsource_mssql/setup.py @@ -0,0 +1,6 @@ +import setuptools + +setuptools.setup( + setup_requires=['setuptools-odoo'], + odoo_addon=True, +)