[16.0][MIG]base_external_dbsource_mssql

base_external_dbsource_mssql/__manifest__.py

@@ -3,13 +3,14 @@
 # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl).
 {
     "name": "External Database Source - MSSQL",
-    "version": "15.0.1.0.0",
+    "version": "16.0.1.0.0",
     "category": "Tools",
     "author": "Daniel Reis, " "LasLabs, " "Odoo Community Association (OCA)",
+    "maintainers": ["anddago78"],
     "website": "https://github.com/OCA/server-backend",
     "license": "LGPL-3",
     "depends": ["base_external_dbsource_sqlite"],
-    "external_dependencies": {"python": ["pymssql<=2.2.5"]},
+    "external_dependencies": {"python": ["pymssql<=2.2.5", "sqlalchemy"]},
     "demo": ["demo/base_external_dbsource.xml"],
     "installable": True,
 }

base_external_dbsource_mssql/models/base_external_dbsource.py

@@ -4,12 +4,7 @@
 
 import pymssql
 
-from odoo import models
-
-from odoo.addons.base_external_dbsource.models import base_external_dbsource
-
-CONNECTORS = base_external_dbsource.BaseExternalDbsource.CONNECTORS
-CONNECTORS.append(("mssql", "Microsoft SQL Server"))
+from odoo import fields, models
 
 assert pymssql
 
@@ -19,6 +14,9 @@ class BaseExternalDbsource(models.Model):
 
     _inherit = "base.external.dbsource"
 
+    connector = fields.Selection(
+        selection_add=[("mssql", "Microsoft SQL Server")], ondelete={"mssql": "cascade"}
+    )
     PWD_STRING_MSSQL = "Password=%s;"
 
     def connection_close_mssql(self, connection):

base_external_dbsource_mssql/readme/CONTRIBUTORS.rst

@@ -4,3 +4,4 @@
 * Dave Lasley <dave@laslabs.com>
 * `Tecnativa <https://www.tecnativa.com>`_:
     * Sergio Teruel
+* Andrea Cattalani (`Moduon <https://www.moduon.team/>`__)

base_external_dbsource_mssql/tests/test_base_external_dbsource.py

@@ -1,6 +1,6 @@
 # Copyright 2016 LasLabs Inc.
 
-import mock
+from unittest import mock
 
 from odoo.tests import common
 

requirements.txt

@@ -1,2 +1,3 @@
 # generated from manifests external_dependencies
+pymssql<=2.2.5
 sqlalchemy

setup/base_external_dbsource_mssql/odoo/addons/base_external_dbsource_mssql

@@ -0,0 +1 @@
+../../../../base_external_dbsource_mssql

setup/base_external_dbsource_mssql/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)