From 567512272fa74f4ab428b269cfd47628d9ee8129 Mon Sep 17 00:00:00 2001
From: Stefan Rijnhart <stefan@opener.am>
Date: Wed, 16 Dec 2020 22:46:53 +0100
Subject: [PATCH] [FIX] Prevent warning abount fields with same name

Also fix some other inconsistencies.
---
 base_global_discount/models/res_partner.py       |  4 +++-
 base_global_discount/views/res_partner_views.xml | 11 ++++++++---
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/base_global_discount/models/res_partner.py b/base_global_discount/models/res_partner.py
index ee9c87a0..e204c49d 100644
--- a/base_global_discount/models/res_partner.py
+++ b/base_global_discount/models/res_partner.py
@@ -27,8 +27,10 @@ class ResPartner(models.Model):
     customer_global_discount_ids_readonly = fields.Many2many(
         related="customer_global_discount_ids",
         readonly=True,
+        string='Sale Global Discounts (Readonly)',
     )
     supplier_global_discount_ids_readonly = fields.Many2many(
-        related="customer_global_discount_ids",
+        related="supplier_global_discount_ids",
         readonly=True,
+        string='Purchase Global Discounts (Readonly)',
     )
diff --git a/base_global_discount/views/res_partner_views.xml b/base_global_discount/views/res_partner_views.xml
index ec40ca40..e4608441 100644
--- a/base_global_discount/views/res_partner_views.xml
+++ b/base_global_discount/views/res_partner_views.xml
@@ -8,16 +8,21 @@
          <field name="inherit_id" ref="base.view_partner_form"/>
          <field name="arch" type="xml">
             <group name="sale" position="inside">
-                <field name="customer_global_discount_ids" widget="many2many_tags" groups="base_global_discount.group_global_discount"
+                <field name="customer_global_discount_ids" widget="many2many_tags"
+                       groups="base_global_discount.group_global_discount"
                        attrs="{'invisible': [('customer', '=', False), ('is_company', '=', False), ('parent_id', '!=', False)]}"/>
                 <field name="customer_global_discount_ids_readonly" widget="many2many_tags"
                        groups="!base_global_discount.group_global_discount"
+                       string="Sale Global Discounts"
                        attrs="{'invisible': [('customer', '=', False), ('is_company', '=', False), ('parent_id', '!=', False)]}"/>
             </group>
             <group name="purchase" position="inside">
-                <field name="supplier_global_discount_ids" widget="many2many_tags" groups="base_global_discount.group_global_discount"
+                <field name="supplier_global_discount_ids" widget="many2many_tags"
+                       groups="base_global_discount.group_global_discount"
                        attrs="{'invisible': [('supplier', '=', False), ('is_company', '=', False), ('parent_id', '!=', False)]}"/>
-                <field name="supplier_global_discount_ids" widget="many2many_tags" groups="!base_global_discount.group_global_discount"
+                <field name="supplier_global_discount_ids_readonly" widget="many2many_tags"
+                       groups="!base_global_discount.group_global_discount"
+                       string="Purchase Global Discounts"
                        attrs="{'invisible': [('supplier', '=', False), ('is_company', '=', False), ('parent_id', '!=', False)]}"/>
             </group>
          </field>