From 31f0d8ab311ff2346bb87043f8d81c913fc3b2f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A0=20Gil=20Sorribes?= Date: Tue, 13 Nov 2018 15:26:17 +0100 Subject: [PATCH] [FIX] base_external_dbsource_sqlite crashing when sqlparams equal None --- base_external_dbsource_sqlite/__manifest__.py | 2 +- .../models/base_external_dbsource.py | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/base_external_dbsource_sqlite/__manifest__.py b/base_external_dbsource_sqlite/__manifest__.py index 601248f4..6aee9378 100644 --- a/base_external_dbsource_sqlite/__manifest__.py +++ b/base_external_dbsource_sqlite/__manifest__.py @@ -3,7 +3,7 @@ # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl). { 'name': 'External Database Source - SQLite', - 'version': '11.0.1.0.0', + 'version': '11.0.1.0.1', 'category': 'Tools', 'author': "Daniel Reis, " "LasLabs, " diff --git a/base_external_dbsource_sqlite/models/base_external_dbsource.py b/base_external_dbsource_sqlite/models/base_external_dbsource.py index 5e00bf69..ca62ceef 100644 --- a/base_external_dbsource_sqlite/models/base_external_dbsource.py +++ b/base_external_dbsource_sqlite/models/base_external_dbsource.py @@ -51,7 +51,10 @@ class BaseExternalDbsource(models.Model): rows, cols = list(), list() for record in self: with record.connection_open() as connection: - cur = connection.execute(sqlquery, sqlparams) + if sqlparams is None: + cur = connection.execute(sqlquery) + else: + cur = connection.execute(sqlquery, sqlparams) if metadata: cols = list(cur.keys()) rows = [r for r in cur]