audrius/server-backend
1
0
Fork 0
mirror of https://github.com/OCA/server-backend.git synced 2025-02-18 09:52:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

[base_user_role] improve performance by only adding/removing from a user

Browse Source 
the groups that have changed with respecto the role.
This commit is contained in:
Jordi Ballester Alomar
2019-01-02 11:34:38 +01:00
committed by Duc Dao
parent 45cc7096cf
commit 300455f59d
1 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
base_user_role/models/user.py
View File

@@ -55,6 +55,13 @@ class ResUsers(models.Model):
If no role is defined on the user, its groups are let untouched unless
the `force` parameter is `True`.
"""
role_groups = {}
# We obtain all the groups associated to each role first, so that
# it is faster to compare later with each user's groups.
for role in self.mapped('role_line_ids.role_id'):
role_groups[role] = list(set(
role.group_id.ids + role.implied_ids.ids +
role.trans_implied_ids.ids))
for user in self:
if not user.role_line_ids and not force:
continue
@@ -64,11 +71,16 @@ class ResUsers(models.Model):
for role_line in role_lines:
role = role_line.role_id
if role:
group_ids.append(role.group_id.id)
group_ids.extend(role.implied_ids.ids)
group_ids += role_groups[role]
group_ids = list(set(group_ids)) # Remove duplicates IDs
vals = {
'groups_id': [(6, 0, group_ids)],
}
super(ResUsers, user).write(vals)
groups_to_add = list(set(group_ids) - set(user.groups_id.ids))
groups_to_remove = list(set(user.groups_id.ids) - set(group_ids))
to_add = [(4, gr) for gr in groups_to_add]
to_remove = [(3, gr) for gr in groups_to_remove]
groups = to_remove + to_add
if groups:
vals = {
'groups_id': groups,
}
super(ResUsers, user).write(vals)
return True