[IMP] base_external_dbsource: Refactor & Split by source

* Heavily refactor code for reusability
* Split all sources into independent modules
* Add more test coverage
* Add CRUD methods
* Add iterator execute return to roadmap
This commit is contained in:
Dave Lasley
2016-12-07 18:28:41 -08:00
committed by sergio.teruel
parent 17a3433ed0
commit 0128b6429a
15 changed files with 379 additions and 0 deletions

View File

@@ -0,0 +1,3 @@
# -*- encoding: utf-8 -*-
from . import test_base_external_dbsource

View File

@@ -0,0 +1,42 @@
# -*- coding: utf-8 -*-
# Copyright 2016 LasLabs Inc.
import mock
from odoo.tests import common
ADAPTER = ('odoo.addons.base_external_dbsource_mysql.models'
'.base_external_dbsource.MySQLdb')
class TestBaseExternalDbsource(common.TransactionCase):
def setUp(self):
super(TestBaseExternalDbsource, self).setUp()
self.dbsource = self.env.ref(
'base_external_dbsource_mysql.demo_mysql',
)
def test_connection_close_mysql(self):
""" It should close the connection """
connection = mock.MagicMock()
res = self.dbsource.connection_close_mysql(connection)
self.assertEqual(res, connection.close())
def test_connection_open_mysql(self):
""" It should call SQLAlchemy open """
with mock.patch.object(
self.dbsource, '_connection_open_sqlalchemy'
) as parent_method:
self.dbsource.connection_open_mysql()
parent_method.assert_called_once_with()
def test_excecute_mysql(self):
""" It should pass args to SQLAlchemy execute """
expect = 'sqlquery', 'sqlparams', 'metadata'
with mock.patch.object(
self.dbsource, '_execute_sqlalchemy'
) as parent_method:
self.dbsource.execute_mysql(*expect)
parent_method.assert_called_once_with(*expect)