From 9d906298e6f89a63ea6c48232c526fdfde29ed14 Mon Sep 17 00:00:00 2001 From: Osval Reyes Date: Wed, 18 Nov 2015 17:34:44 -0430 Subject: [PATCH] [FIX] crm_claim_rma: fix display_name that wasn't showing as expected --- crm_claim_rma/models/claim_line.py | 7 ++----- crm_claim_rma/tests/test_picking_creation.py | 11 +++++++++++ 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/crm_claim_rma/models/claim_line.py b/crm_claim_rma/models/claim_line.py index f91f692d..2e8b6728 100644 --- a/crm_claim_rma/models/claim_line.py +++ b/crm_claim_rma/models/claim_line.py @@ -424,9 +424,6 @@ class ClaimLine(models.Model): @api.multi def _get_display_name(self): - res = [] for line_id in self: - res.append( - (line_id.id, "%s - %s" % - (line_id.claim_id.code, line_id.name))) - return res + line_id.display_name = "%s - %s" % ( + line_id.claim_id.code, line_id.name) diff --git a/crm_claim_rma/tests/test_picking_creation.py b/crm_claim_rma/tests/test_picking_creation.py index da5c384b..f0bdcf6a 100644 --- a/crm_claim_rma/tests/test_picking_creation.py +++ b/crm_claim_rma/tests/test_picking_creation.py @@ -186,3 +186,14 @@ class TestPickingCreation(common.TransactionCase): self.assertTrue(res) self.assertEquals(res['res_model'], 'account.invoice') self.assertEquals(eval(res['context'])['type'], 'out_refund') + + def test_04_display_name(self): + """ + It tests that display_name for each line has a message for it + """ + claim_line_ids = self.env['crm.claim'].browse( + self.ref('crm_claim.crm_claim_6'))[0].claim_line_ids + + all_values = sum([bool(line_id.display_name) + for line_id in claim_line_ids]) + self.assertEquals(len(claim_line_ids), all_values)