From b251dd480d1c5b1bea995e10d2011aad521dbc17 Mon Sep 17 00:00:00 2001
From: Ernesto Tejeda <ernesto.tejeda@tecnativa.com>
Date: Sat, 12 Dec 2020 10:18:13 -0500
Subject: [PATCH 1/3] [IMP] *rma*: Avoid RMAs of kits until rma_mrp is
 installed

---
 rma_sale/views/sale_portal_template.xml | 12 +++++-------
 website_rma/controllers/main.py         | 13 +++++++++++--
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/rma_sale/views/sale_portal_template.xml b/rma_sale/views/sale_portal_template.xml
index 3e75f659..f33c9de0 100644
--- a/rma_sale/views/sale_portal_template.xml
+++ b/rma_sale/views/sale_portal_template.xml
@@ -67,7 +67,7 @@
                                 </thead>
                                 <tbody class="request-rma-tbody">
                                     <t t-foreach="data_list" t-as="data">
-                                        <t t-if="data['quantity'] > 0">
+                                        <t t-if="data['quantity'] > 0 and data['picking']">
                                             <tr>
                                                 <td class="text-left">
                                                     <span t-esc="data['product'].display_name"/>
@@ -92,12 +92,10 @@
                                                     </div>
                                                 </td>
                                                 <td class="text-left">
-                                                    <t t-if="data['picking']">
-                                                        <span t-esc="data['picking'].name"/>
-                                                        <input type="hidden"
-                                                            t-attf-name="#{data_index}-picking_id"
-                                                            t-att-value="data['picking'].id"/>
-                                                    </t>
+                                                    <span t-esc="data['picking'].name"/>
+                                                    <input type="hidden"
+                                                        t-attf-name="#{data_index}-picking_id"
+                                                        t-att-value="data['picking'].id"/>
                                                 </td>
                                                 <td class="text-left">
                                                     <select t-attf-name="#{data_index}-operation_id"
diff --git a/website_rma/controllers/main.py b/website_rma/controllers/main.py
index d1ac3b00..67447f50 100644
--- a/website_rma/controllers/main.py
+++ b/website_rma/controllers/main.py
@@ -26,10 +26,19 @@ class WebsiteRMA(http.Controller):
         """Domain used for the products to be shown in selection of
         the web form.
         """
-        return [
-            ('name', '=ilike', "%{}%".format(q or '')),
+        domain = [
+            ("name", "=ilike", "%{}%".format(q or "")),
             ("sale_ok", "=", True),
         ]
+        # HACK: As there is no glue module for this purpose we have put
+        # this this condition to check that the mrp module is installed.
+        if "bom_ids" in request.env["product.product"]._fields:
+            domain += [
+                "|",
+                ("bom_ids.type", "!=", "phantom"),
+                ("bom_ids", "=", False),
+            ]
+        return domain
 
     @http.route(['/requestrma'], type='http', auth="user", website=True)
     def request_rma(self, **kw):

From 68b8a9ec971ddcb888ab9623ebca8695933f1d9e Mon Sep 17 00:00:00 2001
From: Ernesto Tejeda <ernesto.tejeda@tecnativa.com>
Date: Sat, 12 Dec 2020 10:21:44 -0500
Subject: [PATCH 2/3] [IMP] *rma*: some improvements

---
 rma_sale/wizard/sale_order_rma_wizard.py | 3 +++
 website_rma/controllers/main.py          | 1 +
 2 files changed, 4 insertions(+)

diff --git a/rma_sale/wizard/sale_order_rma_wizard.py b/rma_sale/wizard/sale_order_rma_wizard.py
index 96410bd8..baeb0319 100644
--- a/rma_sale/wizard/sale_order_rma_wizard.py
+++ b/rma_sale/wizard/sale_order_rma_wizard.py
@@ -62,6 +62,8 @@ class SaleOrderRmaWizard(models.TransientModel):
     def create_and_open_rma(self):
         self.ensure_one()
         rma = self.create_rma()
+        if not rma:
+            return
         for rec in rma:
             rec.action_confirm()
         action = self.env.ref('rma.rma_action').read()[0]
@@ -137,6 +139,7 @@ class SaleOrderLineRmaWizard(models.TransientModel):
     @api.onchange('product_id')
     def onchange_product_id(self):
         self.picking_id = False
+        self.uom_id = self.product_id.uom_id
 
     @api.depends('picking_id')
     def _compute_move_id(self):
diff --git a/website_rma/controllers/main.py b/website_rma/controllers/main.py
index 67447f50..bf365282 100644
--- a/website_rma/controllers/main.py
+++ b/website_rma/controllers/main.py
@@ -11,6 +11,7 @@ class WebsiteForm(WebsiteForm):
     def insert_record(self, request, model, values, custom, meta=None):
         if model.model == 'rma':
             values['partner_id'] = request.env.user.partner_id.id
+            values['origin'] = 'Website form'
         res = super(WebsiteForm, self).insert_record(
             request, model, values, custom, meta)
         # Add the customer to the followers, the same as when creating

From 61092105858173864086b083c968ee60131de426 Mon Sep 17 00:00:00 2001
From: david <david.vidal@tecnativa.com>
Date: Thu, 17 Dec 2020 17:04:05 +0100
Subject: [PATCH 3/3] [FIX] rma_sale: product in multiple lines

If there are several stock moves with the same product in the picking we
won't be able to make the RMA
---
 rma_sale/models/sale.py                  | 7 +++++--
 rma_sale/views/sale_portal_template.xml  | 4 ++++
 rma_sale/wizard/sale_order_rma_wizard.py | 9 +++++++--
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/rma_sale/models/sale.py b/rma_sale/models/sale.py
index 54f59860..28ff0b14 100644
--- a/rma_sale/models/sale.py
+++ b/rma_sale/models/sale.py
@@ -37,6 +37,7 @@ class SaleOrder(models.Model):
         line_vals = [(0, 0, {
             'product_id': data['product'].id,
             'quantity': data['quantity'],
+            'sale_line_id': data['sale_line_id'].id,
             'uom_id': data['uom'].id,
             'picking_id': data['picking'] and data['picking'].id,
         }) for data in self.get_delivery_rma_data()]
@@ -84,7 +85,7 @@ class SaleOrderLine(models.Model):
     def get_delivery_move(self):
         self.ensure_one()
         return self.move_ids.filtered(lambda r: (
-            self.product_id == r.product_id
+            self == r.sale_line_id
             and r.state == 'done'
             and not r.scrapped
             and r.location_dest_id.usage == "customer"
@@ -107,10 +108,11 @@ class SaleOrderLine(models.Model):
                                           'assigned', 'done'])
                 qty -= sum(move_dest.mapped('product_uom_qty'))
                 data.append({
-                    'product': product,
+                    'product': move.product_id,
                     'quantity': qty,
                     'uom': move.product_uom,
                     'picking': move.picking_id,
+                    'sale_line_id': self,
                 })
         else:
             data.append({
@@ -118,5 +120,6 @@ class SaleOrderLine(models.Model):
                 'quantity': self.qty_delivered,
                 'uom': self.product_uom,
                 'picking': False,
+                'sale_line_id': self,
             })
         return data
diff --git a/rma_sale/views/sale_portal_template.xml b/rma_sale/views/sale_portal_template.xml
index f33c9de0..a1f0027e 100644
--- a/rma_sale/views/sale_portal_template.xml
+++ b/rma_sale/views/sale_portal_template.xml
@@ -74,6 +74,10 @@
                                                     <input type="hidden"
                                                            t-attf-name="#{data_index}-product_id"
                                                            t-att-value="data['product'].id"/>
+                                                    <input type="hidden"
+                                                           t-if="data.get('sale_line_id')"
+                                                           t-attf-name="#{data_index}-sale_line_id"
+                                                           t-att-value="data['sale_line_id'].id"/>
                                                 </td>
                                                 <td class="text-right">
                                                     <div id="delivery-rma-qty">
diff --git a/rma_sale/wizard/sale_order_rma_wizard.py b/rma_sale/wizard/sale_order_rma_wizard.py
index baeb0319..d6ca3ad0 100644
--- a/rma_sale/wizard/sale_order_rma_wizard.py
+++ b/rma_sale/wizard/sale_order_rma_wizard.py
@@ -134,6 +134,9 @@ class SaleOrderLineRmaWizard(models.TransientModel):
         comodel_name='rma.operation',
         string='Requested operation',
     )
+    sale_line_id = fields.Many2one(
+        comodel_name="sale.order.line",
+    )
     description = fields.Text()
 
     @api.onchange('product_id')
@@ -146,8 +149,10 @@ class SaleOrderLineRmaWizard(models.TransientModel):
         for record in self:
             if record.picking_id:
                 record.move_id = record.picking_id.move_lines.filtered(
-                    lambda r: (r.sale_line_id.product_id == record.product_id
-                               and r.sale_line_id.order_id == record.order_id))
+                    lambda r: (
+                        r.sale_line_id == record.sale_line_id and
+                        r.sale_line_id.product_id == record.product_id
+                        and r.sale_line_id.order_id == record.order_id))
 
     @api.depends('order_id')
     def _compute_allowed_product_ids(self):