From 2ddc6b94e9caddf22a3bb9c3a2f88b53f13a8f97 Mon Sep 17 00:00:00 2001
From: David <david.vidal@tecnativa.com>
Date: Mon, 6 Nov 2023 09:25:48 +0100
Subject: [PATCH] [FIX] *: Linter fixes

---
 product_warranty/views/product_warranty.xml |  2 +-
 rma/views/rma_finalization_views.xml        |  2 +-
 rma/views/rma_tag_views.xml                 |  2 +-
 rma_sale/static/src/js/rma_portal_form.js   |  1 +
 website_rma/data/website_data.xml           | 14 ++++++--------
 5 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/product_warranty/views/product_warranty.xml b/product_warranty/views/product_warranty.xml
index 3c2db686..888bfc3b 100644
--- a/product_warranty/views/product_warranty.xml
+++ b/product_warranty/views/product_warranty.xml
@@ -5,7 +5,7 @@
         <field name="name">product.return.instructions.tree</field>
         <field name="model">return.instruction</field>
         <field name="arch" type="xml">
-            <tree string="Return instructions">
+            <tree>
                 <field name="name" />
                 <field name="instructions" />
                 <field name="is_default" />
diff --git a/rma/views/rma_finalization_views.xml b/rma/views/rma_finalization_views.xml
index ce0fb51c..abc7c20c 100644
--- a/rma/views/rma_finalization_views.xml
+++ b/rma/views/rma_finalization_views.xml
@@ -44,7 +44,7 @@
         <field name="model">rma.finalization</field>
         <field eval="6" name="priority" />
         <field name="arch" type="xml">
-            <tree string="RMA Finalization Reasons">
+            <tree>
                 <field name="name" />
                 <field name="company_id" groups="base.group_multi_company" />
             </tree>
diff --git a/rma/views/rma_tag_views.xml b/rma/views/rma_tag_views.xml
index d7166b65..d8e47b7d 100644
--- a/rma/views/rma_tag_views.xml
+++ b/rma/views/rma_tag_views.xml
@@ -37,7 +37,7 @@
         <field name="model">rma.tag</field>
         <field eval="6" name="priority" />
         <field name="arch" type="xml">
-            <tree string="RMA Tags">
+            <tree>
                 <field name="name" />
                 <field name="is_public" />
                 <field name="active" />
diff --git a/rma_sale/static/src/js/rma_portal_form.js b/rma_sale/static/src/js/rma_portal_form.js
index 1bda0788..398219a2 100644
--- a/rma_sale/static/src/js/rma_portal_form.js
+++ b/rma_sale/static/src/js/rma_portal_form.js
@@ -69,6 +69,7 @@ odoo.define("rma_sale.animation", function (require) {
          * We should be able to submit only when an operation is selected and a
          * quantity entered in a row at least.
          * @private
+         * @returns {Boolean}
          */
         _canSubmit: function () {
             var can_submit = false;
diff --git a/website_rma/data/website_data.xml b/website_rma/data/website_data.xml
index 3acb3276..1488a87c 100644
--- a/website_rma/data/website_data.xml
+++ b/website_rma/data/website_data.xml
@@ -2,12 +2,10 @@
 <!-- Copyright 2020 Tecnativa - Ernesto Tejeda
      License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
 <odoo>
-    <data>
-        <record id="request_rma_thanks_page" model="website.page">
-            <field name="url">/requestrma-thank-you</field>
-            <field name="website_indexed" eval="False" />
-            <field name="website_published">True</field>
-            <field name="view_id" ref="request_rma_thanks_page_view" />
-        </record>
-    </data>
+    <record id="request_rma_thanks_page" model="website.page">
+        <field name="url">/requestrma-thank-you</field>
+        <field name="website_indexed" eval="False" />
+        <field name="website_published">True</field>
+        <field name="view_id" ref="request_rma_thanks_page_view" />
+    </record>
 </odoo>