From 07b53eb16a25f3a42254f583fbb4c6f2a3408800 Mon Sep 17 00:00:00 2001
From: David <david.vidal@tecnativa.com>
Date: Thu, 9 Mar 2023 17:03:01 +0100
Subject: [PATCH 1/2] [FIX] rma_sale_mrp: avoid reopening of kit RMAs

As we rely on the kit_qty field have the kit/component relation an
that's computed when the RMA is created, we want to avoid reopening the
RMA to avoid inconsitencies. The user should create a new RMA.

TT41943
---
 rma_sale_mrp/models/rma.py | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/rma_sale_mrp/models/rma.py b/rma_sale_mrp/models/rma.py
index 741af052..b83a8a93 100644
--- a/rma_sale_mrp/models/rma.py
+++ b/rma_sale_mrp/models/rma.py
@@ -65,3 +65,13 @@ class Rma(models.Model):
                 }
             )
         return res
+
+    def action_draft(self):
+        if self.filtered(lambda r: r.state == "cancelled" and r.phantom_bom_product):
+            raise UserError(
+                _(
+                    "To avoid kit quantities inconsistencies it is not possible to convert "
+                    "to draft a cancelled RMA. You should do a new one from the sales order."
+                )
+            )
+        return super().action_draft()

From 6d587c1e2205f4f79f07fdb1eb11a145e62f4ecf Mon Sep 17 00:00:00 2001
From: David <david.vidal@tecnativa.com>
Date: Thu, 9 Mar 2023 17:29:45 +0100
Subject: [PATCH 2/2] [FIX] rma: avoid reopening a cancelled RMA when the
 reception is deleted

When we delete the reception for an RMA, we're setting it to draft
automatically so we can confirm it again and create a new reception.
This is unconvenient when the RMA is cancelled, as we don't wan't to
reopen it automatically.

TT41943
---
 rma/models/stock_move.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/rma/models/stock_move.py b/rma/models/stock_move.py
index 1e846eec..8d992561 100644
--- a/rma/models/stock_move.py
+++ b/rma/models/stock_move.py
@@ -35,7 +35,9 @@ class StockMove(models.Model):
         rma_receiver = self.sudo().mapped("rma_receiver_ids")
         rma = self.sudo().mapped("rma_id")
         res = super().unlink()
-        rma_receiver.write({"state": "draft"})
+        rma_receiver.filtered(lambda x: x.state != "cancelled").write(
+            {"state": "draft"}
+        )
         rma.update_received_state()
         rma.update_replaced_state()
         return res