[IMP] New API + Short Hearder

report_py3o/models/ir_report.py

@@ -1,11 +1,15 @@
+# -*- coding: utf-8 -*-
+# Copyright 2013 XCG Consulting (http://odoo.consulting)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 import os
-from openerp.osv import fields, osv
+from openerp import api, fields, models
 from openerp.report.interface import report_int
 from ..py3o_parser import Py3oParser
+from openerp.exceptions import ValidationError
 from openerp import addons
 
 
-class report_xml(osv.Model):
+class ReportXml(models.Model):
     """ Inherit from ir.actions.report.xml to allow customizing the template
     file. The user cam chose a template from a list.
     The list is configurable in the configuration tab, see py3o_template.py
@@ -13,49 +17,32 @@ class report_xml(osv.Model):
 
     _inherit = 'ir.actions.report.xml'
 
-    _columns = {
-        # TODO required when report_type type is py3o, add python constraint
-        'py3o_fusion_filetype': fields.many2one(
-            'py3o.fusion.filetype',
-            u"Output Format",
-        ),
-        'py3o_template_id': fields.many2one(
-            'py3o.template',
-            u"Template",
-        ),
-        'module': fields.char(
-            u"Module",
-            size=64,
-            help=u"The implementer module that provides this report",
-        ),
-        'py3o_template_fallback': fields.char(
-            u"Fallback",
-            size=128,
-            help=(
-                u"If the user does not provide a template this will be used "
-                u"it should be a relative path to root of YOUR module"
-            )
-        ),
-        'report_type': fields.selection(
-            [
-                ('qweb-pdf', u"PDF"),
-                ('qweb-html', u"HTML"),
-                ('controller', u"Controller"),
-                ('pdf', u"RML pdf (deprecated)"),
-                ('sxw', u"RML sxw (deprecated)"),
-                ('webkit', u"Webkit (deprecated)"),
-                ('py3o', u"Py3o"),
-            ],
-            string=u"Report Type",
-            required=True,
-            help=u"HTML will open the report directly in your browser, "
-                 u"PDF will use wkhtmltopdf to render the HTML into a PDF "
-                 u"file and let you download it, Controller allows you to "
-                 u"define the url of a custom controller outputting "
-                 u"any kind of report.",
-        )
-    }
+    @api.one
+    @api.constrains("py3o_fusion_filetype", "report_type")
+    def _check_py3o_fusion_filetype(self):
+        if self.report_type == "py3o" and not self.py3o_fusion_filetype:
+            raise ValidationError(
+                "Field 'Output Format' is required for Py3O report")
 
+    py3o_fusion_filetype = fields.Many2one(
+        'py3o.fusion.filetype',
+        "Output Format")
+    py3o_template_id = fields.Many2one(
+        'py3o.template',
+        "Template")
+    module = fields.Char(
+        "Module",
+        help="The implementer module that provides this report")
+    py3o_template_fallback = fields.Char(
+        "Fallback",
+        size=128,
+        help=(
+            "If the user does not provide a template this will be used "
+            "it should be a relative path to root of YOUR module"
+        ))
+    report_type = fields.Selection(selection_add=[('py3o', "Py3o")])
+
+    @api.cr
     def _lookup_report(self, cr, name):
         """Look up a report definition.
         """
@@ -95,4 +82,4 @@ class report_xml(osv.Model):
         if new_report:
             return new_report
         else:
-            return super(report_xml, self)._lookup_report(cr, name)
+            return super(ReportXml, self)._lookup_report(cr, name)