mirror of
https://github.com/OCA/reporting-engine.git
synced 2025-02-16 16:30:38 +02:00
[FIX] report_xlsx: fix generation of pdf reports
the report handler for xlsx added over here is always returning `true` even if the report being
generated is not xlsx. Due to this, the report handler doesn't check for other report types
at b309d3a99f/addons/web/static/src/webclient/actions/action_service.js (L1019)
and thus doesn't generate any other reports. So if the converter is not xlsx, return false instead of true.
Also, updating the docids and context in the report_routes controller only needs to be done if
the converter is xlsx and not in any other case.
This commit is contained in:
@@ -48,6 +48,7 @@ registry
|
||||
} else if (onClose) {
|
||||
onClose();
|
||||
}
|
||||
return Promise.resolve(true);
|
||||
}
|
||||
return Promise.resolve(true);
|
||||
return Promise.resolve(false);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user