[IMP] 13.0 base_report_to_printer: improve job title

instead of sending a temporary random file name as the title of the job,
use the report file name. Since this is not displayed by default by
cups, document how to configure the CUPS server so that the information
can be displayed.

Clean up the temporary file after printing to avoid cluttering the
server in the long run.
This commit is contained in:
Alexandre Fayolle
2021-11-09 11:47:44 +01:00
parent 3594f0216b
commit e333bc6472
4 changed files with 28 additions and 1 deletions

View File

@@ -175,6 +175,7 @@ class PrintingPrinter(models.Model):
def print_file(self, file_name, report=None, **print_opts):
""" Print a file """
self.ensure_one()
title = print_opts.pop("title", file_name)
connection = self.server_id._open_connection(raise_on_error=True)
options = self.print_options(report=report, **print_opts)
@@ -182,10 +183,14 @@ class PrintingPrinter(models.Model):
"Sending job to CUPS printer %s on %s"
% (self.system_name, self.server_id.address)
)
connection.printFile(self.system_name, file_name, file_name, options=options)
connection.printFile(self.system_name, file_name, title, options=options)
_logger.info(
"Printing job: '{}' on {}".format(file_name, self.server_id.address)
)
try:
os.remove(file_name)
except OSError as exc:
_logger.warning("Unable to remove temporary file %s: %s", file_name, exc)
return True
def set_default(self):