pre-commit update

2025-02-16 07:11:31 +02:00 · 2020-03-14 12:19:41 +01:00
parent 6c9928760b
commit df0bcabf36
18 changed files with 590 additions and 611 deletions
--- a/.editorconfig
+++ b/.editorconfig
@@ -7,11 +7,11 @@ indent_style = space
 insert_final_newline = true
 trim_trailing_whitespace = true

-[.eslintrc,*.{json,yml,yaml,rst,md}]
+[*.{json,yml,yaml,rst,md}]
 indent_size = 2

 # Do not configure editor for libs and autogenerated content
-[*/static/{lib,src/lib}/**,*/static/description/index.html,*/readme/../README.rst]
+[{*/static/{lib,src/lib}/**,*/static/description/index.html,*/readme/../README.rst}]
 charset = unset
 end_of_line = unset
 indent_size = unset
--- a/.eslintrc
+++ b/.eslintrc
@@ -1,291 +0,0 @@
-{
-  "globals": {
-    "$": false,
-    "_": false,
-    "fuzzy": false,
-    "jQuery": false,
-    "moment": false,
-    "odoo": false,
-    "openerp": false,
-    "self": false
-  },
-  "env": {
-    "browser": true
-  },
-  "rules": {
-    "no-alert": "warn",
-    "no-array-constructor": "warn",
-    "no-bitwise": "off",
-    "no-caller": "warn",
-    "no-case-declarations": "warn",
-    "no-catch-shadow": "warn",
-    "no-class-assign": "warn",
-    "no-cond-assign": "warn",
-    "no-confusing-arrow": "warn",
-    "no-console": "off",
-    "no-const-assign": "warn",
-    "no-constant-condition": "warn",
-    "no-continue": "off",
-    "no-control-regex": "warn",
-    "no-debugger": "warn",
-    "no-delete-var": "warn",
-    "no-div-regex": "warn",
-    "no-dupe-args": "warn",
-    "no-dupe-class-members": "warn",
-    "no-dupe-keys": "warn",
-    "no-duplicate-case": "warn",
-    "no-duplicate-imports": "warn",
-    "no-else-return": "warn",
-    "no-empty": "warn",
-    "no-empty-character-class": "warn",
-    "no-empty-function": "warn",
-    "no-empty-pattern": "warn",
-    "no-eq-null": "warn",
-    "no-eval": "warn",
-    "no-ex-assign": "warn",
-    "no-extend-native": "warn",
-    "no-extra-bind": "warn",
-    "no-extra-boolean-cast": "warn",
-    "no-extra-label": "warn",
-    "no-extra-parens": "warn",
-    "no-extra-semi": "warn",
-    "no-fallthrough": "warn",
-    "no-floating-decimal": "warn",
-    "no-func-assign": "warn",
-    "no-implicit-coercion": ["warn", {
-      "allow": ["~"]
-    }],
-    "no-implicit-globals": "warn",
-    "no-implied-eval": "warn",
-    "no-inline-comments": "warn",
-    "no-inner-declarations": "warn",
-    "no-invalid-regexp": "warn",
-    "no-invalid-this": "off",
-    "no-irregular-whitespace": "warn",
-    "no-iterator": "warn",
-    "no-label-var": "warn",
-    "no-labels": "warn",
-    "no-lone-blocks": "warn",
-    "no-lonely-if": "warn",
-    "no-loop-func": "off",
-    "no-magic-numbers": "off",
-    "no-mixed-operators": "warn",
-    "no-mixed-requires": "warn",
-    "no-mixed-spaces-and-tabs": "warn",
-    "no-multi-spaces": "warn",
-    "no-multi-str": "warn",
-    "no-multiple-empty-lines": "warn",
-    "no-native-reassign": "warn",
-    "no-negated-condition": "warn",
-    "no-negated-in-lhs": "warn",
-    "no-nested-ternary": "off",
-    "no-new": "warn",
-    "no-new-func": "warn",
-    "no-new-object": "warn",
-    "no-new-require": "warn",
-    "no-new-symbol": "warn",
-    "no-new-wrappers": "warn",
-    "no-obj-calls": "warn",
-    "no-octal": "warn",
-    "no-octal-escape": "warn",
-    "no-param-reassign": "warn",
-    "no-path-concat": "warn",
-    "no-plusplus": "off",
-    "no-process-env": "warn",
-    "no-process-exit": "warn",
-    "no-proto": "warn",
-    "no-prototype-builtins": "warn",
-    "no-redeclare": "warn",
-    "no-regex-spaces": "warn",
-    "no-restricted-globals": "warn",
-    "no-restricted-imports": "warn",
-    "no-restricted-modules": "warn",
-    "no-restricted-syntax": "warn",
-    "no-return-assign": "warn",
-    "no-script-url": "warn",
-    "no-self-assign": "warn",
-    "no-self-compare": "warn",
-    "no-sequences": "warn",
-    "no-shadow": "warn",
-    "no-shadow-restricted-names": "warn",
-    "no-whitespace-before-property": "warn",
-    "no-spaced-func": "warn",
-    "no-sparse-arrays": "warn",
-    "no-sync": "warn",
-    "no-tabs": "warn",
-    "no-ternary": "off",
-    "no-trailing-spaces": "warn",
-    "no-this-before-super": "warn",
-    "no-throw-literal": "warn",
-    "no-undef": "warn",
-    "no-undef-init": "warn",
-    "no-undefined": "off",
-    "no-unexpected-multiline": "warn",
-    "no-underscore-dangle": "off",
-    "no-unmodified-loop-condition": "warn",
-    "no-unneeded-ternary": "warn",
-    "no-unreachable": "warn",
-    "no-unsafe-finally": "warn",
-    "no-unused-expressions": "warn",
-    "no-unused-labels": "warn",
-    "no-unused-vars": "warn",
-    "no-use-before-define": "warn",
-    "no-useless-call": "warn",
-    "no-useless-computed-key": "warn",
-    "no-useless-concat": "warn",
-    "no-useless-constructor": "warn",
-    "no-useless-escape": "warn",
-    "no-useless-rename": "warn",
-    "no-void": "warn",
-    "no-var": "off",
-    "no-warning-comments": "off",
-    "no-with": "warn",
-    "array-bracket-spacing": "off",
-    "array-callback-return": "warn",
-    "arrow-body-style": "warn",
-    "arrow-parens": "warn",
-    "arrow-spacing": "off",
-    "accessor-pairs": "warn",
-    "block-scoped-var": "off",
-    "block-spacing": ["warn", "always"],
-    "brace-style": "warn",
-    "callback-return": "warn",
-    "camelcase": "off",
-    "capitalized-comments": ["warn", "always", {
-      "ignoreConsecutiveComments": true,
-      "ignoreInlineComments": true
-    }],
-    "comma-dangle": ["warn", "always-multiline"],
-    "comma-spacing": ["warn", {
-      "before": false,
-      "after": true
-    }],
-    "comma-style": "warn",
-    "complexity": [
-      "warn",
-      15
-    ],
-    "computed-property-spacing": "off",
-    "consistent-return": "off",
-    "consistent-this": "off",
-    "constructor-super": "warn",
-    "curly": "warn",
-    "default-case": "off",
-    "dot-location": ["warn", "property"],
-    "dot-notation": "warn",
-    "eol-last": "warn",
-    "eqeqeq": "warn",
-    "func-names": "off",
-    "func-style": "off",
-    "generator-star-spacing": "off",
-    "global-require": "warn",
-    "guard-for-in": "off",
-    "handle-callback-err": "warn",
-    "id-blacklist": "warn",
-    "id-length": "off",
-    "id-match": "warn",
-    "indent": "warn",
-    "init-declarations": "warn",
-    "jsx-quotes": "warn",
-    "key-spacing": "off",
-    "keyword-spacing": "warn",
-    "linebreak-style": [
-      "warn",
-      "unix"
-    ],
-    "lines-around-comment": "warn",
-    "max-depth": "warn",
-    "max-len": ["warn", {
-      "code": 88,
-      "ignorePattern": "odoo\\.define\\(",
-      "tabWidth": 4
-    }],
-    "max-lines": "off",
-    "max-nested-callbacks": "warn",
-    "max-params": "off",
-    "max-statements": "off",
-    "max-statements-per-line": "warn",
-    "multiline-ternary": "off",
-    "new-cap": "off",
-    "new-parens": "warn",
-    "newline-after-var": "off",
-    "newline-before-return": "off",
-    "newline-per-chained-call": "off",
-    "object-curly-newline": ["warn", { "consistent": true }],
-    "object-curly-spacing": ["warn", "never"],
-    "object-property-newline": ["warn", {
-      "allowAllPropertiesOnSameLine": true
-    }],
-    "object-shorthand": "off",
-    "one-var": "off",
-    "one-var-declaration-per-line": "off",
-    "operator-assignment": "warn",
-    "operator-linebreak": "warn",
-    "padded-blocks": "off",
-    "prefer-arrow-callback": "off",
-    "prefer-const": "warn",
-    "prefer-reflect": "off",
-    "prefer-rest-params": "off",
-    "prefer-spread": "off",
-    "prefer-template": "off",
-    "quote-props": "off",
-    "quotes": "off",
-    "radix": "warn",
-    "require-yield": "warn",
-    "rest-spread-spacing": "off",
-    "semi": [
-      "warn",
-      "always"
-    ],
-    "semi-spacing": "warn",
-    "sort-imports": "warn",
-    "sort-vars": "off",
-    "space-before-blocks": "warn",
-    "space-before-function-paren": "warn",
-    "space-in-parens": "off",
-    "space-infix-ops": "off",
-    "space-unary-ops": "off",
-    "spaced-comment": ["warn", "always"],
-    "strict": ["warn", "function"],
-    "template-curly-spacing": "off",
-    "unicode-bom": "warn",
-    "use-isnan": "warn",
-    "valid-jsdoc": ["warn", {
-      "prefer": {
-        "arg": "param",
-        "argument": "param",
-        "augments": "extends",
-        "constructor": "class",
-        "exception": "throws",
-        "func": "function",
-        "method": "function",
-        "prop": "property",
-        "return": "returns",
-        "virtual": "abstract",
-        "yield": "yields"
-      },
-      "preferType": {
-        "array": "Array",
-        "bool": "Boolean",
-        "boolean": "Boolean",
-        "number": "Number",
-        "object": "Object",
-        "str": "String",
-        "string": "String"
-      },
-      "requireParamDescription": false,
-      "requireReturn": false,
-      "requireReturnDescription": false,
-      "requireReturnType": false
-    }],
-    "valid-typeof": "warn",
-    "vars-on-top": "off",
-    "wrap-iife": "warn",
-    "wrap-regex": "warn",
-    "yield-star-spacing": "off",
-    "yoda": "warn"
-  },
-  "parserOptions": {
-      "ecmaVersion": 2017
-  }
-}
--- a/.eslintrc.yml
+++ b/.eslintrc.yml
@@ -0,0 +1,180 @@
+env:
+  browser: true
+
+# See https://github.com/OCA/odoo-community.org/issues/37#issuecomment-470686449
+parserOptions:
+  ecmaVersion: 2017
+
+# Globals available in Odoo that shouldn't produce errorings
+globals:
+  _: readonly
+  $: readonly
+  fuzzy: readonly
+  jQuery: readonly
+  moment: readonly
+  odoo: readonly
+  openerp: readonly
+  Promise: readonly
+
+# Styling is handled by Prettier, so we only need to enable AST rules;
+# see https://github.com/OCA/maintainer-quality-tools/pull/618#issuecomment-558576890
+rules:
+  accessor-pairs: warn
+  array-callback-return: warn
+  callback-return: warn
+  capitalized-comments:
+    - warn
+    - always
+    - ignoreConsecutiveComments: true
+      ignoreInlineComments: true
+  complexity:
+    - warn
+    - 15
+  constructor-super: warn
+  dot-notation: warn
+  eqeqeq: warn
+  global-require: warn
+  handle-callback-err: warn
+  id-blacklist: warn
+  id-match: warn
+  init-declarations: error
+  max-depth: warn
+  max-nested-callbacks: warn
+  max-statements-per-line: warn
+  no-alert: warn
+  no-array-constructor: warn
+  no-caller: warn
+  no-case-declarations: warn
+  no-class-assign: warn
+  no-cond-assign: error
+  no-const-assign: error
+  no-constant-condition: warn
+  no-control-regex: warn
+  no-debugger: error
+  no-delete-var: warn
+  no-div-regex: warn
+  no-dupe-args: error
+  no-dupe-class-members: error
+  no-dupe-keys: error
+  no-duplicate-case: error
+  no-duplicate-imports: error
+  no-else-return: warn
+  no-empty-character-class: warn
+  no-empty-function: error
+  no-empty-pattern: error
+  no-empty: warn
+  no-eq-null: error
+  no-eval: error
+  no-ex-assign: error
+  no-extend-native: warn
+  no-extra-bind: warn
+  no-extra-boolean-cast: warn
+  no-extra-label: warn
+  no-fallthrough: warn
+  no-func-assign: error
+  no-global-assign: error
+  no-implicit-coercion:
+    - warn
+    - allow: ["~"]
+  no-implicit-globals: warn
+  no-implied-eval: warn
+  no-inline-comments: warn
+  no-inner-declarations: warn
+  no-invalid-regexp: warn
+  no-irregular-whitespace: warn
+  no-iterator: warn
+  no-label-var: warn
+  no-labels: warn
+  no-lone-blocks: warn
+  no-lonely-if: error
+  no-mixed-requires: error
+  no-multi-str: warn
+  no-native-reassign: error
+  no-negated-condition: warn
+  no-negated-in-lhs: error
+  no-new-func: warn
+  no-new-object: warn
+  no-new-require: warn
+  no-new-symbol: warn
+  no-new-wrappers: warn
+  no-new: warn
+  no-obj-calls: warn
+  no-octal-escape: warn
+  no-octal: warn
+  no-param-reassign: warn
+  no-path-concat: warn
+  no-process-env: warn
+  no-process-exit: warn
+  no-proto: warn
+  no-prototype-builtins: warn
+  no-redeclare: warn
+  no-regex-spaces: warn
+  no-restricted-globals: warn
+  no-restricted-imports: warn
+  no-restricted-modules: warn
+  no-restricted-syntax: warn
+  no-return-assign: error
+  no-script-url: warn
+  no-self-assign: warn
+  no-self-compare: warn
+  no-sequences: warn
+  no-shadow-restricted-names: warn
+  no-shadow: warn
+  no-sparse-arrays: warn
+  no-sync: warn
+  no-this-before-super: warn
+  no-throw-literal: warn
+  no-undef-init: warn
+  no-undef: error
+  no-unmodified-loop-condition: warn
+  no-unneeded-ternary: error
+  no-unreachable: error
+  no-unsafe-finally: error
+  no-unused-expressions: error
+  no-unused-labels: error
+  no-unused-vars: error
+  no-use-before-define: error
+  no-useless-call: warn
+  no-useless-computed-key: warn
+  no-useless-concat: warn
+  no-useless-constructor: warn
+  no-useless-escape: warn
+  no-useless-rename: warn
+  no-void: warn
+  no-with: warn
+  operator-assignment: [error, always]
+  prefer-const: warn
+  radix: warn
+  require-yield: warn
+  sort-imports: warn
+  spaced-comment: [error, always]
+  strict: [error, function]
+  use-isnan: error
+  valid-jsdoc:
+    - warn
+    - prefer:
+        arg: param
+        argument: param
+        augments: extends
+        constructor: class
+        exception: throws
+        func: function
+        method: function
+        prop: property
+        return: returns
+        virtual: abstract
+        yield: yields
+      preferType:
+        array: Array
+        bool: Boolean
+        boolean: Boolean
+        number: Number
+        object: Object
+        str: String
+        string: String
+      requireParamDescription: false
+      requireReturn: false
+      requireReturnDescription: false
+      requireReturnType: false
+  valid-typeof: warn
+  yoda: warn
--- a/.isort.cfg
+++ b/.isort.cfg
@@ -9,4 +9,4 @@ line_length=88
 known_odoo=odoo
 known_odoo_addons=odoo.addons
 sections=FUTURE,STDLIB,THIRDPARTY,ODOO,ODOO_ADDONS,FIRSTPARTY,LOCALFOLDER
-known_third_party=mock
+default_section=THIRDPARTY
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -1,13 +1,47 @@
-exclude: "^setup/|/static/lib/|/static/src/lib/"
+exclude: |
+  (?x)
+  # Files and folders generated by bots, to avoid loops
+  ^setup/|/static/description/index\.html$|
+  # Maybe reactivate this when all README files include prettier ignore tags?
+  ^README\.md$|
+  # Library files can have extraneous formatting (even minimized)
+  /static/(src/)?lib/|
+  # Repos using Sphinx to generate docs don't need prettying
+  ^docs/_templates/.*\.html$|
+  # You don't usually want a bot to modify your legal texts
+  (LICENSE.*|COPYING.*)
 default_language_version:
  python: python3
 repos:
  - repo: https://github.com/psf/black
-  rev: 19.3b0
+    rev: 19.10b0
    hooks:
      - id: black
+  - repo: https://github.com/prettier/prettier
+    rev: "1.19.1"
+    hooks:
+      - id: prettier
+  # TODO Avoid awebdeveloper/pre-commit-prettier if possible
+  # HACK https://github.com/prettier/prettier/issues/7407
+  - repo: https://github.com/awebdeveloper/pre-commit-prettier
+    rev: v0.0.1
+    hooks:
+      - id: prettier
+        name: prettier xml plugin
+        additional_dependencies:
+          - "prettier@1.19.1"
+          - "@prettier/plugin-xml@0.7.2"
+        files: \.xml$
+  - repo: https://github.com/pre-commit/mirrors-eslint
+    rev: v6.8.0
+    hooks:
+      - id: eslint
+        verbose: true
+        args:
+          - --color
+          - --fix
  - repo: https://github.com/pre-commit/pre-commit-hooks
-  rev: v2.3.0
+    rev: v2.4.0
    hooks:
      - id: trailing-whitespace
        # exclude autogenerated files
@@ -31,6 +65,8 @@ repos:
      - id: check-docstring-first
      - id: check-executables-have-shebangs
      - id: check-merge-conflict
+        # exclude files where underlines are not distinguishable from merge conflicts
+        exclude: /README\.rst$|^docs/.*\.rst$
      - id: check-symlinks
      - id: check-xml
      - id: mixed-line-ending
@@ -42,27 +78,22 @@ repos:
        name: pylint with optional checks
        args: ["--rcfile=.pylintrc", "--exit-zero"]
        verbose: true
-    additional_dependencies: ["pylint-odoo==3.0.3"]
+        additional_dependencies: ["pylint-odoo==3.1.0"]
      - id: pylint
        name: pylint with mandatory checks
        args: ["--rcfile=.pylintrc-mandatory"]
-    additional_dependencies: ["pylint-odoo==3.0.3"]
+        additional_dependencies: ["pylint-odoo==3.1.0"]
  - repo: https://github.com/asottile/pyupgrade
-  rev: v1.24.0
+    rev: v1.26.2
    hooks:
      - id: pyupgrade
- repo: https://github.com/asottile/seed-isort-config
-  rev: v1.9.3
-  hooks:
-  - id: seed-isort-config
  - repo: https://github.com/pre-commit/mirrors-isort
    rev: v4.3.21
    hooks:
      - id: isort
        name: isort except __init__.py
        exclude: /__init__\.py$
- repo: https://github.com/pre-commit/mirrors-eslint
-  rev: v6.5.1
+  - repo: https://github.com/acsone/setuptools-odoo
+    rev: 2.5.2
    hooks:
-  - id: eslint
-    verbose: true
+      - id: setuptools-odoo-make-default
--- a/.prettierrc.yml
+++ b/.prettierrc.yml
@@ -0,0 +1,8 @@
+# Defaults for all prettier-supported languages.
+# Prettier will complete this with settings from .editorconfig file.
+bracketSpacing: false
+printWidth: 88
+proseWrap: always
+semi: true
+trailingComma: "es5"
+xmlWhitespaceSensitivity: "ignore"
--- a/.travis.yml
+++ b/.travis.yml
@@ -39,7 +39,8 @@ env:
    - VERSION="13.0" TESTS="0" LINT_CHECK="0" MAKEPOT="0"

 install:
-  - git clone --depth=1 https://github.com/OCA/maintainer-quality-tools.git ${HOME}/maintainer-quality-tools
+  - git clone --depth=1 https://github.com/OCA/maintainer-quality-tools.git
+    ${HOME}/maintainer-quality-tools
  - export PATH=${HOME}/maintainer-quality-tools/travis:${PATH}
  - travis_install_nightly

--- a/base_report_to_printer/data/printing_data.xml
+++ b/base_report_to_printer/data/printing_data.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" ?>
 <odoo noupdate="1">
-
    <!-- printing.action -->
    <record model="printing.action" id="printing_action_1">
        <field name="name">Send to Printer</field>
@@ -13,10 +12,12 @@
    <!-- properties -->
    <record forcecreate="True" id="property_printing_action_id" model="ir.property">
        <field name="name">property_printing_action_id</field>
-        <field name="fields_id" search="[('model', '=', 'ir.actions.report'), ('name', '=', 'property_printing_action_id')]"/>
+        <field
+            name="fields_id"
+            search="[('model', '=', 'ir.actions.report'), ('name', '=', 'property_printing_action_id')]"
+        />
        <field name="value" eval="'printing.action,' + str(printing_action_2)" />
    </record>
-
    <record forcecreate="True" id="ir_cron_update_printers" model="ir.cron">
        <field name="name">Update Printers Jobs</field>
        <field eval="True" name="active" />
@@ -29,5 +30,4 @@
        <field name="state">code</field>
        <field name="code">model.action_update_jobs()</field>
    </record>
-
 </odoo>
--- a/base_report_to_printer/security/security.xml
+++ b/base_report_to_printer/security/security.xml
@@ -1,26 +1,18 @@
 <?xml version="1.0" ?>
 <odoo>
-
    <record id="printing_group_user" model="res.groups">
        <field name="name">Printing / Print User</field>
    </record>
-
    <record id="printing_group_manager" model="res.groups">
        <field name="name">Printing / Print Manager</field>
-        <field name="implied_ids"
-               eval="[(4, ref('printing_group_user'))]"/>
+        <field name="implied_ids" eval="[(4, ref('printing_group_user'))]" />
    </record>
-
    <record id="base.group_user" model="res.groups">
-        <field name="implied_ids"
-               eval="[(4, ref('printing_group_user'))]"/>
+        <field name="implied_ids" eval="[(4, ref('printing_group_user'))]" />
    </record>
-
    <record id="base.group_erp_manager" model="res.groups">
-        <field name="implied_ids"
-               eval="[(4, ref('printing_group_manager'))]"/>
+        <field name="implied_ids" eval="[(4, ref('printing_group_manager'))]" />
    </record>
-
    <record id="printing_server_group_manager" model="ir.model.access">
        <field name="name">Printing Server Manager</field>
        <field name="model_id" ref="model_printing_server" />
@@ -57,7 +49,6 @@
        <field eval="1" name="perm_write" />
        <field eval="1" name="perm_create" />
    </record>
-
    <record id="printing_server_group_user" model="ir.model.access">
        <field name="name">Printing Server User</field>
        <field name="model_id" ref="model_printing_server" />
@@ -131,5 +122,4 @@
        <field eval="1" name="perm_write" />
        <field eval="1" name="perm_create" />
    </record>
-
 </odoo>
--- a/base_report_to_printer/static/src/js/qweb_action_manager.js
+++ b/base_report_to_printer/static/src/js/qweb_action_manager.js
@@ -1,43 +1,50 @@
-odoo.define('base_report_to_printer.print', function (require) {
-    'use strict';
+odoo.define("base_report_to_printer.print", function(require) {
+    "use strict";

-    var ActionManager = require('web.ActionManager');
-    var core = require('web.core');
+    var ActionManager = require("web.ActionManager");
+    var core = require("web.core");
    var _t = core._t;

    ActionManager.include({
        _triggerDownload: function(action, options, type) {
            var self = this;
            var _super = this._super;
-            if (type === 'pdf') {
+            if (type === "pdf") {
                this._rpc({
-                    model: 'ir.actions.report',
-                    method: 'print_action_for_report_name',
+                    model: "ir.actions.report",
+                    method: "print_action_for_report_name",
                    args: [action.report_name],
                }).then(function(print_action) {
-                    if (print_action && print_action.action === 'server') {
+                    if (print_action && print_action.action === "server") {
                        self._rpc({
-                            model: 'ir.actions.report',
-                            method: 'print_document',
+                            model: "ir.actions.report",
+                            method: "print_document",
                            args: [action.id, action.context.active_ids],
                            kwargs: {data: action.data || {}},
                            context: action.context || {},
-                        }).then(function () {
-                            self.do_notify(_t('Report'),
+                        }).then(
+                            function() {
+                                self.do_notify(
+                                    _t("Report"),
                                    _.str.sprintf(
-                                    _t('Document sent to the printer %s'),
+                                        _t("Document sent to the printer %s"),
                                        print_action.printer_name
                                    )
                                );
-                        }, function () {
-                            self.do_notify(_t('Report'),
+                            },
+                            function() {
+                                self.do_notify(
+                                    _t("Report"),
                                    _.str.sprintf(
-                                    _t('Error when sending the document ' +
-                                        'to the printer '),
+                                        _t(
+                                            "Error when sending the document " +
+                                                "to the printer "
+                                        ),
                                        print_action.printer_name
                                    )
                                );
-                        });
+                            }
+                        );
                    } else {
                        return _super.apply(self, [action, options, type]);
                    }
--- a/base_report_to_printer/views/assets.xml
+++ b/base_report_to_printer/views/assets.xml
@@ -1,8 +1,15 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <template id="assets_backend" name="base_report_to_printer assets" inherit_id="web.assets_backend">
+    <template
+        id="assets_backend"
+        name="base_report_to_printer assets"
+        inherit_id="web.assets_backend"
+    >
        <xpath expr="." position="inside">
-            <script type="text/javascript" src="/base_report_to_printer/static/src/js/qweb_action_manager.js" />
+            <script
+                type="text/javascript"
+                src="/base_report_to_printer/static/src/js/qweb_action_manager.js"
+            />
        </xpath>
    </template>
 </odoo>
--- a/base_report_to_printer/views/ir_actions_report.xml
+++ b/base_report_to_printer/views/ir_actions_report.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" ?>
 <odoo>
-
    <record model="ir.ui.view" id="act_report_xml_view">
        <field name="name">ir.actions.report.form (in base_report_to_printer)</field>
        <field name="model">ir.actions.report</field>
@@ -13,12 +12,10 @@
                        <field name="printing_printer_id" />
                        <field name="printer_tray_id" />
                    </group>
-
                    <separator string="Specific actions per user" />
                    <field name="printing_action_ids" />
                </page>
            </xpath>
        </field>
    </record>
-
 </odoo>
--- a/base_report_to_printer/views/printing_job.xml
+++ b/base_report_to_printer/views/printing_job.xml
@@ -1,13 +1,17 @@
 <?xml version="1.0" ?>
 <odoo>
-
    <record model="ir.ui.view" id="printing_job_view_form">
        <field name="name">printing.job.form (in base_report_to_printer)</field>
        <field name="model">printing.job</field>
        <field name="arch" type="xml">
            <form string="Job">
                <header>
-                    <button name="action_cancel" type="object" string="Cancel" attrs="{'invisible': [('job_state', 'in', ('canceled', 'aborted', 'completed'))]}"/>
+                    <button
+                        name="action_cancel"
+                        type="object"
+                        string="Cancel"
+                        attrs="{'invisible': [('job_state', 'in', ('canceled', 'aborted', 'completed'))]}"
+                    />
                    <field name="job_state" widget="statusbar" />
                </header>
                <sheet>
@@ -28,7 +32,6 @@
            </form>
        </field>
    </record>
-
    <record model="ir.ui.view" id="printing_job_view_tree">
        <field name="name">printing.job.tree (in base_report_to_printer)</field>
        <field name="model">printing.job</field>
@@ -40,5 +43,4 @@
            </tree>
        </field>
    </record>
-
 </odoo>
--- a/base_report_to_printer/views/printing_printer.xml
+++ b/base_report_to_printer/views/printing_printer.xml
@@ -1,21 +1,36 @@
 <?xml version="1.0" ?>
 <odoo>
-
-    <menuitem name="Printing"
-        id="printing_menu" sequence="1"
+    <menuitem
+        name="Printing"
+        id="printing_menu"
+        sequence="1"
        parent="base.menu_administration"
        groups="printing_group_manager"
    />
-
    <record model="ir.ui.view" id="printing_printer_view_form">
        <field name="name">printing.printer.form (in base_report_to_printer)</field>
        <field name="model">printing.printer</field>
        <field name="arch" type="xml">
            <form string="Printers">
                <header>
-                    <button name="enable" type="object" string="Enable" attrs="{'invisible': [('status', 'in', ('available', 'printing'))]}"/>
-                    <button name="disable" type="object" string="Disable" attrs="{'invisible': [('status', '=', 'unavailable')]}"/>
-                    <button name="action_cancel_all_jobs" type="object" string="Cancel all running jobs" confirm="Are you sure to want to cancel all jobs of this printer?"/>
+                    <button
+                        name="enable"
+                        type="object"
+                        string="Enable"
+                        attrs="{'invisible': [('status', 'in', ('available', 'printing'))]}"
+                    />
+                    <button
+                        name="disable"
+                        type="object"
+                        string="Disable"
+                        attrs="{'invisible': [('status', '=', 'unavailable')]}"
+                    />
+                    <button
+                        name="action_cancel_all_jobs"
+                        type="object"
+                        string="Cancel all running jobs"
+                        confirm="Are you sure to want to cancel all jobs of this printer?"
+                    />
                </header>
                <sheet>
                    <div class="oe_title">
@@ -28,8 +43,18 @@
                    </group>
                    <group col="4" colspan="4" name="default">
                        <field name="default" />
-                        <button name="set_default" string="Set Default" type="object" attrs="{'invisible': [('default','=', True)]}"/>
-                        <button name="unset_default" string="Unset Default" type="object" attrs="{'invisible': [('default','=', False)]}"/>
+                        <button
+                            name="set_default"
+                            string="Set Default"
+                            type="object"
+                            attrs="{'invisible': [('default','=', True)]}"
+                        />
+                        <button
+                            name="unset_default"
+                            string="Unset Default"
+                            type="object"
+                            attrs="{'invisible': [('default','=', False)]}"
+                        />
                    </group>
                    <group name="details">
                        <field name="uri" />
@@ -56,12 +81,15 @@
            </form>
        </field>
    </record>
-
    <record model="ir.ui.view" id="printing_printer_view_tree">
        <field name="name">printing.printer.tree (in base_report_to_printer)</field>
        <field name="model">printing.printer</field>
        <field name="arch" type="xml">
-            <tree decoration-success="status=='available'" decoration-warning="status=='printing'" decoration-danger="status not in ['printing', 'available']">
+            <tree
+                decoration-success="status=='available'"
+                decoration-warning="status=='printing'"
+                decoration-danger="status not in ['printing', 'available']"
+            >
                <field name="default" />
                <field name="name" />
                <field name="system_name" />
@@ -69,7 +97,6 @@
            </tree>
        </field>
    </record>
-
    <record model="ir.ui.view" id="printing_printer_view_search">
        <field name="name">printing.printer.search (in base_report_to_printer)</field>
        <field name="model">printing.printer</field>
@@ -82,18 +109,17 @@
            </search>
        </field>
    </record>
-
    <record model="ir.actions.act_window" id="printing_printer_action">
        <field name="name">Show Printers</field>
        <field name="type">ir.actions.act_window</field>
        <field name="res_model">printing.printer</field>
        <field name="view_mode">tree,form</field>
    </record>
-
-    <menuitem name="Printers"
+    <menuitem
+        name="Printers"
        sequence="20"
        id="printing_printer_menu"
        parent="printing_menu"
-        action="printing_printer_action"/>
-
+        action="printing_printer_action"
+    />
 </odoo>
--- a/base_report_to_printer/views/printing_report.xml
+++ b/base_report_to_printer/views/printing_report.xml
@@ -1,8 +1,9 @@
 <?xml version="1.0" ?>
 <odoo>
-
    <record model="ir.ui.view" id="printing_report_xml_action_view_form">
-        <field name="name">printing.report.xml.action.form (in base_report_to_printer)</field>
+        <field
+            name="name"
+        >printing.report.xml.action.form (in base_report_to_printer)</field>
        <field name="model">printing.report.xml.action</field>
        <field name="arch" type="xml">
            <form string="Report Printing Actions">
@@ -15,9 +16,10 @@
            </form>
        </field>
    </record>
-
    <record model="ir.ui.view" id="printing_report_xml_action_view_tree">
-        <field name="name">printing.report.xml.action.tree (in base_report_to_printer)</field>
+        <field
+            name="name"
+        >printing.report.xml.action.tree (in base_report_to_printer)</field>
        <field name="model">printing.report.xml.action</field>
        <field name="arch" type="xml">
            <tree>
@@ -28,11 +30,11 @@
            </tree>
        </field>
    </record>
-
    <!-- Add a shorcut to "Actions/Report" in the Printing menu -->
-    <menuitem id="printing_report_xml_action_menu"
+    <menuitem
+        id="printing_report_xml_action_menu"
        sequence="30"
        parent="printing_menu"
-              action="base.ir_action_report"/>
-
+        action="base.ir_action_report"
+    />
 </odoo>
--- a/base_report_to_printer/views/printing_server.xml
+++ b/base_report_to_printer/views/printing_server.xml
@@ -1,14 +1,21 @@
 <?xml version="1.0" ?>
 <odoo>
-
    <record model="ir.ui.view" id="printing_server_view_form">
        <field name="name">printing.server.form (in base_report_to_printer)</field>
        <field name="model">printing.server</field>
        <field name="arch" type="xml">
            <form string="Servers">
                <header>
-                    <button name="action_update_printers" type="object" string="Update Printers"/>
-                    <button name="action_update_jobs" type="object" string="Update Jobs"/>
+                    <button
+                        name="action_update_printers"
+                        type="object"
+                        string="Update Printers"
+                    />
+                    <button
+                        name="action_update_jobs"
+                        type="object"
+                        string="Update Jobs"
+                    />
                </header>
                <sheet>
                    <div class="oe_title">
@@ -28,7 +35,6 @@
            </form>
        </field>
    </record>
-
    <record model="ir.ui.view" id="printing_server_view_tree">
        <field name="name">printing.server.tree (in base_report_to_printer)</field>
        <field name="model">printing.server</field>
@@ -40,7 +46,6 @@
            </tree>
        </field>
    </record>
-
    <record model="ir.ui.view" id="printing_server_view_search">
        <field name="name">printing.server.search (in base_report_to_printer)</field>
        <field name="model">printing.server</field>
@@ -52,18 +57,17 @@
            </search>
        </field>
    </record>
-
    <record model="ir.actions.act_window" id="printing_server_action">
        <field name="name">Servers</field>
        <field name="type">ir.actions.act_window</field>
        <field name="res_model">printing.server</field>
        <field name="view_mode">tree,form</field>
    </record>
-
-    <menuitem name="Servers"
+    <menuitem
+        name="Servers"
        sequence="10"
        id="printing_server_menu"
        parent="printing_menu"
-        action="printing_server_action"/>
-
+        action="printing_server_action"
+    />
 </odoo>
--- a/base_report_to_printer/views/res_users.xml
+++ b/base_report_to_printer/views/res_users.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" ?>
 <odoo>
-
    <record model="ir.ui.view" id="view_users_form">
        <field name="name">res.users.form (in base_report_to_printer)</field>
        <field name="model">res.users</field>
@@ -14,7 +13,6 @@
            </xpath>
        </field>
    </record>
-
    <record model="ir.ui.view" id="view_users_form_simple_modif">
        <field name="name">res.users.form.simple (in base_report_to_printer)</field>
        <field name="model">res.users</field>
@@ -23,10 +21,13 @@
            <footer position="before">
                <group string="Printing" name="printing">
                    <field name="printing_action" readonly="0" />
-                    <field name="printing_printer_id" readonly="0" options="{'no_create': True}"/>
+                    <field
+                        name="printing_printer_id"
+                        readonly="0"
+                        options="{'no_create': True}"
+                    />
                </group>
            </footer>
        </field>
    </record>
-
 </odoo>
--- a/base_report_to_printer/wizards/printing_printer_update_wizard_view.xml
+++ b/base_report_to_printer/wizards/printing_printer_update_wizard_view.xml
@@ -5,9 +5,18 @@
        <field name="model">printing.printer.update.wizard</field>
        <field name="arch" type="xml">
            <form string="Update Printers from CUPS">
-                <label string="This process will create all missing printers from the current CUPS server." colspan="2" for=""/>
+                <label
+                    string="This process will create all missing printers from the current CUPS server."
+                    colspan="2"
+                    for=""
+                />
                <footer>
-                    <button name="action_ok" string="Ok" type="object" class="oe_highlight"/>
+                    <button
+                        name="action_ok"
+                        string="Ok"
+                        type="object"
+                        class="oe_highlight"
+                    />
                    or
                    <button string="Cancel" class="oe_link" special="cancel" />
                </footer>
@@ -21,5 +30,10 @@
        <field name="view_mode">form</field>
        <field name="target">new</field>
    </record>
-    <menuitem action="action_printer_update_wizard" sequence="40" id="menu_printer_update_wizard" parent="printing_menu"/>
+    <menuitem
+        action="action_printer_update_wizard"
+        sequence="40"
+        id="menu_printer_update_wizard"
+        parent="printing_menu"
+    />
 </odoo>