From 0b73b7dffabc0b814f1558cecb9f400eff91b33d Mon Sep 17 00:00:00 2001
From: Denis Roussel <denis.roussel@acsone.eu>
Date: Mon, 20 Dec 2021 10:50:03 +0100
Subject: [PATCH 1/9] [14.0][IMP] base_report_to_printer: Add Text render
 document to printer

---
 .../models/ir_actions_report.py               | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/base_report_to_printer/models/ir_actions_report.py b/base_report_to_printer/models/ir_actions_report.py
index 1878344..0cabb65 100644
--- a/base_report_to_printer/models/ir_actions_report.py
+++ b/base_report_to_printer/models/ir_actions_report.py
@@ -159,3 +159,22 @@ class IrActionsReport(models.Model):
             )
 
         return document, doc_format
+
+    def _render_qweb_text(self, docids, data=None):
+        """Generate a TEXT file and returns it.
+
+        If the action configured on the report is server, it prints the
+        generated document as well.
+        """
+        document, doc_format = super()._render_qweb_text(docids=docids, data=data)
+
+        behaviour = self.behaviour()
+        printer = behaviour.pop("printer", None)
+        can_print_report = self._can_print_report(behaviour, printer, document)
+
+        if can_print_report:
+            printer.print_document(
+                self, document, doc_format=self.report_type, **behaviour
+            )
+
+        return document, doc_format

From 69a2af2b22f1e9e82be6017f071b39e82f26b12c Mon Sep 17 00:00:00 2001
From: Denis Roussel <denis.roussel@acsone.eu>
Date: Wed, 29 Dec 2021 09:05:33 +0100
Subject: [PATCH 2/9] [14.0][FIX] base_report_to_printer: Manage text
 print_document()

---
 .../models/ir_actions_report.py                 | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/base_report_to_printer/models/ir_actions_report.py b/base_report_to_printer/models/ir_actions_report.py
index 0cabb65..e6627ac 100644
--- a/base_report_to_printer/models/ir_actions_report.py
+++ b/base_report_to_printer/models/ir_actions_report.py
@@ -8,6 +8,8 @@
 from odoo import _, api, exceptions, fields, models
 from odoo.tools.safe_eval import safe_eval, time
 
+REPORT_TYPES = {"qweb-pdf": "pdf", "qweb-text": "text"}
+
 
 class IrActionsReport(models.Model):
     _inherit = "ir.actions.report"
@@ -98,10 +100,17 @@ class IrActionsReport(models.Model):
         return result
 
     def print_document(self, record_ids, data=None):
-        """Print a document, do not return the document file"""
-        document, doc_format = self.with_context(
-            must_skip_send_to_printer=True
-        )._render_qweb_pdf(record_ids, data=data)
+        """ Print a document, do not return the document file """
+        report_type = REPORT_TYPES.get(self.report_type)
+        if not report_type:
+            raise exceptions.UserError(
+                _("This report type (%s) is not supported by direct printing!")
+                % str(self.report_type)
+            )
+        method_name = "_render_qweb_%s" % (report_type)
+        document, doc_format = getattr(
+            self.with_context(must_skip_send_to_printer=True), method_name
+        )(record_ids, data=data)
         behaviour = self.behaviour()
         printer = behaviour.pop("printer", None)
 

From d86f274c305c4c87bbec8732d10d105363072864 Mon Sep 17 00:00:00 2001
From: Denis Roussel <denis.roussel@acsone.eu>
Date: Wed, 29 Dec 2021 09:10:46 +0100
Subject: [PATCH 3/9] [14.0][IMP] base_report_to_printer: Add tests for text
 documents

---
 .../models/ir_actions_report.py               |  2 +-
 base_report_to_printer/tests/test_report.py   | 26 +++++++++++++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/base_report_to_printer/models/ir_actions_report.py b/base_report_to_printer/models/ir_actions_report.py
index e6627ac..10d30b1 100644
--- a/base_report_to_printer/models/ir_actions_report.py
+++ b/base_report_to_printer/models/ir_actions_report.py
@@ -100,7 +100,7 @@ class IrActionsReport(models.Model):
         return result
 
     def print_document(self, record_ids, data=None):
-        """ Print a document, do not return the document file """
+        """Print a document, do not return the document file"""
         report_type = REPORT_TYPES.get(self.report_type)
         if not report_type:
             raise exceptions.UserError(
diff --git a/base_report_to_printer/tests/test_report.py b/base_report_to_printer/tests/test_report.py
index 72ad9c5..cc6a0ea 100644
--- a/base_report_to_printer/tests/test_report.py
+++ b/base_report_to_printer/tests/test_report.py
@@ -47,6 +47,14 @@ class TestReport(common.HttpCase):
                 "report_name": "base_report_to_printer.test",
             }
         )
+        self.report_text = self.Model.create(
+            {
+                "name": "Test",
+                "report_type": "qweb-text",
+                "model": "res.partner",
+                "report_name": "base_report_to_printer.test",
+            }
+        )
         self.partners = self.env["res.partner"]
         for n in range(5):
             self.partners += self.env["res.partner"].create({"name": "Test %d" % n})
@@ -113,6 +121,24 @@ class TestReport(common.HttpCase):
                 tray=False,
             )
 
+    def test_render_qweb_text_printable(self):
+        """It should print the report, only if it is printable"""
+        with mock.patch(
+            "odoo.addons.base_report_to_printer.models."
+            "printing_printer.PrintingPrinter."
+            "print_document"
+        ) as print_document:
+            self.report_text.property_printing_action_id.action_type = "server"
+            self.report_text.printing_printer_id = self.new_printer()
+            document = self.report_text._render_qweb_text(self.partners.ids)
+            print_document.assert_called_once_with(
+                self.report_text,
+                document[0],
+                action="server",
+                doc_format="qweb-text",
+                tray=False,
+            )
+
     def test_print_document_not_printable(self):
         """It should print the report, regardless of the defined behaviour"""
         self.report.printing_printer_id = self.new_printer()

From 0414d9c4531ac3ef3ceccadb79323dad32d09afd Mon Sep 17 00:00:00 2001
From: Akim Juillerat <akim.juillerat@camptocamp.com>
Date: Mon, 27 Apr 2020 14:36:35 +0200
Subject: [PATCH 4/9] [ADD] base_report_to_printer: Print attachments wizard

---
 base_report_to_printer/README.rst             |  1 +
 base_report_to_printer/__manifest__.py        |  1 +
 .../readme/CONTRIBUTORS.rst                   |  1 +
 .../static/description/index.html             |  3 +-
 base_report_to_printer/wizards/__init__.py    |  1 +
 .../wizards/print_attachment_report.py        | 74 +++++++++++++++++++
 .../wizards/print_attachment_report.xml       | 50 +++++++++++++
 7 files changed, 130 insertions(+), 1 deletion(-)
 create mode 100644 base_report_to_printer/wizards/print_attachment_report.py
 create mode 100644 base_report_to_printer/wizards/print_attachment_report.xml

diff --git a/base_report_to_printer/README.rst b/base_report_to_printer/README.rst
index ca78947..e46e8a5 100644
--- a/base_report_to_printer/README.rst
+++ b/base_report_to_printer/README.rst
@@ -155,6 +155,7 @@ Contributors
 * Rod Schouteden <rod@schout-it.be>
 * Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
 * Matias Peralta <mnp@adhoc.com.ar>
+* Akim Juillerat <akim.juillerat@camptocamp.com>
 
 Maintainers
 ~~~~~~~~~~~
diff --git a/base_report_to_printer/__manifest__.py b/base_report_to_printer/__manifest__.py
index 61af227..1512214 100644
--- a/base_report_to_printer/__manifest__.py
+++ b/base_report_to_printer/__manifest__.py
@@ -24,6 +24,7 @@
         "views/printing_report.xml",
         "views/res_users.xml",
         "views/ir_actions_report.xml",
+        "wizards/print_attachment_report.xml",
         "wizards/printing_printer_update_wizard_view.xml",
     ],
     "assets": {
diff --git a/base_report_to_printer/readme/CONTRIBUTORS.rst b/base_report_to_printer/readme/CONTRIBUTORS.rst
index 7085b17..a046d90 100644
--- a/base_report_to_printer/readme/CONTRIBUTORS.rst
+++ b/base_report_to_printer/readme/CONTRIBUTORS.rst
@@ -12,3 +12,4 @@
 * Rod Schouteden <rod@schout-it.be>
 * Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
 * Matias Peralta <mnp@adhoc.com.ar>
+* Akim Juillerat <akim.juillerat@camptocamp.com>
diff --git a/base_report_to_printer/static/description/index.html b/base_report_to_printer/static/description/index.html
index fecf525..45e1510 100644
--- a/base_report_to_printer/static/description/index.html
+++ b/base_report_to_printer/static/description/index.html
@@ -3,7 +3,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
+<meta name="generator" content="Docutils 0.14: http://docutils.sourceforge.net/" />
 <title>Report to printer</title>
 <style type="text/css">
 
@@ -506,6 +506,7 @@ If you spotted it first, help us smashing it by providing a detailed and welcome
 <li>Rod Schouteden &lt;<a class="reference external" href="mailto:rod&#64;schout-it.be">rod&#64;schout-it.be</a>&gt;</li>
 <li>Alexandre Fayolle &lt;<a class="reference external" href="mailto:alexandre.fayolle&#64;camptocamp.com">alexandre.fayolle&#64;camptocamp.com</a>&gt;</li>
 <li>Matias Peralta &lt;<a class="reference external" href="mailto:mnp&#64;adhoc.com.ar">mnp&#64;adhoc.com.ar</a>&gt;</li>
+<li>Akim Juillerat &lt;<a class="reference external" href="mailto:akim.juillerat&#64;camptocamp.com">akim.juillerat&#64;camptocamp.com</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
diff --git a/base_report_to_printer/wizards/__init__.py b/base_report_to_printer/wizards/__init__.py
index b1638ea..a280931 100644
--- a/base_report_to_printer/wizards/__init__.py
+++ b/base_report_to_printer/wizards/__init__.py
@@ -1 +1,2 @@
+from . import print_attachment_report
 from . import printing_printer_update_wizard
diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
new file mode 100644
index 0000000..65914eb
--- /dev/null
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -0,0 +1,74 @@
+# -*- coding: utf-8 -*-
+# Copyright 2020 Camptocamp SA
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
+import base64
+
+from openerp import _, models, api, fields
+
+
+class PrintAttachment(models.TransientModel):
+    _name = 'wizard.print.attachment'
+    _description = 'Print Attachment'
+
+    printer_id = fields.Many2one(
+        comodel_name='printing.printer', string='Printer', required=True,
+        help='Printer used to print the attachments.'
+    )
+    attachment_line_ids = fields.One2many(
+        'wizard.print.attachment.line', 'wizard_id',
+        string='Attachments to print',
+    )
+
+    @api.multi
+    def print_attachments(self):
+        """ Prints a label per selected record """
+        self.ensure_one()
+        errors = []
+        for att_line in self.attachment_line_ids:
+            data = att_line.attachment_id.datas
+            if not data:
+                errors.append(att_line)
+                continue
+            content = base64.b64decode(data)
+            content_format = att_line.get_format()
+            self.printer_id.print_document(
+                None,
+                content=content,
+                format=content_format,
+                copies=att_line.copies
+            )
+        if errors:
+            return {
+                'warning': _(
+                    'Following attachments could not be printed:\n\n%s'
+                    % '\n'.join(
+                        [
+                            _('%s (%s copies)') % (err.record_name, err.copies)
+                            for err in errors
+                        ]
+                    )
+                )
+            }
+
+
+class PrintAttachmentLine(models.TransientModel):
+    _name = 'wizard.print.attachment.line'
+    _description = 'Print Attachment line'
+
+    wizard_id = fields.Many2one("wizard.print.attachment")
+    attachment_id = fields.Many2one(
+        'ir.attachment',
+        required=True,
+        domain="['|', ('mimetype', '=', 'application/pdf'), ('mimetype', '=', 'application/octet-stream')]"
+    )
+    record_name = fields.Char(related="attachment_id.res_name", readonly=True)
+    copies = fields.Integer(default=1)
+
+    @api.multi
+    def get_format(self):
+        self.ensure_one()
+        mimetype = self.attachment_id.mimetype
+        if mimetype == "application/pdf":
+            return "pdf"
+        else:
+            return 'raw'
diff --git a/base_report_to_printer/wizards/print_attachment_report.xml b/base_report_to_printer/wizards/print_attachment_report.xml
new file mode 100644
index 0000000..cc10e42
--- /dev/null
+++ b/base_report_to_printer/wizards/print_attachment_report.xml
@@ -0,0 +1,50 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>
+    <data>
+        <record id="wizard_print_attachment_form" model="ir.ui.view">
+            <field name="name">wizard.print.attachment</field>
+            <field name="model">wizard.print.attachment</field>
+            <field name="arch" type="xml">
+                <form string="Print attachments">
+                    <group>
+                        <field name="printer_id" />
+                        <field name="attachment_line_ids">
+                            <tree editable="top">
+                                <field name="attachment_id" create="0" />
+                                <field name="record_name" />
+                                <field name="copies" />
+                            </tree>
+                        </field>
+                    </group>
+                    <footer>
+                        <button name="print_attachments" string="Print" type="object" class="oe_highlight"/>
+                        or
+                        <button string="Cancel" class="oe_link" special="cancel"/>
+                    </footer>
+                </form>
+            </field>
+        </record>
+        <record id="wizard_print_attachment_line_form" model="ir.ui.view">
+            <field name="name">wizard.print.attachment.line.form</field>
+            <field name="model">wizard.print.attachment.line</field>
+            <field name="arch" type="xml">
+                <form>
+                    <group>
+                        <field name="attachment_id" create="0" />
+                        <field name="record_name" />
+                        <field name="copies" />
+                    </group>
+                </form>
+            </field>
+        </record>
+        <record id="action_wizard_print_attachment" model="ir.actions.act_window" >
+            <field name="name">Print Attachments</field>
+            <field name="type">ir.actions.act_window</field>
+            <field name="res_model">wizard.print.attachment</field>
+            <field name="view_type">form</field>
+            <field name="view_mode">form</field>
+            <field name="target">new</field>
+        </record>
+        <menuitem id="menu_action_wizard_print_attachment" action="action_wizard_print_attachment" sequence="50" parent="printing_menu" />
+    </data>
+</openerp>

From d1822016a8adb277da34dc57d4c87ceec16c4ad7 Mon Sep 17 00:00:00 2001
From: sebalix <seb@usr-src.org>
Date: Thu, 6 Aug 2020 12:30:44 +0200
Subject: [PATCH 5/9] [MIG] base_report_to_printer: Print attachments wizard

---
 .../static/description/index.html             |   2 +-
 .../wizards/print_attachment_report.py        |  46 ++++----
 .../wizards/print_attachment_report.xml       | 106 +++++++++---------
 3 files changed, 80 insertions(+), 74 deletions(-)

diff --git a/base_report_to_printer/static/description/index.html b/base_report_to_printer/static/description/index.html
index 45e1510..cf2a3f2 100644
--- a/base_report_to_printer/static/description/index.html
+++ b/base_report_to_printer/static/description/index.html
@@ -3,7 +3,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.14: http://docutils.sourceforge.net/" />
+<meta name="generator" content="Docutils: http://docutils.sourceforge.net/" />
 <title>Report to printer</title>
 <style type="text/css">
 
diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
index 65914eb..3addc29 100644
--- a/base_report_to_printer/wizards/print_attachment_report.py
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -1,25 +1,26 @@
-# -*- coding: utf-8 -*-
 # Copyright 2020 Camptocamp SA
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
 import base64
 
-from openerp import _, models, api, fields
+from odoo import _, fields, models
 
 
 class PrintAttachment(models.TransientModel):
-    _name = 'wizard.print.attachment'
-    _description = 'Print Attachment'
+    _name = "wizard.print.attachment"
+    _description = "Print Attachment"
 
     printer_id = fields.Many2one(
-        comodel_name='printing.printer', string='Printer', required=True,
-        help='Printer used to print the attachments.'
+        comodel_name="printing.printer",
+        string="Printer",
+        required=True,
+        help="Printer used to print the attachments.",
     )
     attachment_line_ids = fields.One2many(
-        'wizard.print.attachment.line', 'wizard_id',
-        string='Attachments to print',
+        "wizard.print.attachment.line",
+        "wizard_id",
+        string="Attachments to print",
     )
 
-    @api.multi
     def print_attachments(self):
         """ Prints a label per selected record """
         self.ensure_one()
@@ -32,18 +33,15 @@ class PrintAttachment(models.TransientModel):
             content = base64.b64decode(data)
             content_format = att_line.get_format()
             self.printer_id.print_document(
-                None,
-                content=content,
-                format=content_format,
-                copies=att_line.copies
+                None, content=content, format=content_format, copies=att_line.copies
             )
         if errors:
             return {
-                'warning': _(
-                    'Following attachments could not be printed:\n\n%s'
-                    % '\n'.join(
+                "warning": _(
+                    "Following attachments could not be printed:\n\n%s"
+                    % "\n".join(
                         [
-                            _('%s (%s copies)') % (err.record_name, err.copies)
+                            _("%s (%s copies)") % (err.record_name, err.copies)
                             for err in errors
                         ]
                     )
@@ -52,23 +50,25 @@ class PrintAttachment(models.TransientModel):
 
 
 class PrintAttachmentLine(models.TransientModel):
-    _name = 'wizard.print.attachment.line'
-    _description = 'Print Attachment line'
+    _name = "wizard.print.attachment.line"
+    _description = "Print Attachment line"
 
     wizard_id = fields.Many2one("wizard.print.attachment")
     attachment_id = fields.Many2one(
-        'ir.attachment',
+        "ir.attachment",
         required=True,
-        domain="['|', ('mimetype', '=', 'application/pdf'), ('mimetype', '=', 'application/octet-stream')]"
+        domain=(
+            "['|', ('mimetype', '=', 'application/pdf'), "
+            "('mimetype', '=', 'application/octet-stream')]"
+        ),
     )
     record_name = fields.Char(related="attachment_id.res_name", readonly=True)
     copies = fields.Integer(default=1)
 
-    @api.multi
     def get_format(self):
         self.ensure_one()
         mimetype = self.attachment_id.mimetype
         if mimetype == "application/pdf":
             return "pdf"
         else:
-            return 'raw'
+            return "raw"
diff --git a/base_report_to_printer/wizards/print_attachment_report.xml b/base_report_to_printer/wizards/print_attachment_report.xml
index cc10e42..17354c2 100644
--- a/base_report_to_printer/wizards/print_attachment_report.xml
+++ b/base_report_to_printer/wizards/print_attachment_report.xml
@@ -1,50 +1,56 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<openerp>
-    <data>
-        <record id="wizard_print_attachment_form" model="ir.ui.view">
-            <field name="name">wizard.print.attachment</field>
-            <field name="model">wizard.print.attachment</field>
-            <field name="arch" type="xml">
-                <form string="Print attachments">
-                    <group>
-                        <field name="printer_id" />
-                        <field name="attachment_line_ids">
-                            <tree editable="top">
-                                <field name="attachment_id" create="0" />
-                                <field name="record_name" />
-                                <field name="copies" />
-                            </tree>
-                        </field>
-                    </group>
-                    <footer>
-                        <button name="print_attachments" string="Print" type="object" class="oe_highlight"/>
-                        or
-                        <button string="Cancel" class="oe_link" special="cancel"/>
-                    </footer>
-                </form>
-            </field>
-        </record>
-        <record id="wizard_print_attachment_line_form" model="ir.ui.view">
-            <field name="name">wizard.print.attachment.line.form</field>
-            <field name="model">wizard.print.attachment.line</field>
-            <field name="arch" type="xml">
-                <form>
-                    <group>
-                        <field name="attachment_id" create="0" />
-                        <field name="record_name" />
-                        <field name="copies" />
-                    </group>
-                </form>
-            </field>
-        </record>
-        <record id="action_wizard_print_attachment" model="ir.actions.act_window" >
-            <field name="name">Print Attachments</field>
-            <field name="type">ir.actions.act_window</field>
-            <field name="res_model">wizard.print.attachment</field>
-            <field name="view_type">form</field>
-            <field name="view_mode">form</field>
-            <field name="target">new</field>
-        </record>
-        <menuitem id="menu_action_wizard_print_attachment" action="action_wizard_print_attachment" sequence="50" parent="printing_menu" />
-    </data>
-</openerp>
+<?xml version="1.0" encoding="UTF-8" ?>
+<odoo>
+    <record id="wizard_print_attachment_form" model="ir.ui.view">
+        <field name="name">wizard.print.attachment</field>
+        <field name="model">wizard.print.attachment</field>
+        <field name="arch" type="xml">
+            <form string="Print attachments">
+                <group>
+                    <field name="printer_id" />
+                    <field name="attachment_line_ids">
+                        <tree editable="top">
+                            <field name="attachment_id" create="0" />
+                            <field name="record_name" />
+                            <field name="copies" />
+                        </tree>
+                    </field>
+                </group>
+                <footer>
+                    <button
+                        name="print_attachments"
+                        type="object"
+                        string="Print"
+                        class="btn-primary"
+                    />
+                    <button string="Cancel" class="btn-secondary" special="cancel" />
+                </footer>
+            </form>
+        </field>
+    </record>
+    <record id="wizard_print_attachment_line_form" model="ir.ui.view">
+        <field name="name">wizard.print.attachment.line.form</field>
+        <field name="model">wizard.print.attachment.line</field>
+        <field name="arch" type="xml">
+            <form>
+                <group>
+                    <field name="attachment_id" create="0" />
+                    <field name="record_name" />
+                    <field name="copies" />
+                </group>
+            </form>
+        </field>
+    </record>
+    <record id="action_wizard_print_attachment" model="ir.actions.act_window">
+        <field name="name">Print Attachments</field>
+        <field name="type">ir.actions.act_window</field>
+        <field name="res_model">wizard.print.attachment</field>
+        <field name="view_mode">form</field>
+        <field name="target">new</field>
+    </record>
+    <menuitem
+        id="menu_action_wizard_print_attachment"
+        action="action_wizard_print_attachment"
+        sequence="50"
+        parent="printing_menu"
+    />
+</odoo>

From 0790d65015bc4298a0c3bf1bead8721032307c50 Mon Sep 17 00:00:00 2001
From: Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
Date: Wed, 9 Mar 2022 12:00:36 +0100
Subject: [PATCH 6/9] fix(#259): handle case of print attachment wizard

The fix in #259 only worked for reports being printed at generation
of the PDF. This PR handles sending an attachment to a printer through
the Print Attachment wizard.

Also clarify the configuration section of the README.
---
 base_report_to_printer/README.rst                        | 3 ++-
 base_report_to_printer/readme/CONFIGURE.rst              | 3 ++-
 base_report_to_printer/static/description/index.html     | 3 ++-
 .../wizards/print_attachment_report.py                   | 9 +++++++--
 4 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/base_report_to_printer/README.rst b/base_report_to_printer/README.rst
index e46e8a5..1c659b5 100644
--- a/base_report_to_printer/README.rst
+++ b/base_report_to_printer/README.rst
@@ -82,7 +82,8 @@ The jobs will be sent to the printer with a name matching the print_report_name
 of the report (truncated at 80 characters). By default this will not be
 displayed by CUPS web interface or in Odoo. To see this information, you need
 to change the configuration of your CUPS server and set the JobPrivateValue
-directive to "job-name", and reload the server. See `cupsd.conf(5)
+directive to "none" (or some other list of values which does not include
+"job-name") , and reload the server. See `cupsd.conf(5)
 <https://www.cups.org/doc/man-cupsd.conf.html>` for details.
 
 Usage
diff --git a/base_report_to_printer/readme/CONFIGURE.rst b/base_report_to_printer/readme/CONFIGURE.rst
index 0b12368..3463730 100644
--- a/base_report_to_printer/readme/CONFIGURE.rst
+++ b/base_report_to_printer/readme/CONFIGURE.rst
@@ -8,5 +8,6 @@ The jobs will be sent to the printer with a name matching the print_report_name
 of the report (truncated at 80 characters). By default this will not be
 displayed by CUPS web interface or in Odoo. To see this information, you need
 to change the configuration of your CUPS server and set the JobPrivateValue
-directive to "job-name", and reload the server. See `cupsd.conf(5)
+directive to "none" (or some other list of values which does not include
+"job-name") , and reload the server. See `cupsd.conf(5)
 <https://www.cups.org/doc/man-cupsd.conf.html>` for details.
diff --git a/base_report_to_printer/static/description/index.html b/base_report_to_printer/static/description/index.html
index cf2a3f2..31051a1 100644
--- a/base_report_to_printer/static/description/index.html
+++ b/base_report_to_printer/static/description/index.html
@@ -432,7 +432,8 @@ rights to give users the ability to view the print menu.</li>
 of the report (truncated at 80 characters). By default this will not be
 displayed by CUPS web interface or in Odoo. To see this information, you need
 to change the configuration of your CUPS server and set the JobPrivateValue
-directive to “job-name”, and reload the server. See <cite>cupsd.conf(5)
+directive to “none” (or some other list of values which does not include
+“job-name”) , and reload the server. See <cite>cupsd.conf(5)
 &lt;https://www.cups.org/doc/man-cupsd.conf.html&gt;</cite> for details.</p>
 </div>
 <div class="section" id="usage">
diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
index 3addc29..f2160b2 100644
--- a/base_report_to_printer/wizards/print_attachment_report.py
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -22,18 +22,23 @@ class PrintAttachment(models.TransientModel):
     )
 
     def print_attachments(self):
-        """ Prints a label per selected record """
+        """Prints a label per selected record"""
         self.ensure_one()
         errors = []
         for att_line in self.attachment_line_ids:
             data = att_line.attachment_id.datas
+            title = att_line.attachment_id.store_fname
             if not data:
                 errors.append(att_line)
                 continue
             content = base64.b64decode(data)
             content_format = att_line.get_format()
             self.printer_id.print_document(
-                None, content=content, format=content_format, copies=att_line.copies
+                None,
+                content=content,
+                format=content_format,
+                copies=att_line.copies,
+                title=title,
             )
         if errors:
             return {

From 4ed487a7f62393e4b8800cedccd75c1ac54e160b Mon Sep 17 00:00:00 2001
From: sonhd <sonhd@trobz.com>
Date: Fri, 21 Jan 2022 10:19:14 +0700
Subject: [PATCH 7/9] [ADD] access right for wizrard print attachment and fix
 trans format

---
 base_report_to_printer/security/security.xml    | 17 +++++++++++++++++
 .../wizards/print_attachment_report.py          | 14 ++++++--------
 2 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/base_report_to_printer/security/security.xml b/base_report_to_printer/security/security.xml
index ebda2e8..8f68e12 100644
--- a/base_report_to_printer/security/security.xml
+++ b/base_report_to_printer/security/security.xml
@@ -125,6 +125,23 @@
         <field name="name">Update printer wizard</field>
         <field name="model_id" ref="model_printing_printer_update_wizard" />
         <field name="group_id" ref="printing_group_manager" />
+         <field eval="1" name="perm_read" />
+         <field eval="1" name="perm_unlink" />
+         <field eval="1" name="perm_write" />
+    </record>
+    <record id="access_wizard_print_attachment_user" model="ir.model.access">
+        <field name="name">Print Attachment User</field>
+        <field name="model_id" ref="model_wizard_print_attachment" />
+        <field name="group_id" ref="printing_group_user" />
+        <field eval="1" name="perm_read" />
+        <field eval="1" name="perm_unlink" />
+        <field eval="1" name="perm_write" />
+        <field eval="1" name="perm_create" />
+    </record>
+    <record id="access_wizard_print_attachment_line_user" model="ir.model.access">
+        <field name="name">Print Attachment Line User</field>
+        <field name="model_id" ref="model_wizard_print_attachment_line" />
+        <field name="group_id" ref="printing_group_user" />
         <field eval="1" name="perm_read" />
         <field eval="1" name="perm_unlink" />
         <field eval="1" name="perm_write" />
diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
index f2160b2..8f21825 100644
--- a/base_report_to_printer/wizards/print_attachment_report.py
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -42,14 +42,12 @@ class PrintAttachment(models.TransientModel):
             )
         if errors:
             return {
-                "warning": _(
-                    "Following attachments could not be printed:\n\n%s"
-                    % "\n".join(
-                        [
-                            _("%s (%s copies)") % (err.record_name, err.copies)
-                            for err in errors
-                        ]
-                    )
+                "warning": _("Following attachments could not be printed:\n\n%s")
+                % "\n".join(
+                    [
+                        _("%s (%s copies)") % (err.record_name, err.copies)
+                        for err in errors
+                    ]
                 )
             }
 

From c535f0fc748a7c0aec0eeaa1acd44a7cdc1affe7 Mon Sep 17 00:00:00 2001
From: Stephane Mangin <stephane.mangin@camptocamp.com>
Date: Tue, 12 Jul 2022 10:30:51 +0200
Subject: [PATCH 8/9] FIX bad field used for labeling at print

---
 base_report_to_printer/wizards/print_attachment_report.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
index 8f21825..fb2b38e 100644
--- a/base_report_to_printer/wizards/print_attachment_report.py
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -27,7 +27,7 @@ class PrintAttachment(models.TransientModel):
         errors = []
         for att_line in self.attachment_line_ids:
             data = att_line.attachment_id.datas
-            title = att_line.attachment_id.store_fname
+            title = att_line.attachment_id.name
             if not data:
                 errors.append(att_line)
                 continue

From 82aecdc4ea41efa302b17a68149007ffa39f04da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Alix?= <sebastien.alix@camptocamp.com>
Date: Thu, 15 Dec 2022 09:12:12 +0100
Subject: [PATCH 9/9] base_report_to_printer: fix translation-positional-used

---
 base_report_to_printer/wizards/print_attachment_report.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
index fb2b38e..8ac6473 100644
--- a/base_report_to_printer/wizards/print_attachment_report.py
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -45,7 +45,9 @@ class PrintAttachment(models.TransientModel):
                 "warning": _("Following attachments could not be printed:\n\n%s")
                 % "\n".join(
                     [
-                        _("%s (%s copies)") % (err.record_name, err.copies)
+                        _("{name} ({copies} copies)").format(
+                            name=err.record_name, copies=err.copies
+                        )
                         for err in errors
                     ]
                 )