From cff47af30c8a878e3be8bc3ec5c07de8146dab5d Mon Sep 17 00:00:00 2001
From: Denis Roussel <denis.roussel@acsone.eu>
Date: Mon, 20 Dec 2021 10:50:03 +0100
Subject: [PATCH 1/9] [14.0][IMP] base_report_to_printer: Add Text render
 document to printer

---
 .../models/ir_actions_report.py               | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/base_report_to_printer/models/ir_actions_report.py b/base_report_to_printer/models/ir_actions_report.py
index 1f1d63f..ed23aed 100644
--- a/base_report_to_printer/models/ir_actions_report.py
+++ b/base_report_to_printer/models/ir_actions_report.py
@@ -161,3 +161,24 @@ class IrActionsReport(models.Model):
             )
 
         return document, doc_format
+
+    def _render_qweb_text(self, report_ref, docids, data=None):
+        """Generate a TEXT file and returns it.
+
+        If the action configured on the report is server, it prints the
+        generated document as well.
+        """
+        document, doc_format = super()._render_qweb_text(
+            report_ref, docids=docids, data=data
+        )
+
+        behaviour = self.behaviour()
+        printer = behaviour.pop("printer", None)
+        can_print_report = self._can_print_report(behaviour, printer, document)
+
+        if can_print_report:
+            printer.print_document(
+                self, document, doc_format=self.report_type, **behaviour
+            )
+
+        return document, doc_format

From 91b4111e2b9421b07a3d58874384979aa3c8aea1 Mon Sep 17 00:00:00 2001
From: Denis Roussel <denis.roussel@acsone.eu>
Date: Wed, 29 Dec 2021 09:05:33 +0100
Subject: [PATCH 2/9] [14.0][FIX] base_report_to_printer: Manage text
 print_document()

---
 .../models/ir_actions_report.py                   | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/base_report_to_printer/models/ir_actions_report.py b/base_report_to_printer/models/ir_actions_report.py
index ed23aed..652d6f2 100644
--- a/base_report_to_printer/models/ir_actions_report.py
+++ b/base_report_to_printer/models/ir_actions_report.py
@@ -8,6 +8,8 @@
 from odoo import _, api, exceptions, fields, models
 from odoo.tools.safe_eval import safe_eval, time
 
+REPORT_TYPES = {"qweb-pdf": "pdf", "qweb-text": "text"}
+
 
 class IrActionsReport(models.Model):
     _inherit = "ir.actions.report"
@@ -99,9 +101,16 @@ class IrActionsReport(models.Model):
 
     def print_document(self, record_ids, data=None):
         """Print a document, do not return the document file"""
-        document, doc_format = self.with_context(
-            must_skip_send_to_printer=True
-        )._render_qweb_pdf(self.report_name, record_ids, data=data)
+        report_type = REPORT_TYPES.get(self.report_type)
+        if not report_type:
+            raise exceptions.UserError(
+                _("This report type (%s) is not supported by direct printing!")
+                % str(self.report_type)
+            )
+        method_name = "_render_qweb_%s" % (report_type)
+        document, doc_format = getattr(
+            self.with_context(must_skip_send_to_printer=True), method_name
+        )(self.report_name, record_ids, data=data)
         behaviour = self.behaviour()
         printer = behaviour.pop("printer", None)
 

From a8cb18b04e3730a35c3661bc6d49b3b9640a4b9c Mon Sep 17 00:00:00 2001
From: Denis Roussel <denis.roussel@acsone.eu>
Date: Wed, 29 Dec 2021 09:10:46 +0100
Subject: [PATCH 3/9] [14.0][IMP] base_report_to_printer: Add tests for text
 documents

---
 base_report_to_printer/tests/test_report.py | 28 +++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/base_report_to_printer/tests/test_report.py b/base_report_to_printer/tests/test_report.py
index 2ef9db5..25daf02 100644
--- a/base_report_to_printer/tests/test_report.py
+++ b/base_report_to_printer/tests/test_report.py
@@ -47,6 +47,14 @@ class TestReport(common.HttpCase):
                 "report_name": "base_report_to_printer.test",
             }
         )
+        self.report_text = self.Model.create(
+            {
+                "name": "Test",
+                "report_type": "qweb-text",
+                "model": "res.partner",
+                "report_name": "base_report_to_printer.test",
+            }
+        )
         self.partners = self.env["res.partner"]
         for n in range(5):
             self.partners += self.env["res.partner"].create({"name": "Test %d" % n})
@@ -115,6 +123,26 @@ class TestReport(common.HttpCase):
                 tray=False,
             )
 
+    def test_render_qweb_text_printable(self):
+        """It should print the report, only if it is printable"""
+        with mock.patch(
+            "odoo.addons.base_report_to_printer.models."
+            "printing_printer.PrintingPrinter."
+            "print_document"
+        ) as print_document:
+            self.report_text.property_printing_action_id.action_type = "server"
+            self.report_text.printing_printer_id = self.new_printer()
+            document = self.report_text._render_qweb_text(
+                self.report.report_name, self.partners.ids
+            )
+            print_document.assert_called_once_with(
+                self.report_text,
+                document[0],
+                action="server",
+                doc_format="qweb-text",
+                tray=False,
+            )
+
     def test_print_document_not_printable(self):
         """It should print the report, regardless of the defined behaviour"""
         self.report.printing_printer_id = self.new_printer()

From 2d4b14e5b367e67279904a7424470be36ec11806 Mon Sep 17 00:00:00 2001
From: Akim Juillerat <akim.juillerat@camptocamp.com>
Date: Mon, 27 Apr 2020 14:36:35 +0200
Subject: [PATCH 4/9] [ADD] base_report_to_printer: Print attachments wizard

---
 base_report_to_printer/README.rst             |  1 +
 base_report_to_printer/__manifest__.py        |  1 +
 .../readme/CONTRIBUTORS.rst                   |  1 +
 .../static/description/index.html             |  3 +-
 base_report_to_printer/wizards/__init__.py    |  1 +
 .../wizards/print_attachment_report.py        | 77 +++++++++++++++++++
 .../wizards/print_attachment_report.xml       | 60 +++++++++++++++
 7 files changed, 143 insertions(+), 1 deletion(-)
 create mode 100644 base_report_to_printer/wizards/print_attachment_report.py
 create mode 100644 base_report_to_printer/wizards/print_attachment_report.xml

diff --git a/base_report_to_printer/README.rst b/base_report_to_printer/README.rst
index 5698f59..db77c7a 100644
--- a/base_report_to_printer/README.rst
+++ b/base_report_to_printer/README.rst
@@ -156,6 +156,7 @@ Contributors
 * Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
 * Matias Peralta <mnp@adhoc.com.ar>
 * Hughes Damry <hughes.damry@acsone.eu>
+* Akim Juillerat <akim.juillerat@camptocamp.com>
 
 Maintainers
 ~~~~~~~~~~~
diff --git a/base_report_to_printer/__manifest__.py b/base_report_to_printer/__manifest__.py
index 3162307..ec2ce52 100644
--- a/base_report_to_printer/__manifest__.py
+++ b/base_report_to_printer/__manifest__.py
@@ -24,6 +24,7 @@
         "views/printing_report.xml",
         "views/res_users.xml",
         "views/ir_actions_report.xml",
+        "wizards/print_attachment_report.xml",
         "wizards/printing_printer_update_wizard_view.xml",
     ],
     "assets": {
diff --git a/base_report_to_printer/readme/CONTRIBUTORS.rst b/base_report_to_printer/readme/CONTRIBUTORS.rst
index 9fffa8e..db926ad 100644
--- a/base_report_to_printer/readme/CONTRIBUTORS.rst
+++ b/base_report_to_printer/readme/CONTRIBUTORS.rst
@@ -13,3 +13,4 @@
 * Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
 * Matias Peralta <mnp@adhoc.com.ar>
 * Hughes Damry <hughes.damry@acsone.eu>
+* Akim Juillerat <akim.juillerat@camptocamp.com>
diff --git a/base_report_to_printer/static/description/index.html b/base_report_to_printer/static/description/index.html
index 1934af2..da7f965 100644
--- a/base_report_to_printer/static/description/index.html
+++ b/base_report_to_printer/static/description/index.html
@@ -3,7 +3,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
+<meta name="generator" content="Docutils 0.14: http://docutils.sourceforge.net/" />
 <title>Report to printer</title>
 <style type="text/css">
 
@@ -507,6 +507,7 @@ If you spotted it first, help us smashing it by providing a detailed and welcome
 <li>Alexandre Fayolle &lt;<a class="reference external" href="mailto:alexandre.fayolle&#64;camptocamp.com">alexandre.fayolle&#64;camptocamp.com</a>&gt;</li>
 <li>Matias Peralta &lt;<a class="reference external" href="mailto:mnp&#64;adhoc.com.ar">mnp&#64;adhoc.com.ar</a>&gt;</li>
 <li>Hughes Damry &lt;<a class="reference external" href="mailto:hughes.damry&#64;acsone.eu">hughes.damry&#64;acsone.eu</a>&gt;</li>
+<li>Akim Juillerat &lt;<a class="reference external" href="mailto:akim.juillerat&#64;camptocamp.com">akim.juillerat&#64;camptocamp.com</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
diff --git a/base_report_to_printer/wizards/__init__.py b/base_report_to_printer/wizards/__init__.py
index b1638ea..a280931 100644
--- a/base_report_to_printer/wizards/__init__.py
+++ b/base_report_to_printer/wizards/__init__.py
@@ -1 +1,2 @@
+from . import print_attachment_report
 from . import printing_printer_update_wizard
diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
new file mode 100644
index 0000000..660070b
--- /dev/null
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -0,0 +1,77 @@
+# Copyright 2020 Camptocamp SA
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
+import base64
+
+from openerp import _, api, fields, models
+
+
+class PrintAttachment(models.TransientModel):
+    _name = "wizard.print.attachment"
+    _description = "Print Attachment"
+
+    printer_id = fields.Many2one(
+        comodel_name="printing.printer",
+        string="Printer",
+        required=True,
+        help="Printer used to print the attachments.",
+    )
+    attachment_line_ids = fields.One2many(
+        "wizard.print.attachment.line",
+        "wizard_id",
+        string="Attachments to print",
+    )
+
+    @api.multi
+    def print_attachments(self):
+        """Prints a label per selected record"""
+        self.ensure_one()
+        errors = []
+        for att_line in self.attachment_line_ids:
+            data = att_line.attachment_id.datas
+            if not data:
+                errors.append(att_line)
+                continue
+            content = base64.b64decode(data)
+            content_format = att_line.get_format()
+            self.printer_id.print_document(
+                None, content=content, format=content_format, copies=att_line.copies
+            )
+        if errors:
+            return {
+                "warning": _(
+                    "Following attachments could not be printed:\n\n%s"
+                    % "\n".join(
+                        [
+                            _("%s (%s copies)") % (err.record_name, err.copies)
+                            for err in errors
+                        ]
+                    )
+                )
+            }
+
+
+class PrintAttachmentLine(models.TransientModel):
+    _name = "wizard.print.attachment.line"
+    _description = "Print Attachment line"
+
+    wizard_id = fields.Many2one("wizard.print.attachment")
+    attachment_id = fields.Many2one(
+        "ir.attachment",
+        required=True,
+        domain=[
+            "|",
+            ("mimetype", "=", "application/pdf"),
+            ("mimetype", "=", "application/octet-stream"),
+        ],
+    )
+    record_name = fields.Char(related="attachment_id.res_name", readonly=True)
+    copies = fields.Integer(default=1)
+
+    @api.multi
+    def get_format(self):
+        self.ensure_one()
+        mimetype = self.attachment_id.mimetype
+        if mimetype == "application/pdf":
+            return "pdf"
+        else:
+            return "raw"
diff --git a/base_report_to_printer/wizards/print_attachment_report.xml b/base_report_to_printer/wizards/print_attachment_report.xml
new file mode 100644
index 0000000..049fae4
--- /dev/null
+++ b/base_report_to_printer/wizards/print_attachment_report.xml
@@ -0,0 +1,60 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<openerp>
+    <data>
+        <record id="wizard_print_attachment_form" model="ir.ui.view">
+            <field name="name">wizard.print.attachment</field>
+            <field name="model">wizard.print.attachment</field>
+            <field name="arch" type="xml">
+                <form string="Print attachments">
+                    <group>
+                        <field name="printer_id" />
+                        <field name="attachment_line_ids">
+                            <tree editable="top">
+                                <field name="attachment_id" create="0" />
+                                <field name="record_name" />
+                                <field name="copies" />
+                            </tree>
+                        </field>
+                    </group>
+                    <footer>
+                        <button
+                            name="print_attachments"
+                            string="Print"
+                            type="object"
+                            class="oe_highlight"
+                        />
+                        or
+                        <button string="Cancel" class="oe_link" special="cancel" />
+                    </footer>
+                </form>
+            </field>
+        </record>
+        <record id="wizard_print_attachment_line_form" model="ir.ui.view">
+            <field name="name">wizard.print.attachment.line.form</field>
+            <field name="model">wizard.print.attachment.line</field>
+            <field name="arch" type="xml">
+                <form>
+                    <group>
+                        <field name="attachment_id" create="0" />
+                        <field name="record_name" />
+                        <field name="copies" />
+                    </group>
+                </form>
+            </field>
+        </record>
+        <record id="action_wizard_print_attachment" model="ir.actions.act_window">
+            <field name="name">Print Attachments</field>
+            <field name="type">ir.actions.act_window</field>
+            <field name="res_model">wizard.print.attachment</field>
+            <field name="view_type">form</field>
+            <field name="view_mode">form</field>
+            <field name="target">new</field>
+        </record>
+        <menuitem
+            id="menu_action_wizard_print_attachment"
+            action="action_wizard_print_attachment"
+            sequence="50"
+            parent="printing_menu"
+        />
+    </data>
+</openerp>

From b2894a77045362a9eb483de846c2ce3a4e270b08 Mon Sep 17 00:00:00 2001
From: sebalix <seb@usr-src.org>
Date: Thu, 6 Aug 2020 12:30:44 +0200
Subject: [PATCH 5/9] [MIG] base_report_to_printer: Print attachments wizard

---
 .../static/description/index.html             |   2 +-
 .../wizards/print_attachment_report.py        |   4 +-
 .../wizards/print_attachment_report.xml       | 114 +++++++++---------
 3 files changed, 57 insertions(+), 63 deletions(-)

diff --git a/base_report_to_printer/static/description/index.html b/base_report_to_printer/static/description/index.html
index da7f965..f358b9b 100644
--- a/base_report_to_printer/static/description/index.html
+++ b/base_report_to_printer/static/description/index.html
@@ -3,7 +3,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.14: http://docutils.sourceforge.net/" />
+<meta name="generator" content="Docutils: http://docutils.sourceforge.net/" />
 <title>Report to printer</title>
 <style type="text/css">
 
diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
index 660070b..5196b17 100644
--- a/base_report_to_printer/wizards/print_attachment_report.py
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
 import base64
 
-from openerp import _, api, fields, models
+from odoo import _, fields, models
 
 
 class PrintAttachment(models.TransientModel):
@@ -21,7 +21,6 @@ class PrintAttachment(models.TransientModel):
         string="Attachments to print",
     )
 
-    @api.multi
     def print_attachments(self):
         """Prints a label per selected record"""
         self.ensure_one()
@@ -67,7 +66,6 @@ class PrintAttachmentLine(models.TransientModel):
     record_name = fields.Char(related="attachment_id.res_name", readonly=True)
     copies = fields.Integer(default=1)
 
-    @api.multi
     def get_format(self):
         self.ensure_one()
         mimetype = self.attachment_id.mimetype
diff --git a/base_report_to_printer/wizards/print_attachment_report.xml b/base_report_to_printer/wizards/print_attachment_report.xml
index 049fae4..17354c2 100644
--- a/base_report_to_printer/wizards/print_attachment_report.xml
+++ b/base_report_to_printer/wizards/print_attachment_report.xml
@@ -1,60 +1,56 @@
 <?xml version="1.0" encoding="UTF-8" ?>
-<openerp>
-    <data>
-        <record id="wizard_print_attachment_form" model="ir.ui.view">
-            <field name="name">wizard.print.attachment</field>
-            <field name="model">wizard.print.attachment</field>
-            <field name="arch" type="xml">
-                <form string="Print attachments">
-                    <group>
-                        <field name="printer_id" />
-                        <field name="attachment_line_ids">
-                            <tree editable="top">
-                                <field name="attachment_id" create="0" />
-                                <field name="record_name" />
-                                <field name="copies" />
-                            </tree>
-                        </field>
-                    </group>
-                    <footer>
-                        <button
-                            name="print_attachments"
-                            string="Print"
-                            type="object"
-                            class="oe_highlight"
-                        />
-                        or
-                        <button string="Cancel" class="oe_link" special="cancel" />
-                    </footer>
-                </form>
-            </field>
-        </record>
-        <record id="wizard_print_attachment_line_form" model="ir.ui.view">
-            <field name="name">wizard.print.attachment.line.form</field>
-            <field name="model">wizard.print.attachment.line</field>
-            <field name="arch" type="xml">
-                <form>
-                    <group>
-                        <field name="attachment_id" create="0" />
-                        <field name="record_name" />
-                        <field name="copies" />
-                    </group>
-                </form>
-            </field>
-        </record>
-        <record id="action_wizard_print_attachment" model="ir.actions.act_window">
-            <field name="name">Print Attachments</field>
-            <field name="type">ir.actions.act_window</field>
-            <field name="res_model">wizard.print.attachment</field>
-            <field name="view_type">form</field>
-            <field name="view_mode">form</field>
-            <field name="target">new</field>
-        </record>
-        <menuitem
-            id="menu_action_wizard_print_attachment"
-            action="action_wizard_print_attachment"
-            sequence="50"
-            parent="printing_menu"
-        />
-    </data>
-</openerp>
+<odoo>
+    <record id="wizard_print_attachment_form" model="ir.ui.view">
+        <field name="name">wizard.print.attachment</field>
+        <field name="model">wizard.print.attachment</field>
+        <field name="arch" type="xml">
+            <form string="Print attachments">
+                <group>
+                    <field name="printer_id" />
+                    <field name="attachment_line_ids">
+                        <tree editable="top">
+                            <field name="attachment_id" create="0" />
+                            <field name="record_name" />
+                            <field name="copies" />
+                        </tree>
+                    </field>
+                </group>
+                <footer>
+                    <button
+                        name="print_attachments"
+                        type="object"
+                        string="Print"
+                        class="btn-primary"
+                    />
+                    <button string="Cancel" class="btn-secondary" special="cancel" />
+                </footer>
+            </form>
+        </field>
+    </record>
+    <record id="wizard_print_attachment_line_form" model="ir.ui.view">
+        <field name="name">wizard.print.attachment.line.form</field>
+        <field name="model">wizard.print.attachment.line</field>
+        <field name="arch" type="xml">
+            <form>
+                <group>
+                    <field name="attachment_id" create="0" />
+                    <field name="record_name" />
+                    <field name="copies" />
+                </group>
+            </form>
+        </field>
+    </record>
+    <record id="action_wizard_print_attachment" model="ir.actions.act_window">
+        <field name="name">Print Attachments</field>
+        <field name="type">ir.actions.act_window</field>
+        <field name="res_model">wizard.print.attachment</field>
+        <field name="view_mode">form</field>
+        <field name="target">new</field>
+    </record>
+    <menuitem
+        id="menu_action_wizard_print_attachment"
+        action="action_wizard_print_attachment"
+        sequence="50"
+        parent="printing_menu"
+    />
+</odoo>

From 0eeb248238896ebea6f668047ceb4f3525fea51d Mon Sep 17 00:00:00 2001
From: Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
Date: Wed, 9 Mar 2022 12:00:36 +0100
Subject: [PATCH 6/9] fix(#259): handle case of print attachment wizard

The fix in #259 only worked for reports being printed at generation
of the PDF. This PR handles sending an attachment to a printer through
the Print Attachment wizard.

Also clarify the configuration section of the README.
---
 base_report_to_printer/README.rst                         | 3 ++-
 base_report_to_printer/readme/CONFIGURE.rst               | 3 ++-
 base_report_to_printer/static/description/index.html      | 3 ++-
 base_report_to_printer/wizards/print_attachment_report.py | 7 ++++++-
 4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/base_report_to_printer/README.rst b/base_report_to_printer/README.rst
index db77c7a..0395d69 100644
--- a/base_report_to_printer/README.rst
+++ b/base_report_to_printer/README.rst
@@ -82,7 +82,8 @@ The jobs will be sent to the printer with a name matching the print_report_name
 of the report (truncated at 80 characters). By default this will not be
 displayed by CUPS web interface or in Odoo. To see this information, you need
 to change the configuration of your CUPS server and set the JobPrivateValue
-directive to "job-name", and reload the server. See `cupsd.conf(5)
+directive to "none" (or some other list of values which does not include
+"job-name") , and reload the server. See `cupsd.conf(5)
 <https://www.cups.org/doc/man-cupsd.conf.html>` for details.
 
 Usage
diff --git a/base_report_to_printer/readme/CONFIGURE.rst b/base_report_to_printer/readme/CONFIGURE.rst
index 0b12368..3463730 100644
--- a/base_report_to_printer/readme/CONFIGURE.rst
+++ b/base_report_to_printer/readme/CONFIGURE.rst
@@ -8,5 +8,6 @@ The jobs will be sent to the printer with a name matching the print_report_name
 of the report (truncated at 80 characters). By default this will not be
 displayed by CUPS web interface or in Odoo. To see this information, you need
 to change the configuration of your CUPS server and set the JobPrivateValue
-directive to "job-name", and reload the server. See `cupsd.conf(5)
+directive to "none" (or some other list of values which does not include
+"job-name") , and reload the server. See `cupsd.conf(5)
 <https://www.cups.org/doc/man-cupsd.conf.html>` for details.
diff --git a/base_report_to_printer/static/description/index.html b/base_report_to_printer/static/description/index.html
index f358b9b..b46ef5f 100644
--- a/base_report_to_printer/static/description/index.html
+++ b/base_report_to_printer/static/description/index.html
@@ -432,7 +432,8 @@ rights to give users the ability to view the print menu.</li>
 of the report (truncated at 80 characters). By default this will not be
 displayed by CUPS web interface or in Odoo. To see this information, you need
 to change the configuration of your CUPS server and set the JobPrivateValue
-directive to “job-name”, and reload the server. See <cite>cupsd.conf(5)
+directive to “none” (or some other list of values which does not include
+“job-name”) , and reload the server. See <cite>cupsd.conf(5)
 &lt;https://www.cups.org/doc/man-cupsd.conf.html&gt;</cite> for details.</p>
 </div>
 <div class="section" id="usage">
diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
index 5196b17..2fd8ff2 100644
--- a/base_report_to_printer/wizards/print_attachment_report.py
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -27,13 +27,18 @@ class PrintAttachment(models.TransientModel):
         errors = []
         for att_line in self.attachment_line_ids:
             data = att_line.attachment_id.datas
+            title = att_line.attachment_id.store_fname
             if not data:
                 errors.append(att_line)
                 continue
             content = base64.b64decode(data)
             content_format = att_line.get_format()
             self.printer_id.print_document(
-                None, content=content, format=content_format, copies=att_line.copies
+                None,
+                content=content,
+                format=content_format,
+                copies=att_line.copies,
+                title=title,
             )
         if errors:
             return {

From dab6f34576e2f13af68f09c1ffbb8e58a8fdb336 Mon Sep 17 00:00:00 2001
From: sonhd <sonhd@trobz.com>
Date: Fri, 21 Jan 2022 10:19:14 +0700
Subject: [PATCH 7/9] [ADD] access right for wizrard print attachment and fix
 trans format

---
 base_report_to_printer/security/security.xml    | 17 +++++++++++++++++
 .../wizards/print_attachment_report.py          | 14 ++++++--------
 2 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/base_report_to_printer/security/security.xml b/base_report_to_printer/security/security.xml
index ebda2e8..8f68e12 100644
--- a/base_report_to_printer/security/security.xml
+++ b/base_report_to_printer/security/security.xml
@@ -125,6 +125,23 @@
         <field name="name">Update printer wizard</field>
         <field name="model_id" ref="model_printing_printer_update_wizard" />
         <field name="group_id" ref="printing_group_manager" />
+         <field eval="1" name="perm_read" />
+         <field eval="1" name="perm_unlink" />
+         <field eval="1" name="perm_write" />
+    </record>
+    <record id="access_wizard_print_attachment_user" model="ir.model.access">
+        <field name="name">Print Attachment User</field>
+        <field name="model_id" ref="model_wizard_print_attachment" />
+        <field name="group_id" ref="printing_group_user" />
+        <field eval="1" name="perm_read" />
+        <field eval="1" name="perm_unlink" />
+        <field eval="1" name="perm_write" />
+        <field eval="1" name="perm_create" />
+    </record>
+    <record id="access_wizard_print_attachment_line_user" model="ir.model.access">
+        <field name="name">Print Attachment Line User</field>
+        <field name="model_id" ref="model_wizard_print_attachment_line" />
+        <field name="group_id" ref="printing_group_user" />
         <field eval="1" name="perm_read" />
         <field eval="1" name="perm_unlink" />
         <field eval="1" name="perm_write" />
diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
index 2fd8ff2..b430fa5 100644
--- a/base_report_to_printer/wizards/print_attachment_report.py
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -42,14 +42,12 @@ class PrintAttachment(models.TransientModel):
             )
         if errors:
             return {
-                "warning": _(
-                    "Following attachments could not be printed:\n\n%s"
-                    % "\n".join(
-                        [
-                            _("%s (%s copies)") % (err.record_name, err.copies)
-                            for err in errors
-                        ]
-                    )
+                "warning": _("Following attachments could not be printed:\n\n%s")
+                % "\n".join(
+                    [
+                        _("%s (%s copies)") % (err.record_name, err.copies)
+                        for err in errors
+                    ]
                 )
             }
 

From 2f53117eb4246a985d637900219ee135dcc889cf Mon Sep 17 00:00:00 2001
From: Stephane Mangin <stephane.mangin@camptocamp.com>
Date: Tue, 12 Jul 2022 10:30:51 +0200
Subject: [PATCH 8/9] FIX bad field used for labeling at print

---
 base_report_to_printer/wizards/print_attachment_report.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
index b430fa5..6ec2007 100644
--- a/base_report_to_printer/wizards/print_attachment_report.py
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -27,7 +27,7 @@ class PrintAttachment(models.TransientModel):
         errors = []
         for att_line in self.attachment_line_ids:
             data = att_line.attachment_id.datas
-            title = att_line.attachment_id.store_fname
+            title = att_line.attachment_id.name
             if not data:
                 errors.append(att_line)
                 continue

From 9cc1f85f3a0517b9812a9701af667cf1adf511fc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Alix?= <sebastien.alix@camptocamp.com>
Date: Thu, 15 Dec 2022 09:12:12 +0100
Subject: [PATCH 9/9] base_report_to_printer: fix translation-positional-used

---
 base_report_to_printer/wizards/print_attachment_report.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/base_report_to_printer/wizards/print_attachment_report.py b/base_report_to_printer/wizards/print_attachment_report.py
index 6ec2007..459df98 100644
--- a/base_report_to_printer/wizards/print_attachment_report.py
+++ b/base_report_to_printer/wizards/print_attachment_report.py
@@ -45,7 +45,9 @@ class PrintAttachment(models.TransientModel):
                 "warning": _("Following attachments could not be printed:\n\n%s")
                 % "\n".join(
                     [
-                        _("%s (%s copies)") % (err.record_name, err.copies)
+                        _("{name} ({copies} copies)").format(
+                            name=err.record_name, copies=err.copies
+                        )
                         for err in errors
                     ]
                 )