From 2142d3d8928ddad4c5774eb8474eab85ba16895d Mon Sep 17 00:00:00 2001 From: Roel Adriaans Date: Thu, 10 Dec 2015 12:29:02 +0100 Subject: [PATCH] [IMP] Soft fail on missing cups import cups is an external dependency, if it is not installed Odoo will not start. OCA guidelines specify guidelines for External dependencies, code is from there. --- base_report_to_printer/printing.py | 10 ++++++++-- base_report_to_printer/wizard/update_printers.py | 11 ++++++++--- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/base_report_to_printer/printing.py b/base_report_to_printer/printing.py index 129fc62..b4dd364 100644 --- a/base_report_to_printer/printing.py +++ b/base_report_to_printer/printing.py @@ -22,14 +22,20 @@ # ############################################################################## import logging +_logger = logging.getLogger(__name__) + import os from tempfile import mkstemp -import cups + +try: + import cups +except ImportError: + _logger.debug('Cannot `import cups`.') + from openerp import models, fields, api, _ from openerp.exceptions import Warning from openerp.tools.config import config -_logger = logging.getLogger(__name__) CUPS_HOST = config.get('cups_host', 'localhost') CUPS_PORT = int(config.get('cups_port', 631)) # config.get returns a string diff --git a/base_report_to_printer/wizard/update_printers.py b/base_report_to_printer/wizard/update_printers.py index 7af8f10..0282c15 100644 --- a/base_report_to_printer/wizard/update_printers.py +++ b/base_report_to_printer/wizard/update_printers.py @@ -21,13 +21,18 @@ # ############################################################################## -import cups +import logging +_logger = logging.getLogger(__name__) + +try: + import cups +except ImportError: + _logger.debug('Cannot `import cups`.') + from openerp.exceptions import Warning from openerp import models, api, _ from openerp.tools.config import config -import logging -_logger = logging.getLogger(__name__) CUPS_HOST = config.get('cups_host', 'localhost') CUPS_PORT = int(config.get('cups_port', 631))