From ab8a687c0bfe33f215a4a45819f7bb99505e485c Mon Sep 17 00:00:00 2001
From: Sylvain GARANCHER <sylvain.garancher@syleam.fr>
Date: Wed, 4 Oct 2017 13:12:56 +0200
Subject: [PATCH 1/3] [FIX] Forgot fixes

---
 base_report_to_printer/models/ir_actions_report.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/base_report_to_printer/models/ir_actions_report.py b/base_report_to_printer/models/ir_actions_report.py
index 3d3dfd5..d620228 100644
--- a/base_report_to_printer/models/ir_actions_report.py
+++ b/base_report_to_printer/models/ir_actions_report.py
@@ -14,12 +14,12 @@ class IrActionsReport(models.Model):
 
     property_printing_action_id = fields.Many2one(
         comodel_name='printing.action',
-        string='Action',
+        string='Default Behaviour',
         company_dependent=True,
     )
     printing_printer_id = fields.Many2one(
         comodel_name='printing.printer',
-        string='Printer'
+        string='Default Printer'
     )
     printing_action_ids = fields.One2many(
         comodel_name='printing.report.xml.action',

From 470c25a777dd811a545d1db573826ce1c3336035 Mon Sep 17 00:00:00 2001
From: Sylvain GARANCHER <sylvain.garancher@syleam.fr>
Date: Wed, 4 Oct 2017 15:17:08 +0200
Subject: [PATCH 2/3] [FIX] Views review fixes

---
 base_report_to_printer/views/printing_report.xml | 10 +++++-----
 base_report_to_printer/views/res_users.xml       |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/base_report_to_printer/views/printing_report.xml b/base_report_to_printer/views/printing_report.xml
index 6484433..ee2f4c4 100644
--- a/base_report_to_printer/views/printing_report.xml
+++ b/base_report_to_printer/views/printing_report.xml
@@ -7,9 +7,9 @@
     <field name="arch" type="xml">
       <form string="Report Printing Actions">
         <group col="2">
-            <field name="user_id"/>
+            <field name="user_id" options="{'no_create': True}"/>
             <field name="action"/>
-            <field name="printer_id" select="1"/>
+            <field name="printer_id" options="{'no_create': True}"/>
         </group>
       </form>
     </field>
@@ -18,10 +18,10 @@
     <field name="name">printing.report.xml.action.tree</field>
     <field name="model">printing.report.xml.action</field>
     <field name="arch" type="xml">
-      <tree string="Report Printing Actions">
-        <field name="user_id"/>
+      <tree string="Report Printing Actions" editable="bottom">
+        <field name="user_id" options="{'no_create': True}"/>
         <field name="action" />
-        <field name="printer_id" />
+        <field name="printer_id" options="{'no_create': True}"/>
       </tree>
     </field>
   </record>
diff --git a/base_report_to_printer/views/res_users.xml b/base_report_to_printer/views/res_users.xml
index 6d4a002..673cfe1 100644
--- a/base_report_to_printer/views/res_users.xml
+++ b/base_report_to_printer/views/res_users.xml
@@ -9,7 +9,7 @@
       <xpath expr="//group[@name='preferences']/ancestor::page" position="inside">
         <group string="Printing" name="printing">
           <field name="printing_action"/>
-          <field name="printing_printer_id"/>
+          <field name="printing_printer_id" options="{'no_create': True}"/>
         </group>
       </xpath>
     </field>
@@ -23,7 +23,7 @@
       <footer position="before">
         <group string="Printing" name="printing">
           <field name="printing_action"/>
-          <field name="printing_printer_id"/>
+          <field name="printing_printer_id" options="{'no_create': True}"/>
         </group>
       </footer>
     </field>

From 61cf341565292dc6e74a534bbfecf377ce5d3f27 Mon Sep 17 00:00:00 2001
From: Sylvain GARANCHER <sylvain.garancher@syleam.fr>
Date: Thu, 5 Oct 2017 08:10:23 +0200
Subject: [PATCH 3/3] [IMP] Allow users to define their default behaviour and
 printer

---
 base_report_to_printer/models/res_users.py | 11 +++++++++++
 base_report_to_printer/views/res_users.xml |  4 ++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/base_report_to_printer/models/res_users.py b/base_report_to_printer/models/res_users.py
index 35be34f..092a00b 100644
--- a/base_report_to_printer/models/res_users.py
+++ b/base_report_to_printer/models/res_users.py
@@ -26,3 +26,14 @@ class ResUsers(models.Model):
     )
     printing_printer_id = fields.Many2one(comodel_name='printing.printer',
                                           string='Default Printer')
+
+    @api.model
+    def _register_hook(self):
+        self.SELF_WRITEABLE_FIELDS.extend([
+            'printing_action',
+            'printing_printer_id',
+        ])
+        self.SELF_READABLE_FIELDS.extend([
+            'printing_action',
+            'printing_printer_id',
+        ])
diff --git a/base_report_to_printer/views/res_users.xml b/base_report_to_printer/views/res_users.xml
index 673cfe1..a6792b7 100644
--- a/base_report_to_printer/views/res_users.xml
+++ b/base_report_to_printer/views/res_users.xml
@@ -22,8 +22,8 @@
     <field name="arch" type="xml">
       <footer position="before">
         <group string="Printing" name="printing">
-          <field name="printing_action"/>
-          <field name="printing_printer_id" options="{'no_create': True}"/>
+          <field name="printing_action" readonly="0"/>
+          <field name="printing_printer_id" readonly="0" options="{'no_create': True}"/>
         </group>
       </footer>
     </field>