audrius/pms
1
0
Fork 1
mirror of https://github.com/OCA/pms.git synced 2025-01-29 00:17:45 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
cb96f3a9d04183ed7a49786f639c01b34e9b6f60
pms/pms/tests/test_pms_pricelist_priority.py
Miguel Padin cb96f3a9d0 [DONE] consider SALE dates & OVERNIGHT dates on pricelist items (#38) 
* [FIX] pms: fix timezones (test,compute & create) @ massive changes

* [REF] pms: fiels date_start/end_overnight (pricelist_items)

* [IMP] pms: SQL to consider overnight dates and priorize items (_compute_price_rule_get_items)

* [REF] pms: add tests for overnight dates and unify test cases with subtests

* [FIX] pms: fix apply partially pricelist items on several reservation lines

* [FIX] pms: consider services to priorize pricelists

* [FIX] test pricelist priority without taxs

Co-authored-by: Darío Lodeiros <dario@commitsun.com>
2021-01-20 12:19:42 +01:00

487 lines
20 KiB
Python
Raw Blame History

import datetime
from freezegun import freeze_time
from odoo.tests import common
class TestPmsPricelistRules(common.TransactionCase):
def create_common_scenario(self):
self.product_template = self.env["product.template"].create(
{"name": "Template1"}
)
self.product_category = self.env["product.category"].create(
{"name": "Category1"}
)
self.availability_plan1 = self.env["pms.room.type.availability.plan"].create(
{"name": "Availability 1"}
)
self.availability_plan2 = self.env["pms.room.type.availability.plan"].create(
{"name": "Availability"}
)
self.property1 = self.env["pms.property"].create(
{
"name": "Property_1",
"company_id": self.env.ref("base.main_company").id,
"default_pricelist_id": self.env.ref("product.list0").id,
"default_availability_plan_id": self.availability_plan1.id,
}
)
self.property2 = self.env["pms.property"].create(
{
"name": "Property_2",
"company_id": self.env.ref("base.main_company").id,
"default_pricelist_id": self.env.ref("product.list0").id,
"default_availability_plan_id": self.availability_plan2.id,
}
)
self.room_type_class = self.env["pms.room.type.class"].create(
{"name": "Room Class"}
)
self.room_type = self.env["pms.room.type"].create(
{
"pms_property_ids": [self.property1.id, self.property2.id],
"name": "Single",
"code_type": "SIN",
"class_id": self.room_type_class.id,
"list_price": 30,
}
)
self.room = self.env["pms.room"].create(
{
"pms_property_id": self.property1.id,
"name": "Single 101",
"room_type_id": self.room_type.id,
}
)
self.room2 = self.env["pms.room"].create(
{
"pms_property_id": self.property2.id,
"name": "Single 102",
"room_type_id": self.room_type.id,
}
)
self.pricelist = self.env["product.pricelist"].create(
{
"name": "pricelist_1",
}
)
@freeze_time("2000-01-01")
def test_simple_price_without_items(self):
# TEST CASE : no items applied
# ARRANGE
self.create_common_scenario()
reservation = self.env["pms.reservation"].create(
{
"checkin": datetime.datetime.today(),
"checkout": datetime.datetime.today() + datetime.timedelta(days=3),
"preferred_room_id": self.room.id,
"pms_property_id": self.property1.id,
}
)
# ACT
n_days = (reservation.checkout - reservation.checkin).days
expected_price = self.room.room_type_id.list_price * n_days
# ASSERT
self.assertEqual(
expected_price, reservation.price_subtotal, "The price is not as expected"
)
@freeze_time("2022-01-01")
def test_items_sort(self):
# ARRANGE
self.create_common_scenario()
# - test cases to verify the order for each field considered individually
# - test cases to prioritize fields over other fields:
# 1. applied_on
# 2. date
# 3. date overnight
# 4. num. properties
# 5. id
# - tie
# - no [date_start|date_end|date_start_overnight|date_end_overnight]
test_cases = [
{
"name": "sorting applied_on",
"expected_price": 50 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "2_product_category",
"categ_id": self.product_category.id,
"fixed_price": 60.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"fixed_price": 50.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "1_product",
"product_id": self.room_type.product_id.id,
"product_tmpl_id": self.product_template.id,
"fixed_price": 40.0,
},
],
},
{
"name": "sorting SALE date min range",
"expected_price": 50.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start": datetime.datetime.now(),
"date_end": datetime.datetime.now()
+ datetime.timedelta(days=2),
"fixed_price": 60.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start": datetime.datetime.now(),
"date_end": datetime.datetime.now()
+ datetime.timedelta(days=1),
"fixed_price": 50.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start": datetime.datetime.now(),
"date_end": datetime.datetime.now()
+ datetime.timedelta(days=3),
"fixed_price": 40.0,
},
],
},
{
"name": "sorting OVERNIGHT date min range",
"expected_price": 40.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now()
+ datetime.timedelta(days=6),
"fixed_price": 60.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now()
+ datetime.timedelta(days=10),
"fixed_price": 50.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now()
+ datetime.timedelta(days=3),
"fixed_price": 40.0,
},
],
},
{
"name": "sorting num. properties",
"expected_price": 50.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"fixed_price": 60.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"pms_property_ids": [self.property1.id],
"fixed_price": 50.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"pms_property_ids": [self.property1.id, self.property2.id],
"fixed_price": 40.0,
},
],
},
{
"name": "sorting by item id",
"expected_price": 40.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"fixed_price": 60.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"fixed_price": 50.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"fixed_price": 40.0,
},
],
},
{
"name": "prioritize applied_on over SALE date",
"expected_price": 60.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start": datetime.datetime.now(),
"date_end": datetime.datetime.now()
+ datetime.timedelta(days=2),
"fixed_price": 60.0,
},
{
"pricelist_id": self.pricelist.id,
"product_id": self.room_type.product_id.id,
"product_tmpl_id": self.product_template.id,
"applied_on": "1_product",
"date_start": datetime.datetime.now(),
"date_end": datetime.datetime.now()
+ datetime.timedelta(days=1),
"fixed_price": 50.0,
},
],
},
{
"name": "prioritize SALE date over OVERNIGHT date",
"expected_price": 120.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start": datetime.datetime.now(),
"date_end": datetime.datetime.now()
+ datetime.timedelta(days=10),
"fixed_price": 120.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now()
+ datetime.timedelta(days=3),
"fixed_price": 50.0,
},
],
},
{
"name": "prioritize OVERNIGHT date over min. num. properties",
"expected_price": 50.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now()
+ datetime.timedelta(days=3),
"fixed_price": 120.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now()
+ datetime.timedelta(days=3),
"pms_property_ids": [self.property1.id, self.property2.id],
"fixed_price": 50.0,
},
],
},
{
"name": "prioritize min. num. properties over item id",
"expected_price": 50.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now()
+ datetime.timedelta(days=3),
"fixed_price": 120.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now()
+ datetime.timedelta(days=3),
"pms_property_ids": [self.property1.id, self.property2.id],
"fixed_price": 50.0,
},
],
},
{
"name": "tie => order by item id",
"expected_price": 50.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now()
+ datetime.timedelta(days=3),
"date_start": datetime.datetime.now(),
"date_end": datetime.datetime.now()
+ datetime.timedelta(days=3),
"pms_property_ids": [self.property1.id, self.property2.id],
"fixed_price": 120.0,
},
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now()
+ datetime.timedelta(days=3),
"date_start": datetime.datetime.now(),
"date_end": datetime.datetime.now()
+ datetime.timedelta(days=3),
"pms_property_ids": [self.property1.id, self.property2.id],
"fixed_price": 50.0,
},
],
},
{
"name": "no SALE DATE START",
"expected_price": 40.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_end": datetime.datetime.now()
+ datetime.timedelta(days=1),
"fixed_price": 40.0,
},
],
},
{
"name": "no SALE DATE END",
"expected_price": 40.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start": datetime.datetime.now(),
"fixed_price": 40.0,
},
],
},
{
"name": "no overnight DATE START",
"expected_price": 40.0 + self.room_type.list_price * 2,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_end_overnight": datetime.datetime.now(),
"fixed_price": 40.0,
},
],
},
{
"name": "no overnight DATE END",
"expected_price": 40.0 * 3,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"fixed_price": 40.0,
},
],
},
{
"name": "only applied overnight in one night",
"expected_price": 40.0 + self.room_type.list_price * 2,
"items": [
{
"pricelist_id": self.pricelist.id,
"applied_on": "0_product_variant",
"product_id": self.room_type.product_id.id,
"date_start_overnight": datetime.datetime.now(),
"date_end_overnight": datetime.datetime.now(),
"fixed_price": 40.0,
},
],
},
]
for tc in test_cases:
with self.subTest(k=tc):
# ARRANGE
items = []
for item in tc["items"]:
item = self.env["product.pricelist.item"].create(item)
items.append(item.id)
# ACT
reservation = self.env["pms.reservation"].create(
{
"checkin": datetime.datetime.now(),
"checkout": datetime.datetime.now()
+ datetime.timedelta(days=3),
"preferred_room_id": self.room.id,
"pms_property_id": self.property1.id,
"pricelist_id": self.pricelist.id,
}
)
reservation_price = reservation.price_subtotal
self.env["pms.reservation"].browse(reservation.id).unlink()
self.env["product.pricelist.item"].browse(items).unlink()
# ASSERT
self.assertEqual(tc["expected_price"], reservation_price, tc["name"])
Reference in New Issue View Git Blame Copy Permalink