[RFC]pms: break link between document numbers & vat

pms/__manifest__.py

@@ -89,7 +89,6 @@
         "views/precheckin_portal_templates.xml",
         "wizards/wizard_massive_changes.xml",
         "wizards/wizard_advanced_filters.xml",
-        "views/res_partner_id_category.xml",
         "views/payment_transaction_views.xml",
         "views/account_move_line_views.xml",
         "report/proforma_report_templates.xml",

pms/i18n/es.po

@@ -10714,7 +10714,6 @@ msgstr "Usuario que creo la ficha"
 msgid "The value of the down payment amount must be positive."
 msgstr "El valor del pago inicial debe ser positivo."
 
-
 #. module: pms
 #: model_terms:ir.ui.view,arch_db:pms.portal_my_folio
 msgid "There are currently no folios for your account."

pms/models/__init__.py

@@ -46,7 +46,6 @@ from . import pms_availability
 from . import res_partner_id_number
 from . import pms_automated_mails
 from . import payment_transaction
-from . import res_partner_id_category
 from . import pms_team_member
 from . import ir_pms_property
 from . import payment_acquirer

pms/models/res_partner.py

@@ -124,11 +124,6 @@ class ResPartner(models.Model):
         store=True,
         compute="_compute_lastname2",
     )
-    vat = fields.Char(
-        readonly=False,
-        store=True,
-        compute="_compute_vat",
-    )
     country_id = fields.Many2one(
         readonly=False,
         store=True,
@@ -556,17 +551,6 @@ class ResPartner(models.Model):
             elif not record.lastname2:
                 record.lastname2 = False
 
-    @api.depends("id_numbers", "id_numbers.name")
-    def _compute_vat(self):
-        if hasattr(super(), "_compute_vat"):
-            super()._compute_vat()
-        for record in self:
-            if not record.vat and record.id_numbers:
-                vat = list(filter(None, set(record.id_numbers.mapped("name"))))
-                record.vat = vat[0]
-            elif not record.vat:
-                record.vat = False
-
     @api.depends("residence_country_id")
     def _compute_country_id(self):
         if hasattr(super(), "_compute_country_id"):
@@ -810,9 +794,8 @@ class ResPartner(models.Model):
 
     def _check_enought_invoice_data(self):
         self.ensure_one()
-        if self.vat and self.country_id and self.city and self.street:
-            return True
-        return False
+        # Template to be inherited by localization modules
+        return True
 
     def unlink(self):
         dummy, various_partner_id = self.env["ir.model.data"].get_object_reference(

pms/models/res_partner_id_category.py

@@ -1,11 +0,0 @@
-from odoo import fields, models
-
-
-class ResPartnerIdCategory(models.Model):
-    _inherit = "res.partner.id_category"
-
-    is_vat_equivalent = fields.Boolean(
-        string="Is VAT Equivalent",
-        help="If true, this document type is check by vat number",
-        default=False,
-    )

pms/tests/test_pms_folio_invoice.py

@@ -76,7 +76,7 @@ class TestPmsFolioInvoice(TestPms):
         self.partner_id = self.env["res.partner"].create(
             {
                 "name": "Miguel",
-                "vat": "ES123456789",
+                "vat": "45224522J",
                 "country_id": self.env.ref("base.es").id,
                 "city": "Madrid",
                 "zip": "28013",
@@ -719,7 +719,7 @@ class TestPmsFolioInvoice(TestPms):
         self.partner_id2 = self.env["res.partner"].create(
             {
                 "name": "Sara",
-                "vat": "ES123456787",
+                "vat": "54235544A",
                 "country_id": self.env.ref("base.es").id,
                 "city": "Madrid",
                 "zip": "28013",

pms/tests/test_pms_reservation.py

@@ -2995,10 +2995,14 @@ class TestPmsReservations(TestPms):
         # ACTION
         reservation.action_cancel()
         reservation.flush()
-        expected_price = (
-            self.service.price_total
-            + self.board_service.price_total * reservation.adults
-        ) - reservation.services_discount
+        expected_price = round(
+            (
+                self.service.price_total
+                + self.board_service.price_total * reservation.adults
+            )
+            - reservation.services_discount,
+            2,
+        )
 
         # ASSERT
         self.assertEqual(

pms/views/res_partner_id_category.xml

@@ -1,15 +0,0 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<odoo>
-    <record id="view_partner_id_category_form" model="ir.ui.view">
-        <field name="model">res.partner.id_category</field>
-        <field
-            name="inherit_id"
-            ref="partner_identification.view_partner_id_category_form"
-        />
-        <field name="arch" type="xml">
-            <xpath expr="//field[@name='code']" position="after">
-               <field name="is_vat_equivalent" />
-            </xpath>
-        </field>
-    </record>
-</odoo>