From c74199f23ad74df01fef4ccd58fdec149ff57e29 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dar=C3=ADo=20Lodeiros?= <dario@commitsun.com>
Date: Sat, 8 Jan 2022 18:10:12 +0100
Subject: [PATCH] [IMP]pms: compute pending amount journal move search

---
 pms/models/pms_folio.py | 45 ++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 23 deletions(-)

diff --git a/pms/models/pms_folio.py b/pms/models/pms_folio.py
index fec47b6a3..f4b5f9a11 100644
--- a/pms/models/pms_folio.py
+++ b/pms/models/pms_folio.py
@@ -982,31 +982,30 @@ class PmsFolio(models.Model):
                     automatic_included=True
                 )
                 paid_out = 0
-                for journal in journals:
-                    paid_out += sum(
-                        self.env["account.move.line"]
-                        .search(
-                            [
-                                ("folio_ids", "in", record.id),
-                                (
-                                    "account_id",
-                                    "in",
-                                    tuple(
-                                        journal.default_account_id.ids
-                                        + journal.payment_debit_account_id.ids
-                                        + journal.payment_credit_account_id.ids
-                                    ),
+                paid_out += sum(
+                    self.env["account.move.line"]
+                    .search(
+                        [
+                            ("folio_ids", "in", record.id),
+                            (
+                                "account_id",
+                                "in",
+                                tuple(
+                                    journals.default_account_id.ids
+                                    + journals.payment_debit_account_id.ids
+                                    + journals.payment_credit_account_id.ids
                                 ),
-                                (
-                                    "display_type",
-                                    "not in",
-                                    ("line_section", "line_note"),
-                                ),
-                                ("move_id.state", "!=", "cancel"),
-                            ]
-                        )
-                        .mapped("balance")
+                            ),
+                            (
+                                "display_type",
+                                "not in",
+                                ("line_section", "line_note"),
+                            ),
+                            ("move_id.state", "!=", "cancel"),
+                        ]
                     )
+                    .mapped("balance")
+                )
                 total = record.amount_total
                 # REVIEW: Must We ignored services in cancelled folios
                 # pending amount?