audrius/pms
1
0
Fork 1
mirror of https://github.com/OCA/pms.git synced 2025-01-29 00:17:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] pms: xls checkin partners export & validate fields import (#34)

Browse Source 
* [FIX] pms: fix xls checkin partners export & validate fields import

* [FIX] pms: fix last commit file missing
This commit is contained in:
Miguel Padin
2021-01-07 11:20:07 +01:00
committed by GitHub
parent ed74fe1764
commit 8b429b4da5
4 changed files with 104 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
pms/tests/test_pms_checkin_partner.py
View File

@@ -382,3 +382,77 @@ class TestPmsCheckinPartner(TestHotel):
1,
"Reservations not set like No checkout",
)
def test_not_valid_emails(self):
# TEST CASES
# emails that should be detected as incorrect
# ARRANGE
test_cases = [
"myemail",
"myemail@",
"myemail@",
"myemail@.com",
".myemail",
".myemail@",
".myemail@.com" ".myemail@.com." "123myemail@aaa.com",
]
for mail in test_cases:
with self.subTest(i=mail):
with self.assertRaises(ValidationError):
self.env["pms.checkin.partner"].create({"email": mail})
def test_valid_emails(self):
# TEST CASES
# emails that should be detected as correct
# ARRANGE
test_cases = [
"hello@commitsun.com",
"hi.welcome@commitsun.com",
"hi.welcome@dev.commitsun.com",
"hi.welcome@dev-commitsun.com",
"john.doe@xxx.yyy.zzz",
]
for mail in test_cases:
with self.subTest(i=mail):
guest = self.env["pms.checkin.partner"].create({"email": mail})
self.assertEqual(
mail,
guest.email,
)
def test_not_valid_phone(self):
# TEST CASES
# phones that should be detected as incorrect
# ARRANGE
test_cases = [
"phone",
"123456789123",
"123.456.789",
"123",
"123123",
]
for phone in test_cases:
with self.subTest(i=phone):
with self.assertRaises(ValidationError):
self.env["pms.checkin.partner"].create({"mobile": phone})
def test_valid_phones(self):
# TEST CASES
# emails that should be detected as incorrect
# ARRANGE
test_cases = [
"981 981 981",
"981981981",
"981 98 98 98",
]
for mobile in test_cases:
with self.subTest(i=mobile):
guest = self.env["pms.checkin.partner"].create({"mobile": mobile})
self.assertEqual(
mobile,
guest.mobile,
)