From 8893ba47c56c011a16fe9ff4ec3149b0c2d348d6 Mon Sep 17 00:00:00 2001 From: miguelpadin Date: Fri, 11 Jun 2021 01:14:26 +0200 Subject: [PATCH] [REF] pms: refactor board service room type line tests --- pms/tests/test_pms_board_service_line.py | 6 +- .../test_pms_board_service_room_type_line.py | 146 +++++++++--------- 2 files changed, 76 insertions(+), 76 deletions(-) diff --git a/pms/tests/test_pms_board_service_line.py b/pms/tests/test_pms_board_service_line.py index 1cb062dde..21e3d6d4b 100644 --- a/pms/tests/test_pms_board_service_line.py +++ b/pms/tests/test_pms_board_service_line.py @@ -4,7 +4,7 @@ from .common import TestPms class TestPmsBoardService(TestPms): - def test_pms_board_service_line_product_property_integrity(self): + def test_pms_bsl_product_property_integrity(self): """ Creation of a board service line without property, of a product only available for a specific property. @@ -30,7 +30,7 @@ class TestPmsBoardService(TestPms): } ) - def test_pms_board_service_line_board_service_integrity(self): + def test_pms_bsl_board_service_property_integrity(self): """ Creation of a board service line without property, of board service only available for a specific property. @@ -65,7 +65,7 @@ class TestPmsBoardService(TestPms): } ) - def test_pms_board_service_line_board_service_line_integrity(self): + def test_pms_bsl_board_service_line_prop_integrity(self): """ Creation of a board service line with a specific property, of board service without property. diff --git a/pms/tests/test_pms_board_service_room_type_line.py b/pms/tests/test_pms_board_service_room_type_line.py index 6311c8cc7..62b44feb3 100644 --- a/pms/tests/test_pms_board_service_room_type_line.py +++ b/pms/tests/test_pms_board_service_room_type_line.py @@ -1,95 +1,95 @@ from odoo.exceptions import UserError -from odoo.tests import common + +from .common import TestPms -class TestPmsBoardServiceRoomTypeLine(common.SavepointCase): - def test_check_product_property_integrity(self): - self.company1 = self.env["res.company"].create( - { - "name": "Pms_Company_Test", - } +class TestPmsBoardServiceRoomTypeLine(TestPms): + def test_pms_bsrtl_product_property_integrity(self): + """ + Creation of a board service room type line without property, of a product + only available for a specific property. + """ + # ARRANGE + + product = self.env["product.product"].create( + {"name": "Product", "pms_property_ids": self.pms_property1} ) - self.folio_sequence = self.env["ir.sequence"].create( - { - "name": "PMS Folio", - "code": "pms.folio", - "padding": 4, - "company_id": self.company1.id, - } - ) - self.reservation_sequence = self.env["ir.sequence"].create( - { - "name": "PMS Reservation", - "code": "pms.reservation", - "padding": 4, - "company_id": self.company1.id, - } - ) - self.checkin_sequence = self.env["ir.sequence"].create( - { - "name": "PMS Checkin", - "code": "pms.checkin.partner", - "padding": 4, - "company_id": self.company1.id, - } - ) - self.property1 = self.env["pms.property"].create( - { - "name": "Pms_property_test1", - "company_id": self.company1.id, - "default_pricelist_id": self.env.ref("product.list0").id, - "folio_sequence_id": self.folio_sequence.id, - "reservation_sequence_id": self.reservation_sequence.id, - "checkin_sequence_id": self.checkin_sequence.id, - } - ) - self.property2 = self.env["pms.property"].create( - { - "name": "Pms_property_test2", - "company_id": self.company1.id, - "default_pricelist_id": self.env.ref("product.list0").id, - "folio_sequence_id": self.folio_sequence.id, - "reservation_sequence_id": self.reservation_sequence.id, - "checkin_sequence_id": self.checkin_sequence.id, - } - ) - self.board_service = self.env["pms.board.service"].create( + board_service = self.env["pms.board.service"].create( { "name": "Board Service", "default_code": "CB", - "pms_property_ids": self.property1, } ) - self.room_type_class = self.env["pms.room.type.class"].create( - { - "name": "Room Type Class", - "default_code": "SIN1", - "pms_property_ids": self.property1, - } - ) - self.room_type = self.env["pms.room.type"].create( + room_type = self.env["pms.room.type"].create( { "name": "Room Type", "default_code": "Type1", - "pms_property_ids": self.property1, - "class_id": self.room_type_class.id, + "class_id": self.room_type_class1.id, } ) - self.board_service_room_type = self.env["pms.board.service.room.type"].create( + board_service_room_type = self.env["pms.board.service.room.type"].create( { - "pms_board_service_id": self.board_service.id, - "pms_room_type_id": self.room_type.id, - "pms_property_ids": self.property1, + "pms_board_service_id": board_service.id, + "pms_room_type_id": room_type.id, } ) - self.product = self.env["product.product"].create( - {"name": "Product", "pms_property_ids": self.property2} - ) - with self.assertRaises(UserError): + # ACT & ASSERT + with self.assertRaises( + UserError, msg="Board service room type line shouldnt be created." + ): self.env["pms.board.service.room.type.line"].create( { - "pms_board_service_room_type_id": self.board_service_room_type.id, - "product_id": self.product.id, + "pms_board_service_room_type_id": board_service_room_type.id, + "product_id": product.id, + } + ) + + def test_pms_bsrtl_board_service_line_prop_integrity(self): + """ + Creation of a board service room type line with a specific property, + of board service without property. + """ + # ARRANGE + pms_property2 = self.env["pms.property"].create( + { + "name": "Property 1", + "company_id": self.company1.id, + "default_pricelist_id": self.pricelist1.id, + } + ) + product = self.env["product.product"].create( + {"name": "Product", "pms_property_ids": [self.pms_property1.id]} + ) + board_service = self.env["pms.board.service"].create( + { + "name": "Board Service", + "default_code": "CB", + } + ) + + room_type = self.env["pms.room.type"].create( + { + "name": "Room Type", + "default_code": "Type1", + "class_id": self.room_type_class1.id, + } + ) + board_service_room_type = self.env["pms.board.service.room.type"].create( + { + "pms_board_service_id": board_service.id, + "pms_room_type_id": room_type.id, + } + ) + + # ACT & ASSERT + with self.assertRaises( + UserError, msg="Board service line shouldnt be created." + ): + self.env["pms.board.service.room.type.line"].create( + { + "product_id": product.id, + "pms_property_ids": [pms_property2.id], + "pms_board_service_room_type_id": board_service_room_type.id, } )