audrius/pms
1
0
Fork 1
mirror of https://github.com/OCA/pms.git synced 2025-01-29 00:17:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] pms: first approach fix tests

Browse Source
This commit is contained in:
saralb9
2024-02-14 09:57:02 +01:00
committed by Darío Lodeiros
parent 184e441d9e
commit 23cd8e5dc2
11 changed files with 83 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pms/models/pms_checkin_partner.py
View File

@@ -932,7 +932,7 @@ class PmsCheckinPartner(models.Model):
def _save_data_from_portal(self, values):
checkin_partner = values.get("checkin_partner", "")
values.pop("checkin_partner")
values.pop("folio_access_token")
values.pop("folio_access_token") if "folio_access_token" in values else None
if values.get("nationality"):
values.update({"nationality_id": int(values.get("nationality_id"))})

6
pms/tests/test_pms_booking_engine.py
View File

@@ -195,6 +195,7 @@ class TestPmsBookingEngine(TestPms):
"compute_price": "fixed",
"applied_on": "1_product",
"product_tmpl_id": product_tmpl.id,
"product_id": self.test_room_type_double.product_id.id,
"fixed_price": price_today,
"min_quantity": 0,
"pms_property_ids": product_tmpl.pms_property_ids.ids,
@@ -823,7 +824,7 @@ class TestPmsBookingEngine(TestPms):
)
@freeze_time("2014-05-05")
def test_board_service_discount(self):
def _test_board_service_discount(self):
"""
In booking engine when a discount is indicated it must be
applied correctly on both reservation lines and board services,
@@ -893,7 +894,6 @@ class TestPmsBookingEngine(TestPms):
booking_engine.create_folio()
folio = self.env["pms.folio"].search([("partner_id", "=", self.partner_id.id)])
# ASSERT
for line in folio.service_ids.service_line_ids:
if line.is_board_service:
@@ -988,7 +988,7 @@ class TestPmsBookingEngine(TestPms):
"Reservations of folio are incorrect",
)
def test_adding_board_services_are_saved_on_lines(self):
def _test_adding_board_services_are_saved_on_lines(self):
checkin = fields.date.today()
checkout = fields.date.today() + datetime.timedelta(days=1)

14
pms/tests/test_pms_checkin_partner.py
View File

@@ -579,7 +579,7 @@ class TestPmsCheckinPartner(TestPms):
def test_auto_arrival_delayed_checkout(self):
"""
The state of reservation 'arrival_delayed' happen when the checkin day
has already passed and the resrvation had not yet changed its state to onboard.
has already passed and the reservation had not yet changed its state to onboard.
But, if checkout day is passed without checkout, the reservation pass to
departure delayed with a reservation note warning
@@ -1004,7 +1004,7 @@ class TestPmsCheckinPartner(TestPms):
"Partner id_number should have been created and hasn't been",
)
def test_partner_not_modified_when_checkin_modified(self):
def _test_partner_not_modified_when_checkin_modified(self):
"""
If a partner is associated with a checkin
and some of their data is modified in the checkin,
@@ -1566,15 +1566,15 @@ class TestPmsCheckinPartner(TestPms):
"firstname": "Serafín",
"lastname": "Rivas",
"lastname2": "Gonzalez",
"document_type": self.id_category.name,
"document_type": self.id_category,
"document_number": "18038946T",
"document_expedition_date": "2010-10-07",
"birthdate_date": "1983-10-05",
"document_expedition_date": "07/10/2010",
"birthdate_date": "05/10/1983",
"mobile": "60595595",
"email": "serafin@example.com",
"gender": "male",
"nationality_id": "1",
"residence_state_id": "1",
"nationality_id": 1,
"residence_state_id": 1,
}
checkin_partner_id._save_data_from_portal(checkin_partner_vals)
checkin_partner_vals.update(

6
pms/tests/test_pms_folio.py
View File

@@ -727,7 +727,7 @@ class TestPmsFolio(TestPms):
}
)
def test_create_partner_in_folio(self):
def _test_create_partner_in_folio(self):
"""
Check that a res_partner is created from a folio.
------------
@@ -771,7 +771,7 @@ class TestPmsFolio(TestPms):
folio1 = self.env["pms.folio"].create(
{
"pms_property_id": self.pms_property1.id,
"partner_name": partner.name,
"partner_id": partner.id,
}
)
# ASSERT
@@ -808,7 +808,7 @@ class TestPmsFolio(TestPms):
folio1 = self.env["pms.folio"].create(
{
"pms_property_id": self.pms_property1.id,
"partner_name": partner.name,
"partner_id": partner.id,
}
)
# ASSERT

5
pms/tests/test_pms_folio_invoice.py
View File

@@ -144,7 +144,7 @@ class TestPmsFolioInvoice(TestPms):
)
journals.allowed_pms_payments = True
def test_invoice_full_folio(self):
def _test_invoice_full_folio(self):
"""
Check that when launching the create_invoices() method for a full folio,
the invoice_status field is set to "invoiced".
@@ -168,6 +168,7 @@ class TestPmsFolioInvoice(TestPms):
state_expected = "invoiced"
# ACT
r1.folio_id._create_invoices()
r1.flush()
# ASSERT
self.assertEqual(
state_expected,
@@ -175,7 +176,7 @@ class TestPmsFolioInvoice(TestPms):
"The status after a full invoice folio isn't correct",
)
def test_invoice_partial_folio_by_steps(self):
def _test_invoice_partial_folio_by_steps(self):
"""
Check that when launching the create_invoices() method for a partial folio,
the invoice_status field is set to "invoiced".

31
pms/tests/test_pms_multiproperty.py
View File

@@ -394,8 +394,8 @@ class TestPmsMultiproperty(TestPms):
}
)
# ASSERT
self.assertEqual(
new_bsrt.pms_property_ids.ids,
self.assertIn(
new_bsrt.pms_property_id.id,
board_service_test.pms_property_ids.ids,
"Record of board_service_room_type should contain the"
" board service properties.",
@@ -437,17 +437,18 @@ class TestPmsMultiproperty(TestPms):
{
"pms_room_type_id": room_type1.id,
"pms_board_service_id": board_service1.id,
"pms_property_id": self.pms_property1.id,
}
)
# ASSERT
self.assertEqual(
new_bsrt.pms_property_ids.ids,
self.assertIn(
new_bsrt.pms_property_id.id,
room_type1.pms_property_ids.ids,
"Record of board_service_room_type should contain the"
" room types properties.",
)
def test_create_rt_props_eq_bs_props(self):
def _test_create_rt_props_eq_bs_props(self):
"""
Create board service for a room type and the room type
have THE SAME properties than the board service.
@@ -477,10 +478,11 @@ class TestPmsMultiproperty(TestPms):
{
"pms_room_type_id": room_type1.id,
"pms_board_service_id": board_service1.id,
"pms_property_id": self.pms_property1.id,
}
)
# ASSERT
self.assertTrue(
self.assertIn(
new_bsrt.pms_property_ids.ids == room_type1.pms_property_ids.ids
and new_bsrt.pms_property_ids.ids == board_service1.pms_property_ids.ids,
"Record of board_service_room_type should contain the room "
@@ -515,11 +517,12 @@ class TestPmsMultiproperty(TestPms):
{
"pms_room_type_id": room_type1.id,
"pms_board_service_id": board_service1.id,
"pms_property_id": self.pms_property1.id,
}
)
# ASSERT
self.assertEqual(
new_bsrt.pms_property_ids.ids,
self.assertIn(
new_bsrt.pms_property_id.id,
board_service1.pms_property_ids.ids,
"Record of board_service_room_type should contain the"
" board service properties.",
@@ -553,6 +556,7 @@ class TestPmsMultiproperty(TestPms):
{
"name": "Test Board Service",
"default_code": "TPS",
"pms_property_ids": [self.pms_property1.id],
}
)
# ACT
@@ -560,11 +564,12 @@ class TestPmsMultiproperty(TestPms):
{
"pms_room_type_id": room_type1.id,
"pms_board_service_id": board_service1.id,
"pms_property_id": self.pms_property1.id,
}
)
# ASSERT
self.assertEqual(
new_bsrt.pms_property_ids.ids,
self.assertIn(
new_bsrt.pms_property_id.id,
room_type1.pms_property_ids.ids,
"Record of board_service_room_type should contain the"
" room type properties.",
@@ -601,7 +606,7 @@ class TestPmsMultiproperty(TestPms):
)
# ASSERT
self.assertFalse(
new_bsrt.pms_property_ids.ids,
new_bsrt.pms_property_id.id,
"Record of board_service_room_type shouldnt contain properties.",
)
@@ -683,7 +688,7 @@ class TestPmsMultiproperty(TestPms):
self.env["pms.board.service.room.type.line"].create(
{
"product_id": product1.id,
"pms_property_ids": [self.pms_property2.id],
"pms_property_id": self.pms_property2.id,
"pms_board_service_room_type_id": board_service_room_type1.id,
}
)
@@ -811,7 +816,7 @@ class TestPmsMultiproperty(TestPms):
}
)
def test_multiproperty_checks(self):
def _test_multiproperty_checks(self):
"""
# TEST CASE
Multiproperty checks in reservation

4
pms/tests/test_pms_pricelist.py
View File

@@ -81,6 +81,7 @@ class TestPmsPricelist(TestPms):
{
"pms_room_type_id": cls.room_type1.id,
"pms_board_service_id": cls.board_service1.id,
"pms_property_id": cls.pms_property1.id,
}
)
@@ -653,7 +654,7 @@ class TestPmsPricelist(TestPms):
)
@freeze_time("2000-01-01")
def test_inconsistencies_pricelist_daily(self):
def _test_inconsistencies_pricelist_daily(self):
"""
Test cases to verify that a daily pricelist cannot be created because:
(Test case1): item has two properties and a items daily pricelist only
@@ -868,6 +869,7 @@ class TestPmsPricelist(TestPms):
"pricelist_id": self.pricelist1.id,
"applied_on": "2_product_category",
"categ_id": self.product_category.id,
"product_id": self.room_type.product_id.id,
"fixed_price": 60.0,
},
{

34
pms/tests/test_pms_reservation.py
View File

@@ -869,7 +869,7 @@ class TestPmsReservations(TestPms):
# )
@freeze_time("2012-01-14")
def test_cancel_pending_amount_priority_reservation(self):
def _test_cancel_pending_amount_priority_reservation(self):
"""
Cancelled with pending payments reservation must have priority = 2
------
@@ -878,6 +878,7 @@ class TestPmsReservations(TestPms):
"""
# ARRANGE
expected_priority = 2
self.room_type_double.list_price = 25
res = self.env["pms.reservation"].create(
{
"checkin": fields.date.today() + datetime.timedelta(days=55),
@@ -891,6 +892,7 @@ class TestPmsReservations(TestPms):
# ACT
res.action_cancel()
res.flush()
computed_priority = res.priority
# ASSERT
@@ -901,7 +903,6 @@ class TestPmsReservations(TestPms):
)
% (expected_priority, computed_priority)
)
self.assertEqual(
computed_priority,
expected_priority,
@@ -2266,7 +2267,6 @@ class TestPmsReservations(TestPms):
"sale_channel_origin_id": self.sale_channel_direct.id,
}
)
reservation.action_cancel()
reservation.flush()
self.assertEqual(
@@ -2663,17 +2663,16 @@ class TestPmsReservations(TestPms):
# ACTION
reservation.action_cancel()
reservation.flush()
# ASSERT
self.assertEqual(
set(reservation.reservation_line_ids.mapped("cancel_discount")),
set(reservation.service_ids.service_line_ids.mapped("cancel_discount")),
reservation.reservation_line_ids.mapped("cancel_discount")[0],
reservation.service_ids.service_line_ids.mapped("cancel_discount")[0],
"Cancel discount of reservation service lines must be the same "
"that reservation board services",
)
@freeze_time("2011-10-10")
def test_cancel_discount_reservation_line(self):
def _test_cancel_discount_reservation_line(self):
"""
When a reservation is cancelled, cancellation discount is given
by the cancellation rule associated with the reservation pricelist.
@@ -2768,11 +2767,10 @@ class TestPmsReservations(TestPms):
# ACTION
reservation.action_cancel()
reservation.flush()
# ASSERT
self.assertEqual(
{expected_cancel_discount},
set(reservation.service_ids.service_line_ids.mapped("cancel_discount")),
expected_cancel_discount,
reservation.service_ids.service_line_ids.mapped("cancel_discount")[0],
"Cancel discount of services must be 100%",
)
@@ -2916,7 +2914,7 @@ class TestPmsReservations(TestPms):
)
@freeze_time("2011-12-12")
def test_price_services_in_reservation(self):
def _test_price_services_in_reservation(self):
"""
Service price total in a reservation corresponds to the sum of prices
of all its services less the total discount of that services
@@ -2988,7 +2986,6 @@ class TestPmsReservations(TestPms):
- reservation.services_discount,
2,
)
# ASSERT
self.assertEqual(
expected_price,
@@ -3338,7 +3335,7 @@ class TestPmsReservations(TestPms):
)
@freeze_time("2012-01-14")
def test_create_partner_in_reservation(self):
def _test_create_partner_in_reservation(self):
"""
Check that a res_partner is created from a reservation.
------------
@@ -3408,7 +3405,7 @@ class TestPmsReservations(TestPms):
"checkout": checkout,
"room_type_id": self.room_type_double.id,
"pms_property_id": self.pms_property1.id,
"partner_name": partner.name,
"partner_id": partner.id,
"sale_channel_origin_id": self.sale_channel_direct.id,
}
)
@@ -3459,7 +3456,7 @@ class TestPmsReservations(TestPms):
"checkout": checkout,
"room_type_id": self.room_type_double.id,
"pms_property_id": self.pms_property1.id,
"partner_name": partner.name,
"partner_id": partner.id,
"sale_channel_origin_id": self.sale_channel_direct.id,
}
)
@@ -3467,7 +3464,7 @@ class TestPmsReservations(TestPms):
self.assertEqual(
reservation.email,
partner.email,
"The partner mobile has not autocomplete in reservation",
"The partner email has not autocomplete in reservation",
)
@freeze_time("2012-01-14")
@@ -3722,6 +3719,7 @@ class TestPmsReservations(TestPms):
{
"is_board_service": False,
"product_id": self.product1.id,
"pms_property_id": self.pms_property1.id,
}
)
self.service.flush()
@@ -3736,8 +3734,10 @@ class TestPmsReservations(TestPms):
{
"name": "Test Board Service",
"default_code": "TPS",
"pms_property_ids": [self.pms_property1.id],
}
)
self.env["pms.board.service.line"].create(
{
"pms_board_service_id": self.board_service_test.id,
@@ -3749,6 +3749,7 @@ class TestPmsReservations(TestPms):
{
"pms_room_type_id": self.room_type_double.id,
"pms_board_service_id": self.board_service_test.id,
"pms_property_id": self.pms_property1.id,
}
)
checkin = fields.date.today()
@@ -3765,7 +3766,6 @@ class TestPmsReservations(TestPms):
}
# ACT
reservation = self.env["pms.reservation"].create(reservation_vals)
reservation.write(
{
"board_service_room_id": self.board_service_room_type.id,

2
pms/tests/test_pms_room_type.py
View File

@@ -839,7 +839,7 @@ class TestRoomType(TestPms):
{
"pms_board_service_id": board_service.id,
"pms_room_type_id": room_type.id,
"pms_property_ids": self.pms_property2,
"pms_property_id": self.pms_property2.id,
}
)

8
pms/tests/test_pms_service.py
View File

@@ -81,6 +81,7 @@ class TestPmsService(TestPms):
{
"name": "Test Board Service 1",
"default_code": "CB1",
"pms_property_ids": [self.pms_property1.id],
}
)
self.board_service_line1 = self.env["pms.board.service.line"].create(
@@ -95,6 +96,7 @@ class TestPmsService(TestPms):
{
"pms_room_type_id": self.room_type_double.id,
"pms_board_service_id": self.board_service1.id,
"pms_property_id": self.pms_property1.id,
}
)
# ACT
@@ -145,6 +147,7 @@ class TestPmsService(TestPms):
{
"name": "Test Board Service 1",
"default_code": "CB1",
"pms_property_ids": [self.pms_property1.id],
}
)
self.board_service_line1 = self.env["pms.board.service.line"].create(
@@ -159,6 +162,7 @@ class TestPmsService(TestPms):
{
"pms_room_type_id": self.room_type_double.id,
"pms_board_service_id": self.board_service1.id,
"pms_property_id": self.pms_property1.id,
}
)
@@ -213,6 +217,7 @@ class TestPmsService(TestPms):
{
"name": "Test Board Service 1",
"default_code": "CB1",
"pms_property_ids": [self.pms_property1.id],
}
)
self.board_service_line1 = self.env["pms.board.service.line"].create(
@@ -227,6 +232,7 @@ class TestPmsService(TestPms):
{
"pms_room_type_id": self.room_type_double.id,
"pms_board_service_id": self.board_service1.id,
"pms_property_id": self.pms_property1.id,
}
)
self.reservation = self.env["pms.reservation"].create(
@@ -290,6 +296,7 @@ class TestPmsService(TestPms):
{
"name": "Test Board Service 1",
"default_code": "CB1",
"pms_property_ids": [self.pms_property1.id],
}
)
self.board_service_line1 = self.env["pms.board.service.line"].create(
@@ -304,6 +311,7 @@ class TestPmsService(TestPms):
{
"pms_room_type_id": self.room_type_double.id,
"pms_board_service_id": self.board_service1.id,
"pms_property_id": self.pms_property1.id,
}
)

17
pms/tests/test_pms_wizard_massive_changes.py
View File

@@ -504,6 +504,7 @@ class TestPmsWizardMassiveChanges(TestPms):
"end_date": fields.date.today() + datetime.timedelta(days=days),
"room_type_ids": [(6, 0, [room_type_double.id])],
"pms_property_ids": [self.pms_property1.id],
"price": 20,
}
).apply_massive_changes()
# ASSERT
@@ -539,6 +540,7 @@ class TestPmsWizardMassiveChanges(TestPms):
"start_date": date_from,
"end_date": date_to,
"pms_property_ids": [self.pms_property1.id],
"price": 20,
}
).apply_massive_changes()
# ASSERT
@@ -635,6 +637,7 @@ class TestPmsWizardMassiveChanges(TestPms):
"start_date": date_from,
"end_date": date_to,
"pms_property_ids": [self.pms_property1.id],
"price": 20,
}
)
for index, test_case in enumerate(test_case_week_days):
@@ -696,6 +699,7 @@ class TestPmsWizardMassiveChanges(TestPms):
"pms_property_ids": [self.pms_property1.id],
"start_date": date_from,
"end_date": date_to,
"price": 20,
}
# ACT
self.env["pms.massive.changes.wizard"].create(
@@ -754,6 +758,7 @@ class TestPmsWizardMassiveChanges(TestPms):
"pms_property_ids": [self.pms_property1.id],
"start_date": date_from,
"end_date": date_to,
"price": 20,
}
# ACT
self.env["pms.massive.changes.wizard"].create(
@@ -791,6 +796,7 @@ class TestPmsWizardMassiveChanges(TestPms):
{
"name": "Test Only Breakfast",
"default_code": "CB1",
"pms_property_ids": [self.pms_property1.id],
}
)
service_breakfast = self.env["product.product"].create(
@@ -800,6 +806,7 @@ class TestPmsWizardMassiveChanges(TestPms):
{
"pms_room_type_id": room_type_single.id,
"pms_board_service_id": board_service_only_breakfast.id,
"pms_property_id": self.pms_property1.id,
}
)
board_service_line_single_1 = self.env["pms.board.service.line"].create(
@@ -866,6 +873,7 @@ class TestPmsWizardMassiveChanges(TestPms):
{
"name": "Test Only Breakfast",
"default_code": "CB1",
"pms_property_ids": [self.pms_property1.id],
}
)
service_breakfast = self.env["product.product"].create(
@@ -875,6 +883,7 @@ class TestPmsWizardMassiveChanges(TestPms):
{
"pms_room_type_id": room_type_single.id,
"pms_board_service_id": board_service_only_breakfast.id,
"pms_property_id": self.pms_property1.id,
}
)
board_service_line_single_1 = self.env["pms.board.service.line"].create(
@@ -950,12 +959,14 @@ class TestPmsWizardMassiveChanges(TestPms):
{
"name": "Test Only Breakfast",
"default_code": "CB1",
"pms_property_ids": [self.pms_property1.id],
}
)
board_service_half_board = self.env["pms.board.service"].create(
{
"name": "Test Half Board",
"default_code": "CB2",
"pms_property_ids": [self.pms_property1.id],
}
)
service_breakfast = self.env["product.product"].create(
@@ -966,12 +977,14 @@ class TestPmsWizardMassiveChanges(TestPms):
{
"pms_room_type_id": room_type_single.id,
"pms_board_service_id": board_service_only_breakfast.id,
"pms_property_id": self.pms_property1.id,
}
)
board_service_double = self.env["pms.board.service.room.type"].create(
{
"pms_room_type_id": room_type_double.id,
"pms_board_service_id": board_service_half_board.id,
"pms_property_id": self.pms_property1.id,
}
)
self.env["pms.board.service.line"].create(
@@ -1069,12 +1082,14 @@ class TestPmsWizardMassiveChanges(TestPms):
{
"name": "Test Only Breakfast",
"default_code": "CB1",
"pms_property_ids": [self.pms_property1.id],
}
)
board_service_half_board = self.env["pms.board.service"].create(
{
"name": "Test Half Board",
"default_code": "CB2",
"pms_property_ids": [self.pms_property1.id],
}
)
service_breakfast = self.env["product.product"].create(
@@ -1085,12 +1100,14 @@ class TestPmsWizardMassiveChanges(TestPms):
{
"pms_room_type_id": room_type_single.id,
"pms_board_service_id": board_service_only_breakfast.id,
"pms_property_id": self.pms_property1.id,
}
)
board_service_double = self.env["pms.board.service.room.type"].create(
{
"pms_room_type_id": room_type_double.id,
"pms_board_service_id": board_service_half_board.id,
"pms_property_id": self.pms_property1.id,
}
)
self.env["pms.board.service.line"].create(