Code review (#62)

* [REF] pms: refactor amenity type

* [REF] pms: refactor amenity

* [REF]Refactor amenity views and demo data

* [WIP] master model 2nd day

* [WIP] Master model refactor

* [WIP] Refactor in tests

* [WIP] Add mandatory sequence in pms_property at tests and fix create in folio, reservation and checkin

* [WIP] Test refactor

* [WIP]Refactor pms_room, pms_room_clousure_reason and pms_room_type

* [WIP]review of guidelines in master models

* [WIP]test refactor

* [WIP]review guidelines in master models 2

* [WIP] fixed fields in pms_l10n_es

* [WIP]Refactor product_product, product_template, res_company, res_partner and res_user

* [IMP] Add common.py for tests

* [WIP] Refactor fields in pms.folio and pms.reservation

* [WIP] Review guidelines in pms.reservation, pms.reservation.line and rename availability models

* [WIP] Rename availability models

* [WIP] Refactor availability models

* [WIP] Refactor availity models 2

* [WIP] Pms: add sequences creation in pms_property create

* [WIP] Fix sequence creation in pmp.property

* [REF] Refactor fields in res_partner and rename date_overnight

* [REF] Refactoring master models tests

* [FIX] Fix sequence create in pms.reservation

* [REF] Refactor helps in master and availability models

* [IMP] Extend test coverage in test_pms_reservation

* [REF] Refactor fields in pms_reservation

* [REF] Refactor fields in pms_reservation 2

* [REF] Refactor fields in service flow

* [REF] Refactor pms_reservation

* [REF] Refactor pms_reservation 2

* [REF] draft button removed from view

* [REF] change no_show to arrival_delayed in field state of pms_reservation

* [REF] Add compute_preferred_room_id in pms_reservation

* [REF] Fix cache problem in test_reservation_action_checkout

Co-authored-by: braisab <braisterbutalino@gmail.com>
Co-authored-by: Sara Lago <saralago126@gmail.com>
Co-authored-by: Brais Abeijón <>

pms/wizards/wizard_folio.py

@@ -103,7 +103,7 @@ class FolioWizard(models.TransientModel):
                     ]
                 ):
                     num_rooms_available = self.env[
-                        "pms.room.type.availability.plan"
+                        "pms.availability.plan"
                     ].get_count_rooms_available(
                         checkin=record.start_date,
                         checkout=record.end_date,

pms/wizards/wizard_folio_availability.py

@@ -81,7 +81,7 @@ class AvailabilityWizard(models.TransientModel):
                     partner=partner.id,
                     quantity=1,
                     date=fields.Date.today(),
-                    date_overnight=date_iterator,
+                    consumption_date=date_iterator,
                     pricelist=record.folio_wizard_id.pricelist_id.id,
                     uom=product.uom_id.id,
                     property=record.folio_wizard_id.pms_property_id.id,
@@ -113,7 +113,7 @@ class AvailabilityWizard(models.TransientModel):
     def _compute_num_rooms_available(self):
         for record in self:
             record.num_rooms_available = self.env[
-                "pms.room.type.availability.plan"
+                "pms.availability.plan"
             ].get_count_rooms_available(
                 record.checkin,
                 record.checkout,

pms/wizards/wizard_massive_changes.py

@@ -30,7 +30,7 @@ class AvailabilityWizard(models.TransientModel):
         required=True,
     )
     availability_plan_id = fields.Many2one(
-        comodel_name="pms.room.type.availability.plan",
+        comodel_name="pms.availability.plan",
         string="Availability Plan to apply massive changes",
         # can be setted by context from availability plan detail
     )
@@ -169,7 +169,7 @@ class AvailabilityWizard(models.TransientModel):
     )
 
     rules_to_overwrite = fields.One2many(
-        comodel_name="pms.room.type.availability.rule",
+        comodel_name="pms.availability.plan.rule",
         compute="_compute_rules_to_overwrite",
         store=False,
         readonly=True,
@@ -275,7 +275,7 @@ class AvailabilityWizard(models.TransientModel):
                     record.apply_on_sunday,
                 )
                 if record.start_date and record.end_date:
-                    rules = self.env["pms.room.type.availability.rule"].search(domain)
+                    rules = self.env["pms.availability.plan.rule"].search(domain)
                     if (
                         not record.apply_on_all_week
                         and record.start_date
@@ -525,7 +525,7 @@ class AvailabilityWizard(models.TransientModel):
                                 )
                                 overwrite.write(vals)
                             else:
-                                self.env["pms.room.type.availability.rule"].create(
+                                self.env["pms.availability.plan.rule"].create(
                                     {
                                         "availability_plan_id": avail_plan_id,
                                         "date": date,
@@ -556,9 +556,9 @@ class AvailabilityWizard(models.TransientModel):
                 record.massive_changes_on == "availability_plan"
                 and not record.avail_readonly
             ):
-                action = self.env.ref("pms.room_type_availability_action").read()[0]
+                action = self.env.ref("pms.availability_action").read()[0]
                 action["views"] = [
-                    (self.env.ref("pms.room_type_availability_view_form").id, "form")
+                    (self.env.ref("pms.availability_view_form").id, "form")
                 ]
                 action["res_id"] = record.availability_plan_id.id
                 return action