Code review (#62)

* [REF] pms: refactor amenity type

* [REF] pms: refactor amenity

* [REF]Refactor amenity views and demo data

* [WIP] master model 2nd day

* [WIP] Master model refactor

* [WIP] Refactor in tests

* [WIP] Add mandatory sequence in pms_property at tests and fix create in folio, reservation and checkin

* [WIP] Test refactor

* [WIP]Refactor pms_room, pms_room_clousure_reason and pms_room_type

* [WIP]review of guidelines in master models

* [WIP]test refactor

* [WIP]review guidelines in master models 2

* [WIP] fixed fields in pms_l10n_es

* [WIP]Refactor product_product, product_template, res_company, res_partner and res_user

* [IMP] Add common.py for tests

* [WIP] Refactor fields in pms.folio and pms.reservation

* [WIP] Review guidelines in pms.reservation, pms.reservation.line and rename availability models

* [WIP] Rename availability models

* [WIP] Refactor availability models

* [WIP] Refactor availity models 2

* [WIP] Pms: add sequences creation in pms_property create

* [WIP] Fix sequence creation in pmp.property

* [REF] Refactor fields in res_partner and rename date_overnight

* [REF] Refactoring master models tests

* [FIX] Fix sequence create in pms.reservation

* [REF] Refactor helps in master and availability models

* [IMP] Extend test coverage in test_pms_reservation

* [REF] Refactor fields in pms_reservation

* [REF] Refactor fields in pms_reservation 2

* [REF] Refactor fields in service flow

* [REF] Refactor pms_reservation

* [REF] Refactor pms_reservation 2

* [REF] draft button removed from view

* [REF] change no_show to arrival_delayed in field state of pms_reservation

* [REF] Add compute_preferred_room_id in pms_reservation

* [REF] Fix cache problem in test_reservation_action_checkout

Co-authored-by: braisab <braisterbutalino@gmail.com>
Co-authored-by: Sara Lago <saralago126@gmail.com>
Co-authored-by: Brais Abeijón <>
This commit is contained in:
Miguel Padin
2021-04-15 01:01:11 +02:00
committed by GitHub
parent eace7de663
commit 0d03152402
79 changed files with 3920 additions and 2480 deletions

View File

@@ -619,10 +619,10 @@ msgid "Arrival Hour (GMT)"
msgstr "Hora de Llegada (GMT)"
#. module: pms
#: model:ir.model.fields,help:pms.field_pms_room__floor_id
#: model:ir.model.fields,help:pms.field_pms_shared_room__floor_id
msgid "At which floor the room is located."
msgstr "Piso en el que está localizada la habitación."
#: model:ir.model.fields,help:pms.field_pms_room__ubication_id
#: model:ir.model.fields,help:pms.field_pms_shared_room__ubication_id
msgid "At which ubication the room is located."
msgstr "Ubicación en la que está localizada la habitación."
#. module: pms
#: model:ir.model.fields,field_description:pms.field_pms_folio__message_attachment_count
@@ -1436,7 +1436,7 @@ msgstr "Creado por"
#: model:ir.model.fields,field_description:pms.field_pms_board_service_room_type_line__create_uid
#: model:ir.model.fields,field_description:pms.field_pms_cancelation_rule__create_uid
#: model:ir.model.fields,field_description:pms.field_pms_checkin_partner__create_uid
#: model:ir.model.fields,field_description:pms.field_pms_floor__create_uid
#: model:ir.model.fields,field_description:pms.field_pms_ubication__create_uid
#: model:ir.model.fields,field_description:pms.field_pms_folio__create_uid
#: model:ir.model.fields,field_description:pms.field_pms_folio_availability_wizard__create_uid
#: model:ir.model.fields,field_description:pms.field_pms_folio_wizard__create_uid
@@ -1473,7 +1473,7 @@ msgstr "Creado por"
#: model:ir.model.fields,field_description:pms.field_pms_board_service_room_type_line__create_date
#: model:ir.model.fields,field_description:pms.field_pms_cancelation_rule__create_date
#: model:ir.model.fields,field_description:pms.field_pms_checkin_partner__create_date
#: model:ir.model.fields,field_description:pms.field_pms_floor__create_date
#: model:ir.model.fields,field_description:pms.field_pms_ubication__create_date
#: model:ir.model.fields,field_description:pms.field_pms_folio__create_date
#: model:ir.model.fields,field_description:pms.field_pms_folio_availability_wizard__create_date
#: model:ir.model.fields,field_description:pms.field_pms_folio_wizard__create_date
@@ -1856,7 +1856,7 @@ msgstr "Descuento por cancelación"
#: model:ir.model.fields,field_description:pms.field_pms_board_service_room_type_line__display_name
#: model:ir.model.fields,field_description:pms.field_pms_cancelation_rule__display_name
#: model:ir.model.fields,field_description:pms.field_pms_checkin_partner__display_name
#: model:ir.model.fields,field_description:pms.field_pms_floor__display_name
#: model:ir.model.fields,field_description:pms.field_pms_ubication__display_name
#: model:ir.model.fields,field_description:pms.field_pms_folio__display_name
#: model:ir.model.fields,field_description:pms.field_pms_folio_availability_wizard__display_name
#: model:ir.model.fields,field_description:pms.field_pms_folio_wizard__display_name
@@ -2107,7 +2107,7 @@ msgid "First Day"
msgstr "Primer Día"
#. module: pms
#: model:pms.floor,name:pms.pms_floor_1
#: model:pms.ubication,name:pms.pms_ubication_1
msgid "First Floor"
msgstr "Primer Piso"
@@ -2124,7 +2124,7 @@ msgid "Fixed"
msgstr "Fijo"
#. module: pms
#: model:ir.actions.act_window,name:pms.open_pms_floor_form_tree
#: model:ir.actions.act_window,name:pms.open_pms_ubication_form_tree
msgid "Floor Structure"
msgstr "Estructura del Piso"
@@ -2360,7 +2360,7 @@ msgid "Gives the different ways to package the same product."
msgstr "Ofrece diferentes formas de empaquetar el mismo producto."
#. module: pms
#: model:pms.floor,name:pms.pms_floor_0
#: model:pms.ubication,name:pms.pms_ubication_0
msgid "Ground Floor"
msgstr "Planta Baja"
@@ -2463,7 +2463,7 @@ msgstr "Nombre del huésped"
#: model:ir.model.fields,field_description:pms.field_pms_board_service_room_type_line__id
#: model:ir.model.fields,field_description:pms.field_pms_cancelation_rule__id
#: model:ir.model.fields,field_description:pms.field_pms_checkin_partner__id
#: model:ir.model.fields,field_description:pms.field_pms_floor__id
#: model:ir.model.fields,field_description:pms.field_pms_ubication__id
#: model:ir.model.fields,field_description:pms.field_pms_folio__id
#: model:ir.model.fields,field_description:pms.field_pms_folio_availability_wizard__id
#: model:ir.model.fields,field_description:pms.field_pms_folio_wizard__id
@@ -3020,7 +3020,7 @@ msgstr "Lenguaje"
#: model:ir.model.fields,field_description:pms.field_pms_board_service_room_type_line____last_update
#: model:ir.model.fields,field_description:pms.field_pms_cancelation_rule____last_update
#: model:ir.model.fields,field_description:pms.field_pms_checkin_partner____last_update
#: model:ir.model.fields,field_description:pms.field_pms_floor____last_update
#: model:ir.model.fields,field_description:pms.field_pms_ubication____last_update
#: model:ir.model.fields,field_description:pms.field_pms_folio____last_update
#: model:ir.model.fields,field_description:pms.field_pms_folio_availability_wizard____last_update
#: model:ir.model.fields,field_description:pms.field_pms_folio_wizard____last_update
@@ -3064,7 +3064,7 @@ msgstr "Última modificación en"
#: model:ir.model.fields,field_description:pms.field_pms_board_service_room_type_line__write_uid
#: model:ir.model.fields,field_description:pms.field_pms_cancelation_rule__write_uid
#: model:ir.model.fields,field_description:pms.field_pms_checkin_partner__write_uid
#: model:ir.model.fields,field_description:pms.field_pms_floor__write_uid
#: model:ir.model.fields,field_description:pms.field_pms_ubication__write_uid
#: model:ir.model.fields,field_description:pms.field_pms_folio__write_uid
#: model:ir.model.fields,field_description:pms.field_pms_folio_availability_wizard__write_uid
#: model:ir.model.fields,field_description:pms.field_pms_folio_wizard__write_uid
@@ -3101,7 +3101,7 @@ msgstr "Última Actualización por"
#: model:ir.model.fields,field_description:pms.field_pms_board_service_room_type_line__write_date
#: model:ir.model.fields,field_description:pms.field_pms_cancelation_rule__write_date
#: model:ir.model.fields,field_description:pms.field_pms_checkin_partner__write_date
#: model:ir.model.fields,field_description:pms.field_pms_floor__write_date
#: model:ir.model.fields,field_description:pms.field_pms_ubication__write_date
#: model:ir.model.fields,field_description:pms.field_pms_folio__write_date
#: model:ir.model.fields,field_description:pms.field_pms_folio_availability_wizard__write_date
#: model:ir.model.fields,field_description:pms.field_pms_folio_wizard__write_date
@@ -4264,7 +4264,7 @@ msgstr "Prop. Demo Vistas"
#: model:ir.model.fields,field_description:pms.field_pms_board_service_line__pms_property_ids
#: model:ir.model.fields,field_description:pms.field_pms_board_service_room_type__pms_property_ids
#: model:ir.model.fields,field_description:pms.field_pms_cancelation_rule__pms_property_ids
#: model:ir.model.fields,field_description:pms.field_pms_floor__pms_property_ids
#: model:ir.model.fields,field_description:pms.field_pms_ubication__pms_property_ids
#: model:ir.model.fields,field_description:pms.field_pms_room_type__pms_property_ids
#: model:ir.model.fields,field_description:pms.field_pms_room_type_availability_plan__pms_property_ids
#: model:ir.model.fields,field_description:pms.field_pms_room_type_class__pms_property_ids
@@ -4332,12 +4332,12 @@ msgid "Property Type Class"
msgstr "Clase del Tipo de la propiedad"
#. module: pms
#: model_terms:ir.ui.view,arch_db:pms.pms_floor_view_form
#: model_terms:ir.ui.view,arch_db:pms.pms_ubication_view_form
msgid "Property Ubication"
msgstr "Ubicación de la Propiedad"
#. module: pms
#: model_terms:ir.ui.view,arch_db:pms.pms_floor_view_tree
#: model_terms:ir.ui.view,arch_db:pms.pms_ubication_view_tree
msgid "Property Ubications"
msgstr "Ubicaciones de la Propiedad"
@@ -4912,7 +4912,7 @@ msgid "Search"
msgstr "Buscar"
#. module: pms
#: model:pms.floor,name:pms.pms_floor_2
#: model:pms.ubication,name:pms.pms_ubication_2
msgid "Second Floor"
msgstr "Segundo Piso"
@@ -4971,7 +4971,7 @@ msgstr "Self"
#. module: pms
#: model:ir.model,name:pms.model_ir_sequence
#: model:ir.model.fields,field_description:pms.field_folio_sale_line__sequence
#: model:ir.model.fields,field_description:pms.field_pms_floor__sequence
#: model:ir.model.fields,field_description:pms.field_pms_ubication__sequence
#: model:ir.model.fields,field_description:pms.field_pms_folio__sequence
#: model:ir.model.fields,field_description:pms.field_pms_room__sequence
#: model:ir.model.fields,field_description:pms.field_pms_room_type__sequence
@@ -5874,21 +5874,21 @@ msgid "Types"
msgstr "Tipos"
#. module: pms
#: model:ir.model,name:pms.model_pms_floor
#: model:ir.model.fields,field_description:pms.field_pms_room__floor_id
#: model:ir.model.fields,field_description:pms.field_pms_shared_room__floor_id
#: model:ir.model,name:pms.model_pms_ubication
#: model:ir.model.fields,field_description:pms.field_pms_room__ubication_id
#: model:ir.model.fields,field_description:pms.field_pms_shared_room__ubication_id
#: model_terms:ir.ui.view,arch_db:pms.pms_room_view_form
#: model_terms:ir.ui.view,arch_db:pms.pms_shared_room_view_form
msgid "Ubication"
msgstr "Ubicación"
#. module: pms
#: model:ir.model.fields,field_description:pms.field_pms_floor__name
#: model:ir.model.fields,field_description:pms.field_pms_ubication__name
msgid "Ubication Name"
msgstr "Nombre de la Ubicación"
#. module: pms
#: model:ir.ui.menu,name:pms.menu_open_pms_floor_form_tree
#: model:ir.ui.menu,name:pms.menu_open_pms_ubication_form_tree
msgid "Ubications"
msgstr "Ubicaciones"