From 0009614669b914954b96beb8a5c3b27ffa101d0f Mon Sep 17 00:00:00 2001
From: miguelpadin <miguel.padin.dominguez@gmail.com>
Date: Mon, 21 Feb 2022 21:31:52 +0000
Subject: [PATCH] [FIX] pms: fix tests (reservation type out & required closure
 reason)

---
 pms/tests/test_pms_folio.py           |  7 +++++++
 pms/tests/test_pms_folio_sale_line.py |  7 +++++++
 pms/tests/test_pms_reservation.py     | 27 +++++++++++++++++++++++++--
 3 files changed, 39 insertions(+), 2 deletions(-)

diff --git a/pms/tests/test_pms_folio.py b/pms/tests/test_pms_folio.py
index 9831814e2..f80ca7715 100644
--- a/pms/tests/test_pms_folio.py
+++ b/pms/tests/test_pms_folio.py
@@ -565,6 +565,12 @@ class TestPmsFolio(TestPms):
         checkin = fields.date.today()
         checkout = fields.date.today() + datetime.timedelta(days=3)
         self.partner1 = self.env["res.partner"].create({"name": "Pedro"})
+        closure_reason = self.env["room.closure.reason"].create(
+            {
+                "name": "test closure reason",
+                "description": "test clopsure reason description",
+            }
+        )
         # ACT
         reservation = self.env["pms.reservation"].create(
             {
@@ -575,6 +581,7 @@ class TestPmsFolio(TestPms):
                 "pms_property_id": self.pms_property1.id,
                 "pricelist_id": self.pricelist1.id,
                 "reservation_type": "out",
+                "closure_reason_id": closure_reason.id,
             }
         )
         # ASSERT
diff --git a/pms/tests/test_pms_folio_sale_line.py b/pms/tests/test_pms_folio_sale_line.py
index ca0e3c951..b329d93f1 100644
--- a/pms/tests/test_pms_folio_sale_line.py
+++ b/pms/tests/test_pms_folio_sale_line.py
@@ -1234,6 +1234,12 @@ class TestPmsFolioSaleLine(TestPms):
         self.partner1 = self.env["res.partner"].create({"name": "Alberto"})
         checkin = fields.date.today()
         checkout = fields.date.today() + datetime.timedelta(days=3)
+        closure_reason = self.env["room.closure.reason"].create(
+            {
+                "name": "test closure reason",
+                "description": "test clopsure reason description",
+            }
+        )
         # ACT
         reservation = self.env["pms.reservation"].create(
             {
@@ -1244,6 +1250,7 @@ class TestPmsFolioSaleLine(TestPms):
                 "pms_property_id": self.pms_property1.id,
                 "pricelist_id": self.pricelist1.id,
                 "reservation_type": "out",
+                "closure_reason_id": closure_reason.id,
             }
         )
         # ASSERT
diff --git a/pms/tests/test_pms_reservation.py b/pms/tests/test_pms_reservation.py
index d2592cf76..bceb2c059 100644
--- a/pms/tests/test_pms_reservation.py
+++ b/pms/tests/test_pms_reservation.py
@@ -3062,6 +3062,12 @@ class TestPmsReservations(TestPms):
         # ARRANGE
         checkin = fields.date.today()
         checkout = fields.date.today() + datetime.timedelta(days=3)
+        closure_reason = self.env["room.closure.reason"].create(
+            {
+                "name": "test closure reason",
+                "description": "test clopsure reason description",
+            }
+        )
         # ACT
         self.room_type_double.write({"list_price": 30})
         reservation = self.env["pms.reservation"].create(
@@ -3073,6 +3079,7 @@ class TestPmsReservations(TestPms):
                 "pms_property_id": self.pms_property1.id,
                 "pricelist_id": self.pricelist1.id,
                 "reservation_type": "out",
+                "closure_reason_id": closure_reason.id,
             }
         )
         # ASSERT
@@ -3119,6 +3126,12 @@ class TestPmsReservations(TestPms):
         # ARRANGE
         checkin = fields.date.today()
         checkout = fields.date.today() + datetime.timedelta(days=3)
+        closure_reason = self.env["room.closure.reason"].create(
+            {
+                "name": "test closure reason",
+                "description": "test clopsure reason description",
+            }
+        )
         # ACT
         self.room_type_double.write({"list_price": 30})
         reservation = self.env["pms.reservation"].create(
@@ -3129,6 +3142,7 @@ class TestPmsReservations(TestPms):
                 "partner_id": self.partner1.id,
                 "pms_property_id": self.pms_property1.id,
                 "reservation_type": "out",
+                "closure_reason_id": closure_reason.id,
             }
         )
 
@@ -3176,7 +3190,7 @@ class TestPmsReservations(TestPms):
             "The reservation type of the folio should be 'staff'",
         )
 
-    def test_no_partner_id_out_reservation(self):
+    def _test_no_partner_id_out_reservation(self):
         """
         Check that a reservation of type out of service does not
         have a partner_id.
@@ -3188,6 +3202,12 @@ class TestPmsReservations(TestPms):
         # ARRANGE
         checkin = fields.date.today()
         checkout = fields.date.today() + datetime.timedelta(days=3)
+        closure_reason = self.env["room.closure.reason"].create(
+            {
+                "name": "test closure reason",
+                "description": "test clopsure reason description",
+            }
+        )
         # ACT
         reservation = self.env["pms.reservation"].create(
             {
@@ -3196,6 +3216,7 @@ class TestPmsReservations(TestPms):
                 "room_type_id": self.room_type_double.id,
                 "pms_property_id": self.pms_property1.id,
                 "reservation_type": "out",
+                "closure_reason_id": closure_reason.id,
                 "partner_name": "Install furniture",
             }
         )
@@ -3765,7 +3786,9 @@ class TestPmsReservations(TestPms):
         closure_reason = self.env["room.closure.reason"].create(
             {
                 "name": "Room revision",
-                "description": "Revision of lights, fire extinguishers, smoke detectors and emergency lights",
+                "description": "Revision of lights, "
+                "fire extinguishers, smoke detectors and "
+                "emergency lights",
             }
         )
         # ACT