From d8d7bf57936e2e3c7ae2fbcf38b3bc8c161b5df1 Mon Sep 17 00:00:00 2001 From: sergiocorato Date: Mon, 4 Mar 2024 11:18:15 +0100 Subject: [PATCH 1/2] [FIX] quality_control_stock_oca create trigger with a complete name --- quality_control_stock_oca/models/stock_picking_type.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quality_control_stock_oca/models/stock_picking_type.py b/quality_control_stock_oca/models/stock_picking_type.py index a0d1e1adb..4378757b0 100644 --- a/quality_control_stock_oca/models/stock_picking_type.py +++ b/quality_control_stock_oca/models/stock_picking_type.py @@ -11,7 +11,7 @@ class StockPickingType(models.Model): def _create_qc_trigger(self): for picking_type in self: qc_trigger = { - "name": picking_type.name, + "name": picking_type.display_name, "company_id": picking_type.warehouse_id.company_id.id, "picking_type_id": picking_type.id, "partner_selectable": True, From 8bc34719461dcf541a812e85e5ac76d604bb8e9c Mon Sep 17 00:00:00 2001 From: David Alonso // Solvos Date: Thu, 14 Sep 2023 18:52:28 +0200 Subject: [PATCH 2/2] [IMP] quality_control_stock_oca: picking types - use display_name for trigger name --- .../tests/test_quality_control_stock.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/quality_control_stock_oca/tests/test_quality_control_stock.py b/quality_control_stock_oca/tests/test_quality_control_stock.py index ecc82bfa0..9d42ededc 100644 --- a/quality_control_stock_oca/tests/test_quality_control_stock.py +++ b/quality_control_stock_oca/tests/test_quality_control_stock.py @@ -313,14 +313,14 @@ class TestQualityControl(TransactionCase): self.assertEqual(len(trigger), 1, "One trigger must have been created.") self.assertEqual( trigger.name, - picking_type.name, - "Trigger name must match picking type name.", + picking_type.display_name, + "Trigger name must match picking type display name.", ) picking_type.write({"name": "Test Name Change"}) self.assertEqual( trigger.name, - picking_type.name, - "Trigger name must match picking type name.", + picking_type.display_name, + "Trigger name must match picking type display name.", ) def test_qc_inspection_picking(self):