[FIX] all: fix pre-commit new checks

mrp_bom_component_menu/views/mrp_bom_component_view.xml

@@ -21,7 +21,7 @@
         <field name="name">mrp.bom.line.tree.view</field>
         <field name="model">mrp.bom.line</field>
         <field name="arch" type="xml">
-            <tree string="Components" create="1" edit="1" delete="1">
+            <tree create="1" edit="1" delete="1">
                 <field name="bom_id" />
                 <field name="product_id" />
                 <field name="product_qty" />

mrp_multi_level/views/mrp_area_views.xml

@@ -5,7 +5,7 @@
         <field name="model">mrp.area</field>
         <field name="type">tree</field>
         <field name="arch" type="xml">
-            <tree string="MRP Area">
+            <tree>
                 <field name="name" />
                 <field name="warehouse_id" />
                 <field name="company_id" groups="base.group_multi_company" />

mrp_multi_level/views/mrp_inventory_views.xml

@@ -41,7 +41,7 @@
         <field name="model">mrp.inventory</field>
         <field name="type">tree</field>
         <field name="arch" type="xml">
-            <tree string="MRP Inventory" create="false">
+            <tree create="false">
                 <field name="mrp_area_id" />
                 <field name="company_id" groups="base.group_multi_company" />
                 <field name="product_id" />

mrp_multi_level/views/mrp_move_views.xml

@@ -4,7 +4,7 @@
         <field name="name">mrp.move.tree</field>
         <field name="model">mrp.move</field>
         <field name="arch" type="xml">
-            <tree string="MRP Moves">
+            <tree>
                 <field name="mrp_date" />
                 <field name="current_date" />
                 <field name="mrp_origin" />

mrp_multi_level/views/product_mrp_area_views.xml

@@ -5,7 +5,7 @@
         <field name="model">product.mrp.area</field>
         <field name="type">tree</field>
         <field name="arch" type="xml">
-            <tree string="Product MRP Area parameters">
+            <tree>
                 <field name="mrp_area_id" />
                 <field name="company_id" groups="base.group_multi_company" />
                 <field name="product_tmpl_id" />

mrp_multi_level/wizards/mrp_inventory_procure_views.xml

@@ -14,7 +14,7 @@
                 </p>
                 <group name="items" string="Items">
                     <field name="item_ids" nolabel="1">
-                        <tree string="Items" nocreate="1" editable="top">
+                        <tree nocreate="1" editable="top">
                             <field name="mrp_inventory_id" invisible="True" />
                             <field
                                 name="warehouse_id"

mrp_routing/data/sequence_data.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
-<odoo>
+<odoo noupdate="1">
-    <data noupdate="1">
 
     <record id="sequence_mrp_route" model="ir.sequence">
         <field name="name">Routing</field>
@@ -12,6 +11,4 @@
         <field name="company_id" eval="False" />
     </record>
 
-
-    </data>
 </odoo>

mrp_routing/demo/routing_data.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="mrp_routing_workcenter_0" model="mrp.routing.workcenter.template">
         <field name="workcenter_id" ref="mrp.mrp_workcenter_3" />
@@ -112,5 +111,4 @@
         />
     </record>
 
-    </data>
 </odoo>

mrp_routing/views/mrp_bom_view.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="mrp_bom_form_view" model="ir.ui.view">
         <field name="name">mrp.bom.form.view</field>
@@ -14,5 +13,4 @@
         </field>
     </record>
 
-    </data>
 </odoo>

mrp_routing/views/mrp_routing_view.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="mrp_routing_form_view" model="ir.ui.view">
         <field name="name">mrp.routing.form</field>
@@ -54,7 +53,7 @@
         <field name="name">mrp.routing.tree</field>
         <field name="model">mrp.routing</field>
         <field name="arch" type="xml">
-                <tree string="Routing">
+            <tree>
                 <field name="code" />
                 <field name="name" />
                 <field name="active" invisible="1" />
@@ -135,5 +134,4 @@
         sequence="50"
     />
 
-    </data>
 </odoo>

mrp_routing/views/mrp_routing_workcenter_template_view.xml

@@ -1,12 +1,11 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="mrp_routing_workcenter_template_tree_view" model="ir.ui.view">
         <field name="name">mrp.routing.workcenter.template.tree</field>
         <field name="model">mrp.routing.workcenter.template</field>
         <field name="arch" type="xml">
-                <tree string="Template Routing Work Centers">
+            <tree>
                 <field name="sequence" widget="handle" />
                 <field name="name" />
                 <field name="workcenter_id" />
@@ -36,9 +35,7 @@
                                 for="time_mode_batch"
                                 attrs="{'invisible': [('time_mode', '=', 'manual')]}"
                             />
-                                <div
+                            <div attrs="{'invisible': [('time_mode', '=', 'manual')]}">
-                                    attrs="{'invisible': [('time_mode', '=', 'manual')]}"
-                                >
                                 last
                                 <field name="time_mode_batch" class="oe_inline" />
                                 work orders
@@ -48,9 +45,7 @@
                                 attrs="{'invisible': [('time_mode', '=', 'auto')]}"
                                 string="Default Duration"
                             />
-                                <div
+                            <div attrs="{'invisible':  [('time_mode', '=', 'auto')]}">
-                                    attrs="{'invisible':  [('time_mode', '=', 'auto')]}"
-                                >
                                 <field
                                     name="time_cycle_manual"
                                     widget="float_time"
@@ -138,6 +133,4 @@
         sequence="100"
     />
 
-
-    </data>
 </odoo>

mrp_routing/views/mrp_routing_workcenter_view.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="mrp_routing_workcenter_tree_view" model="ir.ui.view">
         <field name="name">mrp.routing.workcenter.tree</field>
@@ -39,5 +38,4 @@
     </record>
 
 
-    </data>
 </odoo>

mrp_subcontracting_purchase/data/mrp_subcontracting_dropshipping_data.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" ?>
-<odoo>
+<odoo noupdate="1">
-    <data noupdate="1">
     <record id="route_subcontracting_dropshipping" model='stock.location.route'>
         <field name="name">Dropship Subcontractor on Order</field>
         <field name="sequence">5</field>
@@ -20,5 +19,4 @@
         />
         <value eval="{'subcontracting_dropshipping_to_resupply': True}" />
     </function>
-    </data>
 </odoo>

mrp_tag/views/mrp_tag_view.xml

@@ -31,7 +31,7 @@
         <field name="name">mrp.tag.view.tree</field>
         <field name="model">mrp.tag</field>
         <field name="arch" type="xml">
-            <tree string="Tags" editable="bottom">
+            <tree editable="bottom">
                 <field name="name" />
                 <field name="color" widget="color_picker" />
             </tree>

quality_control_oca/data/quality_control_data.xml

@@ -6,19 +6,14 @@
     Copyright 2017 Simone Rubino - Agile Business Group
     Copyright 2021 Tecnativa - Carlos Roca
     License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
-<odoo>
+<odoo noupdate="1">
-    <data noupdate="1">
     <record id="qc_test_template_category_generic" model="qc.test.category">
         <field name="name">Generic</field>
     </record>
     <record id="qc_test_template_category_referenced" model="qc.test.category">
         <field name="name">Referenced</field>
     </record>
-        <record
+    <record forcecreate="True" id="decimal_quality_control" model="decimal.precision">
-            forcecreate="True"
-            id="decimal_quality_control"
-            model="decimal.precision"
-        >
         <field name="name">Quality Control</field>
         <field name="digits">5</field>
     </record>
@@ -28,5 +23,4 @@
         <field name="prefix">QC-</field>
         <field name="padding">6</field>
     </record>
-    </data>
 </odoo>

quality_control_oca/demo/quality_control_demo.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" ?>
-<odoo>
+<odoo noupdate="1">
-    <data noupdate="1">
     <record model="qc.test" id="qc_test_1">
         <field name="name">Generic Test (demo)</field>
         <field name="type">generic</field>
@@ -30,5 +29,4 @@
         <field name="max_value" eval="10.0" />
         <field name="uom_id" ref="uom.product_uom_unit" />
     </record>
-    </data>
 </odoo>

quality_control_oca/views/product_category_view.xml

@@ -15,7 +15,7 @@
             <group name="first" position="after">
                 <group name="qc" string="Quality control">
                     <field name="qc_triggers" nolabel="1">
-                        <tree string="Quality control triggers" editable="bottom">
+                        <tree editable="bottom">
                             <field
                                 name="trigger"
                                 options="{'no_create': True, 'no_edit': True, 'no_open': True}"

quality_control_oca/views/product_template_view.xml

@@ -18,7 +18,7 @@
             <page name="inventory" position="inside">
                 <group name="qc" string="Quality control">
                     <field name="qc_triggers" nolabel="1">
-                        <tree string="Quality control triggers" editable="bottom">
+                        <tree editable="bottom">
                             <field
                                 name="trigger"
                                 options="{'no_create': True, 'no_edit': True, 'no_open': True}"

quality_control_oca/views/qc_inspection_view.xml

@@ -86,12 +86,7 @@
                     <notebook>
                         <page string="Questions">
                             <field name="inspection_lines" nolabel="1">
-                                <tree
+                                <tree editable="top" delete="false" create="false">
-                                    string="Inspection lines"
-                                    editable="top"
-                                    delete="false"
-                                    create="false"
-                                >
                                     <field name="name" />
                                     <field name="question_type" />
                                     <field name="possible_ql_values" invisible="1" />
@@ -141,7 +136,7 @@
         <field name="name">qc.inspection.tree</field>
         <field name="model">qc.inspection</field>
         <field name="arch" type="xml">
-            <tree string="Inspections">
+            <tree>
                 <field name="name" />
                 <field name="user" />
                 <field name="test" />
@@ -241,7 +236,6 @@
             <tree
                 decoration-danger="success==False"
                 decoration-info="success==True"
-                string="Inspection lines"
                 delete="false"
                 create="false"
             >

quality_control_oca/views/qc_test_category_view.xml

@@ -10,7 +10,7 @@
         <field name="name">qc.test.category.tree</field>
         <field name="model">qc.test.category</field>
         <field name="arch" type="xml">
-            <tree string="Test categories" editable="bottom">
+            <tree editable="bottom">
                 <field name="complete_name" />
                 <field name="name" />
                 <field name="parent_id" />

quality_control_oca/views/qc_test_view.xml

@@ -35,7 +35,7 @@
                         </group>
                     </group>
                     <field name="test_lines" nolabel="1">
-                        <tree string="Questions">
+                        <tree>
                             <field name="sequence" widget="handle" />
                             <field name="name" />
                             <field name="type" />
@@ -57,7 +57,7 @@
         <field name="name">qc.test.tree</field>
         <field name="model">qc.test</field>
         <field name="arch" type="xml">
-            <tree string="Tests">
+            <tree>
                 <field name="name" />
                 <field name="category" />
                 <field name="type" />
@@ -95,7 +95,7 @@
                         nolabel="1"
                         attrs="{'required': [('type','=','qualitative')]}"
                     >
-                        <tree string="Question value" editable="bottom">
+                        <tree editable="bottom">
                             <field name="name" />
                             <field name="ok" />
                         </tree>

quality_control_oca/views/qc_trigger_view.xml

@@ -26,7 +26,7 @@
         <field name="name">qc.trigger.tree</field>
         <field name="model">qc.trigger</field>
         <field name="arch" type="xml">
-            <tree string="Quality control triggers" editable="bottom">
+            <tree editable="bottom">
                 <field name="name" />
                 <field name="company_id" groups="base.group_multi_company" />
                 <field name="partner_selectable" />

repair_sale_order/views/repair_order_view.xml

@@ -1,16 +1,12 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="view_repair_order_form" model="ir.ui.view">
         <field name="name">repair.order.form.view</field>
         <field name="model">repair.order</field>
         <field name="inherit_id" ref="repair.view_repair_order_form" />
         <field name="arch" type="xml">
-                <xpath
+            <xpath expr="//button[@name='action_created_invoice']" position="before">
-                    expr="//button[@name='action_created_invoice']"
-                    position="before"
-                >
                 <button
                     name="action_show_sales_order"
                     type="object"
@@ -29,10 +25,7 @@
             <xpath expr="//field[@name='invoice_state']" position="after">
                 <field name="create_sale_order" invisible="1" />
             </xpath>
-                <xpath
+            <xpath expr="//button[@name='action_repair_start']" position="attributes">
-                    expr="//button[@name='action_repair_start']"
-                    position="attributes"
-                >
                 <attribute
                     name="attrs"
                 >{'invisible': ['|', ('create_sale_order', '=', True), '&amp;', ('state','!=','confirmed'), '!', '&amp;', ('state','=','ready'), ('invoice_method','=','b4repair')]}</attribute>
@@ -80,5 +73,4 @@
         </field>
     </record>
 
-    </data>
 </odoo>

repair_sale_order/views/repair_type_view.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="view_repair_type_form" model="ir.ui.view">
         <field name="name">repair.type.form.view</field>
@@ -50,5 +49,4 @@
         </field>
     </record>
 
-    </data>
 </odoo>

repair_sale_order/views/sale_order_view.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="view_sale_order_form" model="ir.ui.view">
         <field name="name">sale.order.form.view</field>
@@ -25,5 +24,4 @@
         </field>
     </record>
 
-    </data>
 </odoo>