Merge PR #1120 into 14.0

Signed-off-by pedrobaeza

.copier-answers.yml

@@ -1,8 +1,7 @@
 # Do NOT update manually; changes here will be overwritten by Copier
-_commit: v1.14.2
+_commit: v1.17.2
 _src_path: gh:oca/oca-addons-repo-template
 ci: GitHub
-dependency_installation_mode: PIP
 generate_requirements_txt: true
 github_check_license: true
 github_ci_extra_env: {}
@@ -11,6 +10,7 @@ github_enable_makepot: true
 github_enable_stale_action: true
 github_enforce_dev_status_compatibility: true
 include_wkhtmltopdf: false
+odoo_test_flavor: Both
 odoo_version: 14.0
 org_name: Odoo Community Association (OCA)
 org_slug: OCA
@@ -19,6 +19,4 @@ repo_description: Odoo modules related to Manufacturing
 repo_name: Odoo Manufacturing Modules
 repo_slug: manufacture
 repo_website: https://github.com/OCA/manufacture
-travis_apt_packages: []
-travis_apt_sources: []
 

.eslintrc.yml

@@ -22,6 +22,7 @@ globals:
   odoo: readonly
   openerp: readonly
   owl: readonly
+  luxon: readonly
 
 # Styling is handled by Prettier, so we only need to enable AST rules;
 # see https://github.com/OCA/maintainer-quality-tools/pull/618#issuecomment-558576890

.github/workflows/pre-commit.yml

@@ -13,8 +13,10 @@ jobs:
   pre-commit:
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: actions/setup-python@v2
+        with:
+          python-version: "3.11"
       - name: Get python version
         run: echo "PY=$(python -VV | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
       - uses: actions/cache@v1
@@ -25,6 +27,15 @@ jobs:
         run: pip install pre-commit
       - name: Run pre-commit
         run: pre-commit run --all-files --show-diff-on-failure --color=always
+        env:
+          # Consider valid a PR that changes README fragments but doesn't
+          # change the README.rst file itself. It's not really a problem
+          # because the bot will update it anyway after merge. This way, we
+          # lower the barrier for functional contributors that want to fix the
+          # readme fragments, while still letting developers get README
+          # auto-generated (which also helps functionals when using runboat).
+          # DOCS https://pre-commit.com/#temporarily-disabling-hooks
+          SKIP: oca-gen-addon-readme
       - name: Check that all files generated by pre-commit are in git
         run: |
           newfiles="$(git ls-files --others --exclude-from=.gitignore)"

.github/workflows/test.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Detect unreleased dependencies
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - run: |
           for reqfile in requirements.txt test-requirements.txt ; do
               if [ -f ${reqfile} ] ; then
@@ -36,10 +36,10 @@ jobs:
       matrix:
         include:
           - container: ghcr.io/oca/oca-ci/py3.6-odoo14.0:latest
-            makepot: "true"
             name: test with Odoo
           - container: ghcr.io/oca/oca-ci/py3.6-ocb14.0:latest
             name: test with OCB
+            makepot: "true"
     services:
       postgres:
         image: postgres:9.6
@@ -50,7 +50,7 @@ jobs:
         ports:
           - 5432:5432
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           persist-credentials: false
       - name: Install addons and dependencies

.pre-commit-config.yaml

@@ -12,6 +12,8 @@ exclude: |
   /static/(src/)?lib/|
   # Repos using Sphinx to generate docs don't need prettying
   ^docs/_templates/.*\.html$|
+  # Don't bother non-technical authors with formatting issues in docs
+  readme/.*\.(rst|md)$|
   # You don't usually want a bot to modify your legal texts
   (LICENSE.*|COPYING.*)
 default_language_version:
@@ -33,12 +35,24 @@ repos:
         language: fail
         files: '[a-zA-Z0-9_]*/i18n/en\.po$'
   - repo: https://github.com/oca/maintainer-tools
-    rev: ab1d7f6
+    rev: 969238e47c07d0c40573acff81d170f63245d738
     hooks:
       # update the NOT INSTALLABLE ADDONS section above
       - id: oca-update-pre-commit-excluded-addons
       - id: oca-fix-manifest-website
         args: ["https://github.com/OCA/manufacture"]
+      - id: oca-gen-addon-readme
+        args:
+          - --addons-dir=.
+          - --branch=14.0
+          - --org-name=OCA
+          - --repo-name=manufacture
+          - --if-source-changed
+  - repo: https://github.com/OCA/odoo-pre-commit-hooks
+    rev: v0.0.25
+    hooks:
+      - id: oca-checks-odoo-module
+      - id: oca-checks-po
   - repo: https://github.com/myint/autoflake
     rev: v1.4
     hooks:

mrp_bom_component_menu/views/mrp_bom_component_view.xml

@@ -21,7 +21,7 @@
         <field name="name">mrp.bom.line.tree.view</field>
         <field name="model">mrp.bom.line</field>
         <field name="arch" type="xml">
-            <tree string="Components" create="1" edit="1" delete="1">
+            <tree create="1" edit="1" delete="1">
                 <field name="bom_id" />
                 <field name="product_id" />
                 <field name="product_qty" />

mrp_multi_level/views/mrp_area_views.xml

@@ -5,7 +5,7 @@
         <field name="model">mrp.area</field>
         <field name="type">tree</field>
         <field name="arch" type="xml">
-            <tree string="MRP Area">
+            <tree>
                 <field name="name" />
                 <field name="warehouse_id" />
                 <field name="company_id" groups="base.group_multi_company" />

mrp_multi_level/views/mrp_inventory_views.xml

@@ -41,7 +41,7 @@
         <field name="model">mrp.inventory</field>
         <field name="type">tree</field>
         <field name="arch" type="xml">
-            <tree string="MRP Inventory" create="false">
+            <tree create="false">
                 <field name="mrp_area_id" />
                 <field name="company_id" groups="base.group_multi_company" />
                 <field name="product_id" />

mrp_multi_level/views/mrp_move_views.xml

@@ -4,7 +4,7 @@
         <field name="name">mrp.move.tree</field>
         <field name="model">mrp.move</field>
         <field name="arch" type="xml">
-            <tree string="MRP Moves">
+            <tree>
                 <field name="mrp_date" />
                 <field name="current_date" />
                 <field name="mrp_origin" />

mrp_multi_level/views/product_mrp_area_views.xml

@@ -5,7 +5,7 @@
         <field name="model">product.mrp.area</field>
         <field name="type">tree</field>
         <field name="arch" type="xml">
-            <tree string="Product MRP Area parameters">
+            <tree>
                 <field name="mrp_area_id" />
                 <field name="company_id" groups="base.group_multi_company" />
                 <field name="product_tmpl_id" />

mrp_multi_level/wizards/mrp_inventory_procure_views.xml

@@ -14,7 +14,7 @@
                 </p>
                 <group name="items" string="Items">
                     <field name="item_ids" nolabel="1">
-                        <tree string="Items" nocreate="1" editable="top">
+                        <tree nocreate="1" editable="top">
                             <field name="mrp_inventory_id" invisible="True" />
                             <field
                                 name="warehouse_id"

mrp_routing/data/sequence_data.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
-<odoo>
+<odoo noupdate="1">
-    <data noupdate="1">
 
     <record id="sequence_mrp_route" model="ir.sequence">
         <field name="name">Routing</field>
@@ -12,6 +11,4 @@
         <field name="company_id" eval="False" />
     </record>
 
-
-    </data>
 </odoo>

mrp_routing/demo/routing_data.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="mrp_routing_workcenter_0" model="mrp.routing.workcenter.template">
         <field name="workcenter_id" ref="mrp.mrp_workcenter_3" />
@@ -112,5 +111,4 @@
         />
     </record>
 
-    </data>
 </odoo>

mrp_routing/views/mrp_bom_view.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="mrp_bom_form_view" model="ir.ui.view">
         <field name="name">mrp.bom.form.view</field>
@@ -14,5 +13,4 @@
         </field>
     </record>
 
-    </data>
 </odoo>

mrp_routing/views/mrp_routing_view.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="mrp_routing_form_view" model="ir.ui.view">
         <field name="name">mrp.routing.form</field>
@@ -54,7 +53,7 @@
         <field name="name">mrp.routing.tree</field>
         <field name="model">mrp.routing</field>
         <field name="arch" type="xml">
-                <tree string="Routing">
+            <tree>
                 <field name="code" />
                 <field name="name" />
                 <field name="active" invisible="1" />
@@ -135,5 +134,4 @@
         sequence="50"
     />
 
-    </data>
 </odoo>

mrp_routing/views/mrp_routing_workcenter_template_view.xml

@@ -1,12 +1,11 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="mrp_routing_workcenter_template_tree_view" model="ir.ui.view">
         <field name="name">mrp.routing.workcenter.template.tree</field>
         <field name="model">mrp.routing.workcenter.template</field>
         <field name="arch" type="xml">
-                <tree string="Template Routing Work Centers">
+            <tree>
                 <field name="sequence" widget="handle" />
                 <field name="name" />
                 <field name="workcenter_id" />
@@ -36,9 +35,7 @@
                                 for="time_mode_batch"
                                 attrs="{'invisible': [('time_mode', '=', 'manual')]}"
                             />
-                                <div
+                            <div attrs="{'invisible': [('time_mode', '=', 'manual')]}">
-                                    attrs="{'invisible': [('time_mode', '=', 'manual')]}"
-                                >
                                 last
                                 <field name="time_mode_batch" class="oe_inline" />
                                 work orders
@@ -48,9 +45,7 @@
                                 attrs="{'invisible': [('time_mode', '=', 'auto')]}"
                                 string="Default Duration"
                             />
-                                <div
+                            <div attrs="{'invisible':  [('time_mode', '=', 'auto')]}">
-                                    attrs="{'invisible':  [('time_mode', '=', 'auto')]}"
-                                >
                                 <field
                                     name="time_cycle_manual"
                                     widget="float_time"
@@ -138,6 +133,4 @@
         sequence="100"
     />
 
-
-    </data>
 </odoo>

mrp_routing/views/mrp_routing_workcenter_view.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="mrp_routing_workcenter_tree_view" model="ir.ui.view">
         <field name="name">mrp.routing.workcenter.tree</field>
@@ -39,5 +38,4 @@
     </record>
 
 
-    </data>
 </odoo>

mrp_subcontracting_purchase/data/mrp_subcontracting_dropshipping_data.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" ?>
-<odoo>
+<odoo noupdate="1">
-    <data noupdate="1">
     <record id="route_subcontracting_dropshipping" model='stock.location.route'>
         <field name="name">Dropship Subcontractor on Order</field>
         <field name="sequence">5</field>
@@ -20,5 +19,4 @@
         />
         <value eval="{'subcontracting_dropshipping_to_resupply': True}" />
     </function>
-    </data>
 </odoo>

mrp_tag/views/mrp_tag_view.xml

@@ -31,7 +31,7 @@
         <field name="name">mrp.tag.view.tree</field>
         <field name="model">mrp.tag</field>
         <field name="arch" type="xml">
-            <tree string="Tags" editable="bottom">
+            <tree editable="bottom">
                 <field name="name" />
                 <field name="color" widget="color_picker" />
             </tree>

quality_control_oca/data/quality_control_data.xml

@@ -6,19 +6,14 @@
     Copyright 2017 Simone Rubino - Agile Business Group
     Copyright 2021 Tecnativa - Carlos Roca
     License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
-<odoo>
+<odoo noupdate="1">
-    <data noupdate="1">
     <record id="qc_test_template_category_generic" model="qc.test.category">
         <field name="name">Generic</field>
     </record>
     <record id="qc_test_template_category_referenced" model="qc.test.category">
         <field name="name">Referenced</field>
     </record>
-        <record
+    <record forcecreate="True" id="decimal_quality_control" model="decimal.precision">
-            forcecreate="True"
-            id="decimal_quality_control"
-            model="decimal.precision"
-        >
         <field name="name">Quality Control</field>
         <field name="digits">5</field>
     </record>
@@ -28,5 +23,4 @@
         <field name="prefix">QC-</field>
         <field name="padding">6</field>
     </record>
-    </data>
 </odoo>

quality_control_oca/demo/quality_control_demo.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" ?>
-<odoo>
+<odoo noupdate="1">
-    <data noupdate="1">
     <record model="qc.test" id="qc_test_1">
         <field name="name">Generic Test (demo)</field>
         <field name="type">generic</field>
@@ -30,5 +29,4 @@
         <field name="max_value" eval="10.0" />
         <field name="uom_id" ref="uom.product_uom_unit" />
     </record>
-    </data>
 </odoo>

quality_control_oca/i18n/quality_control_oca.pot

@@ -336,17 +336,11 @@ msgstr ""
 
 #. module: quality_control_oca
 #: model:ir.model.fields,help:quality_control_oca.field_qc_inspection__message_has_error
-#: model:ir.model.fields,help:quality_control_oca.field_qc_inspection__message_has_sms_error
 #: model:ir.model.fields,help:quality_control_oca.field_qc_test__message_has_error
-#: model:ir.model.fields,help:quality_control_oca.field_qc_test__message_has_sms_error
 #: model:ir.model.fields,help:quality_control_oca.field_qc_trigger_line__message_has_error
-#: model:ir.model.fields,help:quality_control_oca.field_qc_trigger_line__message_has_sms_error
 #: model:ir.model.fields,help:quality_control_oca.field_qc_trigger_product_category_line__message_has_error
-#: model:ir.model.fields,help:quality_control_oca.field_qc_trigger_product_category_line__message_has_sms_error
 #: model:ir.model.fields,help:quality_control_oca.field_qc_trigger_product_line__message_has_error
-#: model:ir.model.fields,help:quality_control_oca.field_qc_trigger_product_line__message_has_sms_error
 #: model:ir.model.fields,help:quality_control_oca.field_qc_trigger_product_template_line__message_has_error
-#: model:ir.model.fields,help:quality_control_oca.field_qc_trigger_product_template_line__message_has_sms_error
 msgid "If checked, some messages have a delivery error."
 msgstr ""
 
@@ -847,16 +841,6 @@ msgstr ""
 msgid "Responsible User"
 msgstr ""
 
-#. module: quality_control_oca
-#: model:ir.model.fields,field_description:quality_control_oca.field_qc_inspection__message_has_sms_error
-#: model:ir.model.fields,field_description:quality_control_oca.field_qc_test__message_has_sms_error
-#: model:ir.model.fields,field_description:quality_control_oca.field_qc_trigger_line__message_has_sms_error
-#: model:ir.model.fields,field_description:quality_control_oca.field_qc_trigger_product_category_line__message_has_sms_error
-#: model:ir.model.fields,field_description:quality_control_oca.field_qc_trigger_product_line__message_has_sms_error
-#: model:ir.model.fields,field_description:quality_control_oca.field_qc_trigger_product_template_line__message_has_sms_error
-msgid "SMS Delivery error"
-msgstr ""
-
 #. module: quality_control_oca
 #: model_terms:ir.ui.view,arch_db:quality_control_oca.qc_inspection_search_view
 msgid "Search inspection"

quality_control_oca/views/product_category_view.xml

@@ -15,7 +15,7 @@
             <group name="first" position="after">
                 <group name="qc" string="Quality control">
                     <field name="qc_triggers" nolabel="1">
-                        <tree string="Quality control triggers" editable="bottom">
+                        <tree editable="bottom">
                             <field
                                 name="trigger"
                                 options="{'no_create': True, 'no_edit': True, 'no_open': True}"

quality_control_oca/views/product_template_view.xml

@@ -18,7 +18,7 @@
             <page name="inventory" position="inside">
                 <group name="qc" string="Quality control">
                     <field name="qc_triggers" nolabel="1">
-                        <tree string="Quality control triggers" editable="bottom">
+                        <tree editable="bottom">
                             <field
                                 name="trigger"
                                 options="{'no_create': True, 'no_edit': True, 'no_open': True}"

quality_control_oca/views/qc_inspection_view.xml

@@ -86,12 +86,7 @@
                     <notebook>
                         <page string="Questions">
                             <field name="inspection_lines" nolabel="1">
-                                <tree
+                                <tree editable="top" delete="false" create="false">
-                                    string="Inspection lines"
-                                    editable="top"
-                                    delete="false"
-                                    create="false"
-                                >
                                     <field name="name" />
                                     <field name="question_type" />
                                     <field name="possible_ql_values" invisible="1" />
@@ -141,7 +136,7 @@
         <field name="name">qc.inspection.tree</field>
         <field name="model">qc.inspection</field>
         <field name="arch" type="xml">
-            <tree string="Inspections">
+            <tree>
                 <field name="name" />
                 <field name="user" />
                 <field name="test" />
@@ -241,7 +236,6 @@
             <tree
                 decoration-danger="success==False"
                 decoration-info="success==True"
-                string="Inspection lines"
                 delete="false"
                 create="false"
             >

quality_control_oca/views/qc_test_category_view.xml

@@ -10,7 +10,7 @@
         <field name="name">qc.test.category.tree</field>
         <field name="model">qc.test.category</field>
         <field name="arch" type="xml">
-            <tree string="Test categories" editable="bottom">
+            <tree editable="bottom">
                 <field name="complete_name" />
                 <field name="name" />
                 <field name="parent_id" />

quality_control_oca/views/qc_test_view.xml

@@ -35,7 +35,7 @@
                         </group>
                     </group>
                     <field name="test_lines" nolabel="1">
-                        <tree string="Questions">
+                        <tree>
                             <field name="sequence" widget="handle" />
                             <field name="name" />
                             <field name="type" />
@@ -57,7 +57,7 @@
         <field name="name">qc.test.tree</field>
         <field name="model">qc.test</field>
         <field name="arch" type="xml">
-            <tree string="Tests">
+            <tree>
                 <field name="name" />
                 <field name="category" />
                 <field name="type" />
@@ -95,7 +95,7 @@
                         nolabel="1"
                         attrs="{'required': [('type','=','qualitative')]}"
                     >
-                        <tree string="Question value" editable="bottom">
+                        <tree editable="bottom">
                             <field name="name" />
                             <field name="ok" />
                         </tree>

quality_control_oca/views/qc_trigger_view.xml

@@ -26,7 +26,7 @@
         <field name="name">qc.trigger.tree</field>
         <field name="model">qc.trigger</field>
         <field name="arch" type="xml">
-            <tree string="Quality control triggers" editable="bottom">
+            <tree editable="bottom">
                 <field name="name" />
                 <field name="company_id" groups="base.group_multi_company" />
                 <field name="partner_selectable" />

repair_sale_order/views/repair_order_view.xml

@@ -1,16 +1,12 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="view_repair_order_form" model="ir.ui.view">
         <field name="name">repair.order.form.view</field>
         <field name="model">repair.order</field>
         <field name="inherit_id" ref="repair.view_repair_order_form" />
         <field name="arch" type="xml">
-                <xpath
+            <xpath expr="//button[@name='action_created_invoice']" position="before">
-                    expr="//button[@name='action_created_invoice']"
-                    position="before"
-                >
                 <button
                     name="action_show_sales_order"
                     type="object"
@@ -29,10 +25,7 @@
             <xpath expr="//field[@name='invoice_state']" position="after">
                 <field name="create_sale_order" invisible="1" />
             </xpath>
-                <xpath
+            <xpath expr="//button[@name='action_repair_start']" position="attributes">
-                    expr="//button[@name='action_repair_start']"
-                    position="attributes"
-                >
                 <attribute
                     name="attrs"
                 >{'invisible': ['|', ('create_sale_order', '=', True), '&amp;', ('state','!=','confirmed'), '!', '&amp;', ('state','=','ready'), ('invoice_method','=','b4repair')]}</attribute>
@@ -80,5 +73,4 @@
         </field>
     </record>
 
-    </data>
 </odoo>

repair_sale_order/views/repair_type_view.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="view_repair_type_form" model="ir.ui.view">
         <field name="name">repair.type.form.view</field>
@@ -50,5 +49,4 @@
         </field>
     </record>
 
-    </data>
 </odoo>

repair_sale_order/views/sale_order_view.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <data>
 
     <record id="view_sale_order_form" model="ir.ui.view">
         <field name="name">sale.order.form.view</field>
@@ -25,5 +24,4 @@
         </field>
     </record>
 
-    </data>
 </odoo>