From 9b65878e5b68bd87b576a55ed58a58a56c912e85 Mon Sep 17 00:00:00 2001 From: oihane Date: Thu, 13 Nov 2014 12:10:28 +0100 Subject: [PATCH] [FIX] quality_control: * Pylint fixing * PEP8 fixing --- quality_control/models/quality_control.py | 25 +++++++++++------------ quality_control/wizard/qc_test_wizard.py | 4 ++-- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/quality_control/models/quality_control.py b/quality_control/models/quality_control.py index 6a9c36a0f..90bf9e214 100644 --- a/quality_control/models/quality_control.py +++ b/quality_control/models/quality_control.py @@ -263,10 +263,10 @@ class QcTestTemplate(orm.Model): def _default_name(self, cr, uid, context=None): if context and context.get('reference_model', False): - id = context.get('reference_id') - if not id: - id = context.get('active_id') - if id: + templ_id = context.get('reference_id') + if not templ_id: + templ_id = context.get('active_id') + if templ_id: source = self.pool[context['reference_model']].browse( cr, uid, id, context=context) if hasattr(source, 'name'): @@ -445,14 +445,12 @@ class QcTest(orm.Model): 'enabled': True, } - def copy(self, cr, uid, id, default=None, context=None): - if context is None: - context = {} - + def copy(self, cr, uid, copy_id, default=None, context=None): if default is None: default = {} default['name'] = time.strftime('%Y-%m-%d %H:%M:%S') - return super(QcTest, self).copy(cr, uid, id, default, context=context) + return super(QcTest, self).copy( + cr, uid, copy_id, default, context=context) def create(self, cr, uid, datas, context=None): if context and context.get('reference_model', False): @@ -486,11 +484,11 @@ class QcTest(orm.Model): context = {} test_obj = self.pool['qc.test'] test_line_obj = self.pool['qc.test.line'] - for id in ids: - test_obj.write(cr, uid, id, { + for test_id in ids: + test_obj.write(cr, uid, test_id, { 'test_template_id': template_id }, context) - test = test_obj.browse(cr, uid, id, context=context) + test = test_obj.browse(cr, uid, test_id, context=context) if len(test.test_line_ids) > 0: test_line_obj.unlink(cr, uid, @@ -498,7 +496,8 @@ class QcTest(orm.Model): context=context) test_lines = self._prepare_test_lines( cr, uid, test, force_fill=force_fill, context=context) - test_obj.write(cr, uid, id, {'test_line_ids': test_lines}, context) + test_obj.write(cr, uid, test_id, {'test_line_ids': test_lines}, + context=context) def _prepare_test_lines(self, cr, uid, test, force_fill=False, context=None): diff --git a/quality_control/wizard/qc_test_wizard.py b/quality_control/wizard/qc_test_wizard.py index 19c60c4d3..3db93da64 100644 --- a/quality_control/wizard/qc_test_wizard.py +++ b/quality_control/wizard/qc_test_wizard.py @@ -40,8 +40,8 @@ class QcTestWizard(orm.TransientModel): _name = 'qc.test.set.template.wizard' def _default_test_template_id(self, cr, uid, context=None): - id = context.get('active_id', False) - test = self.pool['qc.test'].browse(cr, uid, id, context=context) + active_id = context.get('active_id', False) + test = self.pool['qc.test'].browse(cr, uid, active_id, context=context) ids = self.pool['qc.test.template'].search(cr, uid, [('object_id', '=', test.object_id)], context=context)