From 7d7f9fda3f8b26d5525c4b9b688a1f9ba63cceb5 Mon Sep 17 00:00:00 2001 From: "Kay K. Cross" Date: Tue, 22 Oct 2024 10:01:37 +0200 Subject: [PATCH] [IMP] mrp_bom_version: rename field to make more clear --- mrp_bom_version/models/mrp_bom.py | 14 +++++++------- mrp_bom_version/tests/test_mrp_bom_version.py | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/mrp_bom_version/models/mrp_bom.py b/mrp_bom_version/models/mrp_bom.py index 4ac71477f..c6045b692 100644 --- a/mrp_bom_version/models/mrp_bom.py +++ b/mrp_bom_version/models/mrp_bom.py @@ -10,11 +10,11 @@ class MrpBom(models.Model): def _compute_old_versions(self): for bom in self: - parent = bom.parent_bom + previous = bom.previous_bom_id old_version = self.env["mrp.bom"] - while parent: - old_version |= parent - parent = parent.parent_bom + while previous: + old_version |= previous + previous = previous.previous_bom_id bom.old_versions = [(6, 0, old_version.ids)] def _default_active(self): @@ -72,8 +72,8 @@ class MrpBom(models.Model): version = fields.Integer( states={"historical": [("readonly", True)]}, copy=False, default=1 ) - parent_bom = fields.Many2one( - comodel_name="mrp.bom", string="Parent BoM", copy=False + previous_bom_id = fields.Many2one( + comodel_name="mrp.bom", string="Previous BoM", copy=False ) old_versions = fields.Many2many( comodel_name="mrp.bom", compute="_compute_old_versions" @@ -114,7 +114,7 @@ class MrpBom(models.Model): { "version": self.version + 1, "active": active_draft, - "parent_bom": self.id, + "previous_bom_id": self.id, } ) return new_bom diff --git a/mrp_bom_version/tests/test_mrp_bom_version.py b/mrp_bom_version/tests/test_mrp_bom_version.py index 90a281135..9aaf978fa 100644 --- a/mrp_bom_version/tests/test_mrp_bom_version.py +++ b/mrp_bom_version/tests/test_mrp_bom_version.py @@ -68,7 +68,7 @@ class TestMrpBomVersion(common.TransactionCase): ) new_boms = self.bom_model.with_context(active_test=False).search( [ - ("parent_bom", "=", self.mrp_bom.id), + ("previous_bom_id", "=", self.mrp_bom.id), ] ) for new_bom in new_boms: