new ioBroker versions

Admin detection patch

.VERSION

@@ -1 +1 @@
-v7.1.0-beta.1
+v7.1.2

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,11 @@
+blank_issues_enabled: true
+contact_links:
+  - name: ioBroker Docker image discussions
+    url: https://github.com/buanet/ioBroker.docker/discussions
+#    about: You can ask your questions here. 
+  - name: ioBroker Community Forum
+    url: https://forum.iobroker.net/
+  - name: ioBroker Discord channel
+    url: https://discord.gg/Ne3y6fUac3
+  - name: ioBroker Facebook group
+    url: https://www.facebook.com/groups/440499112958264/

.github/ISSUE_TEMPLATE/feature_request.yaml

@@ -0,0 +1,17 @@
+name: Feature Request
+description: I want to request a new feature.
+title: "[Feature Request]: "
+labels: "enhancement"
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to give us your feedback!
+  - type: textarea
+    id: description
+    attributes:
+      label: Description
+      description: Please describe your request.
+      placeholder: Waht are your ideas?
+    validations:
+      required: true

.github/ISSUE_TEMPLATE/problem_report.yaml

@@ -0,0 +1,32 @@
+name: Problem Report
+description: I want to report a problem.
+title: "[Problem]: "
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this bug report!
+  - type: textarea
+    id: description
+    attributes:
+      label: Description
+      description: Please describe your problem.
+      placeholder: What happened? What did you expect?
+    validations:
+      required: true
+  - type: input
+    id: version
+    attributes:
+      label: Image version
+      description: Which image version do you use?
+      placeholder: v1.2.3
+    validations:
+      required: true
+  - type: textarea
+    id: logs
+    attributes:
+      label: Docker logs
+      description: Please provide the full Docker log output from your Docker container startup.
+      render: shell
+    validations:
+      required: true

.github/dependencies/.admin-version

@@ -0,0 +1 @@
+6.2.23

.github/dependencies/.backitup-version

@@ -0,0 +1 @@
+2.5.4

.github/dependencies/.discovery-version

@@ -0,0 +1 @@
+3.0.5

.github/workflows/build-debian-image-beta-node18.yml

@@ -48,7 +48,7 @@ jobs:
 
       - name: Set up Docker Buildx
         id: buildx
-        uses: docker/setup-buildx-action@v2.1.0
+        uses: docker/setup-buildx-action@v2.2.1
 
       - name: Login to DockerHub
         uses: docker/login-action@v2.1.0

.github/workflows/build-debian-image-beta.yml

@@ -48,7 +48,7 @@ jobs:
 
       - name: Set up Docker Buildx
         id: buildx
-        uses: docker/setup-buildx-action@v2.1.0
+        uses: docker/setup-buildx-action@v2.2.1
 
       - name: Login to DockerHub
         uses: docker/login-action@v2.1.0

.github/workflows/build-debian-image-dev-node18.yml

@@ -43,7 +43,7 @@ jobs:
 
       - name: Set up Docker Buildx
         id: buildx
-        uses: docker/setup-buildx-action@v2.1.0
+        uses: docker/setup-buildx-action@v2.2.1
 
       - name: Login to DockerHub
         uses: docker/login-action@v2.1.0

.github/workflows/build-debian-image-dev.yml

@@ -43,7 +43,7 @@ jobs:
 
       - name: Set up Docker Buildx
         id: buildx
-        uses: docker/setup-buildx-action@v2.1.0
+        uses: docker/setup-buildx-action@v2.2.1
 
       - name: Login to DockerHub
         uses: docker/login-action@v2.1.0

.github/workflows/build-debian-image-latest-iob.yml

@@ -39,8 +39,8 @@ jobs:
           sed -e "s/\${VERSION}/$VERSION/" -e "s/\${BUILD}/$DATI/" ./debian/scripts/iobroker_startup.sh > ./debian/scripts/iobroker_startup.tmp
           mv -f ./debian/scripts/iobroker_startup.tmp ./debian/scripts/iobroker_startup.sh
           # amd64
-          sed -e "s/\${VERSION}/$VERSION/" -e "s/\${DATI}/$DATI/" ./debian/node14/Dockerfile > ./debian/node14/Dockerfile.tmp 
+          sed -e "s/\${VERSION}/$VERSION/" -e "s/\${DATI}/$DATI/" ./debian/node16/Dockerfile > ./debian/node16/Dockerfile.tmp 
-          mv -f ./debian/node14/Dockerfile.tmp ./debian/node14/Dockerfile
+          mv -f ./debian/node16/Dockerfile.tmp ./debian/node16/Dockerfile
 
       - name: Set up manifest tool
         run: |
@@ -52,7 +52,7 @@ jobs:
 
       - name: Set up Docker Buildx
         id: buildx
-        uses: docker/setup-buildx-action@v2.1.0
+        uses: docker/setup-buildx-action@v2.2.1
 
       - name: Login to DockerHub (iobroker)
         uses: docker/login-action@v2.1.0
@@ -64,7 +64,7 @@ jobs:
         uses: docker/build-push-action@v3.2.0
         with:
           context: ./debian
-          file: ./debian/node14/Dockerfile
+          file: ./debian/node16/Dockerfile
           push: true
           platforms: linux/amd64
           tags: |
@@ -74,7 +74,7 @@ jobs:
         uses: docker/build-push-action@v3.2.0
         with:
           context: ./debian
-          file: ./debian/node14/Dockerfile
+          file: ./debian/node16/Dockerfile
           push: true
           platforms: linux/arm/v7
           tags: |
@@ -84,7 +84,7 @@ jobs:
         uses: docker/build-push-action@v3.2.0
         with:
           context: ./debian
-          file: ./debian/node14/Dockerfile
+          file: ./debian/node16/Dockerfile
           push: true
           platforms: linux/arm64/v8
           tags: |

.github/workflows/build-debian-image-latest.yml

@@ -52,7 +52,7 @@ jobs:
 
       - name: Set up Docker Buildx
         id: buildx
-        uses: docker/setup-buildx-action@v2.1.0
+        uses: docker/setup-buildx-action@v2.2.1
 
       - name: Login to DockerHub (buanet)
         uses: docker/login-action@v2.1.0

.github/workflows/check-iobroker-versions.yml

@@ -2,7 +2,7 @@ name: Check ioBroker versions
 
 on:
   schedule:
-    - cron:  '42 23 * * *'
+    - cron: '42 23 * * *'
   workflow_dispatch:
 
 jobs:
@@ -44,7 +44,7 @@ jobs:
 
       - name: Trigger build debian latest (buanet)
         if: steps.git-check.outputs.modified == 'true'
-        uses: benc-uk/workflow-dispatch@v1.1
+        uses: benc-uk/workflow-dispatch@v1.2
         with:
           workflow: Build debian latest (buanet)
           repo: buanet/ioBroker.docker
@@ -52,7 +52,7 @@ jobs:
 
       - name: Trigger build debian latest (iobroker)
         if: steps.git-check.outputs.modified == 'true'
-        uses: benc-uk/workflow-dispatch@v1.1
+        uses: benc-uk/workflow-dispatch@v1.2
         with:
           workflow: Build debian latest (iobroker)
           repo: buanet/ioBroker.docker

CHANGELOG.md

@@ -1,12 +1,20 @@
 ## Changelog
 
-### v7.1.0-beta.1 (12.10.2022)
+### v7.1.2 (08.11.2022)
-* add env DEBUG for extended debugging log
+* fix hostname check ([#293](https://github.com/buanet/ioBroker.docker/issues/293))
-* enhance logging in iobroker-startuo.sh
+
-* enhance build process
+### v7.1.1 (01.11.2022)
-* add restart option to maintenance script
+* fix setting gid of iobroker group ([#289](https://github.com/buanet/ioBroker.docker/issues/289))
-* add strict mode for iobroker-startup.sh
+
-* fix "unary operator expected" error
+### v7.1.0 (31.10.2022)
+* fix [build action node issue](https://forum.iobroker.net/topic/59518/docker-image-7-0-1-auf-node-js-14/14?_=1667244004952) for iobroker/iobroker repo
+* v7.1.0-beta.1 (12.10.2022)
+  * add env DEBUG for extended debugging log
+  * enhance logging in iobroker-startup.sh
+  * enhance build process
+  * add restart option to maintenance script
+  * add strict mode for iobroker-startup.sh
+  * fix "unary operator expected" error
 
 ### v7.0.1 (05.07.2022)
 * backitup restore patch

debian/scripts/iobroker_startup.sh

@@ -28,6 +28,20 @@ set -u
 
 pkill_timeout=10      # timeout for iobroker shutdown in seconds
 
+# Stop on error function
+stop_on_error() {
+  if [[ "$debug" == "true" ]]; then 
+    echo ' '
+    echo "[DEBUG] Debug mode prevents the container from exiting on errors."
+    echo "[DEBUG] This enables you to investigate or fix your issue on the command line."
+    echo "[DEBUG] If you want to stop or restart your container you have to do it manually."
+    echo "[DEBUG] IoBroker is not running!"
+      tail -f /dev/null
+  else
+    exit 1
+  fi
+}
+
 # Getting date and time for logging
 dati=`date '+%Y-%m-%d %H:%M:%S'`
 
@@ -104,7 +118,7 @@ if [[ -f /opt/.firstrun ]]; then
   if [[ "$packages" != "" && "$offlinemode" = "true" ]]; then
     echo 'PACKAGES is set, but OFFLINE_MODE is \"true\". Skipping Linux package installation.'
     echo ' '
-  else
+  elif [[ "$packages" != "" ]]; then
     echo 'PACKAGES is set. Installing additional Linux packages.'
     echo "Checking the following packages:" $packages"..."
     echo $packages > /opt/scripts/.docker_config/.packages
@@ -129,7 +143,7 @@ if [[ "$setgid" != "$(cat /etc/group | grep 'iobroker:' | cut -d':' -f3)" || "$s
   echo "SETUID and/ or SETGID are set to individual values."
   echo -n "Changing UID to "$setuid" and GID to "$setgid"... "
     usermod -u $setuid iobroker
-    groupmod -g $setgid iobroker
+    groupmod -og $setgid iobroker
   echo 'Done.'
   echo ' '
 fi
@@ -160,9 +174,7 @@ elif [[ "$(ls *_backupiobroker.tar.gz 2> /dev/null | wc -l)" != "0" && "$(tar -z
     exit 1
   else
     echo "IoBroker backup file detected in /opt/iobroker."
-    if [[ "$debug" == "true" ]]; then
+    if [[ "$debug" == "true" ]]; then echo "[DEBUG] Backup file name: " $(ls *_backupiobroker.tar.gz); fi
-      echo "[DEBUG] Backup file name: " $(ls *_backupiobroker.tar.gz) 
-    fi
     echo -n "Preparing restore... "
       mv /opt/iobroker/*.tar.gz /opt/
       tar -xf /opt/initial_iobroker.tar -C /
@@ -218,33 +230,39 @@ echo -n "Fixing \"sudo-bug\" by replacing sudo with gosu... "
 echo 'Done.'
 echo ' '
 
-# checking hostname in ioBroker to match container hostname
+# hostname check
-if [[ "$(bash iobroker object get system.adapter.admin.0 --pretty | grep -oP '(?<="host": ")[^"]*')" != "$(hostname)" && "$multihost" != "slave" ]]; then
+if [[ "$multihost" == "slave" ]]; then
-  echo "Hostname in ioBroker does not match the hostname of this container."
-  if [[ "$debug" == "true" ]]; then
-    echo "[DEBUG] Detected hostname in ioBroker: " $(bash iobroker object get system.adapter.admin.0 --pretty | grep -oP '(?<="host": ")[^"]*')
-    echo "[DEBUG] Detected hostname in container: " $(hostname)
-  fi
-  echo -n "Updating hostname to "$(hostname)"... "
-    bash iobroker host $(bash iobroker object get system.adapter.admin.0 --pretty | grep -oP '(?<="host": ")[^"]*')
-  echo 'Done.'
-  echo ' '
-elif [[ "$multihost" == "slave" ]]; then
   echo "IOB_MULTIHOST ist set to \"slave\". Hostname check will be skipped."
   echo ' '
-elif [[ "$(bash iobroker object get system.adapter.admin.0 --pretty | grep -oP '(?<="host": ")[^"]*')" = "$(hostname)" && "$multihost" != "slave" ]]; then
-  echo "Hostname in ioBroker matches the hostname of this container."
-  if [[ "$debug" == "true" ]]; then
-    echo "[DEBUG] Detected hostname in ioBroker: " $(bash iobroker object get system.adapter.admin.0 --pretty | grep -oP '(?<="host": ")[^"]*')
-    echo "[DEBUG] Detected hostname in container: " $(hostname)
-  fi
-  echo "No action required."
-  echo ' '
 else
-  if [[ "$debug" == "true" ]]; then
+  # get admin instance and hostname
-    echo "[DEBUG] There was a problem checking the hostname."
+  set +e
-    echo "[DEBUG] Detected hostname in ioBroker: " $(bash iobroker object get system.adapter.admin.0 --pretty | grep -oP '(?<="host": ")[^"]*')
+  admininstance=$(bash iobroker list instances | grep 'enabled' | grep -m 1 -o 'system.adapter.admin..')
-    echo "[DEBUG] Detected hostname in container: " $(hostname)
+  set -e
+  if [[ "$admininstance" != "" ]]; then
+    if [[ "$debug" == "true" ]]; then echo "[DEBUG] Detected admin instance is:" $admininstance; fi 
+    adminhostname=$(bash iobroker object get $admininstance --pretty | grep -oP '(?<="host": ")[^"]*')
+    if [[ "$debug" == "true" ]]; then echo "[DEBUG] Detected admin hostname is:" $adminhostname; fi
+  else
+    echo "There was a problem detecting the admin instance of your iobroker."
+    echo "Make sure the ioBroker installation you use has an admin instance or start over with a fresh installation and restore your configuration."
+    echo "For more details see https://docs.buanet.de/iobroker-docker-image/docs/#restore"
+    stop_on_error
+  fi
+  # check hostname
+  if [[ "$adminhostname" != "" && "$adminhostname" != "$(hostname)" ]]; then
+    echo "Hostname in ioBroker does not match the hostname of this container."
+    echo -n "Updating hostname to "$(hostname)"... "
+      bash iobroker host $adminhostname
+    echo 'Done.'
+    echo ' '
+  elif [[ "$adminhostname" = "$(hostname)" ]]; then
+    echo "Hostname in ioBroker matches the hostname of this container."
+    echo "No action required."
+    echo ' '
+  else
+    echo "There was a problem checking the hostname."
+    stop_on_error
   fi
 fi
 
@@ -261,14 +279,14 @@ echo "For more information see ioBroker Docker Image Docs (https://docs.buanet.d
 echo ' '
 
 # Checking ENV for Adminport
-if [[ "$adminport" != "" ]]; then
+if [[ "$adminport" != "" && "$multihost" != "slave" ]]; then
-  if [[ "$adminport" != "$(bash iobroker object get system.adapter.admin.0 --pretty | grep -oP '(?<="port": )[^,]*')" ]]; then
+  adminportold=$(bash iobroker object get $admininstance --pretty | grep -oP '(?<="port": )[^,]*')
+  admininstanceshort=$(echo $admininstance | grep -m 1 -o 'admin..')
+  if [[ "$adminport" != "$adminportold" ]]; then
     echo "IOB_ADMINPORT is set and does not match port configured in ioBroker."
-    if [[ "$debug" == "true" ]]; then
+    if [[ "$debug" == "true" ]]; then echo "[DEBUG] Detected Admin Port in ioBroker: " $adminportold; fi
-      echo "[DEBUG] Detected Admin Port in ioBroker: " $(bash iobroker object get system.adapter.admin.0 --pretty | grep -oP '(?<="port": )[^,]*')
+    echo "Setting Adminport to \""$adminport"\"... "
-    fi
+      bash iobroker set $admininstanceshort --port $adminport
-    echo -n "Setting Adminport to \""$adminport"\"... "
-      bash iobroker set admin.0 --port $adminport
     echo 'Done.'
     echo ' '
   fi