From ae42123a2f2389fbafe60ff369c935ad8619c488 Mon Sep 17 00:00:00 2001 From: dontobi Date: Fri, 7 Jul 2023 09:18:00 +0200 Subject: [PATCH 1/5] Adjustments to all scripts --- debian/scripts/healthcheck.sh | 8 +- debian/scripts/iobroker_startup.sh | 148 +++++++++--------- debian/scripts/maintenance.sh | 132 ++++++++-------- debian/scripts/setup_avahi.sh | 24 +-- debian/scripts/setup_iob_db.sh | 74 ++++----- debian/scripts/setup_packages.sh | 11 +- debian/scripts/setup_zwave.sh | 6 +- .../userscript_everystart_example.sh | 4 +- .../userscript_firststart_example.sh | 4 +- 9 files changed, 206 insertions(+), 205 deletions(-) diff --git a/debian/scripts/healthcheck.sh b/debian/scripts/healthcheck.sh index 072f9c0..d55d1f4 100644 --- a/debian/scripts/healthcheck.sh +++ b/debian/scripts/healthcheck.sh @@ -4,17 +4,17 @@ if [ "$(cat /opt/scripts/.docker_config/.healthcheck)" == "starting" ] then - echo 'Health status: OK - Startup script is still running.' + echo "Health status: OK - Startup script is still running." exit 0 elif [ "$(cat /opt/scripts/.docker_config/.healthcheck)" == "maintenance" ] then - echo 'Health status: OK - Container is running in maintenance mode.' + echo "Health status: OK - Container is running in maintenance mode." exit 0 elif [ "$(ps -fe|grep "[i]obroker.js-controller"|awk '{print $2}')" != "" ] then - echo 'Health status: OK - Main process (js-controller) is running.' + echo "Health status: OK - Main process (js-controller) is running." exit 0 fi -echo 'Health status: !!! NOT OK !!! - Something went wrong. Please see container logs for more details and/or try restarting the container.' +echo "Health status: !!! NOT OK !!! - Something went wrong. Please see container logs for more details and/or try restarting the container." exit 1 diff --git a/debian/scripts/iobroker_startup.sh b/debian/scripts/iobroker_startup.sh index 2005c62..b153da3 100644 --- a/debian/scripts/iobroker_startup.sh +++ b/debian/scripts/iobroker_startup.sh @@ -4,7 +4,7 @@ set -euo pipefail # Setting healthcheck status to "starting" -echo 'starting' > /opt/scripts/.docker_config/.healthcheck +echo "starting" > /opt/scripts/.docker_config/.healthcheck # Reading ENV set +u @@ -37,14 +37,14 @@ pkill_timeout=10 # timeout for iobroker shutdown in seconds # Stop on error function stop_on_error() { if [[ "$debug" == "true" ]]; then - echo ' ' + echo " " echo "[DEBUG] Debug mode prevents the container from exiting on errors." echo "[DEBUG] This enables you to investigate or fix your issue on the command line." echo "[DEBUG] If you want to stop or restart your container you have to do it manually." echo "[DEBUG] IoBroker is not running!" tail -f /dev/null else - echo ' ' + echo " " echo "This Script will exit now." exit 1 fi @@ -54,7 +54,7 @@ stop_on_error() { dati=$(date '+%Y-%m-%d %H:%M:%S') # Logging header -echo ' ' +echo " " echo "$(printf -- '-%.0s' {1..80})" echo -n "$(printf -- '-%.0s' {1..25})" && echo -n " ""$dati"" " && echo "$(printf -- '-%.0s' {1..25})" echo "$(printf -- '-%.0s' {1..80})" @@ -70,7 +70,7 @@ echo "----- Welcome to your ioBroker Docker container! echo "----- Startupscript is now running! -----" echo "----- Please be patient! -----" echo "$(printf -- '-%.0s' {1..80})" -echo ' ' +echo " " echo "$(printf -- '-%.0s' {1..80})" echo "----- System Information -----" echo -n "----- " && echo -n "$(printf "%-20s %-28s" arch: "$(uname -m)")" && echo " -----" @@ -106,7 +106,7 @@ if [[ "$setuid" != "" ]]; then echo -n "----- " && echo -n "$ if [[ "$usbdevices" != "" ]]; then echo -n "----- " && echo -n "$(printf "%-20s %-28s" USBDEVICES: "$usbdevices")" && echo " -----"; fi if [[ "$zwave" != "" ]]; then echo -n "----- " && echo -n "$(printf "%-20s %-28s" ZWAVE: "$zwave")" && echo " -----"; fi echo "$(printf -- '-%.0s' {1..80})" -echo ' ' +echo " " # Debug logging notice if [[ "$debug" == "true" ]]; then @@ -118,7 +118,7 @@ if [[ "$debug" == "true" ]]; then echo "!!!! For more information see ioBroker Docker image documentation: !!!!" echo "!!!! https://docs.buanet.de/iobroker-docker-image/docs/ !!!!" echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!" - echo ' ' + echo " " fi ##### @@ -127,7 +127,7 @@ fi echo "$(printf -- '-%.0s' {1..80})" echo "----- Step 1 of 5: Preparing container -----" echo "$(printf -- '-%.0s' {1..80})" -echo ' ' +echo " " # Actions running on first start only if [[ -f /opt/.first_run ]]; then @@ -137,35 +137,35 @@ if [[ -f /opt/.first_run ]]; then else bash /opt/scripts/setup_packages.sh -update fi - echo ' ' + echo " " # Installing packages from ENV if [[ "$packages" != "" && "$offlinemode" = "true" ]]; then echo "PACKAGES is set, but OFFLINE_MODE is \"true\". Skipping Linux package installation." elif [[ "$packages" != "" ]]; then echo "PACKAGES is set. Installing the following additional Linux packages: ""$packages" -# echo "$packages" > /opt/scripts/.docker_config/.packages + #echo "$packages" > /opt/scripts/.docker_config/.packages bash /opt/scripts/setup_packages.sh -install fi - echo ' ' + echo " " # Register maintenance script - echo -n 'Registering maintenance script as command... ' + echo -n "Registering maintenance script as command..." echo "alias maintenance=\'/opt/scripts/maintenance.sh\'" >> /root/.bashrc echo "alias maint=\'/opt/scripts/maintenance.sh\'" >> /root/.bashrc echo "alias m=\'/opt/scripts/maintenance.sh\'" >> /root/.bashrc - echo 'Done.' + echo "Done." else echo "This is not the first run of this container. Skipping first run preparation." fi -echo ' ' +echo " " # Setting UID and/ or GID if [[ "$setgid" != "$(cat /etc/group | grep 'iobroker:' | cut -d':' -f3)" || "$setuid" != "$(cat /etc/passwd | grep 'iobroker:' | cut -d':' -f3)" ]]; then echo "SETUID and/ or SETGID are set to custom values." - echo -n "Changing UID to \"""$setuid""\" and GID to \"""$setgid""\"... " + echo -n "Changing UID to \"""$setuid""\" and GID to \"""$setgid""\"..." usermod -u "$setuid" iobroker groupmod -og "$setgid" iobroker - echo 'Done.' - echo ' ' + echo "Done." + echo " " fi # Change directory for next steps @@ -177,13 +177,13 @@ cd /opt/iobroker echo "$(printf -- '-%.0s' {1..80})" echo "----- Step 2 of 5: Detecting ioBroker installation -----" echo "$(printf -- '-%.0s' {1..80})" -echo ' ' +echo " " if [[ `find /opt/iobroker -type f | wc -l` -lt 1 ]]; then echo "There is no data detected in /opt/iobroker." - echo -n "Restoring initial ioBroker installation... " + echo -n "Restoring initial ioBroker installation..." tar -xf /opt/initial_iobroker.tar -C / - echo 'Done.' + echo "Done." elif [[ -f /opt/iobroker/iobroker ]]; then echo "Existing installation of ioBroker detected in \"/opt/iobroker\"." elif [[ "$(ls *_backupiobroker.tar.gz 2> /dev/null | wc -l)" != "0" && "$(tar -ztvf /opt/iobroker/*_backupiobroker.tar.gz "backup/backup.json" 2> /dev/null | wc -l)" != "0" ]]; then @@ -201,7 +201,7 @@ elif [[ "$(ls *_backupiobroker.tar.gz 2> /dev/null | wc -l)" != "0" && "$(tar -z mv /opt/*.tar.gz /opt/iobroker/backups/ # fixing permission errors during restore chown -R "$setuid":"$setgid" /opt/iobroker - echo 'Done.' + echo "Done." else echo "There is data detected in /opt/iobroker but it looks like it is no instance of ioBroker!" if [[ "$debug" == "true" ]]; then @@ -211,7 +211,7 @@ else echo "Please check/ recreate mounted folder or volume and try again." stop_on_error fi -echo ' ' +echo " " ##### # STEP 3 - Checking ioBroker-Installation @@ -219,7 +219,7 @@ echo ' ' echo "$(printf -- '-%.0s' {1..80})" echo "----- Step 3 of 5: Checking ioBroker installation -----" echo "$(printf -- '-%.0s' {1..80})" -echo ' ' +echo " " # (Re)Setting permissions to "/opt/iobroker" and "/opt/scripts" if [[ "$permissioncheck" == "false" ]]; then @@ -228,17 +228,17 @@ else echo -n "(Re)setting permissions (This might take a while! Please be patient!)... " chown -R "$setuid":"$setgid" /opt/iobroker chown -R "$setuid":"$setgid" /opt/scripts - echo 'Done.' +echo "Done." fi -echo ' ' +echo " " # Backing up original iobroker-file and changing sudo to gosu -echo -n "Fixing \"sudo-bug\" by replacing sudo with gosu... " +echo -n "Fixing \"sudo-bug\" by replacing sudo with gosu..." cp -a /opt/iobroker/iobroker /opt/iobroker/iobroker.bak chmod 755 /opt/iobroker/iobroker sed -i 's/sudo -H -u/gosu/g' /opt/iobroker/iobroker -echo 'Done.' -echo ' ' +echo "Done." +echo " " # Checking multihost and db setup if [[ "$multihost" == "master" || "$multihost" == "slave" ]]; then @@ -262,7 +262,7 @@ elif [[ "$multihost" == "" || "$multihost" == "false" ]]; then echo "[DEBUG] Checking multihost settings... " echo "[DEBUG] No multihost settings detected." echo "[DEBUG] Done." - echo ' ' + echo " " fi # checking custom objects db settings if [[ "$objectsdbtype" != "" || "$objectsdbhost" != "" || "$objectsdbport" != "" ]]; then @@ -277,7 +277,7 @@ elif [[ "$multihost" == "" || "$multihost" == "false" ]]; then echo "[DEBUG] Checking custom objects db settings... " echo "[DEBUG] No custom objects db settings detected." echo "[DEBUG] Done." - echo ' ' + echo " " fi fi # checking custom states db settings @@ -293,7 +293,7 @@ elif [[ "$multihost" == "" || "$multihost" == "false" ]]; then echo "[DEBUG] Checking custom states db settings... " echo "[DEBUG] No custom states db settings detected." echo "[DEBUG] Done." - echo ' ' + echo " " fi fi else @@ -317,14 +317,14 @@ if [[ -f /opt/iobroker/.fresh_install && "$multihost" != "slave" ]]; then echo "Please check your configuration and try again." stop_on_error fi - echo 'Done.' - echo ' ' + echo "Done." + echo " " else echo -n "Checking Database connection... " set +e if iob uuid &> /dev/null; then - echo 'Done.' - echo ' ' + echo "Done." + echo " " else errormsg=$(iob uuid 2>&1 | sed 's/^/[DEBUG] /') echo "Failed." @@ -342,7 +342,7 @@ fi # hostname check if [[ "$multihost" == "slave" ]]; then echo "IOB_MULTIHOST is set to \"slave\". Hostname check will be skipped." - echo ' ' + echo " " else # get admin instance and hostname set +e @@ -371,14 +371,14 @@ else # check hostname if [[ "$adminhostname" != "" && "$adminhostname" != "$(hostname)" ]]; then echo "Hostname in ioBroker does not match the hostname of this container." - echo -n "Updating hostname to \"""$(hostname)""\"... " + echo -n "Updating hostname to \"""$(hostname)""\"..." bash iobroker host "$adminhostname" - echo 'Done.' - echo ' ' + echo "Done." + echo " " elif [[ "$adminhostname" = "$(hostname)" ]]; then echo "Hostname in ioBroker matches the hostname of this container." echo "No action required." - echo ' ' + echo " " else echo "There was a problem checking the hostname." stop_on_error @@ -388,7 +388,7 @@ fi # extended debug output if [[ "$debug" == "true" && "$multihost" != "slave" ]]; then echo "[DEBUG] Collecting some more ioBroker debug information... " - echo ' ' + echo " " # get information and send to array IFS=$'\n' instances_array=("$(iob list instances)") @@ -400,19 +400,19 @@ if [[ "$debug" == "true" && "$multihost" != "slave" ]]; then do echo "$i" done - echo ' ' + echo " " echo "[DEBUG] ##### iobroker repo list #####" for i in "${repos_array[@]}" do echo "$i" done - echo ' ' + echo " " echo "[DEBUG] ##### iobroker update #####" for i in "${updates_array[@]}" do echo "$i" done - echo ' ' + echo " " unset IFS fi @@ -422,11 +422,11 @@ fi echo "$(printf -- '-%.0s' {1..80})" echo "----- Step 4 of 5: Applying special settings -----" echo "$(printf -- '-%.0s' {1..80})" -echo ' ' +echo " " echo "Some adapters have special requirements/ settings which can be activated by the use of environment variables." echo "For more information see ioBroker Docker Image Docs (https://docs.buanet.de/iobroker-docker-image/docs/)." -echo ' ' +echo " " # Checking ENV for Adminport if [[ "$adminport" != "" && "$multihost" != "slave" ]]; then @@ -435,41 +435,41 @@ if [[ "$adminport" != "" && "$multihost" != "slave" ]]; then if [[ "$adminport" != "$adminportold" ]]; then echo "IOB_ADMINPORT is set and does not match port configured in ioBroker." if [[ "$debug" == "true" ]]; then echo "[DEBUG] Detected Admin Port in ioBroker: " "$adminportold"; fi - echo "Setting Adminport to \"""$adminport""\"... " + echo "Setting Adminport to \"""$adminport""\"..." bash iobroker set "$admininstanceshort" --port "$adminport" - echo 'Done.' - echo ' ' + echo "Done." + echo " " fi fi # Checking ENV for Backitup (external database backups) if [[ "$backitup" == "true" ]]; then - echo -n "IOB_BACKITUP_EXTDB is \"true\". Unlocking features... " - echo 'true' > /opt/scripts/.docker_config/.backitup - echo 'Done.' - echo ' ' + echo -n "IOB_BACKITUP_EXTDB is \"true\". Unlocking features..." + echo "true" > /opt/scripts/.docker_config/.backitup + echo "Done." + echo " " fi # Checking ENV for AVAHI if [[ "$avahi" = "true" && "$offlinemode" = "true" ]]; then echo "AVAHI is \"true\", but OFFLINE_MODE is also \"true\". Skipping Avahi daemon setup." elif [[ "$avahi" = "true" ]]; then - echo "AVAHI is \"true\". Running setup script... " + echo "AVAHI is \"true\". Running setup script..." chmod 755 /opt/scripts/setup_avahi.sh bash /opt/scripts/setup_avahi.sh - echo 'Done.' - echo ' ' + echo "Done." + echo " " fi # Checking ENV for Z-WAVE if [[ "$zwave" = "true" && "$offlinemode" = "true" ]]; then echo "ZWAVE is \"true\", but OFFLINE_MODE is also \"true\". Skipping Z-Wave setup." elif [[ "$zwave" = "true" ]]; then - echo "ZWAVE is \"true\". Running setup script... " + echo "ZWAVE is \"true\". Running setup script..." chmod 755 /opt/scripts/setup_zwave.sh bash /opt/scripts/setup_zwave.sh - echo 'Done.' - echo ' ' + echo "Done." + echo " " fi # checking ENV for USBDEVICES @@ -482,7 +482,7 @@ if [[ "$usbdevices" != "" && "$usbdevices" != "none" ]]; then echo -n "Setting permissions for \"""$i""\"... " chown root:dialout "$i" chmod g+rw "$i" - echo 'Done.' + echo "Done." if [[ "$debug" == "true" ]]; then echo "[DEBUG] Permissions set: " "$(ls -al "$i")"; fi else echo "Looks like the device \"""$i""\" does not exist." @@ -491,7 +491,7 @@ if [[ "$usbdevices" != "" && "$usbdevices" != "none" ]]; then stop_on_error fi done - echo ' ' + echo " " fi # Checking for Userscripts in /opt/userscripts @@ -500,23 +500,23 @@ if [[ $(find /opt/userscripts -type f | wc -l) -lt 1 ]]; then tar -xf /opt/initial_userscripts.tar -C / chmod 755 /opt/userscripts/userscript_firststart_example.sh chmod 755 /opt/userscripts/userscript_everystart_example.sh - echo 'Done.' + echo "Done." elif [[ -f /opt/userscripts/userscript_firststart.sh || -f /opt/userscripts/userscript_everystart.sh ]]; then if [[ -f /opt/userscripts/userscript_firststart.sh && -f /opt/.first_run ]]; then echo "Userscript for first start detected and this is the first start of a new container." - echo "Running userscript_firststart.sh... " + echo "Running userscript_firststart.sh..." chmod 755 /opt/userscripts/userscript_firststart.sh bash /opt/userscripts/userscript_firststart.sh - echo 'Done.' + echo "Done." fi if [[ -f /opt/userscripts/userscript_everystart.sh ]]; then - echo "Userscript for every start detected. Running userscript_everystart.sh... " + echo "Userscript for every start detected. Running userscript_everystart.sh..." chmod 755 /opt/userscripts/userscript_everystart.sh bash /opt/userscripts/userscript_everystart.sh - echo 'Done.' + echo "Done." fi fi -echo ' ' +echo " " # Removing first run an fresh install markers when exists if [[ -f /opt/.first_run ]]; then rm -f /opt/.first_run; fi @@ -528,9 +528,9 @@ if [[ -f /opt/iobroker/.fresh_install ]]; then rm -f /opt/iobroker/.fresh_instal echo "$(printf -- '-%.0s' {1..80})" echo "----- Step 5 of 5: ioBroker startup -----" echo "$(printf -- '-%.0s' {1..80})" -echo ' ' -echo "Starting ioBroker... " -echo ' ' +echo " " +echo "Starting ioBroker..." +echo " " echo "##### #### ### ## # iobroker.js-controller log output # ## ### #### #####" # Setting healthcheck status to "running" @@ -538,9 +538,9 @@ echo "running" > /opt/scripts/.docker_config/.healthcheck # Function for graceful shutdown by SIGTERM signal shut_down() { - echo ' ' + echo " " echo "Recived termination signal (SIGTERM)." - echo "Shutting down ioBroker... " + echo "Shutting down ioBroker..." local status timeout @@ -558,9 +558,9 @@ shut_down() { # pgrep exits with status 1 when there are no matches while pgrep -u iobroker > /dev/null; (( $? != 1 )); do if (($(date +%s) > timeout)); then - echo -e '\nTimeout reached. Killing remaining processes... ' + echo -e '\nTimeout reached. Killing remaining processes...' pkill --signal SIGKILL -u iobroker - echo 'Done. Have a nice day!' + echo "Done. Have a nice day!" exit fi diff --git a/debian/scripts/maintenance.sh b/debian/scripts/maintenance.sh index dc423bc..4157f82 100644 --- a/debian/scripts/maintenance.sh +++ b/debian/scripts/maintenance.sh @@ -10,27 +10,27 @@ pkill_timeout=10 # timeout for stopping iobroker in seconds # display help text display_help() { - echo 'This script helps you manage your ioBroker container!' - echo '' + echo "This script helps you manage your ioBroker container!" + echo " " echo "Usage: maintenance [ COMMAND ] [ OPTION ]" echo " maint [ COMMAND ] [ OPTION ]" echo " m [ COMMAND ] [ OPTION ]" - echo '' - echo 'COMMANDS' - echo '------------------' - echo ' status > reports the current state of maintenance mode' - echo ' on > switches mantenance mode ON' - echo ' off > switches mantenance mode OFF and stops or restarts the container' - echo ' upgrade > puts the container to maintenance mode and upgrades ioBroker' - echo ' restart > stops iobroker and stops or restarts the container' - echo ' restore > stops iobroker and restores the last backup' - echo ' help > shows this help' - echo '' - echo 'OPTIONS' - echo '------------------' - echo ' -y|--yes > confirms the used command without asking' - echo ' -h|--help > shows this help' - echo '' + echo " " + echo "COMMANDS" + echo "------------------" + echo " status > reports the current state of maintenance mode" + echo " on > switches mantenance mode ON" + echo " off > switches mantenance mode OFF and stops or restarts the container" + echo " upgrade > puts the container to maintenance mode and upgrades ioBroker" + echo " restart > stops iobroker and stops or restarts the container" + echo " restore > stops iobroker and restores the last backup" + echo " help > shows this help" + echo " " + echo "OPTIONS" + echo "------------------" + echo " -y|--yes > confirms the used command without asking" + echo " -h|--help > shows this help" + echo " " } # check maintenance enabled @@ -46,35 +46,35 @@ check_starting() { # display maintenance status maintenance_status() { if maintenance_enabled; then - echo 'Maintenance mode is turned ON.' + echo "Maintenance mode is turned ON." else - echo 'Maintenance mode is turned OFF.' + echo "Maintenance mode is turned OFF." fi } # enable maintenance mode enable_maintenance() { if maintenance_enabled; then - echo 'Maintenance mode is already turned ON.' + echo "Maintenance mode is already turned ON." return fi if [[ "$killbyname" == yes ]]; then # undocumented option, only for use with backitup restore scripts # stops iobroker by terminating js-controller process by name (the old way) - echo 'This command will activate maintenance mode and stop js-controller.' - echo 'Activating maintenance mode...' - echo 'maintenance' > "$healthcheck" + echo "This command will activate maintenance mode and stop js-controller." + echo "Activating maintenance mode..." + echo "maintenance" > "$healthcheck" sleep 1 - echo 'Done.' + echo "Done." echo -n 'Stopping ioBroker...' pkill -u iobroker -f iobroker.js-controller sleep 5 - echo 'Done.' + echo "Done." return fi - echo 'You are now going to stop ioBroker and activate maintenance mode for this container.' + echo "You are now going to stop ioBroker and activate maintenance mode for this container." if [[ "$autoconfirm" != yes ]]; then local reply @@ -86,13 +86,13 @@ enable_maintenance() { return 1 fi else - echo 'This command was already confirmed by the -y or --yes option.' + echo "This command was already confirmed by the -y or --yes option." fi - echo 'Activating maintenance mode...' - echo 'maintenance' > "$healthcheck" + echo "Activating maintenance mode..." + echo "maintenance" > "$healthcheck" sleep 1 - echo 'Done.' + echo "Done." echo -n 'Stopping ioBroker...' stop_iob } @@ -100,12 +100,12 @@ enable_maintenance() { # disable maintenance mode disable_maintenance() { if ! maintenance_enabled; then - echo 'Maintenance mode is already turned OFF.' + echo "Maintenance mode is already turned OFF." return fi - echo 'You are now going to deactivate maintenance mode for this container.' - echo 'Depending on the restart policy, your container will be stopped or restarted immediately.' + echo "You are now going to deactivate maintenance mode for this container." + echo "Depending on the restart policy, your container will be stopped or restarted immediately." if [[ "$autoconfirm" != yes ]]; then local reply @@ -117,21 +117,21 @@ disable_maintenance() { return 1 fi else - echo 'This command was already confirmed by the -y or --yes option.' + echo "This command was already confirmed by the -y or --yes option." fi - echo 'Deactivating maintenance mode and forcing container to stop or restart...' - echo 'stopping' > "$healthcheck" + echo "Deactivating maintenance mode and forcing container to stop or restart..." + echo "stopping" > "$healthcheck" pkill -u root - echo 'Done.' + echo "Done." } # upgrade js-controller upgrade_jscontroller() { - echo 'You are now going to upgrade your js-controller.' - echo 'As this will change data in /opt/iobroker, make sure you have a backup!' - echo 'During the upgrade process, the container will automatically switch into maintenance mode and stop ioBroker.' - echo 'Depending on the restart policy, your container will be stopped or restarted automatically after the upgrade.' + echo "You are now going to upgrade your js-controller." + echo "As this will change data in /opt/iobroker, make sure you have a backup!" + echo "During the upgrade process, the container will automatically switch into maintenance mode and stop ioBroker." + echo "Depending on the restart policy, your container will be stopped or restarted automatically after the upgrade." if [[ "$autoconfirm" != yes ]]; then local reply @@ -143,7 +143,7 @@ upgrade_jscontroller() { return 1 fi else - echo 'This command was already confirmed by the -y or --yes option.' + echo "This command was already confirmed by the -y or --yes option." fi if ! maintenance_enabled > /dev/null; then @@ -151,16 +151,16 @@ upgrade_jscontroller() { enable_maintenance fi - echo 'Upgrading js-controller...' + echo "Upgrading js-controller..." iobroker update sleep 1 iobroker upgrade self sleep 1 - echo 'Done.' + echo "Done." - echo 'Container will be stopped or restarted in 5 seconds...' + echo "Container will be stopped or restarted in 5 seconds..." sleep 5 - echo 'stopping' > "$healthcheck" + echo "stopping" > "$healthcheck" pkill -u root } @@ -182,24 +182,24 @@ stop_iob() { # pgrep exits with status 1 when there are no matches while pgrep -u iobroker > /dev/null; (( $? != 1 )); do if (($(date +%s) > timeout)); then - echo -e '\nTimeout reached. Killing remaining processes...' + echo -e "\nTimeout reached. Killing remaining processes..." pgrep --list-full -u iobroker pkill --signal SIGKILL -u iobroker - echo 'Done.' + echo "Done." return fi - echo -n '.' + echo -n "." sleep 1 done - echo -e '\nDone.' + echo -e "\nDone." } # restart container restart_container() { - echo 'You are now going to call a restart of your container.' - echo 'Restarting will work depending on the configured restart policy.' + echo "You are now going to call a restart of your container." + echo "Restarting will work depending on the configured restart policy." if [[ "$autoconfirm" != yes ]]; then local reply @@ -211,23 +211,23 @@ restart_container() { return 1 fi else - echo 'This command was already confirmed by the -y or --yes option.' + echo "This command was already confirmed by the -y or --yes option." fi - echo -n 'Stopping ioBroker...' + echo -n "Stopping ioBroker..." stop_iob - echo 'Container will be stopped or restarted in 5 seconds...' + echo "Container will be stopped or restarted in 5 seconds..." sleep 5 - echo 'stopping' > "$healthcheck" + echo "stopping" > "$healthcheck" pkill -u root } # restore iobroker restore_iobroker() { - echo 'You are now going to perform a restore of your iobroker.' - echo 'During the restore process, the container will automatically switch into maintenance mode and stop ioBroker.' - echo 'Depending on the restart policy, your container will be stopped or restarted automatically after the restore.' + echo "You are now going to perform a restore of your iobroker." + echo "During the restore process, the container will automatically switch into maintenance mode and stop ioBroker." + echo "Depending on the restart policy, your container will be stopped or restarted automatically after the restore." if [[ "$autoconfirm" != yes ]]; then local reply @@ -239,7 +239,7 @@ restore_iobroker() { return 1 fi else - echo 'This command was already confirmed by the -y or --yes option.' + echo "This command was already confirmed by the -y or --yes option." fi if check_starting > /dev/null; then @@ -265,8 +265,8 @@ restore_iobroker() { echo "Please check backup file location and permissions and try again." return 1 fi - echo 'Done.' - echo ' ' + echo "Done." + echo " " echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!" echo "!!!! IMPORTANT NOTE !!!!" echo "!!!! The maintenance script restored iobroker from a backup file. !!!!" @@ -276,9 +276,9 @@ restore_iobroker() { echo "!!!! You can view installation process by taking a look at ioBroker log. !!!!" echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!" sleep 10 - echo 'Container will be stopped or restarted in 10 seconds...' + echo "Container will be stopped or restarted in 10 seconds..." sleep 10 - echo 'stopping' > "$healthcheck" + echo "stopping" > "$healthcheck" pkill -u root } @@ -321,7 +321,7 @@ for arg in "$@"; do ;; *) >&2 echo "Unknown parameter: $arg" - >&2 echo 'Please try again or see help (help|-h|--help).' + >&2 echo "Please try again or see help (help|-h|--help)." exit 1 ;; esac diff --git a/debian/scripts/setup_avahi.sh b/debian/scripts/setup_avahi.sh index 6445516..01f6878 100644 --- a/debian/scripts/setup_avahi.sh +++ b/debian/scripts/setup_avahi.sh @@ -2,19 +2,19 @@ if [ -e /usr/sbin/avahi-daemon ] && [ -e /var/run/dbus ] then - echo '[setup_avahi.sh] Avahi is already installed. Nothing to do here.' + echo "[setup_avahi.sh] Avahi is already installed. Nothing to do here." else - echo -n '[setup_avahi.sh] Avahi-daemon is NOT installed. Going to install it now... ' + echo -n "[setup_avahi.sh] Avahi-daemon is NOT installed. Going to install it now... " apt-get update > /opt/scripts/avahi_startup.log 2>&1 - apt-get install -y libavahi-compat-libdnssd-dev avahi-daemon >> /opt/scripts/avahi_startup.log 2>&1 + apt-get install -y --no-install-recommends libavahi-compat-libdnssd-dev avahi-daemon >> /opt/scripts/avahi_startup.log 2>&1 rm -rf /var/lib/apt/lists/* >> /opt/scripts/avahi_startup.log 2>&1 - echo 'Done.' - echo -n '[setup_avahi.sh] Configuring avahi-daemon... ' + echo "Done." + echo -n "[setup_avahi.sh] Configuring avahi-daemon... " sed -i '/^rlimit-nproc/s/^\(.*\)/#\1/g' /etc/avahi/avahi-daemon.conf - echo 'Done.' - echo -n '[setup_avahi.sh] Configuring dbus... ' + echo "Done." + echo -n "[setup_avahi.sh] Configuring dbus... " mkdir /var/run/dbus/ - echo 'Done.' + echo "Done." fi if [ -f /var/run/dbus/pid ]; @@ -27,12 +27,12 @@ then rm -f /var/run/avahi-daemon//pid fi -echo -n '[setup_avahi.sh] Starting dbus... ' +echo -n "[setup_avahi.sh] Starting dbus... " dbus-daemon --system >> /opt/scripts/avahi_startup.log 2>&1 -echo 'Done.' +echo "Done." -echo -n '[setup_avahi.sh] Starting avahi-daemon... ' +echo -n "[setup_avahi.sh] Starting avahi-daemon..." /etc/init.d/avahi-daemon start >> /opt/scripts/avahi_startup.log 2>&1 -echo 'Done.' +echo "Done." exit 0 diff --git a/debian/scripts/setup_iob_db.sh b/debian/scripts/setup_iob_db.sh index 44164b9..df1d679 100644 --- a/debian/scripts/setup_iob_db.sh +++ b/debian/scripts/setup_iob_db.sh @@ -26,7 +26,7 @@ set_objectsdb_type() { echo -n "Setting type of objects db to \"""$objectsdbtype""\"... " jq --arg value "$objectsdbtype" '.objects.type = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_OBJECTSDB_TYPE is available and value meets detected ioBroker installation." fi @@ -38,7 +38,7 @@ set_objectsdb_host() { echo -n "Setting host of objects db to \"""$objectsdbhost""\"... " jq --arg value "$objectsdbhost" '.objects.host = ($value|split(","))' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_OBJECTSDB_HOST is available and value meets detected ioBroker installation." fi @@ -48,7 +48,7 @@ set_objectsdb_host() { echo -n "Setting name of objects db to \"""$objectsdbname""\"... " jq --arg value "$objectsdbname" '.objects.sentinelName = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_OBJECTSDB_NAME is available and value meets detected ioBroker installation." fi @@ -58,7 +58,7 @@ set_objectsdb_host() { echo -n "Setting name of objects db to \"mymaster\"... " jq --arg value "mymaster" '.objects.sentinelName = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_OBJECTSDB_NAME is not available but default value \"mymaster\" meets detected ioBroker installation.." fi @@ -69,7 +69,7 @@ set_objectsdb_host() { echo -n "Setting host of objects db to \"""$objectsdbhost""\"... " jq --arg value "$objectsdbhost" '.objects.host = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_OBJECTSDB_HOST is available and value meets detected ioBroker installation." fi @@ -82,7 +82,7 @@ set_objectsdb_port() { echo -n "Setting port of objects db to \"""$objectsdbport""\"... " jq --arg value "$objectsdbport" '.objects.port = ($value|split(","))' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_OBJECTSDB_PORT is available and value meets detected ioBroker installation." fi @@ -92,7 +92,7 @@ set_objectsdb_port() { echo -n "Setting port of objects db to \"""$objectsdbport""\"... " jq --arg value "$objectsdbport" '.objects.port = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_OBJECTSDB_PORT is available and value meets detected ioBroker installation." fi @@ -104,13 +104,13 @@ set_objectsdb_pass() { echo -n "Removing password of objects db... " jq '.objects.options.auth_pass = null' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." elif [[ "$objectsdbpass" != "$(jq -r '.objects.options.auth_pass' /opt/iobroker/iobroker-data/iobroker.json)" ]]; then echo "IOB_OBJECTSDB_PASS is available but value is different from detected ioBroker installation." echo -n "Setting password of objects db... " jq --arg value "$objectsdbpass" '.objects.options.auth_pass = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_OBJECTSDB_PASS is available and value meets detected ioBroker installation." fi @@ -121,7 +121,7 @@ set_statesdb_type() { echo -n "Setting type of states db to \"""$statesdbtype""\"... " jq --arg value "$statesdbtype" '.states.type = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_STATESDB_TYPE is available and value meets detected ioBroker installation." fi @@ -133,7 +133,7 @@ set_statesdb_host() { echo -n "Setting host of states db to \"""$statesdbhost""\"... " jq --arg value "$statesdbhost" '.states.host = ($value|split(","))' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_STATESDB_HOST is available and value meets detected ioBroker installation." fi @@ -143,7 +143,7 @@ set_statesdb_host() { echo -n "Setting name of states db to \"""$statesdbname""\"... " jq --arg value "$statesdbname" '.states.sentinelName = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_STATESDB_NAME is available and value meets detected ioBroker installation." fi @@ -153,7 +153,7 @@ set_statesdb_host() { echo -n "Setting name of states db to \"mymaster\"... " jq --arg value "mymaster" '.states.sentinelName = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_STATESDB_NAME is not available but default value \"mymaster\" meets detected ioBroker installation.." fi @@ -164,7 +164,7 @@ set_statesdb_host() { echo -n "Setting host of states db to \"""$statesdbhost""\"... " jq --arg value "$statesdbhost" '.states.host = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_STATESDB_HOST is available and value meets detected ioBroker installation." fi @@ -177,7 +177,7 @@ set_statesdb_port() { echo -n "Setting port of states db to \"""$statesdbport""\"... " jq --arg value "$statesdbport" '.states.port = ($value|split(","))' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_STATESDB_PORT is available and value meets detected ioBroker installation." fi @@ -187,7 +187,7 @@ set_statesdb_port() { echo -n "Setting port of states db to \"""$statesdbport""\"... " jq --arg value "$statesdbport" '.states.port = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_STATESDB_PORT is available and value meets detected ioBroker installation." fi @@ -199,19 +199,19 @@ set_statesdb_pass() { echo -n "Removing password of states db... " jq '.states.options.auth_pass = null' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." elif [[ "$statesdbpass" != "$(jq -r '.states.options.auth_pass' /opt/iobroker/iobroker-data/iobroker.json)" ]]; then echo "IOB_STATESDB_PASS is available but value is different from detected ioBroker installation." echo -n "Setting password of states db... " jq --arg value "$statesdbpass" '.states.options.auth_pass = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "IOB_STATESDB_PASS is available and value meets detected ioBroker installation." fi } config_error_output() { - echo ' ' + echo " " echo "Something went wrong. Looks like at least one parameter defining the custom db connection was not set properly or is missing." echo "Please check your configuration and try again." echo "For more information see ioBroker Docker Image Docs (https://docs.buanet.de/iobroker-docker-image/docs/)." @@ -220,8 +220,8 @@ config_error_output() { # parameter check if [[ "$1" == "-master" ]]; then # setup master echo "IOB_MULTIHOST is available and set to \"master\"." - echo 'Done.' - echo ' ' + echo "Done." + echo " " # multihost objects db if [[ "$objectsdbtype" != "" && "$objectsdbhost" != "" && "$objectsdbport" != "" ]]; then echo "Configuring custom objects db..." @@ -229,15 +229,15 @@ if [[ "$1" == "-master" ]]; then # setup master set_objectsdb_host set_objectsdb_port if [[ "$objectsdbpass" != "" ]]; then set_objectsdb_pass; fi - echo 'Done.' - echo ' ' + echo "Done." + echo " " elif [[ "$objectsdbtype" == "" && "$objectsdbhost" == "" && "$objectsdbport" == "" ]]; then echo "No custom objects db is set." if [[ "$(jq -r '.objects.host' /opt/iobroker/iobroker-data/iobroker.json)" != "0.0.0.0" ]]; then echo -n "Configuring default objects db to accept external connections... " jq --arg value "0.0.0.0" '.objects.host = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "Default objects db is accepting external connections." fi @@ -257,15 +257,15 @@ if [[ "$1" == "-master" ]]; then # setup master set_statesdb_host set_statesdb_port if [[ "$statesdbpass" != "" ]]; then set_statesdb_pass; fi - echo 'Done.' - echo ' ' + echo "Done." + echo " " elif [[ "$statesdbtype" == "" && "$statesdbhost" == "" && "$statesdbport" == "" ]]; then echo "No custom states db is set." if [[ "$(jq -r '.states.host' /opt/iobroker/iobroker-data/iobroker.json)" != "0.0.0.0" ]]; then echo -n "Configuring default states db to accept external connections... " jq --arg value "0.0.0.0" '.states.host = $value' /opt/iobroker/iobroker-data/iobroker.json > /opt/iobroker/iobroker-data/iobroker.json.tmp write_iobroker_json - echo 'Done.' + echo "Done." else echo "Default states db is accepting external connections." fi @@ -280,8 +280,8 @@ if [[ "$1" == "-master" ]]; then # setup master fi elif [[ "$1" == "-slave" ]]; then # setup slave echo "IOB_MULTIHOST is available and set to \"slave\"." - echo 'Done.' - echo ' ' + echo "Done." + echo " " # multihost slave objects db connection if [[ "$objectsdbtype" != "" && "$objectsdbhost" != "" && "$objectsdbport" != "" ]]; then echo "Configuring objects db connection..." @@ -289,8 +289,8 @@ elif [[ "$1" == "-slave" ]]; then # setup slave set_objectsdb_host set_objectsdb_port if [[ "$objectsdbpass" != "" ]]; then set_objectsdb_pass; fi - echo 'Done.' - echo ' ' + echo "Done." + echo " " else if [[ "$debug" == "true" ]]; then echo "[DEBUG] IOB_OBJECTSDB_TYPE = ""$objectsdbtype" @@ -307,8 +307,8 @@ elif [[ "$1" == "-slave" ]]; then # setup slave set_statesdb_host set_statesdb_port if [[ "$statesdbpass" != "" ]]; then set_statesdb_pass; fi - echo 'Done.' - echo ' ' + echo "Done." + echo " " else if [[ "$debug" == "true" ]]; then echo "[DEBUG] IOB_STATESDB_TYPE = ""$statesdbtype" @@ -325,8 +325,8 @@ elif [[ "$1" == "-objectsdb" ]]; then # setup objects db standalone set_objectsdb_host set_objectsdb_port if [[ "$objectsdbpass" != "" ]]; then set_objectsdb_pass; fi - echo 'Done.' - echo ' ' + echo "Done." + echo " " else if [[ "$debug" == "true" ]]; then echo "[DEBUG] IOB_OBJECTSDB_TYPE = ""$objectsdbtype" @@ -343,8 +343,8 @@ elif [[ "$1" == "-statesdb" ]]; then # setup states db standalone set_statesdb_host set_statesdb_port if [[ "$statesdbpass" != "" ]]; then set_statesdb_pass; fi - echo 'Done.' - echo ' ' + echo "Done." + echo " " else if [[ "$debug" == "true" ]]; then echo "[DEBUG] IOB_STATESDB_TYPE = ""$statesdbtype" diff --git a/debian/scripts/setup_packages.sh b/debian/scripts/setup_packages.sh index 4d6ddb6..6c79c79 100644 --- a/debian/scripts/setup_packages.sh +++ b/debian/scripts/setup_packages.sh @@ -16,7 +16,7 @@ check_package_preq() { if [[ "$i" == "influxdb" || "$i" == "influxdb2-cli" ]]; then # add influxdata repo keys wget -qO- https://repos.influxdata.com/influxdata-archive_compat.key | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/influxdata-archive_compat.gpg > /dev/null - echo 'deb [signed-by=/etc/apt/trusted.gpg.d/influxdata-archive_compat.gpg] https://repos.influxdata.com/debian stable main' | sudo tee /etc/apt/sources.list.d/influxdata.list + echo "deb [signed-by=/etc/apt/trusted.gpg.d/influxdata-archive_compat.gpg] https://repos.influxdata.com/debian stable main" | sudo tee /etc/apt/sources.list.d/influxdata.list apt-get -q update >> /opt/scripts/setup_packages.log 2>&1 fi } @@ -35,12 +35,12 @@ check_package_validity() { packages=$(echo "$packages" | sed 's/ / /g') done if [[ $debug == "true" ]]; then echo "[DEBUG] New list of packages: ""$packages"; fi - echo ' ' + echo " " fi } if [[ "$1" == "-install" ]]; then - echo ' ' + echo " " apt-get -q update >> /opt/scripts/setup_packages.log 2>&1 check_package_validity for i in $packages; do @@ -69,7 +69,7 @@ elif [[ "$1" == "-update" ]]; then echo "Make sure the container has internet access to get the latest package updates." echo "This has no impact to the setup process. The script will continue." else - echo 'Done.' + echo "Done." fi else echo "No paramerter found!" @@ -78,6 +78,7 @@ fi # Silent Cleanup apt-get -qq autoclean -y && apt-get -qq autoremove && apt-get -qq clean -rm -rf /tmp/* /var/tmp/* && rm -rf /root/.cache/* && rm -rf /var/lib/apt/lists/* && rm -f /opt/scripts/.docker_config/.packages +rm -rf /tmp/* /var/tmp/* /root/.cache/* /var/lib/apt/lists/* +rm -f /opt/scripts/.packages /opt/scripts/.docker_config/.packages exit 0 \ No newline at end of file diff --git a/debian/scripts/setup_zwave.sh b/debian/scripts/setup_zwave.sh index d85bbd6..8efd62e 100644 --- a/debian/scripts/setup_zwave.sh +++ b/debian/scripts/setup_zwave.sh @@ -2,16 +2,16 @@ if [ -e /usr/local/lib64 ] then - echo '[setup_zwave.sh] Openzwave is already installed. Nothing to do here.' + echo "[setup_zwave.sh] Openzwave is already installed. Nothing to do here." else - echo -n '[setup_zwave.sh] Openzwave is NOT installed. Going to install it now... ' + echo -n "[setup_zwave.sh] Openzwave is NOT installed. Going to install it now... " cd /opt || exit curl -s -L -O http://old.openzwave.com/downloads/openzwave-1.6.1007.tar.gz tar -xf openzwave-1.6.1007.tar.gz && rm openzwave-1.6.1007.tar.gz cd openzwave-1.6.1007 && make > /dev/null 2>&1 && make install > /dev/null 2>&1 ldconfig /usr/local/lib64 cd /opt/iobroker || exit - echo 'Done.' + echo "Done." fi exit 0 diff --git a/debian/userscripts/userscript_everystart_example.sh b/debian/userscripts/userscript_everystart_example.sh index 9023677..320e6a9 100644 --- a/debian/userscripts/userscript_everystart_example.sh +++ b/debian/userscripts/userscript_everystart_example.sh @@ -5,9 +5,9 @@ # You can add your advanced script code here! -echo ' ' +echo " " echo "I'm your startscript userscript_everystart.sh. I will run on EVERY container startup." -echo ' ' +echo " " exit 0 diff --git a/debian/userscripts/userscript_firststart_example.sh b/debian/userscripts/userscript_firststart_example.sh index 4fef50d..1e25e34 100644 --- a/debian/userscripts/userscript_firststart_example.sh +++ b/debian/userscripts/userscript_firststart_example.sh @@ -5,8 +5,8 @@ # You can add your advanced script code here! -echo ' ' +echo " " echo "I'm your startscript userscript_firststart.sh. I will run only on the FIRST startup of the container." -echo ' ' +echo " " exit 0 From 2359e5118c26f94b7cc2660ee000d5ee7c3bc093 Mon Sep 17 00:00:00 2001 From: dontobi Date: Fri, 7 Jul 2023 09:28:06 +0200 Subject: [PATCH 2/5] Add "--no-install-recommends" --- debian/scripts/setup_packages.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/scripts/setup_packages.sh b/debian/scripts/setup_packages.sh index 6c79c79..1db9a5f 100644 --- a/debian/scripts/setup_packages.sh +++ b/debian/scripts/setup_packages.sh @@ -47,7 +47,7 @@ if [[ "$1" == "-install" ]]; then if ! dpkg -s "$i" >/dev/null 2>&1; then echo -n "$i is not installed. Installing... " check_package_preq >> /opt/scripts/setup_packages.log 2>&1 - if ! apt-get -q -y install "$i" >> /opt/scripts/setup_packages.log 2>&1; then + if ! apt-get -q -y --no-install-recommends install "$i" >> /opt/scripts/setup_packages.log 2>&1; then echo "Failed." echo "For more details see \"/opt/scripts/setup_packages.log\"." else From 52306ee19a6dd648dbf8393e3491faa29650c440 Mon Sep 17 00:00:00 2001 From: dontobi Date: Sat, 8 Jul 2023 08:14:59 +0200 Subject: [PATCH 3/5] Latest script adjustments --- debian/scripts/iobroker_startup.sh | 31 +++++++++++++++--------------- debian/scripts/maintenance.sh | 2 +- debian/scripts/setup_avahi.sh | 2 +- 3 files changed, 17 insertions(+), 18 deletions(-) diff --git a/debian/scripts/iobroker_startup.sh b/debian/scripts/iobroker_startup.sh index b153da3..f5c1adf 100644 --- a/debian/scripts/iobroker_startup.sh +++ b/debian/scripts/iobroker_startup.sh @@ -143,12 +143,11 @@ if [[ -f /opt/.first_run ]]; then echo "PACKAGES is set, but OFFLINE_MODE is \"true\". Skipping Linux package installation." elif [[ "$packages" != "" ]]; then echo "PACKAGES is set. Installing the following additional Linux packages: ""$packages" - #echo "$packages" > /opt/scripts/.docker_config/.packages bash /opt/scripts/setup_packages.sh -install fi echo " " # Register maintenance script - echo -n "Registering maintenance script as command..." + echo -n "Registering maintenance script as command... " echo "alias maintenance=\'/opt/scripts/maintenance.sh\'" >> /root/.bashrc echo "alias maint=\'/opt/scripts/maintenance.sh\'" >> /root/.bashrc echo "alias m=\'/opt/scripts/maintenance.sh\'" >> /root/.bashrc @@ -181,7 +180,7 @@ echo " " if [[ `find /opt/iobroker -type f | wc -l` -lt 1 ]]; then echo "There is no data detected in /opt/iobroker." - echo -n "Restoring initial ioBroker installation..." + echo -n "Restoring initial ioBroker installation... " tar -xf /opt/initial_iobroker.tar -C / echo "Done." elif [[ -f /opt/iobroker/iobroker ]]; then @@ -193,7 +192,7 @@ elif [[ "$(ls *_backupiobroker.tar.gz 2> /dev/null | wc -l)" != "0" && "$(tar -z echo "IoBroker will start with a fresh installation, while your backup file will be copied into the backup directory." echo "You will be able to restore your backup file manually by using the backitup adapter or the containers maintenance script." echo "For more information see ioBroker Docker Image Docs (https://docs.buanet.de/iobroker-docker-image/docs/)." - echo ' ' + echo " " echo -n "Copying backup file and restoring initial ioBroker installation... " mv /opt/iobroker/*.tar.gz /opt/ tar -xf /opt/initial_iobroker.tar -C / @@ -228,12 +227,12 @@ else echo -n "(Re)setting permissions (This might take a while! Please be patient!)... " chown -R "$setuid":"$setgid" /opt/iobroker chown -R "$setuid":"$setgid" /opt/scripts -echo "Done." + echo "Done." fi echo " " # Backing up original iobroker-file and changing sudo to gosu -echo -n "Fixing \"sudo-bug\" by replacing sudo with gosu..." +echo -n "Fixing \"sudo-bug\" by replacing sudo with gosu... " cp -a /opt/iobroker/iobroker /opt/iobroker/iobroker.bak chmod 755 /opt/iobroker/iobroker sed -i 's/sudo -H -u/gosu/g' /opt/iobroker/iobroker @@ -371,7 +370,7 @@ else # check hostname if [[ "$adminhostname" != "" && "$adminhostname" != "$(hostname)" ]]; then echo "Hostname in ioBroker does not match the hostname of this container." - echo -n "Updating hostname to \"""$(hostname)""\"..." + echo -n "Updating hostname to \"""$(hostname)""\"... " bash iobroker host "$adminhostname" echo "Done." echo " " @@ -435,7 +434,7 @@ if [[ "$adminport" != "" && "$multihost" != "slave" ]]; then if [[ "$adminport" != "$adminportold" ]]; then echo "IOB_ADMINPORT is set and does not match port configured in ioBroker." if [[ "$debug" == "true" ]]; then echo "[DEBUG] Detected Admin Port in ioBroker: " "$adminportold"; fi - echo "Setting Adminport to \"""$adminport""\"..." + echo "Setting Adminport to \"""$adminport""\"... " bash iobroker set "$admininstanceshort" --port "$adminport" echo "Done." echo " " @@ -454,7 +453,7 @@ fi if [[ "$avahi" = "true" && "$offlinemode" = "true" ]]; then echo "AVAHI is \"true\", but OFFLINE_MODE is also \"true\". Skipping Avahi daemon setup." elif [[ "$avahi" = "true" ]]; then - echo "AVAHI is \"true\". Running setup script..." + echo "AVAHI is \"true\". Running setup script... " chmod 755 /opt/scripts/setup_avahi.sh bash /opt/scripts/setup_avahi.sh echo "Done." @@ -465,7 +464,7 @@ fi if [[ "$zwave" = "true" && "$offlinemode" = "true" ]]; then echo "ZWAVE is \"true\", but OFFLINE_MODE is also \"true\". Skipping Z-Wave setup." elif [[ "$zwave" = "true" ]]; then - echo "ZWAVE is \"true\". Running setup script..." + echo "ZWAVE is \"true\". Running setup script... " chmod 755 /opt/scripts/setup_zwave.sh bash /opt/scripts/setup_zwave.sh echo "Done." @@ -504,13 +503,13 @@ if [[ $(find /opt/userscripts -type f | wc -l) -lt 1 ]]; then elif [[ -f /opt/userscripts/userscript_firststart.sh || -f /opt/userscripts/userscript_everystart.sh ]]; then if [[ -f /opt/userscripts/userscript_firststart.sh && -f /opt/.first_run ]]; then echo "Userscript for first start detected and this is the first start of a new container." - echo "Running userscript_firststart.sh..." + echo "Running userscript_firststart.sh... " chmod 755 /opt/userscripts/userscript_firststart.sh bash /opt/userscripts/userscript_firststart.sh echo "Done." fi if [[ -f /opt/userscripts/userscript_everystart.sh ]]; then - echo "Userscript for every start detected. Running userscript_everystart.sh..." + echo "Userscript for every start detected. Running userscript_everystart.sh... " chmod 755 /opt/userscripts/userscript_everystart.sh bash /opt/userscripts/userscript_everystart.sh echo "Done." @@ -529,7 +528,7 @@ echo "$(printf -- '-%.0s' {1..80})" echo "----- Step 5 of 5: ioBroker startup -----" echo "$(printf -- '-%.0s' {1..80})" echo " " -echo "Starting ioBroker..." +echo "Starting ioBroker... " echo " " echo "##### #### ### ## # iobroker.js-controller log output # ## ### #### #####" @@ -540,7 +539,7 @@ echo "running" > /opt/scripts/.docker_config/.healthcheck shut_down() { echo " " echo "Recived termination signal (SIGTERM)." - echo "Shutting down ioBroker..." + echo "Shutting down ioBroker... " local status timeout @@ -558,13 +557,13 @@ shut_down() { # pgrep exits with status 1 when there are no matches while pgrep -u iobroker > /dev/null; (( $? != 1 )); do if (($(date +%s) > timeout)); then - echo -e '\nTimeout reached. Killing remaining processes...' + echo -e "\nTimeout reached. Killing remaining processes... " pkill --signal SIGKILL -u iobroker echo "Done. Have a nice day!" exit fi - echo -n '.' + echo -n "." sleep 1 done diff --git a/debian/scripts/maintenance.sh b/debian/scripts/maintenance.sh index 4157f82..be5c0de 100644 --- a/debian/scripts/maintenance.sh +++ b/debian/scripts/maintenance.sh @@ -63,7 +63,7 @@ enable_maintenance() { # undocumented option, only for use with backitup restore scripts # stops iobroker by terminating js-controller process by name (the old way) echo "This command will activate maintenance mode and stop js-controller." - echo "Activating maintenance mode..." + echo -n "Activating maintenance mode... " echo "maintenance" > "$healthcheck" sleep 1 echo "Done." diff --git a/debian/scripts/setup_avahi.sh b/debian/scripts/setup_avahi.sh index 01f6878..46d5873 100644 --- a/debian/scripts/setup_avahi.sh +++ b/debian/scripts/setup_avahi.sh @@ -31,7 +31,7 @@ echo -n "[setup_avahi.sh] Starting dbus... " dbus-daemon --system >> /opt/scripts/avahi_startup.log 2>&1 echo "Done." -echo -n "[setup_avahi.sh] Starting avahi-daemon..." +echo -n "[setup_avahi.sh] Starting avahi-daemon... " /etc/init.d/avahi-daemon start >> /opt/scripts/avahi_startup.log 2>&1 echo "Done." From 3c6fc0b1b12df0fd7ee8b7551bc3b0a787f515cf Mon Sep 17 00:00:00 2001 From: dontobi Date: Sun, 9 Jul 2023 13:34:56 +0200 Subject: [PATCH 4/5] latest changes --- debian/scripts/iobroker_startup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/scripts/iobroker_startup.sh b/debian/scripts/iobroker_startup.sh index f5c1adf..a72c972 100644 --- a/debian/scripts/iobroker_startup.sh +++ b/debian/scripts/iobroker_startup.sh @@ -160,7 +160,7 @@ echo " " # Setting UID and/ or GID if [[ "$setgid" != "$(cat /etc/group | grep 'iobroker:' | cut -d':' -f3)" || "$setuid" != "$(cat /etc/passwd | grep 'iobroker:' | cut -d':' -f3)" ]]; then echo "SETUID and/ or SETGID are set to custom values." - echo -n "Changing UID to \"""$setuid""\" and GID to \"""$setgid""\"..." + echo -n "Changing UID to \"""$setuid""\" and GID to \"""$setgid""\"... " usermod -u "$setuid" iobroker groupmod -og "$setgid" iobroker echo "Done." From 6af2d4879fe1e7c0e5969a96e44d551dbad665a1 Mon Sep 17 00:00:00 2001 From: dontobi Date: Mon, 10 Jul 2023 07:22:09 +0200 Subject: [PATCH 5/5] manual sync (beta branch) --- CHANGELOG.md | 2 +- debian/scripts/iobroker_startup.sh | 6 +- debian/scripts/maintenance.sh | 90 ++++++++++++------------------ 3 files changed, 41 insertions(+), 57 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 73c15a2..e3adada 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -283,4 +283,4 @@ * added support for avahi-daemon (installation and autostart) ### v0.0.1 (2017-01-31) -* project started / initial release +* project started / initial release \ No newline at end of file diff --git a/debian/scripts/iobroker_startup.sh b/debian/scripts/iobroker_startup.sh index a72c972..3131964 100644 --- a/debian/scripts/iobroker_startup.sh +++ b/debian/scripts/iobroker_startup.sh @@ -148,9 +148,9 @@ if [[ -f /opt/.first_run ]]; then echo " " # Register maintenance script echo -n "Registering maintenance script as command... " - echo "alias maintenance=\'/opt/scripts/maintenance.sh\'" >> /root/.bashrc - echo "alias maint=\'/opt/scripts/maintenance.sh\'" >> /root/.bashrc - echo "alias m=\'/opt/scripts/maintenance.sh\'" >> /root/.bashrc + echo "alias maintenance='/opt/scripts/maintenance.sh'" >> /etc/bash.bashrc + echo "alias maint='/opt/scripts/maintenance.sh'" >> /etc/bash.bashrc + echo "alias m='/opt/scripts/maintenance.sh'" >> /etc/bash.bashrc echo "Done." else echo "This is not the first run of this container. Skipping first run preparation." diff --git a/debian/scripts/maintenance.sh b/debian/scripts/maintenance.sh index be5c0de..5f2a3a0 100644 --- a/debian/scripts/maintenance.sh +++ b/debian/scripts/maintenance.sh @@ -59,41 +59,25 @@ enable_maintenance() { return fi - if [[ "$killbyname" == yes ]]; then - # undocumented option, only for use with backitup restore scripts - # stops iobroker by terminating js-controller process by name (the old way) - echo "This command will activate maintenance mode and stop js-controller." - echo -n "Activating maintenance mode... " - echo "maintenance" > "$healthcheck" - sleep 1 - echo "Done." - echo -n 'Stopping ioBroker...' - pkill -u iobroker -f iobroker.js-controller - sleep 5 - echo "Done." - return - fi - echo "You are now going to stop ioBroker and activate maintenance mode for this container." - if [[ "$autoconfirm" != yes ]]; then - local reply + if [[ "$killbyname" != yes ]]; then + if [[ "$autoconfirm" != yes ]]; then + local reply - read -rp 'Do you want to continue [yes/no]? ' reply - if [[ "$reply" == y || "$reply" == Y || "$reply" == yes ]]; then + read -rp 'Do you want to continue [yes/no]? ' reply + if [[ "$reply" == y || "$reply" == Y || "$reply" == yes ]]; then : # continue - else - return 1 + else + return 1 + fi fi - else - echo "This command was already confirmed by the -y or --yes option." fi echo "Activating maintenance mode..." echo "maintenance" > "$healthcheck" sleep 1 - echo "Done." - echo -n 'Stopping ioBroker...' + echo -n "Stopping ioBroker..." stop_iob } @@ -116,13 +100,11 @@ disable_maintenance() { else return 1 fi - else - echo "This command was already confirmed by the -y or --yes option." fi echo "Deactivating maintenance mode and forcing container to stop or restart..." echo "stopping" > "$healthcheck" - pkill -u root + gosu root pkill -u root echo "Done." } @@ -142,8 +124,6 @@ upgrade_jscontroller() { else return 1 fi - else - echo "This command was already confirmed by the -y or --yes option." fi if ! maintenance_enabled > /dev/null; then @@ -161,7 +141,7 @@ upgrade_jscontroller() { echo "Container will be stopped or restarted in 5 seconds..." sleep 5 echo "stopping" > "$healthcheck" - pkill -u root + gosu root pkill -u root } # stop iobroker and wait until all processes stopped or pkill_timeout is reached @@ -169,7 +149,7 @@ stop_iob() { local status timeout timeout="$(date --date="now + $pkill_timeout sec" +%s)" - pkill -u iobroker -f iobroker.js-controller + pkill -u iobroker -f 'iobroker.js-controller[^/]*$' status=$? if (( status >= 2 )); then # syntax error or fatal error return 1 @@ -179,19 +159,25 @@ stop_iob() { return fi - # pgrep exits with status 1 when there are no matches - while pgrep -u iobroker > /dev/null; (( $? != 1 )); do - if (($(date +%s) > timeout)); then - echo -e "\nTimeout reached. Killing remaining processes..." - pgrep --list-full -u iobroker - pkill --signal SIGKILL -u iobroker - echo "Done." - return - fi - - echo -n "." - sleep 1 - done + if [[ "$killbyname" != yes ]]; then + # pgrep exits with status 1 when there are no matches + while pgrep -u iobroker -f 'io.' > /dev/null; (( $? != 1 )); do + if (($(date +%s) > timeout)); then + echo -e "\nTimeout reached. Killing remaining processes..." + pgrep --list-full -u iobroker + pkill --signal SIGKILL -u iobroker -f 'io.' + echo "Done." + return + fi + echo -n "." + sleep 1 + done + else + for ((i=0; i<3; i++)); do + sleep 1 + echo -n "." + done + fi echo -e "\nDone." } @@ -210,17 +196,17 @@ restart_container() { else return 1 fi - else - echo "This command was already confirmed by the -y or --yes option." fi - echo -n "Stopping ioBroker..." - stop_iob + if ! maintenance_enabled > /dev/null; then + echo -n "Stopping ioBroker..." + stop_iob + fi echo "Container will be stopped or restarted in 5 seconds..." sleep 5 echo "stopping" > "$healthcheck" - pkill -u root + gosu root pkill -u root } # restore iobroker @@ -238,8 +224,6 @@ restore_iobroker() { else return 1 fi - else - echo "This command was already confirmed by the -y or --yes option." fi if check_starting > /dev/null; then @@ -279,7 +263,7 @@ restore_iobroker() { echo "Container will be stopped or restarted in 10 seconds..." sleep 10 echo "stopping" > "$healthcheck" - pkill -u root + gosu root pkill -u root } # parsing commands and options