From 39234a70180bbac74be29cdd12e4850e327c265a Mon Sep 17 00:00:00 2001
From: Luc De Meyer <luc.demeyer@noviat.com>
Date: Tue, 1 Oct 2024 19:23:29 +0200
Subject: [PATCH] [IMP] intrastat_product : adapt unit tests for inheritance

This PR makes a few changes to allow the localisation modules to
inherit from the IntrastatProductCommon class.

E.g. l10n_be_intrastat_product/tests

In this module most of code lines in the unit tests can be removed
via inheritance of the IntrastatProductCommon.

Changes:

- region code '2' conflicts with the module data in l10n_be_intrastat_product
- _create_xls() should be a class method, this change allows to pass an object
  in the unit tests
---
 intrastat_product/tests/common.py | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/intrastat_product/tests/common.py b/intrastat_product/tests/common.py
index 05b7a25..871a323 100644
--- a/intrastat_product/tests/common.py
+++ b/intrastat_product/tests/common.py
@@ -96,33 +96,32 @@ class IntrastatProductCommon(IntrastatCommon):
         cls._init_products()
         cls._init_transaction()
 
-    @classmethod
-    def _create_xls(cls, declaration=False):
+    def _create_xls(self, declaration=False):
         """
             Prepare the Excel report to be tested
 
         :return: The Excel file
         :rtype: bytes
         """
-        report = cls.env.ref(
+        report = self.env.ref(
             "intrastat_product.intrastat_product_xlsx_report"
-        ).with_context(active_ids=cls.declaration.ids)
+        ).with_context(active_ids=self.declaration.ids)
         report_name = report.report_name
-        cls.report = cls.report_obj._get_report_from_name(report_name)
+        self.report = self.report_obj._get_report_from_name(report_name)
         datas = {
             "context": {
-                "active_ids": [cls.declaration.id],
+                "active_ids": [self.declaration.id],
             }
         }
         data = {}
         encoded_data = "report/report_xlsx/" + report_name + "?" + url_encode(data)
         datas["data"] = encoded_data
-        active_model = cls.declaration._name
+        active_model = self.declaration._name
         if not declaration:
             computation_lines = True
         else:
             computation_lines = False
-        file_data = cls.xls_declaration.with_context(
+        file_data = self.xls_declaration.with_context(
             computation_lines=computation_lines, active_model=active_model
         ).create_xlsx_report(None, datas)
         return file_data
@@ -175,7 +174,7 @@ class IntrastatProductCommon(IntrastatCommon):
     @classmethod
     def _create_region(cls, vals=None):
         values = {
-            "code": "2",
+            "code": "WAL",
             "country_id": cls.env.ref("base.be").id,
             "company_id": cls.env.company.id,
             "description": "Belgium Walloon Region",