mirror of
https://github.com/OCA/contract.git
synced 2025-02-13 17:57:24 +02:00
23d42d6974
Make recurrence mechanism on contract line and some other refactoring [FIX] - Keep contract_cron on account_analytic_account model contract_cron defined with no_update option. Changing it, will cause issue to past version installation. [IMP] - Fix recurring_next_date default value recurring_next_date should have start_date as default value in prepaid policy and start_date + invoicing_interval if postpaid [FIX] - Fix test check no journal [IMP] - Return created invoices on recurring_create_invoice [IMP] - Specific process to compute recurring_next_date for monthly-last-day fixes: #198 [ADD] - Add Post-migration script to bring recurrence info from contract to contract lines [ADD] - Add search filter based on date_end and recurring_next_date - not_finished filter in contract search view - finished filter in contract search view - Next Invoice group by in contract search view [ADD] - Add unit tests - cases to compute first recurring next date - contract recurring_next_date - contract date_end [IMP] - Improve Unit tests
251 lines
8.8 KiB
Python
251 lines
8.8 KiB
Python
# Copyright 2017 LasLabs Inc.
|
|
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
|
|
|
|
from dateutil.relativedelta import relativedelta
|
|
|
|
from odoo import api, fields, models, _
|
|
from odoo.exceptions import ValidationError
|
|
|
|
|
|
class AccountAnalyticInvoiceLine(models.Model):
|
|
_name = 'account.analytic.invoice.line'
|
|
_inherit = 'account.abstract.analytic.contract.line'
|
|
|
|
contract_id = fields.Many2one(
|
|
comodel_name='account.analytic.account',
|
|
string='Analytic Account',
|
|
required=True,
|
|
ondelete='cascade',
|
|
oldname='analytic_account_id',
|
|
)
|
|
date_start = fields.Date(string='Date Start', default=fields.Date.today())
|
|
date_end = fields.Date(string='Date End', index=True)
|
|
recurring_next_date = fields.Date(
|
|
copy=False, string='Date of Next Invoice'
|
|
)
|
|
create_invoice_visibility = fields.Boolean(
|
|
compute='_compute_create_invoice_visibility'
|
|
)
|
|
partner_id = fields.Many2one(
|
|
comodel_name="res.partner",
|
|
string="Partner (always False)",
|
|
related='contract_id.partner_id',
|
|
store=True,
|
|
readonly=True,
|
|
)
|
|
pricelist_id = fields.Many2one(
|
|
comodel_name='product.pricelist',
|
|
string='Pricelist',
|
|
related='contract_id.pricelist_id',
|
|
store=True,
|
|
readonly=True,
|
|
)
|
|
|
|
@api.model
|
|
def _compute_first_recurring_next_date(
|
|
self,
|
|
date_start,
|
|
recurring_invoicing_type,
|
|
recurring_rule_type,
|
|
recurring_interval,
|
|
):
|
|
if recurring_rule_type == 'monthlylastday':
|
|
return date_start + self.get_relative_delta(
|
|
recurring_rule_type, recurring_interval - 1
|
|
)
|
|
if recurring_invoicing_type == 'pre-paid':
|
|
return date_start
|
|
return date_start + self.get_relative_delta(
|
|
recurring_rule_type, recurring_interval
|
|
)
|
|
|
|
@api.onchange(
|
|
'date_start',
|
|
'recurring_invoicing_type',
|
|
'recurring_rule_type',
|
|
'recurring_interval',
|
|
)
|
|
def _onchange_date_start(self):
|
|
for rec in self.filtered('date_start'):
|
|
rec.recurring_next_date = self._compute_first_recurring_next_date(
|
|
rec.date_start,
|
|
rec.recurring_invoicing_type,
|
|
rec.recurring_rule_type,
|
|
rec.recurring_interval,
|
|
)
|
|
|
|
@api.constrains('recurring_next_date', 'date_start')
|
|
def _check_recurring_next_date_start_date(self):
|
|
for line in self.filtered('recurring_next_date'):
|
|
if line.date_start and line.recurring_next_date:
|
|
if line.date_start > line.recurring_next_date:
|
|
raise ValidationError(
|
|
_(
|
|
"You can't have a next invoicing date before the "
|
|
"start of the contract '%s'"
|
|
)
|
|
% line.contract_id.name
|
|
)
|
|
|
|
@api.constrains('recurring_next_date')
|
|
def _check_recurring_next_date_recurring_invoices(self):
|
|
for line in self.filtered('contract_id.recurring_invoices'):
|
|
if not line.recurring_next_date:
|
|
raise ValidationError(
|
|
_(
|
|
"You must supply a next invoicing date for contract "
|
|
"'%s'"
|
|
)
|
|
% line.contract_id.name
|
|
)
|
|
|
|
@api.constrains('date_start')
|
|
def _check_date_start_recurring_invoices(self):
|
|
for line in self.filtered('contract_id.recurring_invoices'):
|
|
if not line.date_start:
|
|
raise ValidationError(
|
|
_("You must supply a start date for contract '%s'")
|
|
% line.contract_id.name
|
|
)
|
|
|
|
@api.constrains('date_start', 'date_end')
|
|
def _check_start_end_dates(self):
|
|
for line in self.filtered('date_end'):
|
|
if line.date_start and line.date_end:
|
|
if line.date_start > line.date_end:
|
|
raise ValidationError(
|
|
_(
|
|
"Contract '%s' start date can't be later than "
|
|
"end date"
|
|
)
|
|
% line.contract_id.name
|
|
)
|
|
|
|
@api.depends('recurring_next_date', 'date_end')
|
|
def _compute_create_invoice_visibility(self):
|
|
for line in self:
|
|
line.create_invoice_visibility = not line.date_end or (
|
|
line.recurring_next_date
|
|
and line.date_end
|
|
and line.recurring_next_date <= line.date_end
|
|
)
|
|
|
|
@api.model
|
|
def recurring_create_invoice(self, contract=False):
|
|
domain = []
|
|
date_ref = fields.Date.today()
|
|
if contract:
|
|
contract.ensure_one()
|
|
date_ref = contract.recurring_next_date
|
|
domain.append(('contract_id', '=', contract.id))
|
|
|
|
domain.extend(
|
|
[
|
|
('contract_id.recurring_invoices', '=', True),
|
|
('recurring_next_date', '<=', date_ref),
|
|
'|',
|
|
('date_end', '=', False),
|
|
('date_end', '>=', date_ref),
|
|
]
|
|
)
|
|
lines = self.search(domain).filtered('create_invoice_visibility')
|
|
if lines:
|
|
return lines._recurring_create_invoice()
|
|
return False
|
|
|
|
@api.multi
|
|
def _recurring_create_invoice(self):
|
|
"""Create invoices from contracts
|
|
|
|
:return: invoices created
|
|
"""
|
|
invoices = self.env['account.invoice']
|
|
for contract in self.mapped('contract_id'):
|
|
lines = self.filtered(lambda l: l.contract_id == contract)
|
|
invoices |= lines._create_invoice()
|
|
lines._update_recurring_next_date()
|
|
return invoices
|
|
|
|
@api.multi
|
|
def _create_invoice(self):
|
|
"""
|
|
:param invoice: If not False add lines to this invoice
|
|
:return: invoice created or updated
|
|
"""
|
|
contract = self.mapped('contract_id')
|
|
date_invoice = min(self.mapped('recurring_next_date'))
|
|
invoice = self.env['account.invoice'].create(
|
|
contract._prepare_invoice(date_invoice)
|
|
)
|
|
for line in self:
|
|
invoice_line_vals = line._prepare_invoice_line(invoice.id)
|
|
if invoice_line_vals:
|
|
self.env['account.invoice.line'].create(invoice_line_vals)
|
|
invoice.compute_taxes()
|
|
return invoice
|
|
|
|
@api.multi
|
|
def _prepare_invoice_line(self, invoice_id):
|
|
self.ensure_one()
|
|
invoice_line = self.env['account.invoice.line'].new(
|
|
{
|
|
'invoice_id': invoice_id,
|
|
'product_id': self.product_id.id,
|
|
'quantity': self.quantity,
|
|
'uom_id': self.uom_id.id,
|
|
'discount': self.discount,
|
|
}
|
|
)
|
|
# Get other invoice line values from product onchange
|
|
invoice_line._onchange_product_id()
|
|
invoice_line_vals = invoice_line._convert_to_write(invoice_line._cache)
|
|
# Insert markers
|
|
contract = self.contract_id
|
|
lang_obj = self.env['res.lang']
|
|
lang = lang_obj.search([('code', '=', contract.partner_id.lang)])
|
|
date_format = lang.date_format or '%m/%d/%Y'
|
|
name = self._insert_markers(date_format)
|
|
invoice_line_vals.update(
|
|
{
|
|
'name': name,
|
|
'account_analytic_id': contract.id,
|
|
'price_unit': self.price_unit,
|
|
}
|
|
)
|
|
return invoice_line_vals
|
|
|
|
@api.multi
|
|
def _insert_markers(self, date_format):
|
|
self.ensure_one()
|
|
date_from = fields.Date.from_string(self.recurring_next_date)
|
|
date_to = date_from + self.get_relative_delta(
|
|
self.recurring_rule_type, self.recurring_interval
|
|
)
|
|
name = self.name
|
|
name = name.replace('#START#', date_from.strftime(date_format))
|
|
name = name.replace('#END#', date_to.strftime(date_format))
|
|
return name
|
|
|
|
@api.multi
|
|
def _update_recurring_next_date(self):
|
|
for line in self:
|
|
ref_date = line.recurring_next_date or fields.Date.today()
|
|
old_date = fields.Date.from_string(ref_date)
|
|
new_date = old_date + self.get_relative_delta(
|
|
line.recurring_rule_type, line.recurring_interval
|
|
)
|
|
line.recurring_next_date = new_date
|
|
|
|
@api.model
|
|
def get_relative_delta(self, recurring_rule_type, interval):
|
|
if recurring_rule_type == 'daily':
|
|
return relativedelta(days=interval)
|
|
elif recurring_rule_type == 'weekly':
|
|
return relativedelta(weeks=interval)
|
|
elif recurring_rule_type == 'monthly':
|
|
return relativedelta(months=interval)
|
|
elif recurring_rule_type == 'monthlylastday':
|
|
return relativedelta(months=interval, day=31)
|
|
else:
|
|
return relativedelta(years=interval)
|