Commit Graph

41 Commits

Author SHA1 Message Date
sbejaoui
e71fcc1694 [IMP] - use terminate term instead of resiliate 2020-03-11 11:13:13 +01:00
sbejaoui
be7c3527e9 [IMP] - track resiliation fields 2020-03-10 11:12:51 +01:00
sbejaoui
a638f59faf [IMP] - don't copy resiliate fields 2020-03-10 11:12:51 +01:00
sbejaoui
58b38490f6 [IMP] - contract resiliation 2020-03-10 11:11:59 +01:00
OCA-git-bot
737239cc9a Merge PR #412 into 12.0
Signed-off-by sbejaoui
2020-03-02 12:04:27 +00:00
OCA-git-bot
4b4fb37022 Merge PR #456 into 12.0
Signed-off-by sbidoul
2020-01-30 08:31:21 +00:00
sbejaoui
29cc7cb23a [12.0][IMP] - Add an action for contracts manual invoicing
It happen that a company has to trigger the invoicing action to generate invoices before
the scheduled date (to print and prepare invoices documents, check invoices, etc.).
This requires technical access for end users with the risk that this represents.

This commit adds a new wizard to run the invoicing action for a given date with a helper
to see and check the contract that will be invoiced. When the manual action is called,
the system displays all created invoices.

[12.0][IMP] - log the manual invoice action in contract chatter

[IMP] - Add alink to the invoice in contract message at manual invoicing

[IMP] - Improve code

[FIX] - log message for invoice creation only when there is an invoice

[IMP] - split the manual invoice menu into to menus sale & purhcase

[IMP] - hide invoice button if there is nothing to invoice
2020-01-29 16:40:22 +01:00
Pedro M. Baeza
96d1abeb6c [IMP] contract: remove redundant method
I have detected a method that was created as redundant and with the same
technique used when preparing the line values, so better to have
everything together in the same method instead of having it spread.
2020-01-24 00:38:01 +01:00
OCA-git-bot
e54a2aaa52 Merge PR #422 into 12.0
Signed-off-by sbidoul
2020-01-17 10:47:25 +00:00
Pedro M. Baeza
acd45545fa [FIX] contract: Handle properly multi-company setups
If you have contracts in several companies, cron will create all of them, but
property fields will be populated with incorrect data as the taken company is
the main from the cron user (usually admin).
2020-01-08 18:46:05 +01:00
sbejaoui
fd10c32f4f [12.0][ADD] - Add note field to contract 2019-12-23 10:27:54 +01:00
OCA-git-bot
51d8ccd387 Merge PR #402 into 12.0
Signed-off-by sbidoul
2019-12-22 22:24:35 +00:00
Pedro M. Baeza
d415e44ff7 [FIX] contract: Don't execute onchange after invoice creation
Using that approach (that is the current one in core)  has a lot of side effects and
performance bottlenecks. You can read odoo/odoo#40156 for summarizing them.

This also improves the handling of the values of payment term an fiscal position
for using the partner ones if not set.
2019-12-02 16:00:08 +01:00
sbejaoui
1e9755d1e0 [12.0][FIX] - Run onchange contract_type when changing the contract template
Fix this use-case:

If the contract journal is not set on the contract template the contract is created
without a journal when confirming the sale order
2019-11-26 11:16:49 +01:00
sbejaoui
3b79dea3eb [IMP] - Add contract tags 2019-11-04 13:07:27 +01:00
hparfr
dcda2a1980 Add commercial_partner_id fields into contract module
Remove string attribute
2019-09-24 09:56:11 +02:00
Pedro M. Baeza
09d860ba17 [FIX+IMP+MIG] contract: Several refinements:
* Remove incorrect oldname attributes.
* Add filter on partners for running contracts (+ a support o2m field for that).
* Cover more tables in model renaming + cleaner code using a loop.
* Don't copy contract lines, but rename table + copy contract records on pre.
* Contract code is now populated to "Reference/Description" field in invoice.
* Order on new contract model has been restored to the same as old analytic accounts.
2019-09-14 14:34:02 +02:00
sbejaoui
d93139d147 [IMP] - Make one migration from 12.0.1 to 12.0.4
[RMV] - Remove empty file

[IMP] - Update no_update cron after migration

[IMP] - move contract template recurrence info to line level

[FIX] - Fix contract line model description

[IMP] - Link contracts to analytic accounts

[FIX] - Fix pylint

[IMP] - Move chatter and attachments from analytic account to contract

[IMP] - Move account_analytic_id to contract line level

[IMP] - Improve version check in migration script

[IMP] - Move contracts followers from analytic accounts

[ADD] - Add mail.activity.mixin to contract.contract model

remove data drop from migration scripts

[12.0][FIX] - Fix _init_last_date_invoiced

fix flake8

[ADD] - Update contributors list
2019-09-14 14:34:02 +02:00
Thomas Binsfeld
a429b10c20 [REF] Contract Sale Invoicing: split from analytic account
[REF] Contract Sale Invoicing: update translations

[IMP] - Assert that the predecessor is available for new link at uncancel

[RMV] - remove usless changes

[RMV] - Remove usless field recurring_invoices

after the total isolation between contract model and account analytic one.
recurring_invoices which was used to mark analytic account as contract became usless

[IMP] - P3 syntax

[IMP] - use @openupgrade.migrate() and openupgrade.logged_query

[IMP] - drop transient table in migration script
2019-09-14 14:34:02 +02:00
Thomas Binsfeld
da7826797c [REF] Contract: split from analytic account 2019-09-14 14:34:02 +02:00
Aaron Henriquez
1be3305052 [IMP]pass the payment term to the contract from the partner 2019-09-14 14:34:02 +02:00
sbejaoui
3bd431e0ed [IMP] - A canceled contract line can't be set to auto-renew
[REF] Contract: pep8

[IMP] Contract: update USAGE section of README

[IMP]call onchange_is_auto_renew when changing template
2019-09-14 14:34:02 +02:00
sbejaoui
130fbb693e [FIX] - don't play onchange date_start for old lines on contract template change
[FIX] - Fix stop post message

[FIX] - Fix sale_contract_count should count all partner contract

[FIX] - set recurring_next_date to False if contract line stoped at last date invoiced

[FIX] - Group by next_invoice also considers dates in the past
2019-09-14 14:34:02 +02:00
sbejaoui
834d0b959b [FIX] - Onchange contract line don't reste contract lines
[FIX] - Rename _get_invoiced_period to _get_period_to_invoice

[ADD] - Add stop_at_date_end to _get_period_to_invoice

[FIX] - Remove useless filter
2019-09-14 14:34:02 +02:00
sbejaoui
2f7aed2744 [REF] - add method to get quantity to invoice
the contract line quantity can be in some use cases variable, to simplify
the way it is changed we add a new method _get_quantity_to_invoice.
2019-09-14 14:34:02 +02:00
Thomas Binsfeld
be5cc5fba1 [FIX] Contract to Invoice: take contract vendor instead of partner's 2019-09-14 14:34:02 +02:00
Thomas Binsfeld
7683e5a736 [IMP] Contract: matching invoice view depending on contract type
[ADD] Contract: invoice partner
2019-09-14 14:34:02 +02:00
Thomas Binsfeld
19b3f50d34 [ADD] Contract: fiscal position
[ADD] Contract: new contributor

[REF] Contract: indexes
2019-09-14 14:34:02 +02:00
Thomas Binsfeld
a1f1fd8c10 [FIX] Contract: copy payment term on generated invoice 2019-09-14 14:34:02 +02:00
sbejaoui
55d16c3d4b [MV] - move onchange method to contract_product module
[RMV] - Remove useless check
2019-09-14 14:34:02 +02:00
sbejaoui
8171c1d955 [IMP] - Link invoice line to contract lines
[IMP] - Add index on contract line

[IMP] - Add is_suspended flag and _search_state

[IMP] - Add is_suspended flag to stop contract line
2019-09-14 14:34:02 +02:00
sbejaoui
42a70ddaac [12.0][IMP] - check invoice line vals before assignment
[FIX] - Fix unit tests.
2019-09-14 14:34:02 +02:00
Thomas Binsfeld
60f589a41f [ADD] Contract: payment term 2019-09-14 14:34:02 +02:00
sbejaoui
494892f6b1 [FIX] - default value for active field in contract line
[FIX] - fix flake8
2019-09-14 14:34:02 +02:00
sbejaoui
3e6633046e [FIX] - as date_start is required, constraints on it become useless
[FIX] - for finished contract _get_lines_to_invoice should return False
2019-09-14 14:34:02 +02:00
Thomas Binsfeld
f95d2a3582 [REF] Contract: invoice creation
[REF] Contract Unit Tests: base the cron check on invoice lines instead of invoices
2019-09-14 14:34:02 +02:00
Thomas Binsfeld
a874e94802 [REF] Contract: invoice creation
[FIX] - Fix typo

[IMP] - date start required for contract line

[REF] Gitignore: .eggs
2019-09-14 14:34:02 +02:00
sbejaoui
d1d6500452 [FIX] - contract recurring_next_date ignore canceled lines
[FIX] - fix _get_invoiced_period if recurring_next_date manually updated
2019-09-14 14:34:02 +02:00
sbejaoui
c55540b2c9 [FIX] - compute recurring_next_date for contract
[IMP] - get contract line default data onchange product_id
2019-09-14 14:34:02 +02:00
sbejaoui
aefa12ab9e [IMP] - store last_date_invoiced on contract_line
Improve CRITERIA_ALLOWED_DICT

[IMP] - code improvement

[IMP] - Use last_date_invoiced to set marker in invoice description

[IMP] - add migration script to init last_day_invoiced and some other improvement

[FIX] - a contract line suspended should start a day after the suspension end
2019-09-14 14:34:02 +02:00
sbejaoui
b979a4a342 [IMP] - Make recurrence mechanism on contract line
Make recurrence mechanism on contract line and some other refactoring

[FIX] - Keep contract_cron on account_analytic_account model

contract_cron defined with no_update option.
Changing it, will cause issue to past version installation.

[IMP] - Fix recurring_next_date default value

recurring_next_date should have start_date as default value in prepaid policy
and start_date + invoicing_interval if postpaid

[FIX] - Fix test check no journal

[IMP] - Return created invoices on recurring_create_invoice

[IMP] - Specific process to compute recurring_next_date for  monthly-last-day

fixes: #198

[ADD] - Add Post-migration script to bring recurrence info from contract to contract lines

[ADD] - Add search filter based on date_end and recurring_next_date

 - not_finished filter in contract search view
 - finished filter in contract search view
 - Next Invoice group by in contract search view

[ADD] - Add unit tests

- cases to compute first recurring next date
- contract recurring_next_date
- contract date_end

[IMP] - Improve Unit tests
2019-09-14 14:34:02 +02:00