[10.0][FIX+IMP] contract: Improve usability and don't fail on wrong data (#130)

* [FIX+IMP] contract: Improve usability and don't fail on wrong data

* Cron create invoices masked for avoiding silent errors
* New constraints for assuring data consistency
* UI helps for entering consistent data
* Spanish translation
* Remove double company_id field on form

contract/i18n/es.po

@@ -5,6 +5,8 @@
 # Translators:
 # OCA Transbot <transbot@odoo-community.org>, 2017
 # Pedro M. Baeza <pedro.baeza@gmail.com>, 2017
+#	* contract
+#
 msgid ""
 msgstr ""
 "Project-Id-Version: Odoo Server 11.0\n"
@@ -16,13 +18,11 @@ msgstr ""
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: es\n"
-"Plural-Forms: nplurals=2; plural=(n != 1);\n"
+"Plural-Forms: \n"
 
 #. module: contract
 #: model:mail.template,body_html:contract.email_contract_template
-msgid ""
-"\n"
+msgid "\n"
 "<div style=\"font-family: 'Lucida Grande', Ubuntu, Arial, Verdana, sans-serif; font-size: 12px; color: rgb(34, 34, 34); background-color: #FFF; \">\n"
 "    <p>Hello ${object.partner_id.name or ''},</p>\n"
 "    <p>A new contract has been created: </p>\n"
@@ -70,8 +70,7 @@ msgid ""
 "    </div>\n"
 "</div>\n"
 "        "
-msgstr ""
-"\n"
+msgstr "\n"
 "<div style=\"font-family: 'Lucida Grande', Ubuntu, Arial, Verdana, sans-serif; font-size: 12px; color: rgb(34, 34, 34); background-color: #FFF; \">\n"
 "    <p>Hola ${object.partner_id.name or ''},</p>\n"
 "    <p>Se ha creado un nuevo contrato: </p>\n"
@@ -143,7 +142,7 @@ msgstr "<strong>Contrato: </strong>"
 #. module: contract
 #: model:ir.ui.view,arch_db:contract.report_contract_document
 msgid "<strong>Date Start: </strong>"
-msgstr "<strong>Fecha inicio: </strong>"
+msgstr "<strong>Fecha de inicio: </strong>"
 
 #. module: contract
 #: model:ir.ui.view,arch_db:contract.report_contract_document
@@ -200,15 +199,21 @@ msgstr "Cuenta analítica"
 #. module: contract
 #: model:ir.actions.act_window,help:contract.account_analytic_contract_action
 msgid "Click to create a new contract template."
-msgstr "Pinche para crear una nueva plantilla de contrato"
+msgstr "Pulse para crear una nueva plantilla de contrato."
 
 #. module: contract
 #: model:ir.actions.act_window,help:contract.action_account_analytic_overdue_all
 msgid "Click to create a new contract."
-msgstr "Pinche para crear un contrato nuevo. "
+msgstr "Pulse para crear un contrato nuevo. "
 
 #. module: contract
 #: code:addons/contract/models/account_analytic_account.py:264
+#: model:ir.model.fields,field_description:contract.field_account_analytic_contract_company_id
+msgid "Company"
+msgstr "Compañía"
+
+#. module: contract
+#: code:addons/contract/models/account_analytic_account.py:321
 #, python-format
 msgid "Compose Email"
 msgstr "Componer correo electrónico"
@@ -226,6 +231,12 @@ msgstr "Contacto"
 msgid "Contract"
 msgstr "Contrato"
 
+#. module: contract
+#: code:addons/contract/models/account_analytic_account.py:138
+#, python-format
+msgid "Contract '%s' start date can't be later than end date"
+msgstr "La fecha de inicio del contrato '%s' no puede ser superior a la fecha de fin"
+
 #. module: contract
 #: model:ir.model,name:contract.model_account_analytic_contract_line
 msgid "Contract Lines"
@@ -233,6 +244,7 @@ msgstr "Líneas de contrato"
 
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_contract_template_id
+#: model:ir.model.fields,field_description:contract.field_project_project_contract_template_id
 #: model:ir.ui.view,arch_db:contract.account_analytic_contract_view_form
 msgid "Contract Template"
 msgstr "Plantilla de contrato"
@@ -255,6 +267,12 @@ msgstr "Plantillas de contrato"
 msgid "Contracts"
 msgstr "Contratos"
 
+#. module: contract
+#: model:ir.model.fields,field_description:contract.field_account_analytic_account_create_invoice_visibility
+#: model:ir.model.fields,field_description:contract.field_project_project_create_invoice_visibility
+msgid "Create invoice visibility"
+msgstr "Visibilidad de crear factura"
+
 #. module: contract
 #: model:ir.ui.view,arch_db:contract.account_analytic_account_recurring_form_form
 msgid "Create invoices"
@@ -276,6 +294,7 @@ msgstr "Creado en"
 
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_date_end
+#: model:ir.model.fields,field_description:contract.field_project_project_date_end
 #: model:ir.ui.view,arch_db:contract.view_account_analytic_account_contract_search
 msgid "Date End"
 msgstr "Fecha fin"
@@ -283,10 +302,11 @@ msgstr "Fecha fin"
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_date_start
 msgid "Date Start"
-msgstr "Fecha inicio"
+msgstr "Fecha de inicio"
 
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_recurring_next_date
+#: model:ir.model.fields,field_description:contract.field_project_project_recurring_next_date
 msgid "Date of Next Invoice"
 msgstr "Próxima fecha de factura"
 
@@ -317,12 +337,8 @@ msgstr "El descuento debería ser menor o igual a 100"
 #. module: contract
 #: model:ir.model.fields,help:contract.field_account_analytic_contract_line_discount
 #: model:ir.model.fields,help:contract.field_account_analytic_invoice_line_discount
-msgid ""
-"Discount that is applied in generated invoices. It should be less or equal "
-"to 100"
-msgstr ""
-"Descuento que es aplicado en las facturas generadas. Debería ser menor o "
-"igual a 100"
+msgid "Discount that is applied in generated invoices. It should be less or equal to 100"
+msgstr "Descuento que es aplicado en las facturas generadas. Debería ser menor o igual a 100"
 
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_contract_display_name
@@ -345,6 +361,7 @@ msgstr "Generar facturas recurrentes desde los contratos"
 
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_recurring_invoices
+#: model:ir.model.fields,field_description:contract.field_project_project_recurring_invoices
 msgid "Generate recurring invoices automatically"
 msgstr "Generar facturas recurrentes automáticamente."
 
@@ -368,6 +385,7 @@ msgstr "Factura"
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_recurring_invoice_line_ids
 #: model:ir.model.fields,field_description:contract.field_account_analytic_contract_recurring_invoice_line_ids
+#: model:ir.model.fields,field_description:contract.field_project_project_recurring_invoice_line_ids
 #: model:ir.ui.view,arch_db:contract.account_analytic_contract_view_form
 msgid "Invoice Lines"
 msgstr "Líneas de factura"
@@ -385,12 +403,15 @@ msgstr "Tipo Facturación"
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_recurring_invoicing_type
 #: model:ir.model.fields,field_description:contract.field_account_analytic_contract_recurring_invoicing_type
+#: model:ir.model.fields,field_description:contract.field_project_project_recurring_invoicing_type
+#: model:ir.ui.view,arch_db:contract.account_analytic_contract_view_search
 msgid "Invoicing type"
 msgstr "Tipo de facturación"
 
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_journal_id
 #: model:ir.model.fields,field_description:contract.field_account_analytic_contract_journal_id
+#: model:ir.model.fields,field_description:contract.field_project_project_journal_id
 #: model:ir.ui.view,arch_db:contract.account_analytic_contract_view_search
 msgid "Journal"
 msgstr "Diario"
@@ -420,8 +441,7 @@ msgstr "Última actualización en"
 #: model:ir.ui.view,arch_db:contract.account_analytic_account_recurring_form_form
 #: model:ir.ui.view,arch_db:contract.account_analytic_contract_view_form
 msgid "Legend (for the markers inside invoice lines description)"
-msgstr ""
-"Leyenda (para los marcadores dentro de descripción en lineas de factura)"
+msgstr "Leyenda (para los marcadores dentro de descripción en lineas de factura)"
 
 #. module: contract
 #: selection:account.analytic.account,recurring_rule_type:0
@@ -445,16 +465,21 @@ msgstr "Nombre"
 msgid "Next Invoice"
 msgstr "Próxima factura"
 
+#. module: contract
+#: model:ir.model,name:contract.model_res_partner
+msgid "Partner"
+msgstr "Empresa"
+
 #. module: contract
 #: model:ir.ui.view,arch_db:contract.view_account_analytic_account_contract_search
 msgid "Partner and dependents"
 msgstr "Empresa y contactos"
 
 #. module: contract
-#: code:addons/contract/models/account_analytic_account.py:170
+#: code:addons/contract/models/account_analytic_account.py:224
 #, python-format
 msgid "Please define a sale journal for the company '%s'."
-msgstr "Por favor define un diario de ventas para la compañía '%s'."
+msgstr "Por favor defina un diario de ventas para la compañía '%s'."
 
 #. module: contract
 #: selection:account.analytic.account,recurring_invoicing_type:0
@@ -471,6 +496,7 @@ msgstr "Prepago"
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_pricelist_id
 #: model:ir.model.fields,field_description:contract.field_account_analytic_contract_pricelist_id
+#: model:ir.model.fields,field_description:contract.field_project_project_pricelist_id
 #: model:ir.ui.view,arch_db:contract.account_analytic_contract_view_search
 msgid "Pricelist"
 msgstr "Lista de precios"
@@ -490,6 +516,7 @@ msgstr "Cantidad"
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_recurring_rule_type
 #: model:ir.model.fields,field_description:contract.field_account_analytic_contract_recurring_rule_type
+#: model:ir.model.fields,field_description:contract.field_project_project_recurring_rule_type
 #: model:ir.ui.view,arch_db:contract.account_analytic_contract_view_search
 msgid "Recurrence"
 msgstr "Recurrencia"
@@ -503,12 +530,14 @@ msgstr "Facturas recurrentes"
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_account_recurring_interval
 #: model:ir.model.fields,field_description:contract.field_account_analytic_contract_recurring_interval
+#: model:ir.model.fields,field_description:contract.field_project_project_recurring_interval
 msgid "Repeat Every"
 msgstr "Repetir cada"
 
 #. module: contract
 #: model:ir.model.fields,help:contract.field_account_analytic_account_recurring_interval
 #: model:ir.model.fields,help:contract.field_account_analytic_contract_recurring_interval
+#: model:ir.model.fields,help:contract.field_project_project_recurring_interval
 msgid "Repeat every (Days/Week/Month/Year)"
 msgstr "Repetir cada (días/semana/mes/año)"
 
@@ -532,20 +561,21 @@ msgstr "Secuencia"
 #: model:ir.model.fields,help:contract.field_account_analytic_contract_line_sequence
 #: model:ir.model.fields,help:contract.field_account_analytic_invoice_line_sequence
 msgid "Sequence of the contract line when displaying contracts"
-msgstr "Secuencia de la línea de contrato cuando se visualizan los contratos"
+msgstr "Secuencia de la linea de contrato cuando se muestra en los contratos"
 
 #. module: contract
 #: model:ir.model.fields,help:contract.field_account_analytic_account_recurring_rule_type
 #: model:ir.model.fields,help:contract.field_account_analytic_contract_recurring_rule_type
+#: model:ir.model.fields,help:contract.field_project_project_recurring_rule_type
 msgid "Specify Interval for automatic invoice generation."
 msgstr "Especifica el intervalo para la generación de facturas automática."
 
 #. module: contract
 #: model:ir.model.fields,help:contract.field_account_analytic_account_recurring_invoicing_type
 #: model:ir.model.fields,help:contract.field_account_analytic_contract_recurring_invoicing_type
+#: model:ir.model.fields,help:contract.field_project_project_recurring_invoicing_type
 msgid "Specify if process date is 'from' or 'to' invoicing date"
-msgstr ""
-"Especifica si la fecha de proceso es desde o hasta la fecha de facturación"
+msgstr "Especifica si la fecha de proceso es desde o hasta la fecha de facturación"
 
 #. module: contract
 #: model:ir.model.fields,field_description:contract.field_account_analytic_contract_line_price_subtotal
@@ -573,7 +603,7 @@ msgstr "NIF:"
 #. module: contract
 #: model:ir.ui.view,arch_db:contract.view_account_analytic_account_contract_search
 msgid "Valid"
-msgstr "Vigente"
+msgstr "Válido"
 
 #. module: contract
 #: selection:account.analytic.account,recurring_rule_type:0
@@ -588,21 +618,43 @@ msgid "Year(s)"
 msgstr "Año(s)"
 
 #. module: contract
-#: code:addons/contract/models/account_analytic_account.py:162
+#: code:addons/contract/models/account_analytic_account.py:111
+#, python-format
+msgid "You can't have a next invoicing date before the start of the contract '%s'"
+msgstr "No puede tener una fecha de próxima factura anterior a la fecha de inicio del contrato '%s'"
+
+#. module: contract
+#: code:addons/contract/models/account_analytic_account.py:216
 #, python-format
 msgid "You must first select a Customer for Contract %s!"
 msgstr "¡Seleccione un cliente para este contrato %s!"
 
 #. module: contract
-#: code:addons/contract/models/account_analytic_account.py:217
+#: code:addons/contract/models/account_analytic_account.py:273
 #, python-format
-msgid ""
-"You must review start and end dates!\n"
+msgid "You must review start and end dates!\n"
 "%s"
-msgstr ""
-"Debe revisar las fechas de inicio y de fin\n"
+msgstr "Debe revisar las fechas de inicio y de fin\n"
 "%s"
 
+#. module: contract
+#: code:addons/contract/models/account_analytic_account.py:102
+#, python-format
+msgid "You must supply a customer for the contract '%s'"
+msgstr "Debe especificar un cliente para el contrato '%s'"
+
+#. module: contract
+#: code:addons/contract/models/account_analytic_account.py:120
+#, python-format
+msgid "You must supply a next invoicing date for contract '%s'"
+msgstr "Debe suministrar una fecha de próxima factura para el contrato '%s'"
+
+#. module: contract
+#: code:addons/contract/models/account_analytic_account.py:129
+#, python-format
+msgid "You must supply a start date for contract '%s'"
+msgstr "Debe suministrar una fecha de inicio para el contrato '%s'"
+
 #. module: contract
 #: model:ir.model,name:contract.model_account_analytic_contract
 msgid "account.analytic.contract"
@@ -615,10 +667,11 @@ msgstr "account.analytic.invoice.line"
 
 #. module: contract
 #: model:ir.ui.view,arch_db:contract.view_partner_form
-msgid "show the contracts for this partner"
-msgstr "Mostrar los contratos de este partner"
+msgid "Show the contracts for this partner"
+msgstr "Muestra los contratos para esta empresa/contacto"
 
 #. module: contract
 #: model:ir.ui.view,arch_db:contract.account_analytic_account_recurring_form_form
 msgid "⇒ Show recurring invoices"
 msgstr "⇒ Mostrar facturas recurrentes"
+