From e5a2be35cc68ac6ee460c71881bfcdbebabee9ce Mon Sep 17 00:00:00 2001 From: Denis Roussel Date: Mon, 7 Mar 2022 15:12:53 +0100 Subject: [PATCH] [14.0][IMP] contract: simplify compute as False values are already taken into account In get_next_invoice_date, False values are already taken into account, so, simplifying compute_recurring_next_date function. --- contract/models/contract_recurrency_mixin.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/contract/models/contract_recurrency_mixin.py b/contract/models/contract_recurrency_mixin.py index 2bb49c5bd..0d38a085e 100644 --- a/contract/models/contract_recurrency_mixin.py +++ b/contract/models/contract_recurrency_mixin.py @@ -95,8 +95,7 @@ class ContractRecurrencyMixin(models.AbstractModel): @api.depends("next_period_date_start") def _compute_recurring_next_date(self): - records_with_date_start = self.filtered("next_period_date_start") - for rec in records_with_date_start: + for rec in self: rec.recurring_next_date = self.get_next_invoice_date( rec.next_period_date_start, rec.recurring_invoicing_type, @@ -105,11 +104,6 @@ class ContractRecurrencyMixin(models.AbstractModel): rec.recurring_interval, max_date_end=rec.date_end, ) - (self - records_with_date_start).update( - { - "recurring_next_date": False, - } - ) @api.depends("last_date_invoiced", "date_start", "date_end") def _compute_next_period_date_start(self):