From e065a99d3c88010eb139d9df14aadda17ecfc663 Mon Sep 17 00:00:00 2001
From: Oscar Soto <osoto@sdi.es>
Date: Wed, 5 Feb 2020 16:09:36 +0100
Subject: [PATCH] [FIX]contract_count == len(active contracts)

---
 product_contract/models/sale_order.py | 4 +++-
 product_contract/views/sale_order.xml | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/product_contract/models/sale_order.py b/product_contract/models/sale_order.py
index 1a277a963..949c45e36 100644
--- a/product_contract/models/sale_order.py
+++ b/product_contract/models/sale_order.py
@@ -103,7 +103,9 @@ class SaleOrder(models.Model):
     @api.depends("order_line")
     def _compute_contract_count(self):
         for rec in self:
-            rec.contract_count = len(rec.order_line.mapped('contract_id'))
+            rec.contract_count = len(
+                rec.order_line.mapped('contract_id').filtered(
+                    lambda r: r.active))
 
     @api.multi
     def action_show_contracts(self):
diff --git a/product_contract/views/sale_order.xml b/product_contract/views/sale_order.xml
index 4fd1b90b9..0805121fd 100644
--- a/product_contract/views/sale_order.xml
+++ b/product_contract/views/sale_order.xml
@@ -23,7 +23,7 @@
                 <button name="action_show_contracts"
                         type="object" icon="fa-book"
                         class="oe_stat_button"
-                        attrs="{'invisible': ['|', ('is_contract', '!=', True), ('state', 'not in', ['sale', 'done'])]}">
+                        attrs="{'invisible': ['|', '|', ('is_contract', '!=', True), ('state', 'not in', ['sale', 'done']), ('contract_count', '=', 0)]}">
                     <field string="Contracts"
                            name="contract_count"
                            widget="statinfo"/>